Dev support/flaky test updates #19220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ec.rb (#19208) * removing the xit and adding new test * Added a test for an expired key for the Idt::Token active method * APPEALS-24131: removed unused let statement * Removed the sleep statement from the test. * Included a docket_spec test fix as well. --------- Co-authored-by: = <tyler.broyles@va.gov>
This will be explained more in the accompanying PR but this test has been skipped for a couple years and does not need to be in the code base anymore as it does not add any value.
…establishment" (#19209) * deleted a flakey hang and added an expect for the url * Added a few more expects * small formating changes * removed no longer needed comment * removed unneccesarcy expect
|
Code Climate has analyzed commit ea346a2 and detected 0 issues on this pull request. View more on Code Climate. |
|
A new flaky test story was created here for the failing test in motion_to_vacate_spec.rb |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves:
Description
Removed skips, modified tests, removed unnecessary tests
Acceptance Criteria
Tests
Test Coverage
Did you include any test coverage for your code? Check below:
Code Climate
Your code does not add any new code climate offenses? If so why?