Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Success banner fix in Scenario-3 Appeals-28703 #19221

Merged
merged 3 commits into from
Aug 25, 2023
Merged

Success banner fix in Scenario-3 Appeals-28703 #19221

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
05de630
Success banner fix in Scenario-3 Appeals-28703
kamala-07 Aug 21, 2023
1f5ef9d
Merge branch 'feature/APPEALS-24914' into kamalam7/APPEALS-28703
cacevesva Aug 22, 2023
3e7bb75
Merge branch 'feature/APPEALS-24914' into kamalam7/APPEALS-28703
cacevesva Aug 25, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions client/COPY.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -663,6 +663,7 @@
"PULAC_CERULLO_REMINDER_MODAL_OPT_FALSE": "No, continue sending to Dispatch",
"PULAC_CERULLO_REMINDER_MODAL_OPT_TRUE": "Yes, notify Pulac Cerullo team of jurisdictional conflict",
"ASSIGN_TASK_SUCCESS_MESSAGE": "Task assigned to %s",
"REASSIGN_TASK_SUCCESS_MESSAGE_SCM": "You have successfully assigned %s’s case to %s",
"REASSIGN_TASK_SUCCESS_MESSAGE": "You have successfully reassigned this task to %s",
"HEARING_ASSIGN_TASK_SUCCESS_MESSAGE_DETAIL": "You can continue to assign tasks to yourself and others using this queue.",
"ASSIGN_TASK_SUCCESS_MESSAGE_MOVE_LEGACY_APPEALS_VLJ": "You have successfully reassigned %s’s case to %s",
Expand Down
8 changes: 7 additions & 1 deletion client/app/queue/AssignToView.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -210,7 +210,13 @@ class AssignToView extends React.Component {
}
};

const successMsg = { title: sprintf(COPY.REASSIGN_TASK_SUCCESS_MESSAGE, this.getAssignee()) };
const assignedByListItem = () => {
const assignor = this.props.appeal.veteranFullName || null;

return assignor;
};

const successMsg = { title: sprintf(COPY.REASSIGN_TASK_SUCCESS_MESSAGE_SCM, assignedByListItem(), this.getAssignee()) };

return this.props.requestPatch(`/tasks/${task.taskId}`, payload, successMsg).then((resp) => {
this.props.onReceiveAmaTasks(resp.body.tasks.data);
Expand Down
2 changes: 1 addition & 1 deletion client/app/queue/AttorneyTaskListView.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ class AttorneyTaskListView extends React.PureComponent {
{error.detail}
</Alert>}
{success && <Alert type="success" title={success.title}>
{success.detail || COPY.ATTORNEY_QUEUE_TABLE_SUCCESS_MESSAGE_DETAIL}
{success.detail || (success.title.includes('You have successfully reassigned ') && COPY.ATTORNEY_QUEUE_TABLE_SUCCESS_MESSAGE_DETAIL)}
</Alert>}
<QueueTableBuilder
assignedTasks={this.props.workableTasks}
Expand Down
2 changes: 1 addition & 1 deletion client/app/queue/JudgeDecisionReviewTaskListView.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ class JudgeDecisionReviewTaskListView extends React.PureComponent {
{messages.error.detail}
</Alert>}
{messages.success && <Alert type="success" title={messages.success.title}>
{messages.success.detail || COPY.JUDGE_QUEUE_TABLE_SUCCESS_MESSAGE_DETAIL}
{messages.success.detail || (messages.success.title.includes('You have successfully reassigned ') && COPY.JUDGE_QUEUE_TABLE_SUCCESS_MESSAGE_DETAIL)}
</Alert>}
<QueueTableBuilder assignedTasks={tasks} />
</AppSegment>;
Expand Down
Loading