Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

APPEALS-29120 - Enhance hlr_sync_lock with logging #19259

Merged
merged 15 commits into from
Aug 28, 2023

Conversation

Jruuuu
Copy link
Contributor

@Jruuuu Jruuuu commented Aug 24, 2023

Resolves APPEALS-29120

Description

enhance the hlr_sync_lock with logging of creation and releasing of hlr_sync_lock key and errors when they occur

Acceptance Criteria

  • add logging for lock creation
  • add logging for lock release
  • add logging for error
  • add logging error to rspec

Testing Plan

  1. Test Plan: APPEALS-29165
  2. Test Execution: APPEALS-29251

Tests

Test Coverage

Did you include any test coverage for your code? Check below:

  • RSpec
  • Jest
  • Other

Code Climate

Your code does not add any new code climate offenses? If so why?

  • No new code climate issues added

Logging

  • Are logs being produced at appropriate log levels (debug, info, warn, error, fatal)? yes, these errors will not be sent to raven but will be logged via Rails Logger
  • Are logs structured (e.g., using log tags) for easier querying and analysis?
  • Are sensitive data (e.g., passwords, tokens) redacted or omitted from logs?
  • Is log retention and rotation configured correctly?
  • Are logs being forwarded to a centralized logging system if needed?

Error Handling

  • Are errors being caught and handled gracefully? yes
  • Are appropriate error messages being displayed to users?
  • Are critical errors being reported to an error tracking system (e.g., Sentry, ELK)?
  • Are unhandled exceptions being caught at the application level ?

@codeclimate
Copy link

codeclimate bot commented Aug 24, 2023

Code Climate has analyzed commit 305faeb and detected 0 issues on this pull request.

View more on Code Climate.

@Jruuuu Jruuuu requested a review from jtsangVA August 25, 2023 21:44
@Jruuuu Jruuuu changed the base branch from master to feature/APPEALS-19847 August 25, 2023 21:45
@Jruuuu Jruuuu marked this pull request as ready for review August 25, 2023 21:48
Copy link
Contributor

@jtsangVA jtsangVA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Jruuuu Jruuuu merged commit 5fdecdc into feature/APPEALS-19847 Aug 28, 2023
12 of 14 checks passed
@Jruuuu Jruuuu deleted the willlove/APPEALS-29120 branch December 1, 2023 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants