-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
B_reed/APPEALS-28105 #19264
Closed
Closed
B_reed/APPEALS-28105 #19264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…name, updated method to be more generic, changed pexip.rb to ruby style
…-of-veterans-affairs/caseflow into b_reed/APPEALS-25137
…thompson/APPEALS-26633
…19239-revert-19112-lthompson/APPEALS-26633 * laurenoelle/APPEALS-19871 initial files * Fixing error with .pick * Fixing .pick * Adding a rails initializer for monitoring deprecation warnings * Modifying jest tests * Updated language following feedback from UX team * APPEALS-17497 MST & PACT Special issues identification changes * Adding Subscriber to monitor deprecation warnings * Add spec file for deprecation warnings * APPEALS-27327: MST and PACT BGS Fix (#19116) * added grouping for feature toggles * moved special issue deserialization for ratings into contestable issue model and added datadog incrementing for reporting * added wildcard to datadog counters and removed redundant logging in bgs_service * updated data dog service logging * Delete deprecation_alerts.rb * APPEALS-26633 Added method to update meeting_type in Users Controller, and updated Organizations User model with new method to change meeting_type * APPEALS-26633 Progress on linking backend and frontend radio option changes and added modifyConferenceTypes * Apply suggestions from code review Co-authored-by: Jeremy Croteau <jcroteau@users.noreply.github.com> * Update deprecation_warning_subscriber_spec.rb * Fix typo * APPEALS-26633 Framing for logic to link onChange function * 🐛 Pre-emptive bugfix - TypeError Exception: allocator undefined for Thread::Backtrace::Location * 🔊 Log additional metadata to Sentry on deprecation warnings * Updated for AC as of August 8 * commented out bgs call and adding logging for production * Fixed spacing * added data dog logging for fetch rating profile and ratings in range * Adding modifyConferenceType to patch to backend * updated contentions response to handle blank? responses in addition to nil? * 🚨 Lint: Remove trailing whites space c * 🥅 Add blanket rescue to DeprecationWarningSubscriber (Puts on tin foil hat) Prevent potential exceptions from SlackService from impacting user experience * ✏️ Fix typo in test description * 🧪 Fix test so that it will pass in non-'test' environments as well * put in explicit nil return statement for contention BGS call testing. * Update deprecation_warning_subscriber.rb * Revert "Update deprecation_warning_subscriber.rb" This reverts commit 50bf09f. * use env variable for efolder express url * add efolder url env variable to demo environmentt * Add meeting_type to user to capture new meeting type from frontend, debugging in byebug * Hotfix/appeals 27980 NightlySyncsJob (#19173) * add error handling to sync_vacols_cases * add test for sync_bgs_attorneys method * add slack notification on job error, add tests * codeclimate * codeclimate * Fixed bug so frontend hearings change is persisted to backend and updates user meeting type * Revert "APPEALS-17497 MST & PACT Special issues identification" * Fixed linting issues and added rspec test to check the new meeting type * Add information about patch response test * Fix code climates issues * Jest testing fixed to check for changing values by radio button selection * Pamatya/APPEALS-24131: Fix flaky/skipped tests in models/idt/token_spec.rb (#19208) * removing the xit and adding new test * Added a test for an expired key for the Idt::Token active method * APPEALS-24131: removed unused let statement * Removed the sleep statement from the test. * Included a docket_spec test fix as well. --------- Co-authored-by: = <tyler.broyles@va.gov> * Remove skipped and unneeded feature test (#19214) This will be explained more in the accompanying PR but this test has been skipped for a couple years and does not need to be in the code base anymore as it does not add any value. * APPEALS-24145 Fix test scenario "Assigning it to complete the claims establishment" (#19209) * deleted a flakey hang and added an expect for the url * Added a few more expects * small formating changes * removed no longer needed comment * removed unneccesarcy expect * Revert "laurenoelle/APPEALS-19871 initial files" * Hearing Admin selection changed to Hearings Management * Revert "lthompson/APPEALS-26633" * Revert "Revert "lthompson/APPEALS-26633"" --------- Co-authored-by: Lauren Berry <berry_lauren@bah.com> Co-authored-by: AnandEdara <131183324+AnandEdara@users.noreply.github.com> Co-authored-by: kristeja <krishnateja.golla@va.gov> Co-authored-by: HunJerBAH <99915461+HunJerBAH@users.noreply.github.com> Co-authored-by: HunJerBAH <Jeremy.Hunton@va.gov> Co-authored-by: 631862 <lauren.thompson@va.gov> Co-authored-by: kristeja <112115264+kristeja@users.noreply.github.com> Co-authored-by: Jeremy Croteau <jcroteau@users.noreply.github.com> Co-authored-by: Jeremy Croteau <jeremiah.croteau@va.gov> Co-authored-by: Lauren Berry <95879805+laurenberrybah@users.noreply.github.com> Co-authored-by: Matt Roth <roth_matthew@bah.com> Co-authored-by: mikefinneran <110622959+mikefinneran@users.noreply.github.com> Co-authored-by: Craig Reese <109101548+craigrva@users.noreply.github.com> Co-authored-by: sbashamoni <138054633+sbashamoni@users.noreply.github.com> Co-authored-by: Prajwal Amatya <122557351+pamatyatake2@users.noreply.github.com> Co-authored-by: = <tyler.broyles@va.gov> Co-authored-by: Brandon Lee Dorner <brandonleedorner@gmail.com> Co-authored-by: Sean Craig <110493538+seancva@users.noreply.github.com>
…of-veterans-affairs/caseflow into b_reed/APPEALS-28105
Code Climate has analyzed commit 6828546 and detected 0 issues on this pull request. View more on Code Climate. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves Jira Issue Title
Description
Please explain the changes you made here.
Acceptance Criteria
Testing Plan
Frontend
User Facing Changes
Storybook Story
For Frontend (Presentation) Components
MyComponent.stories.js
alongsideMyComponent.jsx
)Backend
Database Changes
Only for Schema Changes
created_at
,updated_at
) for new tablesCaseflow::Migration
, especially when adding indexes (useadd_safe_index
) (see Writing DB migrations)migrate:rollback
works as desired (change
supported functions)make check-fks
; add any missing foreign keys or add toconfig/initializers/immigrant.rb
(see Record associations and Foreign Keys)belongs_to
for associations to enable the schema diagrams to be automatically updatedIntegrations: Adding endpoints for external APIs
Best practices
Code Documentation Updates
Tests
Test Coverage
Did you include any test coverage for your code? Check below:
Code Climate
Your code does not add any new code climate offenses? If so why?
Monitoring, Logging, Auditing, Error, and Exception Handling Checklist
Monitoring
Logging
Auditing
Error Handling
Exception Handling