APPEAL/29184 - Add key to AmaIssueList

[brandondorner]

Resolves https://jira.devops.va.gov/browse/APPEALS-29184

Description

This is a tech-debt task and should not change any functionality. https://jira.devops.va.gov/browse/APPEALS-29184

AmaIssueList was missing a key prop which was throwing a React error Warning: Each child in a list should have a unique "key" prop.

In an effort to reduce errors and increase performance we have added in these component keys.

Further reading on why React keys are important:
https://dev.to/francodalessio/understanding-the-importance-of-the-key-prop-in-react-3ag7

Acceptance Criteria

• Code compiles correctly
• The key warnings are gone

Testing Plan - At queue/appeals/{appeal-id}

1. Switch user to BVAAABSHIRE
2. Go to Queue and select an AMA Appeal (e.g. Bob SmithMayer)

• The "Issues" section should display as expected
• Inside the browser dev tools there should be no key warning for "AmaIssueList". (There may be other warnings not related to this that can become there own Jira tickets)

QA/Dev notes:

This error will show up in the browser Dev Tools (Message me if you need help with this)

The key prop itself will not show up on the element tree in the dev tools but that is okay as according to the React docs "Keys serve as a hint to React but they don’t get passed to your components."
I did not realize this prior to this task so I was looking for the key where it wouldn't be. So all we need for this task is just see if the error/warning went away.

Before

After

[codeclimate]

Code Climate has analyzed commit 0b6b539 and detected 0 issues on this pull request.

View more on Code Climate.