-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Eli/APPEALS-28088_APPEALS-28090 #19726
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Code Climate has analyzed commit a581048 and detected 0 issues on this pull request. View more on Code Climate. |
…issues, and decision issue has many request issues
…-affairs/caseflow into eli/APPEALS-28088
…-affairs/caseflow into eli/APPEALS-28088
Aaron-Willis
approved these changes
Oct 23, 2023
mikefinneran
added a commit
that referenced
this pull request
Dec 27, 2023
…EALS-28087 Eli/APPEALS-28088_APPEALS-28090 (#19726)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves APPEALS-28088, APPEALS-28090
Description
AMA JSON Schema and Mock Response
Note:
Attributes
caseflow_considers_status_active
,caseflow_considers_title_of_active_review
, andcaseflow_considers_eligible
are not columns on therequest_issues
table. Instead, they're transient attributes whose values are populated via the following methods inrequest_issue.rb
:#status_active?
#title_of_active_review
#eligible?
Eligibility AMA JSON Schema
> {Eligibility AMA Mock Response
}
28088:
As a developer I need to create a query that will collect all of the data points needed to identify request issues and decision issues in the Caseflow database so that the data points can be mapped and sent out in the data API.
Method must be created in the legacy_appeals model that will return a boolean value based on if the file_number passed in is associated with VACOLS appeals. The method will create Legacy Appeal records if they don't already exist. This method must be tested in legacy_appeal_spec.rb.
Seed file is created with various scenarios to test veterans with/without legacy appeals in vacols, veterans with high number of request and decision issues, veterans that has a request issue with multiple decision issues, and veteran that has a decision issue with multiple request issues. A spec file must be created to test the seed file.
Make command is created to create the seeds, and the seed file is added to seeds.rb to create the seeds upon running make reset.
Migration exists that adds the column nonrating_issue_bgs_id to the request issues table. The column should be a string datatype and include a comment. The migration should inherit from Caseflow::Migration.
28090:
As developer I need to create an AMA DTO to store all the data points per request and decision issues and a mapper to convert query data into flat data structures so that a pageable list of dtos can be returned by the API
A Data Transfer Object is created that has all the data points for AMA request/decision issues
A data mapper exists that will map the data from the AMA to a flat DTO structure
AMA DTO can be serialized into JSON using JSON_API_SERIALIZER
Acceptance Criteria
Queries:
Seeds:
Migrations:
Serializers (DTO):
Service Objects:
Mock Controllers:
Mock Routes:
Testing Plan
28088
Test 1 (tests method in legacy_appeals.rb, seed file, and migration):
Test 2 (tests query):
28090
Test Coverage
Did you include any test coverage for your code? Check below:
Backend
Database Changes
Only for Schema Changes
Caseflow::Migration
, especially when adding indexes (useadd_safe_index
) (see Writing DB migrations)migrate:rollback
works as desired (change
supported functions)Best practices
Code Documentation Updates
Code Climate
Your code does not add any new code climate offenses? If so why?