feature/APPEALS-21478: Update Geo-matching to use zip code instead of street address #19756
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-of-veterans-affairs/caseflow into jefftmarks/APPEALS-31482
…rks/APPEALS-31482 jefftmarks/APPEALS-31482-31483
|
Code Climate has analyzed commit 483f3d7 and detected 0 issues on this pull request. View more on Code Climate. |
* APPEALS-31484 added in country code check and new condition for closest regional office * APPEALS-31484 added rspec test for veterans not living in us * APPEALS-31484 changed to check appellant address * APPEALS-31484 changed name of method from veteran to appellant * added new rspec tests * added guards for errors for R071 geomatch * R011 returns instead of RO71 for foreign appeals * Update spec/services/va_dot_gov_address_validator_spec.rb Co-authored-by: Marc Steele <71673522+msteele96@users.noreply.github.com> --------- Co-authored-by: Marc Steele <71673522+msteele96@users.noreply.github.com>
msteele96
changed the title
* APPEALS-34933 Add country name to zip code validation * APPEALS-34933 Update va dot gov spec * APPEALS-34933 Update Philippines, international, and US territory checks * APPEALS-34933 Update geomatch spec * APPEALS-34933 Add foreign address error to address validation response * APPEALS-34933 Use dig to access addressMetaData * APPEALS-34933 Fix specs related to address validation * APPEALS-34933 Remove commented out code * APPEALS-34933 Create and implement child ZipCodeValidationResponse class * APPEALS-34933 Update specs with ZipCodeValidationResponse
* APPEALS-36158 Update retry on fetch_bgs_record to raise error * APPEALS-36158 Undo nested rescue * APPEALS-36158 Add error logging to bgs address service * APPEALS-36158 FIx duplicate blocks of code * APPEALS-36158 Fix variable name * APPEALS-36158 Fix variable name --------- Co-authored-by: Marc Steele <71673522+msteele96@users.noreply.github.com>
msteele96
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves APPEALS-21478
Description
Updates the geomatch service to use only zip code instead of full street address for geomatching. Geomatches all foreign appeals to the Pittsburgh RO by default. Adds logging for Savon::Errors received when connection to BGS is interrupted.
Acceptance Criteria
Testing Plan
Backend
Integrations: Adding endpoints for external APIs
Best practices
Code Documentation Updates
Tests
Test Coverage
Did you include any test coverage for your code? Check below:
Code Climate
Your code does not add any new code climate offenses? If so why?