-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
hearings/APPEALS-34517 and breedbah/APPEALS-34669 #19929
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tment-of-veterans-affairs/caseflow into prototype/APPEALS-34517-v2
…tment-of-veterans-affairs/caseflow into prototype/APPEALS-34517-v2
…tment-of-veterans-affairs/caseflow into prototype/APPEALS-34517-v2
…pe/34517-v2-minus-ui-updates Prototype/34517-v2-minus-ui-updates
…tment-of-veterans-affairs/caseflow into prototype/APPEALS-34517-v2
…tment-of-veterans-affairs/caseflow into prototype/APPEALS-34517-v2
ThorntonMatthew
changed the title
Update to guestLink rendering
hearings/APPEALS-34517 and breedbah/APPEALS-34669
Nov 9, 2023
mchbidwell
approved these changes
Nov 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves APPEALS-34517 and APPEALS-34669
Description
34517
Whenever a virtual hearing is scheduled a VirtualHearing::CreateConferenceJob is initiated to
Currently there is a technical gap where information about Webex conferences are not being persisted to the virtual_hearings table. This prevents Webex conference links from being properly being displayed in emails and in the Caseflow UI.
This story aims to remedy this by making sure information returned to us by Webex InstantConnect in responses in stored in our virtual_hearings table, and that it can be retrieved and displayed properly.
34669
Changes the guest link fields for Webex conferences on the daily docket page.
Acceptance Criteria
34517
In/around VirtualHearings::CreateConferenceJob's create_conference method:
A differentiation between Pexip and Webex virtual hearing must be made whenever creating the conference information.
Hearing confirmation and reminder emails sent to appellants and representatives contain the correct links.
Hearing links on the hearing details page are correct.
In/around VirtualHearings::CreateConferenceJob's create_conference method:
A differentiation between Pexip and Webex virtual hearing must be made whenever creating the conference information.
Hearing confirmation and reminder emails sent to appellants and representatives contain the correct links.
Hearing links on the hearing details page are correct.
34669
Display of Daily Docket Webex section "header"
Testing Plan
Frontend
User Facing Changes
Best practices
Code Documentation Updates
Tests
Test Coverage
Did you include any test coverage for your code? Check below:
Code Climate
Your code does not add any new code climate offenses? If so why?
Monitoring, Logging, Auditing, Error, and Exception Handling Checklist
Monitoring
Logging
Auditing
Error Handling
Exception Handling