Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hearings/APPEALS-34517 and breedbah/APPEALS-34669 #19929

Merged
merged 42 commits into from
Nov 13, 2023

Conversation

ThorntonMatthew
Copy link
Contributor

@ThorntonMatthew ThorntonMatthew commented Nov 9, 2023

Resolves APPEALS-34517 and APPEALS-34669

Description

34517

Whenever a virtual hearing is scheduled a VirtualHearing::CreateConferenceJob is initiated to

  • Create a virtual_hearing record
  • Update its virtualhearingestablishment record
  • Create a conference in either Pexip or Webex
  • Send emails to hearing participants

Currently there is a technical gap where information about Webex conferences are not being persisted to the virtual_hearings table. This prevents Webex conference links from being properly being displayed in emails and in the Caseflow UI.

This story aims to remedy this by making sure information returned to us by Webex InstantConnect in responses in stored in our virtual_hearings table, and that it can be retrieved and displayed properly.

34669

Changes the guest link fields for Webex conferences on the daily docket page.

Acceptance Criteria

34517

  1. In/around VirtualHearings::CreateConferenceJob's create_conference method:

    1. A differentiation between Pexip and Webex virtual hearing must be made whenever creating the conference information.

      1. If a virtualhearing's conferenceprovider is "pexip"
        1. All existing behavior should be retained
      2. If a virtualhearing's conferenceprovider is "webex"
        1. The host link is saved to the virtual_hearings table
        2. The guest link is saved to the virtual_hearings table
        3. How these items are saved, and which columns are used, is all still TBD.
  2. Hearing confirmation and reminder emails sent to appellants and representatives contain the correct links.

  3. Hearing links on the hearing details page are correct.

    1. Adjustments are made to the VirtualHearingSerializer as needed to accommodate this need.
  4. In/around VirtualHearings::CreateConferenceJob's create_conference method:

    1. A differentiation between Pexip and Webex virtual hearing must be made whenever creating the conference information.

      1. If a virtualhearing's conferenceprovider is "pexip"
        1. All existing behavior should be retained
      2. If a virtualhearing's conferenceprovider is "webex"
        1. The host link is saved to the virtual_hearings table
        2. The guest link is saved to the virtual_hearings table
        3. How these items are saved, and which columns are used, is all still TBD.
  5. Hearing confirmation and reminder emails sent to appellants and representatives contain the correct links.

  6. Hearing links on the hearing details page are correct.

    1. Adjustments are made to the VirtualHearingSerializer as needed to accommodate this need.

34669

Display of Daily Docket Webex section "header"

  1. Daily Docket displays a section for the Webex Guest Link area
  2. Webex is displayed as the Label with a URL label and link
  3. Copy Guest link is still available

Testing Plan

  • For feature branches merging into master: Was this deployed to UAT?

Frontend

User Facing Changes

  • Screenshots of UI changes added to PR & Original Issue
BEFORE AFTER
before after

Best practices

Code Documentation Updates

  • Add or update code comments at the top of the class, module, and/or component.

Tests

Test Coverage

Did you include any test coverage for your code? Check below:

  • RSpec
  • Jest
  • Other

Code Climate

Your code does not add any new code climate offenses? If so why?

  • No new code climate issues added

Monitoring, Logging, Auditing, Error, and Exception Handling Checklist

Monitoring

  • Are performance metrics (e.g., response time, throughput) being tracked?
  • Are key application components monitored (e.g., database, cache, queues)?
  • Is there a system in place for setting up alerts based on performance thresholds?

Logging

  • Are logs being produced at appropriate log levels (debug, info, warn, error, fatal)?
  • Are logs structured (e.g., using log tags) for easier querying and analysis?
  • Are sensitive data (e.g., passwords, tokens) redacted or omitted from logs?
  • Is log retention and rotation configured correctly?
  • Are logs being forwarded to a centralized logging system if needed?

Auditing

  • Are user actions being logged for audit purposes?
  • Are changes to critical data being tracked ?
  • Are logs being securely stored and protected from tampering or exposing protected data?

Error Handling

  • Are errors being caught and handled gracefully?
  • Are appropriate error messages being displayed to users?
  • Are critical errors being reported to an error tracking system (e.g., Sentry, ELK)?
  • Are unhandled exceptions being caught at the application level ?

Exception Handling

  • Are custom exceptions defined and used where appropriate?
  • Is exception handling consistent throughout the codebase?
  • Are exceptions logged with relevant context and stack trace information?
  • Are exceptions being grouped and categorized for easier analysis and resolution?

ThorntonMatthew and others added 30 commits November 7, 2023 11:22
@ThorntonMatthew ThorntonMatthew changed the title Update to guestLink rendering hearings/APPEALS-34517 and breedbah/APPEALS-34669 Nov 9, 2023
@ThorntonMatthew ThorntonMatthew marked this pull request as ready for review November 13, 2023 15:12
@mchbidwell mchbidwell merged commit f9ce9ac into feature/APPEALS-26734 Nov 13, 2023
24 of 28 checks passed
@ThorntonMatthew ThorntonMatthew deleted the hearings/APPEALS-34517 branch November 21, 2023 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants