APPEALS-35011 Disable ForeignKeyPolymorphicAssociationJob
[pre Rails 6.0]
#20114
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves APPEALS-35011
Description
Background
On Rails 6.0, the job
ForeignKeyPolymorphicAssociationJob
has a bug:orphan_records query
Since this will be a blocker for the Rails 6.0 upgrade, and because this job is not essential for day-to-day business (it is more of a remediation tool), we can temporarily disable the job until we have a fix in place.
Proposed Solution
ForeignKeyPolymorphicAssociationJob
job. ( Related code in appeals-lambdas )spec/jobs/foreign_key_polymorphic_association_job_spec.rb
Acceptance Criteria
ForeignKeyPolymorphicAssociationJob
has been successfully disabled (is no longer triggered as a scheduled job)spec/jobs/foreign_key_polymorphic_association_job_spec.rb
is skippedTesting Plan
Best practices
Code Documentation Updates
Tests
Test Coverage
Did you include any test coverage for your code? Check below:
Code Climate
Your code does not add any new code climate offenses? If so why?
Monitoring, Logging, Auditing, Error, and Exception Handling Checklist
Monitoring
Logging
Auditing
Error Handling
Exception Handling