-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
APPEALS-36565 | Fixed Rubocop errors for app/jobs/fetch_all_active_ama_appeals_job.rb
#20272
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* update rubocop * update rubocop to 0.83 also updates some breaking changes like LineLength moving to Layout
…hange.rb` (#20187) * Fixed Rubocop offenses in lib/helpers/claim_label_change.rb * Added and Exclusion for AbcSize and changed if statements * Fixed Cyclomatic Complexity error, some code more cleanup * validated same code claim type by added validate_same_claim_type method
* fix rubocop offenses in unreecognized appellant helper * parens * more parens more better
Code Climate has analyzed commit 46fe8a0 and detected 1 issue on this pull request. Here's the issue category breakdown:
View more on Code Climate. |
Main Jira: https://jira.devops.va.gov/browse/APPEALS-35680 Secondary Jira: https://jira.devops.va.gov/browse/APPEALS-36563 Co-authored-by: Clay Sheppard <csheepy@gmail.com>
almorbah
force-pushed
the
Al/APPEALS-36565
branch
from
December 19, 2023 22:31
179b070
to
7ea4758
Compare
almorbah
force-pushed
the
Al/APPEALS-36565
branch
from
December 20, 2023 15:07
fa1a430
to
4ad16e2
Compare
almorbah
force-pushed
the
Al/APPEALS-36565
branch
from
December 20, 2023 15:12
4ad16e2
to
81b05bd
Compare
* fix line length offenses in appellant notification spec * fix refactor
almorbah
changed the title
APPEALS-36565 | Fixed Rubocop errors for app/jobs/fetch_all_active_ama_appeals_job.rb
APPEALS-36565 | Fixed Rubocop errors for Dec 21, 2023
app/jobs/fetch_all_active_ama_appeals_job.rb
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves APPEALS-36565
Description
Fixed Rubocop errors for app/jobs/fetch_all_active_ama_appeals_job.rb.
Acceptance Criteria
Testing Plan
Frontend
User Facing Changes
Storybook Story
For Frontend (Presentation) Components
MyComponent.stories.js
alongsideMyComponent.jsx
)Backend
Database Changes
Only for Schema Changes
created_at
,updated_at
) for new tablesCaseflow::Migration
, especially when adding indexes (useadd_safe_index
) (see Writing DB migrations)migrate:rollback
works as desired (change
supported functions)make check-fks
; add any missing foreign keys or add toconfig/initializers/immigrant.rb
(see Record associations and Foreign Keys)belongs_to
for associations to enable the schema diagrams to be automatically updatedIntegrations: Adding endpoints for external APIs
Best practices
Code Documentation Updates
Tests
Test Coverage
Did you include any test coverage for your code? Check below:
Code Climate
Your code does not add any new code climate offenses? If so why?
Monitoring, Logging, Auditing, Error, and Exception Handling Checklist
Monitoring
Logging
Auditing
Error Handling
Exception Handling