Task related to appeals bugfix. #20369
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jimfoley25
reviewed
Dec 29, 2023
client/app/queue/correspondence/intake/components/TasksAppeals/AddAppealRelatedTaskView.jsx
Outdated
Show resolved
Hide resolved
jimfoley25
approved these changes
Dec 29, 2023
craigrva
pushed a commit
that referenced
this pull request
Jan 24, 2024
* Refactored task ID logic for related tasks. * Updated logic to be cleaner. --------- Co-authored-by: Jim Foley <james.foley4@va.gov>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves APPEALS-37011
Description
Previously, when a user added a new task related to an appeal, the ID of the task would be set to the length of the array + 1. This caused bugs, and, the logic that assigns IDs to tasks has now been refactored. The logic now takes the highest ID in the list of appeals and adds 1, or, if there are none it sets the ID to 0.
Acceptance Criteria