Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev Support/Fix Make-docs-to-webpage Worfklow #20371

Merged
merged 14 commits into from
Jan 2, 2024

Conversation

ThorntonMatthew
Copy link
Contributor

@ThorntonMatthew ThorntonMatthew commented Dec 28, 2023

Description

The Make-docs-to-webpage workflow has been updated to include a requisite Redis service and to resolve some deprecation warnings. Some new polymorphic associations have also been documented in the code in order for them to be able to be represented in our generated docs.

Acceptance Criteria

Testing Plan

  1. Review the last run of the Make-docs-to-webpage workflow (Link)
  2. Review that the "Build and deploy to GH Pages" workflow is able to run successfully (Link)
  3. See that the GitHub Pages site has been updated appropriately (ex: on the Caseflow Postgres DB Schema page).

Copy link

codeclimate bot commented Dec 28, 2023

Code Climate has analyzed commit 682b614 and detected 0 issues on this pull request.

View more on Code Climate.

@ThorntonMatthew ThorntonMatthew marked this pull request as ready for review December 29, 2023 14:49
@@ -28,22 +28,22 @@ jobs:
POSTGRES_DB: caseflow_certification_test
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I ran a linter on this file and it fixed some inconsistencies with the whitespace.

@raymond-hughes raymond-hughes merged commit ea3d07a into master Jan 2, 2024
14 of 15 checks passed
@ThorntonMatthew ThorntonMatthew deleted the dev-support/fix-make-docs-workflow branch April 19, 2024 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants