-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
J hoang/appeals 34906 v5 #20464
J hoang/appeals 34906 v5 #20464
Conversation
app/views/explain/show.html.erb
Outdated
} | ||
|
||
const setDetailsPaneMessage = (htmlContent)=>{ | ||
document.getElementById("side_panel_message").innerHTML = htmlContent; |
Check warning
Code scanning / CodeQL
DOM text reinterpreted as HTML Medium
DOM text
DOM text
DOM text
DOM text
{ | ||
appeal: appeal, | ||
parent_id: appeal.root_task&.id, | ||
assigned_to: data[:assigned_to].constantize.singleton, |
Check failure
Code scanning / CodeQL
Code injection Critical
user-provided value
class_for_data(data).create_from_params( | ||
{ | ||
parent_id: correspondence.root_task.id, | ||
assigned_to: data[:assigned_to].constantize.singleton, |
Check failure
Code scanning / CodeQL
Code injection Critical
user-provided value
end | ||
|
||
def class_for_data(data) | ||
data[:klass]&.constantize |
Check failure
Code scanning / CodeQL
Code injection Critical
user-provided value
Code Climate has analyzed commit b5e6fe1 and detected 13 issues on this pull request. Here's the issue category breakdown:
View more on Code Climate. |
* wrap Intake appeal upload behind feature toggle * update static doc path * rubocop fix efolder uploader * refactor intake_update in correspondence controller * Ignore feature envy code climate * Reek ignore warning --------- Co-authored-by: Jonathan Hoang <trinhjoanthan.hoang@va.gov> Co-authored-by: Kevin Ma <magavakevin10@gmail.com>
Resolves APPEALS-34906
Description
Wrap the logic related to uploading documents to claim evidence behind a feature toggle for UAT testing.
Acceptance Criteria
Best practices
Code Documentation Updates
Tests
Test Coverage
Did you include any test coverage for your code? Check below:
Code Climate
Your code does not add any new code climate offenses? If so why?
Monitoring, Logging, Auditing, Error, and Exception Handling Checklist
Monitoring
Logging
Auditing
Error Handling
Exception Handling