-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wmedders21/appeals 37636 codelimate #20470
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eterans-affairs/caseflow into wmedders21/APPEALS-37636
…rans-affairs/caseflow into wmedders21/APPEALS-37636
…rans-affairs/caseflow into wmedders21/APPEALS-37636
…rans-affairs/caseflow into wmedders21/APPEALS-37636
…rans-affairs/caseflow into wmedders21/APPEALS-37636
…rans-affairs/caseflow into wmedders21/APPEALS-37636
…rans-affairs/caseflow into wmedders21/APPEALS-37636
Code Climate has analyzed commit c7bba69 and detected 0 issues on this pull request. View more on Code Climate. |
jimfoley25
previously approved these changes
Jan 10, 2024
jimfoley25
approved these changes
Jan 10, 2024
craigrva
pushed a commit
that referenced
this pull request
Jan 24, 2024
* Added create_veteran to helper module and used in multi_correspondences * Added seed_helper module to cavc_ama_appeals * Added seed_helper module to test_case_data * Added seed_helper module to seeds/tasks.rb * Adjust formatting * Added seed_helper module to static test data * Added seed_helper module to static dispatched test data * Added seed_helper module to remanded legacy appeals * Added seed_helper module to remanded ama appeals * Added seed_helper module to cavc dashboard data * Relocate duplicate correspondence intake setup to CorrespondenceHelpers * Relocated duplicate create_child_class methods to shared parent * Moved create_child_class to private section * Move autotext table seeding to CorrespondenceHelpers * Codeclimate fixes and ignores * Update validation syntax on CorrespondenceIntake * Refactor method naming convention inCorrespondenceRelation * Update validation syntax on CorrespondenceRelation * Fixing requires * replaces timeout with sleep to fix offense * scss linting fix * Updated Time.local to Time.zone.local (reran tests) * parameter lint fix. * fixed linter issue. * Several linting fixes * fixed cyclomatic complexity * refactored logging statement * Converted statement to one line for better readability. * fixed element count * fixed incorrect element being clicked * Fix other motion bug * Fix codeclimate issues * Fix codeclimate issues * Fix conditional logic for Ruby style * Update current user creation in CorrespondenceHelpers to avoid fk violation * Ignore reek warning --------- Co-authored-by: Ryan Marshall <rnmarshall1993@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves APPEALS-37636
Description
Please explain the changes you made here.
Acceptance Criteria
Testing Plan
Frontend
User Facing Changes
Storybook Story
For Frontend (Presentation) Components
MyComponent.stories.js
alongsideMyComponent.jsx
)Backend
Database Changes
Only for Schema Changes
created_at
,updated_at
) for new tablesCaseflow::Migration
, especially when adding indexes (useadd_safe_index
) (see Writing DB migrations)migrate:rollback
works as desired (change
supported functions)make check-fks
; add any missing foreign keys or add toconfig/initializers/immigrant.rb
(see Record associations and Foreign Keys)belongs_to
for associations to enable the schema diagrams to be automatically updatedIntegrations: Adding endpoints for external APIs
Best practices
Code Documentation Updates
Tests
Test Coverage
Did you include any test coverage for your code? Check below:
Code Climate
Your code does not add any new code climate offenses? If so why?
Monitoring, Logging, Auditing, Error, and Exception Handling Checklist
Monitoring
Logging
Auditing
Error Handling
Exception Handling