Correspondence - Add validation to foreign keys #20474
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rnmarshall93
changed the title
…pondence_type factories.
HunJerBAH
requested changes
Jan 12, 2024
There was a problem hiding this comment.
Fantastic work on this! Tests are looking good and seed data is all looking good as well. My only request is if you could add the updated_by_id to the correspondence.rake task in the create_correspondences_with_documents, create_correspondence, and create_multi_correspondences methods in that rake task. With these changes, we are going to need to blow up our current UAT data and re-run that rake tasks with the correct relationships.
jimfoley25
approved these changes
Jan 12, 2024
craigrva
pushed a commit
that referenced
this pull request
Jan 24, 2024
* presence validation added. * fixed failing tests due to validations * changed data to be less confusing * fixed failing test * added foreign key validation at the db level * Fixed failing tests. * Added additional let! statements to stub data * fixed linting * Fixed failing specs (all of them) by stubbing more correspondence data * Updated correspondence factors to supply all required foreign key objects. * modified correspondence helpers to use only factory. * Fixed failing specs * removed redundant info * updated spec to fix failing validations * Changed seed order to support Correspondence validations * fixed linting issues * Added correspondence_type factory * Modified correspondence factory so that it uses user, veteran, correspondence_type factories. * Added package_document_type factory, changed correspondence factory to use it. * Added association for assigned_by * Updated to use factories for user, removed useless assignments * Removed redundant code * fixed failing spec. * fixed failing spec * added updated_to_id to all correspondences --------- Co-authored-by: Jim Foley <james.foley4@va.gov>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves Add validation to foreign keys
Description
These changes modify the Correspondence Model to have validation for the following foreign keys, and will reject the data if saved without having them present.
Acceptance Criteria
Testing Plan
Correspondence.create!Correspondence.create!( updated_by_id: 1, correspondence_type_id: 1, assigned_by_id: 1, veteran_id: 1, package_document_type_id: 1)Tests
Test Coverage
Did you include any test coverage for your code? Check below:
Code Climate
Your code does not add any new code climate offenses? If so why?