Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mbeard/APPEALS-37794 #20532

Merged
merged 10 commits into from
Jan 22, 2024
Merged

mbeard/APPEALS-37794 #20532

Show file tree
Hide file tree
Changes from 6 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
e25e7aa
"updates copy issue and radiofield"
mbeardy Jan 17, 2024
6a5dc29
"updates accessibility labels"
mbeardy Jan 18, 2024
5e5d491
"attempt to update label"
mbeardy Jan 18, 2024
81c0cd5
Merge branch 'feature/APPEALS-32252' of https://github.com/department…
mbeardy Jan 18, 2024
8684bd7
"updates accessibility vioce over"
mbeardy Jan 18, 2024
9f5a3a5
"moves logic from radiofield to exclusiontable"
mbeardy Jan 18, 2024
3287297
"Updated fixes from comments"
mbeardy Jan 19, 2024
c26d08d
"removes last thing from TextField component"
mbeardy Jan 19, 2024
b75e0e1
Merge branch 'feature/APPEALS-32252' into mbeard/APPEALS-37794
mbeardy Jan 22, 2024
520c17d
Merge branch 'feature/APPEALS-32252' into mbeard/APPEALS-37794
amybids Jan 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions client/COPY.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1397,9 +1397,6 @@
"EMPLOYER_IDENTIFICATION_NUMBER": "Employer Identification Number",
"CASE_DISTRIBUTION_TITLE": "Case Distribution Algorithm Values",
"CASE_DISTRIBUTION_ALGORITHM_DESCRIPTION": "The Case Distribution Algorithm determines how cases are assigned to VLJs and their teams. Current algorithm is \"By Docket Date.\"",
"CASE_DISTRIBUTION_EXCLUSION_TABLE_TITLE": "Excluding Appeals by Docket Type and Priority from Automatic Case Distribution",
"CASE_DISTRIBUTION_EXCLUSION_TABLE_DESCRIPTION": "For both Non-priority and Priority cases, you may use the sliders to turn on or off all options for each row. When you turn off a slider, all items in that row will be automatically deselected and visa versa. ​Additionally, If you wish to select only some options in a row or column, the slider will automatically turn off. You can make individual selections for that row or column at any point.",
"CASE_DISTRIBUTION_EXCLUSION_TABLE_DESCRIPTION_NOTE": "Selected docket type/priority combination options will be excluded from automatic case distribution beginning with the next distribution.",
"CASE_DISTRIBUTION_ACTIVE_LEVERS_TITLE": "Active Data Elements",
"CASE_DISTRIBUTION_ACTIVE_LEVERS_DESCRIPTION": "You may make changes to the Case Distribution algorithm values based on the data elements below. Changes will be applied to the next case distribution event unless subsequent confirmed changes are made to the same variable.",
"CASE_DISTRIBUTION_STATIC_LEVERS_TITLE": "Inactive Data Elements",
Expand All @@ -1414,19 +1411,22 @@
"CASE_DISTRIBUTION_DOCKET_TIME_DESCRIPTION_RIGHT" : " days sets the number of calendar days prior to the Docket Time Goal for that docket type when appeals become eligible for distribution.",
"CASE_DISTRIBUTION_DOCKET_TIME_NOTE": "Please note, if turned on, non-priority appeals of that docket type will not be distributed until eligible, which may disrupt strict docket-date-order distribution across dockets.",
"CASE_DISTRIBUTION_MODAL_TITLE": "Confirm Case Distribution Algorithm Changes",
"CASE_DISTRIBUTION_MODAL_DESCRIPTION": "Please confirm the following changes to the Case Distribution algorithm below. Once saved, these changes will apply to the next scheduled case distribution event.",
"CASE_DISTRIBUTION_MODAL_DESCRIPTION": "Please confirm the following changes to the Case Distribution algorithm below. Once saved, these changes will apply to the next case distribution event.",
"CASE_DISTRIBUTION_SUCCESS_BANNER_TITLE": "You have successfully updated the Case Distribution Algorithm",
"CASE_DISTRIBUTION_SUCCESS_BANNER_DETAIL": "Your changes will apply to the next Case Distribution event.",
"CASE_DISTRIBUTION_FAILURE_BANNER_TITLE": "Case Distribution Algorithm updates have failed.",
"CASE_DISTRIBUTION_FAILURE_BANNER_DETAIL": "Please contact the Caseflow team via the VA Enterprise Service Desk at 855-673-4357 or by creating a ticket via YourIT.",
"CASE_DISTRIBUTION_EXCLUSION_TABLE_TITLE": "Excluding Appeals by Docket Type and Priority from Automatic Case Distribution",
"CASE_DISTRIBUTION_EXCLUSION_TABLE_DESCRIPTION": "For both Non-priority and Priority cases, you may use the sliders to turn on or off all options for each row. When you turn off a slider, all items in that row will be automatically deselected and visa versa. ​Additionally, If you wish to select only some options in a row or column, the slider will automatically turn off. You can make individual selections for that row or column at any point.",
"CASE_DISTRIBUTION_EXCLUSION_TABLE_DESCRIPTION_NOTE": "Selected docket type/priority combination options will be excluded from automatic case distribution beginning with the next distribution.",
"CASE_DISTRIBUTION_EXCLUSION_TABLE_LEGACY_APPEALS_HEADER": "Legacy Appeals",
"CASE_DISTRIBUTION_EXCLUSION_TABLE_AMA_HEARINGS_HEADER": "AMA Hearings Appeals",
"CASE_DISTRIBUTION_EXCLUSION_TABLE_AMA_DIRECT_HEADER": "AMA Direct Review Appeals",
"CASE_DISTRIBUTION_EXCLUSION_TABLE_AMA_EVIDENCE_HEADER": "AMA Evidence Submission Appeals",
"CASE_DISTRIBUTION_EXCLUSION_TABLE_OFF": "OFF",
"CASE_DISTRIBUTION_AFFINITY_DAYS_H2_TITLE": "Affinity Days",
"CASE_DISTRIBUTION_EXCLUSION_TABLE_NON_PRIORITY": "All Non-priority",
"CASE_DISTRIBUTION_EXCLUSION_TABLE_PRIORITY": "All Priority",
"CASE_DISTRIBUTION_AFFINITY_DAYS_H2_TITLE": "Affinity Days",
"CASE_DISTRIBUTION_BATCH_SIZE_H2_TITLE": "Batch Size",
"CASE_DISTRIBUTION_BATCH_SIZE_LEVER_LEFT_TITLE": "Data Elements",
"CASE_DISTRIBUTION_BATCH_SIZE_LEVER_RIGHT_TITLE": "Value",
Expand Down
4 changes: 2 additions & 2 deletions client/app/caseDistribution/components/AffinityDays.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ const AffinityDays = () => {

const generateFields = (dataType, option, lever) => {
const useAriaLabel = !lever.is_disabled_in_ui;
const tabIndex = lever.is_disabled_in_ui ? -1 : null;
const tabIndex = lever.is_disabled_in_ui ? -1 : 0;
mbeardy marked this conversation as resolved.
Show resolved Hide resolved

if (dataType === ACD_LEVERS.data_types.number) {
return (
Expand Down Expand Up @@ -98,7 +98,7 @@ const AffinityDays = () => {
</label>
</div>
<div>
<div className={className}>
<div className={className} aria-label={option.unit}>
{generateFields(option.data_type, option, lever, isUserAcdAdmin)}
</div>
</div>
Expand Down
2 changes: 1 addition & 1 deletion client/app/caseDistribution/components/BatchSize.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ const BatchSize = () => {
{lever.description}
</p>
</div>
<div className={cx('lever-right', 'batch-lever-num-sec')}>
<div className={cx('lever-right', 'batch-lever-num-sec')} aria-label={`${lever.title} ${lever.description}`}>
{isUserAcdAdmin ?
<NumberField
name={lever.item}
Expand Down
6 changes: 5 additions & 1 deletion client/app/caseDistribution/components/DocketTimeGoals.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,11 @@ const DocketTimeGoals = () => {
onChange={updateNumberFieldLever(docketTimeGoalLever)}
/>
</div>
<div className={cx('lever-right', 'docket-lever-right', 'docket-time-lever-num-sec')}>
<div
className={cx('lever-right', 'docket-lever-right', 'docket-time-lever-num-sec')}
aria-label={docketTimeGoalLever.title}
id={`${docketTimeGoalLever.item}-lever-middle`}
>
<ToggleSwitch
id={`toggle-switch-${distributionPriorLever.item}`}
selected={distributionPriorLever.is_toggle_active}
Expand Down
73 changes: 53 additions & 20 deletions client/app/caseDistribution/components/ExclusionTable.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,24 +24,32 @@ const ExclusionTable = () => {
}
];

const generateUniqueId = (leverItem, optionValue, index) => `${leverItem}-${optionValue}-${index}`;

return (
<div className="exclusion-table-container-styling">
<table >
<thead>
<tr>
<th className="table-header-styling">{' '}</th>
<th className="table-header-styling">
<th className="table-header-styling" scope="column">{' '}</th>
mbeardy marked this conversation as resolved.
Show resolved Hide resolved
<th className="table-header-styling" scope="column">
{COPY.CASE_DISTRIBUTION_EXCLUSION_TABLE_LEGACY_APPEALS_HEADER}
</th>
<th className="table-header-styling">{COPY.CASE_DISTRIBUTION_EXCLUSION_TABLE_AMA_HEARINGS_HEADER}</th>
<th className="table-header-styling">{COPY.CASE_DISTRIBUTION_EXCLUSION_TABLE_AMA_DIRECT_HEADER}</th>
<th className="table-header-styling">{COPY.CASE_DISTRIBUTION_EXCLUSION_TABLE_AMA_EVIDENCE_HEADER}</th>
<th className="table-header-styling" scope="column">
{COPY.CASE_DISTRIBUTION_EXCLUSION_TABLE_AMA_HEARINGS_HEADER}
</th>
<th className="table-header-styling" scope="column">
{COPY.CASE_DISTRIBUTION_EXCLUSION_TABLE_AMA_DIRECT_HEADER}
</th>
<th className="table-header-styling" scope="column">
{COPY.CASE_DISTRIBUTION_EXCLUSION_TABLE_AMA_EVIDENCE_HEADER}
</th>
</tr>
</thead>
{isUserAcdAdmin ?
<tbody>
<tr>
<td className={cx('exclusion-table-styling', 'lever-disabled')}>
<td className={cx('exclusion-table-styling', 'lever-disabled')} aria-label="All non-priority">
mbeardy marked this conversation as resolved.
Show resolved Hide resolved
<span>
<h4 className="exclusion-table-header-styling">
{COPY.CASE_DISTRIBUTION_EXCLUSION_TABLE_NON_PRIORITY}
Expand All @@ -53,45 +61,53 @@ const ExclusionTable = () => {
/>
</span>
</td>
<td className={cx('exclusion-table-styling', 'lever-disabled')}>
<td className={cx('exclusion-table-styling', 'lever-disabled')} aria-label="All non-priority">
<span>
<RadioField
name=""
options={options}
vertical
uniqueIdGenerator={(option, index) =>
generateUniqueId(DISTRIBUTION.all_non_priority, option.value, index)}
/>
</span>
</td>
<td className={cx('exclusion-table-styling', 'lever-disabled')}>
<td className={cx('exclusion-table-styling', 'lever-disabled')} aria-label="All non-priority">
<span>
<RadioField
name=""
options={options}
vertical
uniqueIdGenerator={(option, index) =>
generateUniqueId(DISTRIBUTION.all_non_priority, option.value, index)}
/>
</span>
</td>
<td className={cx('exclusion-table-styling', 'lever-disabled')}>
<td className={cx('exclusion-table-styling', 'lever-disabled')} aria-label="All non-priority">
<span>
<RadioField
name=""
options={options}
vertical
uniqueIdGenerator={(option, index) =>
generateUniqueId(DISTRIBUTION.all_non_priority, option.value, index)}
/>
</span>
</td>
<td className={cx('exclusion-table-styling', 'lever-disabled')}>
<td className={cx('exclusion-table-styling', 'lever-disabled')} aria-label="All non-priority">
<span>
<RadioField
name=""
options={options}
vertical
uniqueIdGenerator={(option, index) =>
generateUniqueId(DISTRIBUTION.all_non_priority, option.value, index)}
/>
</span>
</td>
</tr>
<tr>
<td className={cx('exclusion-table-styling', 'lever-disabled')}>
<td className={cx('exclusion-table-styling', 'lever-disabled')} aria-label="All Priority">
<span>
<h4 className="exclusion-table-header-styling">
{COPY.CASE_DISTRIBUTION_EXCLUSION_TABLE_PRIORITY}
Expand All @@ -103,46 +119,55 @@ const ExclusionTable = () => {
/>
</span>
</td>
<td className={cx('exclusion-table-styling', 'lever-disabled')}>
<td className={cx('exclusion-table-styling', 'lever-disabled')} aria-label="All Priority">
<span>
<RadioField
name=""
options={options}
vertical
uniqueIdGenerator={(option, index) =>
generateUniqueId(DISTRIBUTION.all_priority, option.value, index)}
/>
</span>
</td>
<td className={cx('exclusion-table-styling', 'lever-disabled')}>
<td className={cx('exclusion-table-styling', 'lever-disabled')} aria-label="All Priority">
<span>
<RadioField
name=""
options={options}
vertical
uniqueIdGenerator={(option, index) =>
generateUniqueId(DISTRIBUTION.all_priority, option.value, index)}
/>
</span>
</td>
<td className={cx('exclusion-table-styling', 'lever-disabled')}>
<td className={cx('exclusion-table-styling', 'lever-disabled')} aria-label="All Priority">
<span>
<RadioField
name=""
options={options}
vertical
uniqueIdGenerator={(option, index) =>
generateUniqueId(DISTRIBUTION.all_priority, option.value, index)}
/>
</span>
</td>
<td className={cx('exclusion-table-styling', 'lever-disabled')}>
<td className={cx('exclusion-table-styling', 'lever-disabled')} aria-label="All Priority">
<span>
<RadioField
name=""
options={options}
vertical
uniqueIdGenerator={(option, index) =>
generateUniqueId(DISTRIBUTION.all_priority, option.value, index)}
/>
</span>
</td>
</tr>
</tbody> :

<tbody>
<th aria-label="All Non-Priority"></th>
mbeardy marked this conversation as resolved.
Show resolved Hide resolved
<tr>
<td className={cx('exclusion-table-styling', 'lever-disabled')}>
<h3>{COPY.CASE_DISTRIBUTION_EXCLUSION_TABLE_NON_PRIORITY}</h3>
Expand All @@ -168,21 +193,29 @@ const ExclusionTable = () => {
</label>
</td>
</tr>
<th aria-label="All Priority"></th>
<tr>
<td className={cx('exclusion-table-styling', 'lever-disabled')}>
<h3>All Priority</h3>
<h3>{COPY.CASE_DISTRIBUTION_EXCLUSION_TABLE_PRIORITY}</h3>
</td>
<td className={cx('exclusion-table-styling', 'lever-disabled')}>
<label className="exclusion-table-member-view-styling">Off</label>
<label className="exclusion-table-member-view-styling">
{COPY.CASE_DISTRIBUTION_EXCLUSION_TABLE_OFF}</label>
</td>
<td className={cx('exclusion-table-styling', 'lever-disabled')}>
<label className="exclusion-table-member-view-styling">Off</label>
<label className="exclusion-table-member-view-styling">
{COPY.CASE_DISTRIBUTION_EXCLUSION_TABLE_OFF}
</label>
</td>
<td className={cx('exclusion-table-styling', 'lever-disabled')}>
<label className="exclusion-table-member-view-styling">Off</label>
<label className="exclusion-table-member-view-styling">
{COPY.CASE_DISTRIBUTION_EXCLUSION_TABLE_OFF}
</label>
</td>
<td className={cx('exclusion-table-styling', 'lever-disabled')}>
<label className="exclusion-table-member-view-styling">Off</label>
<label className="exclusion-table-member-view-styling">
{COPY.CASE_DISTRIBUTION_EXCLUSION_TABLE_OFF}
</label>
</td>
</tr>
</tbody> }
Expand Down
10 changes: 5 additions & 5 deletions client/app/caseDistribution/components/LeverHistory.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -168,19 +168,19 @@ const LeverHistory = (props) => {
<table>
<tbody>
<tr>
<th className="lever-history-table-header-styling">
<th className="lever-history-table-header-styling" scope="column">
{COPY.CASE_DISTRIBUTION_LEVER_HISTORY_DATE}
</th>
<th className="lever-history-table-header-styling">
<th className="lever-history-table-header-styling" scope="column">
{COPY.CASE_DISTRIBUTION_LEVER_HISTORY_USER}
</th>
<th className="lever-history-table-header-styling">
<th className="lever-history-table-header-styling" scope="column">
{COPY.CASE_DISTRIBUTION_LEVER_HISTORY_DATA_ELEMENT}
</th>
<th className="lever-history-table-header-styling">
<th className="lever-history-table-header-styling" scope="column">
{COPY.CASE_DISTRIBUTION_LEVER_HISTORY_PREV_VALUE}
</th>
<th className="lever-history-table-header-styling">
<th className="lever-history-table-header-styling" scope="column">
{COPY.CASE_DISTRIBUTION_LEVER_HISTORY_UPDATED_VALUE}
</th>
</tr>
Expand Down
6 changes: 3 additions & 3 deletions client/app/caseDistribution/components/SaveModal.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,13 +37,13 @@ export const SaveModal = (props) => {
<table>
<tbody>
<tr>
<th className={cx('modal-table-header-styling', 'modal-table-left-styling')}>
<th className={cx('modal-table-header-styling', 'modal-table-left-styling')} scope="column">
{COPY.CASE_DISTRIBUTION_LEVER_SAVE_BUTTON_DATA}
</th>
<th className={cx('modal-table-header-styling', 'modal-table-right-styling')}>
<th className={cx('modal-table-header-styling', 'modal-table-right-styling')} scope="column">
{COPY.CASE_DISTRIBUTION_LEVER_HISTORY_PREV_VALUE}
</th>
<th className={cx('modal-table-header-styling', 'modal-table-right-styling')}>
<th className={cx('modal-table-header-styling', 'modal-table-right-styling')} scope="column">
{COPY.CASE_DISTRIBUTION_LEVER_SAVE_BUTTON_VALUE}
</th>
</tr>
Expand Down
4 changes: 2 additions & 2 deletions client/app/caseDistribution/components/StaticLever.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ const StaticLever = ({ lever }) => {
const unit = valueArray[1];

return (
<tbody>
<div>
mbeardy marked this conversation as resolved.
Show resolved Hide resolved
mbeardy marked this conversation as resolved.
Show resolved Hide resolved
<tr>
<td className="title-styling">{lever.title}</td>
</tr>
Expand All @@ -36,7 +36,7 @@ const StaticLever = ({ lever }) => {
<span>{unit}</span>
</td>
</tr>
</tbody>
</div>
);
};

Expand Down
2 changes: 2 additions & 0 deletions client/app/components/TextField.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,7 @@ export const TextField = (props) => {
name={name}
required={required}
optional={optional}
labelTextId={`label-${name}`}
/>
);

Expand Down Expand Up @@ -113,6 +114,7 @@ export const TextField = (props) => {
max={max}
autoComplete={autoComplete}
{...inputProps}
aria-labelledby={`label-${name}`}
mbeardy marked this conversation as resolved.
Show resolved Hide resolved
{...ariaLabelObj}
{...inputStyling}
/>
Expand Down
Loading