jcohen/APPEALS-37561: Adjust Seed Data and Factories to Include Timezones #20599
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…in regards to the timezone of the hearing.
…uce appropriate values of timezones in relation to hearing locations.
…one more to keep context relevant in one of the legacy_hearing_spec tests.
|
Code Climate has analyzed commit 29a7da4 and detected 1 issue on this pull request. Here's the issue category breakdown:
View more on Code Climate. |
ThorntonMatthew
changed the base branch from
master
to
feature/APPEALS-32376
app/models/legacy_hearing.rb
Outdated
| @@ -90,7 +90,7 @@ class LegacyHearing < CaseflowRecord | |||
| allow_nil: true | |||
| delegate :external_id, to: :appeal, prefix: true | |||
|
|
|||
| delegate :timezone, :name, to: :regional_office, prefix: true | |||
| delegate :timezone, :name, to: :regional_office, prefix: true, allow_nil: true | |||
There was a problem hiding this comment.
Is this still required?
ThorntonMatthew
changed the title
ThorntonMatthew
changed the title
This reverts commit 18018fa.
ThorntonMatthew
approved these changes
Feb 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge pull request #20509 from department-of-veterans-affairs/jcohen/APPEALS-37561
Resolves APPEALS-37095
Description
As a Caseflow software developer I need for the mechanisms I utilize to stage data for testing to include updates made to how hearing time information is being persisted so that I can quickly and accurately test our work.
Acceptance Criteria
Factories are updated to generate "scheduled_in_timezone" values:
These factories are located in spec/factories
Some of the factories that will need to be updated (not necessarily a comprehensive list):
hearing
legacy_hearing
Factories should produce a default "scheduled_in_timezone" value that will likely correspond with US/Eastern Time.
Factories that generate records with an association to any hearings table should be tested also.
Example: The :held_hearing trait on the Appeal factory.
Seed data configurations are altered to ensure that hearings and legacy hearings include the following information:
"scheduled_in_timezone" values
These values should represent a variety of timezones, and hearings should be spread out over a number of regional offices.
The RO-to-time zone pairings should make sense geographically.
Any RSpec test failures that stem from these updates are resolved.
Code compiles correctly
Testing Plan
Best practices
Code Documentation Updates
Tests
Test Coverage
Did you include any test coverage for your code? Check below:
Code Climate
Your code does not add any new code climate offenses? If so why?