-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/appeals 26750 kepler #21156
Merged
amybids
merged 240 commits into
feature/APPEALS-26750-36998
from
feature/APPEALS-26750-kepler
Mar 14, 2024
Merged
Feature/appeals 26750 kepler #21156
amybids
merged 240 commits into
feature/APPEALS-26750-36998
from
feature/APPEALS-26750-kepler
Mar 14, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* placeholder files exist * APPEALS-32385 the lever component should be singular * APPEALS-32385 fixed plurality in the content file
Co-authored-by: SHarshain <spoosa@razortalent.com>
- Allow intial state to be passed into the Lever Reducer - Add generator to Lever Reducer - Add functions for Lever Reducer - Fix test data array Co-authored-by: Christopher Detlef <>
* Created LeverHistory Component and updated test data * Fixed name and title, resubmitted styling and testing --------- Co-authored-by: 631966 <amy.detwiler@va.gov>
* Add toggle switch component * Added toggle fuctions for ON,OFF and Disable states * Clean up --------- Co-authored-by: SHarshain <spoosa@razortalent.com>
* Add Lever Reducer test Co-authored-by: SHarshain <133917878+SHarshain@users.noreply.github.com>
* Lint Fix for toggle * Add actions to the toggle --------- Co-authored-by: SHarshain <spoosa@razortalent.com>
* Add Lever Buttons * Add Lever Buttons wrapper * Add Lever Buttons story and test * Update Lever Reducer to no longer use lodash * Update test data * Add comments for future funtionality Co-authored-by: Christopher Detlef <>
* fix the syntax in test data * added new line EOF to fix parse error * added AdminTabs story to access the InteractableLever * WIP: nested and toggle. Completed Boolean and field component scenarios * Uppercase the unit to match the wireframe * WIP * Removed the new line * refactor and move the Scenarios into seperate component * updated the test data levers * fixed Id violation * fix indentation * match with the feature branch * add styling for the headers and fixed Header violation * code cleanup * Add the label for number * refactor * Move the components into a seperate stories, added reducers, additional filters to the lever list --------- Co-authored-by: SHarshain <spoosa@razortalent.com>
* Add functions and function shells for save and cancel buttons Co-authored-by: Christopher Detlef <>
* Created Distribution Content Area and updated history for implementation. * Created Distribution Content Area and updated history for implementation. * Updated test data and static lever implementation. * Static lever and lever history updates, declared text constants * Fixed and implementated Static Levers, Updated styling and storybook * Fixed and added buttons, fixes for static lever wrapper, updated history. * Implemented interactive levers, updated test data, created jest test * Updated data for disabled states * APPEALS-32388 made changes to the affinity days so that the default s… (#19851) * APPEALS-32388 made changes to the affinity days so that the default selected option is shown and the text box is always shown * APPEALS-32388 used a ternary statement to make the radio button always display the expected selected value * Added Exclusion Table, added notes, jest test, styling * Test Data Fix for history --------- Co-authored-by: Amy Detwiler <133032208+amybids@users.noreply.github.com>
* Make tests more robust Co-authored-by: Christopher Detlef <>
#19855) * error validation for the Number Field and Accessibility violations fix * Altered the validation message on affinity days component * added test cases for AffinityDays, BatchSize and DocketTimeGoals components * Added Dom ID element for the toggle * fix the lint errors in the component --------- Co-authored-by: SHarshain <spoosa@razortalent.com>
…19889) Co-authored-by: SHarshain <spoosa@razortalent.com>
Co-authored-by: SHarshain <spoosa@razortalent.com>
* adds case_distribution_lever.rb file * removes id column from model * removes migration files * APPEALS-34066 re-added the case distribution levers migration --------- Co-authored-by: 631966 <amy.detwiler@va.gov>
…ated CaseflowDistributionApp file (#19898)
…l, updates leverbuttons (#19919)
* APPEALS-32253. Seeding the case distribution levers table * APPEALS-32253. Updated the levers data according the requirements * updated some values in the case distribution levers. * conditional model validation for new lever object and cleanup --------- Co-authored-by: SHarshain <spoosa@razortalent.com> Co-authored-by: 631966 <amy.detwiler@va.gov>
Co-authored-by: Christopher Detlef <> Co-authored-by: 631966 <amy.detwiler@va.gov>
* Moved Caseflow Distribution work to new directory, fixed imports, created CaseflowDistributionApp file * Removed AdminTabs, and AffinityDays, BatchSize updates. * Caseflow Distribution cleanup and Implementing LeversWrapper. * Component and CSS Updates * Updated stories and styling * More styling formatting and moved scss files. * Further CSS Updates and clean up * Updated Tests, and Test Data --------- Co-authored-by: 631966 <amy.detwiler@va.gov>
* Second draft * APPEALS-34018 Create CDLever Controller and Routing --------- Co-authored-by: Christopher Detlef <> Co-authored-by: 631966 <amy.detwiler@va.gov> Co-authored-by: Amy Detwiler <133032208+amybids@users.noreply.github.com>
* adds levermodal update * adds levermodal story, adds return state in table * updates logic to parse/compare json, styling, story * Updated modal styling * adds jest test for levermodal * Updated LeverModal Test --------- Co-authored-by: 631068 <rickybmanus@gmail.com>
* APPEALS-34018 Create CDLever Controller and Routing * Second draft * APPEALS-34018 Add alpha of Lever page and update controller spec --------- Co-authored-by: Christopher Detlef <>
This reverts commit 6eca847.
Co-authored-by: Amy Detwiler <133032208+amybids@users.noreply.github.com>
* fix units showing when not needed * Update schema.rb * APPEALS-38967 minor cleanup of ticket --------- Co-authored-by: 631966 <amy.detwiler@va.gov>
* APPEALS-38744 added checks for ama hearing case affinity days lever * APPEALS-38744 refactored logic for ama hearing case affinity days lever * APPEALS-38744 update method name
…sts to conform to new data changes (#20991)
* fix units showing when not needed * Update schema.rb * APPEALS-38967 minor cleanup of ticket --------- Co-authored-by: Matthew Roth <roth_matthew@bah.com>
* "adds ama aod original appeals method to scopes" * "adds conditional to only_genpop_appeals" * "removes unnecessary copied code" * "adds comment" * "Updates to formatting for shovel methods" * "updates conditional to include correct function, changes scope chain" * "Updates and adds scope for infinite, test passes" * "adds infinite method to scopes" * "created new test scenarios" * "moves line up" * "updates distribution scope methods" * "updates methods" * "updates rspec to update attribute" * "updates def and values" * "updates rspec to new methods" --------- Co-authored-by: Michael Beard <michael.beard@va.gov>
Co-authored-by: Christopher Detlef <> Co-authored-by: Amy Detwiler <133032208+amybids@users.noreply.github.com>
* "init commit for updating not_genpop_appeals" * "adds new context and updates top ama" * "updates methods on scopes, adds new appeals, updates specs" * Updated logic and rspec tests * APPEALS-38744 rearranged the not_genpop_appeals to only run the not_genpop_appeals query once * APPEALS-38744 took out puts * APPEALS-38744 the queries work through binding.pry the tests are failing due to setup issues * APPEALS-38744 update with new pattern * APPEALS-38744 added a conditional to make affinity days chained correctly * APPEALS-38744 more fiddling * Fix code issues for query structures * Make returns uniformly arrays of arrays * flagged error * "updates hearing docket method to if else" * "fixes ish respecs adding with_no_held_hearings to the array" * "cleanup brush brush brush" --------- Co-authored-by: 631068 <rickybmanus@gmail.com> Co-authored-by: 631966 <amy.detwiler@va.gov> Co-authored-by: Christopher Detlef <>
Co-authored-by: Christopher Detlef <>
… that there isn't 200 changed files
* "updates jest to reflect code changes and updates selector logic" * "updates savemodal jest" * "Updates leversActions test, removes redundancies" * "Updates infinite, omit, and updated value tests"
* APPEALS-42010 fix rspecs * APPEALS-42010 update specs and address pr suggestions --------- Co-authored-by: Amy Detwiler <133032208+amybids@users.noreply.github.com>
* Updated seed data * Updated seed data for days_before_goal_due_for_distribution lever * Reworked solution and renamed lever to be correct
* APPEALS-26750 commenting out method that was failing in seeds * APPEALS-26750 added logic for unique veteran too * APPEALS-26750 updating the seeds to get the params properly * APPEALS-26750 enabled the call to create_case_ready_for_more_than_hearing_affinity_days(judge)
* increase the number of digits in the css_id sequence * modify generated CSS_IDs and sequence to shorten to 12 characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves Jira Issue Title
Description
Please explain the changes you made here.
Acceptance Criteria
Testing Plan
Frontend
User Facing Changes
Storybook Story
For Frontend (Presentation) Components
MyComponent.stories.js
alongsideMyComponent.jsx
)Backend
Database Changes
Only for Schema Changes
created_at
,updated_at
) for new tablesCaseflow::Migration
, especially when adding indexes (useadd_safe_index
) (see Writing DB migrations)migrate:rollback
works as desired (change
supported functions)make check-fks
; add any missing foreign keys or add toconfig/initializers/immigrant.rb
(see Record associations and Foreign Keys)belongs_to
for associations to enable the schema diagrams to be automatically updatedIntegrations: Adding endpoints for external APIs
Best practices
Code Documentation Updates
Tests
Test Coverage
Did you include any test coverage for your code? Check below:
Code Climate
Your code does not add any new code climate offenses? If so why?
Monitoring, Logging, Auditing, Error, and Exception Handling Checklist
Monitoring
Logging
Auditing
Error Handling
Exception Handling