Remove package actions from View package button Review package page

[kamala-07]

Resolves - Review Package: Remove Package (https://jira.devops.va.gov/browse/APPEALS-41727)

Description

If a Correspondence have any pending Removal request a banner displays on the Review package page. There is Review removal request button, when we click on that a modal appears. From the Remove request modal, we can select the radio options for Approve request and Reject request which displays the Success and Failure banners accordingly.

To display the Failure banner for Approve request and Reject request in the Lower Environment, we have a Private method reassign_remove_banner_action in correspondence_contoller_util.rb, we need to pass a statement in this method reassign_remove_banner_action.

Acceptance Criteria

• Code compiles correctly

Testing Plan

1. Login as a Mail Team Supervisor.
2. From Switch view, select Correspondence cases.
3. In the Correspondence cases page, go to Action required tab.
4. Click on the Correspondence with Action type: Remove.

5. A Review request modal appears. 6. Click on the View package button. 7. A info banner displays on the Review package. 8. From the Review package page we can click on the Review removal request button, a modal appears. 9. From the Review request modal, select Approve request radio button and click on Confirm. 10. A Success banner appears on the Correspondence cases page. 11. From the Remove request modal, select Reject request radio button and a textarea field appears, enter the text and click on Confirm button. 12. A Success banner appears on the Correspondence cases page. 13. From the Review request modal, select Approve request radio button and click on Confirm. A Failure banner displays. 14. From the Remove request modal, select Reject request radio button and a textarea field appears, enter the text and click on Confirm button. A failure banner displays.

1. Go to Jira Issue/Test Plan Link or list them below

• For feature branches merging into master: Was this deployed to UAT?

Frontend

User Facing Changes

• Screenshots of UI changes added to PR & Original Issue

BEFORE	AFTER

Storybook Story

For Frontend (Presentation) Components

• Add a Storybook file alongside the component file (e.g. create MyComponent.stories.js alongside MyComponent.jsx)
• Give it a title that reflects the component's location within the overall Caseflow hierarchy
• Write a separate story (within the same file) for each discrete variation of the component

Backend

Database Changes

Only for Schema Changes

• Add typical timestamps (created_at, updated_at) for new tables
• Update column comments; include a "PII" prefix to indicate definite or potential PII data content
• Have your migration classes inherit from Caseflow::Migration, especially when adding indexes (use add_safe_index) (see Writing DB migrations)
• Verify that migrate:rollback works as desired (change supported functions)
• Perform query profiling (eyeball Rails log, check bullet and fasterer output)
• For queries using raw sql was an explain plan run by System Team
• Add appropriate indexes (especially for foreign keys, polymorphic columns, unique constraints, and Rails scopes)
• Run make check-fks; add any missing foreign keys or add to config/initializers/immigrant.rb (see Record associations and Foreign Keys)
• Add belongs_to for associations to enable the schema diagrams to be automatically updated
• Document any non-obvious semantics or logic useful for interpreting database data at Caseflow Data Model and Dictionary

Integrations: Adding endpoints for external APIs

• Check that Caseflow's external API code for the endpoint matches the code in the relevant integration repo
  • Request: Service name, method name, input field names
  • Response: Check expected data structure
  • Check that calls are wrapped in MetricService record block
• Check that all configuration is coming from ENV variables
  • Listed all new ENV variables in description
  • Worked with or notified System Team that new ENV variables need to be set
• Update Fakes
• For feature branches: Was this tested in Caseflow UAT

Best practices

Code Documentation Updates

• Add or update code comments at the top of the class, module, and/or component.

Tests

Test Coverage

Did you include any test coverage for your code? Check below:

• RSpec
• Jest
• Other

Code Climate

Your code does not add any new code climate offenses? If so why?

• No new code climate issues added

Monitoring, Logging, Auditing, Error, and Exception Handling Checklist

Monitoring

• Are performance metrics (e.g., response time, throughput) being tracked?
• Are key application components monitored (e.g., database, cache, queues)?
• Is there a system in place for setting up alerts based on performance thresholds?

Logging

• Are logs being produced at appropriate log levels (debug, info, warn, error, fatal)?
• Are logs structured (e.g., using log tags) for easier querying and analysis?
• Are sensitive data (e.g., passwords, tokens) redacted or omitted from logs?
• Is log retention and rotation configured correctly?
• Are logs being forwarded to a centralized logging system if needed?

Auditing

• Are user actions being logged for audit purposes?
• Are changes to critical data being tracked ?
• Are logs being securely stored and protected from tampering or exposing protected data?

Error Handling

• Are errors being caught and handled gracefully?
• Are appropriate error messages being displayed to users?
• Are critical errors being reported to an error tracking system (e.g., Sentry, ELK)?
• Are unhandled exceptions being caught at the application level ?

Exception Handling

• Are custom exceptions defined and used where appropriate?
• Is exception handling consistent throughout the codebase?
• Are exceptions logged with relevant context and stack trace information?
• Are exceptions being grouped and categorized for easier analysis and resolution?

[HunJerBAH]

Great work!