-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
41642 - Intake: task creation #21636
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HunJerBAH
reviewed
May 15, 2024
HunJerBAH
reviewed
May 15, 2024
HunJerBAH
reviewed
May 15, 2024
HunJerBAH
reviewed
May 15, 2024
HunJerBAH
reviewed
May 15, 2024
HunJerBAH
reviewed
May 15, 2024
HunJerBAH
reviewed
May 17, 2024
HunJerBAH
requested changes
May 17, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some changes needed to keep plurality and naming consistent from before/after, but otherwise good work!
client/app/queue/correspondence/correspondenceReducer/correspondenceConstants.js
Outdated
Show resolved
Hide resolved
client/app/queue/correspondence/correspondenceReducer/correspondenceReducer.js
Outdated
Show resolved
Hide resolved
client/app/queue/correspondence/correspondenceReducer/correspondenceReducer.js
Outdated
Show resolved
Hide resolved
…and removed old checks that are not needed
…rrespondence.scss stylesheet
zurbergram
previously approved these changes
May 29, 2024
HunJerBAH
previously approved these changes
May 29, 2024
…ondence_auto_assign.rb
HunJerBAH
approved these changes
May 29, 2024
Rnmarshall93
pushed a commit
that referenced
this pull request
May 30, 2024
* new branch for inbound_ops_team_user changes * more changes * changes for database * updated changes for InboundOpsTeam * update inbound name * update name * update spec test * remove comma * namespace validation * fixed plurality * change namespace for correspondence verification * fix plurality changes * remove brackets * fixing spec test * update naming * update spec tests... again :) * update affilaited * updated correspondence access check to handle if no user is present, and removed old checks that are not needed * excluded admins from inbound ops team user check * added comment for validation check * added check for system users and allow system users to create correspondence tasks * updated seeds and correspondence validation to check current session user * fixed linting issues * updated factory to sign out system user, removed other org checks from the controller validation, and added back in guard clause for correspondence intake task creation. * reverted mail team change from inbound ops * added saftey operator to system user check * removed factory changes and added validations to correspondence create_from_params methods * moved created methods to self and updated failing test * fixed failing tests * fixed failing correspondence tests * fixed failing tests by adding test user back into MailTeam org * fixed failing test in review package spec by adding back in MailTeam or assignment * updated failing tests and linting issues in tests * fix linting issues in organization users scss * pshing up linting fixes for correspondence.scss * finish lint clean up * fixed test failures * resolved linting issues in stylesheet * resolved failing test in intake spec * resolved failing test * fixed permission check to check current user * fixed styling issue with pagination buttons * removed Jolly Postman from seed data * upped wait time. * updated verify_correspondence_access to accept a user param * fixed linting issues in _correspondence.scss * fixed correspondence_intake_spec test and fixed linting issues on _correspondence.scss stylesheet * fixed method name on inbound ops team seed member creation in correspondence_auto_assign.rb --------- Co-authored-by: HunJerBAH <Jeremy.Hunton@va.gov> Co-authored-by: HunJerBAH <99915461+HunJerBAH@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves Intake: task creation
Description
Limit Correspondence Task creation to only users within Inbound Ops Team so that, when reports are created to view all created tasks during intake, it will be only Inbound Ops users who created the tasks