-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Justin/appeals 41645 v1 #21653
Merged
Merged
Justin/appeals 41645 v1 #21653
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Code Climate has analyzed commit 7f40aca and detected 24 issues on this pull request. Here's the issue category breakdown:
View more on Code Climate. |
HunJerBAH
reviewed
May 16, 2024
HunJerBAH
reviewed
May 16, 2024
HunJerBAH
reviewed
May 16, 2024
HunJerBAH
reviewed
May 16, 2024
HunJerBAH
approved these changes
May 17, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works like a charm and the seed data looks good. Great work Justin!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves Auto-Assign: Mail Superuser capacity calculation
Description
Changed the superuser definitions to calculate based on the "Superuser: Split, Merge, Reassign" permissions.
Added a seed file for test users with the superuser permissions
Updated/Refactored the auto assignable
NOTES:
The users that now meet the new definition of superusers are the following:
Acceptance Criteria
Testing Plan
Go to Jira Issue/Test Plan Link or list them below
Log in as Jolly Postman and navigate to /queue/correspondence (which can either be appended to the address bar, or you can click "queue" and then choose "your correspondence" from the switch views dropdown). This will show you what the view should look like for a standard user.
Using a new tab, you can navigate to /test/users and sign in to INBOUND_OPS_TEAM_ADMIN_USER (Jon Mailteam Snow Admin).
Once you see the new user is logged in in the top right corner, you can navigate back to the first tab and refresh your page (in the /queue/correspondence tab). This should change the views and open the team view of the correspondence cases.
Since this user is now a superuser, the Auto assign correspondences button should show up and appear blue.
Using the /test/users tab, now log in as INBOUND_OPS_TEAM_MAIL_INTAKE_USER (Jon Mailteam Snow Mail Intake)
Once you see the new user is logged in in the top right corner, you can navigate back to the first tab and navigate to /queue/correspondence. This should again change the views and open the team view of the correspondence cases.
Since this user is also a superuser, the Auto assign correspondences button should show up and appear blue.