-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
APPEALS-46239 ACD: Distribution Stats improvements FY24Q3 #21727
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* rebuild branch * Create 20240506140249_add_cols_to_distribution_stats.rb * unit tests and linting
Code Climate has analyzed commit 44e5d3c and detected 0 issues on this pull request. View more on Code Climate. |
…fairs/caseflow into feature/APPEALS-46239
…fairs/caseflow into feature/APPEALS-46239
* remove unnecessary reporting * send slack message to console if on local or demo * add excluded judges to slack report * reporting method cleanup * added affinity date stats to distribution_stats for each docket * Update docket.rb * Update distribution_scopes.rb * unit tests and linting * unit tests and linting
zurbergram
changed the title
APPEALS-42221 Distribution Stats: Break statistics into columns (#21717)
APPEALS-46239 ACD: Distribution Stats improvements FY24Q3
Jul 9, 2024
amybids
reviewed
Jul 12, 2024
amybids
approved these changes
Jul 12, 2024
* code climate and code review changes * move code out to its own class * lint fixes * revert * disable reek checks * fix method calls
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves
Description
Please explain the changes you made here.
Acceptance Criteria
Testing Plan
Frontend
User Facing Changes
Storybook Story
For Frontend (Presentation) Components
MyComponent.stories.js
alongsideMyComponent.jsx
)Backend
Database Changes
Only for Schema Changes
created_at
,updated_at
) for new tablesCaseflow::Migration
, especially when adding indexes (useadd_safe_index
) (see Writing DB migrations)migrate:rollback
works as desired (change
supported functions)make check-fks
; add any missing foreign keys or add toconfig/initializers/immigrant.rb
(see Record associations and Foreign Keys)belongs_to
for associations to enable the schema diagrams to be automatically updatedIntegrations: Adding endpoints for external APIs
Best practices
Code Documentation Updates
Tests
Test Coverage
Did you include any test coverage for your code? Check below:
Code Climate
Your code does not add any new code climate offenses? If so why?
Monitoring, Logging, Auditing, Error, and Exception Handling Checklist
Monitoring
Logging
Auditing
Error Handling
Exception Handling