-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature/APPEALS-28925-33581 - Update to Rails 6.1 & Replace 'multiverse' with standard Rails multi-DB configuration #21736
Commits on May 14, 2024
-
🔥 Remove deprecated config setting `config.active_record.sqlite3.repr…
…esent_boolean_as_integer` This will have no implications for Caseflow, since we are only using the `sqlite3` adapter nominally for the `demo_vacols` database, which is not actually being used in our demo environments (demo environments are deployed as `development` envs).
Configuration menu - View commit details
-
Copy full SHA for c24194d - Browse repository at this point
Copy the full SHA c24194dView commit details
Commits on May 15, 2024
-
⬆️ Update
caseflow-commons
to resolve sub-dependency conflictsRemoves unneeded gems `bourbon` and `neat`, which were causing a sub-dependency conflict on `thor`.
Configuration menu - View commit details
-
Copy full SHA for 4596d29 - Browse repository at this point
Copy the full SHA 4596d29View commit details -
Configuration menu - View commit details
-
Copy full SHA for a351e11 - Browse repository at this point
Copy the full SHA a351e11View commit details -
Configuration menu - View commit details
-
Copy full SHA for c752f17 - Browse repository at this point
Copy the full SHA c752f17View commit details -
Configuration menu - View commit details
-
Copy full SHA for fcbc037 - Browse repository at this point
Copy the full SHA fcbc037View commit details
Commits on May 16, 2024
-
🔧 Assume default for
config.active_record.has_many_inversing
The default value is safe to assume here. There is a possible edge-case for recursive associations having the same name as the model, but we do not have any such associations in Caseflow. For more background, see https://lilyreile.medium.com/rails-6-1-new-framework-defaults-what-they-do-and-how-to-safely-uncomment-them-c546b70f0c5e#9072
Configuration menu - View commit details
-
Copy full SHA for 61e9503 - Browse repository at this point
Copy the full SHA 61e9503View commit details -
🔧 Assume default for
config.active_storage.track_variants
We're not currently using ActiveStorage in Caseflow, so it is safe to just assume the default here.
Configuration menu - View commit details
-
Copy full SHA for 719bd1a - Browse repository at this point
Copy the full SHA 719bd1aView commit details -
🔧 Override default for
config.active_job.retry_jitter
The default jitter is probably safe, however, I'm not 100% sure that we don't have any jobs that need to be requeued with exact wait times. So we let's override this for now to stay on the safe side.
Configuration menu - View commit details
-
Copy full SHA for 6121503 - Browse repository at this point
Copy the full SHA 6121503View commit details -
🔧 Assume default for `config.active_job.skip_after_callbacks_if_termi…
…nated` We're not currently using `throw :abort` within any `before_enqueue`/`before_perform` callbacks on existing Caseflow jobs, so the default should be fine here. For more background, see https://lilyreile.medium.com/rails-6-1-new-framework-defaults-what-they-do-and-how-to-safely-uncomment-them-c546b70f0c5e#4c60
Configuration menu - View commit details
-
Copy full SHA for a4ac181 - Browse repository at this point
Copy the full SHA a4ac181View commit details -
🔧 Assume default for `config.action_dispatch.cookies_same_site_protec…
…tion` This setting controls the `SameSite` optional attribute for the `Set-Cookie` header. `SameSite=Lax` means that the cookie is not sent on cross-site requests, such as on requests to load images or frames, but is sent when a user is navigating to the origin site from an external site (for example, when following a link). This is the default behavior if the SameSite attribute is not specified. `Lax` is currently the default assumed by both Chrome and Edge browsers when this attribute is left unspecified, so assuming this value should be sensible. It allows us to have our cake (blocking CSRF attacks) and eat it too (providing a logged-in experience when users navigate to Caseflow across origins). For more background, see - https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Set-Cookie#samesitesamesite-value - https://lilyreile.medium.com/rails-6-1-new-framework-defaults-what-they-do-and-how-to-safely-uncomment-them-c546b70f0c5e#1f15
Configuration menu - View commit details
-
Copy full SHA for b82a517 - Browse repository at this point
Copy the full SHA b82a517View commit details -
Configuration menu - View commit details
-
Copy full SHA for cdde9b6 - Browse repository at this point
Copy the full SHA cdde9b6View commit details -
🔧 Assume default for `ActiveSupport.utc_to_local_returns_utc_offset_t…
…imes` We're not using `ActiveSupport::TimeZone.utc_to_local` anywhere, so the default is safe to assume here.
Configuration menu - View commit details
-
Copy full SHA for 3e40619 - Browse repository at this point
Copy the full SHA 3e40619View commit details -
🔧 Assume default for `config.action_dispatch.ssl_default_redirect_sta…
…tus` The default is safe to assume. For more background, see https://lilyreile.medium.com/rails-6-1-new-framework-defaults-what-they-do-and-how-to-safely-uncomment-them-c546b70f0c5e#4c3e
Configuration menu - View commit details
-
Copy full SHA for 1383a2c - Browse repository at this point
Copy the full SHA 1383a2cView commit details -
🔧 Assume default for
config.active_record.legacy_connection_handling
The default should be safe to assume here, as we do not do any role or shard switching on database connections. For more background, see https://lilyreile.medium.com/rails-6-1-new-framework-defaults-what-they-do-and-how-to-safely-uncomment-them-c546b70f0c5e#8007
Configuration menu - View commit details
-
Copy full SHA for 5b05f55 - Browse repository at this point
Copy the full SHA 5b05f55View commit details -
🔧 Assume default for `config.action_view.form_with_generates_remote_f…
…orms` We don't use the `form_with` helper anywhere, so this behavior change is inconsequential for us, and we can safely assume the new default.
Configuration menu - View commit details
-
Copy full SHA for 3bb27a0 - Browse repository at this point
Copy the full SHA 3bb27a0View commit details -
🔧 Assume default for
config.active_storage.queues.analysis
We do not use ActiveStorage, so the default is safe to assume here.
Configuration menu - View commit details
-
Copy full SHA for 090b1ee - Browse repository at this point
Copy the full SHA 090b1eeView commit details -
🔧 Assume default for
config.active_storage.queues.purge
We do not use ActiveStorage, so the default is safe to assume here.
Configuration menu - View commit details
-
Copy full SHA for 51a515e - Browse repository at this point
Copy the full SHA 51a515eView commit details -
🔧 Assume default for
config.action_mailbox.queues.incineration
We don't use ActionMailbox, so the new default is safe to assume here.
Configuration menu - View commit details
-
Copy full SHA for fef5031 - Browse repository at this point
Copy the full SHA fef5031View commit details -
🔧 Assume default for
config.action_mailbox.queues.routing
We do not use ActionMailbox, so the default is safe to assume here.
Configuration menu - View commit details
-
Copy full SHA for ea29b0b - Browse repository at this point
Copy the full SHA ea29b0bView commit details -
🔧 Assume default for
config.action_mailer.deliver_later_queue_name
We're not using `ActionMailer::MessageDelivery #deliver_later` anywhere, so the default is safe to assume.
Configuration menu - View commit details
-
Copy full SHA for 43d4b0d - Browse repository at this point
Copy the full SHA 43d4b0dView commit details -
🔧 Assume default for
config.action_view.preload_links_header
This flag can be safely uncommented. Browsers that support Link headers will get a performance boost. Browsers that don’t will ignore them. We override in `development` environments to avoid an edge case leading to an HTTP response header overflow. For more background, see https://lilyreile.medium.com/rails-6-1-new-framework-defaults-what-they-do-and-how-to-safely-uncomment-them-c546b70f0c5e#3679
Configuration menu - View commit details
-
Copy full SHA for e898eff - Browse repository at this point
Copy the full SHA e898effView commit details -
Configuration menu - View commit details
-
Copy full SHA for 542ee80 - Browse repository at this point
Copy the full SHA 542ee80View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7bf11ad - Browse repository at this point
Copy the full SHA 7bf11adView commit details
Commits on May 17, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 9ac6b0e - Browse repository at this point
Copy the full SHA 9ac6b0eView commit details -
Configuration menu - View commit details
-
Copy full SHA for ee5f680 - Browse repository at this point
Copy the full SHA ee5f680View commit details -
Configuration menu - View commit details
-
Copy full SHA for cbb9cec - Browse repository at this point
Copy the full SHA cbb9cecView commit details -
🩹 Add forgotten disallowed deprecation warning
This deprecation warning was addressed by the following PR, but we forgot to add it to the list of disallowed deprecation warnings: #21614
Configuration menu - View commit details
-
Copy full SHA for 0506fdf - Browse repository at this point
Copy the full SHA 0506fdfView commit details -
Task `rake routes` has been replaced with `rails routes`
Configuration menu - View commit details
-
Copy full SHA for a0d6103 - Browse repository at this point
Copy the full SHA a0d6103View commit details -
✅ Update test to account for change to `ActionDispatch::Response#cont…
…ent_type` `ActionDispatch::Response#content_type` now returns the full Content-Type header
Configuration menu - View commit details
-
Copy full SHA for b1ca3da - Browse repository at this point
Copy the full SHA b1ca3daView commit details -
Configuration menu - View commit details
-
Copy full SHA for 043a7d7 - Browse repository at this point
Copy the full SHA 043a7d7View commit details
Commits on May 20, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 9c670c9 - Browse repository at this point
Copy the full SHA 9c670c9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 00c19f1 - Browse repository at this point
Copy the full SHA 00c19f1View commit details -
♻️ Arrange 'database.yml' configs by environment
Group DB configs by environment in anticipation of reformatting for Rails 6+ multi-DB configuration.
Configuration menu - View commit details
-
Copy full SHA for 8844a78 - Browse repository at this point
Copy the full SHA 8844a78View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0df5bac - Browse repository at this point
Copy the full SHA 0df5bacView commit details -
Configuration menu - View commit details
-
Copy full SHA for a02b952 - Browse repository at this point
Copy the full SHA a02b952View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9a1cc75 - Browse repository at this point
Copy the full SHA 9a1cc75View commit details
Commits on May 21, 2024
-
♻️ Use new database-specific rake tasks
After migrating to the Rails 6+ native multi-database configuration, the behavior of some DB management tasks, such as `rake db:migrate` changed such that they now act on ALL databases and not just the primary database. So we must replace the invocations of these tasks with their new, database-specific counterparts.
Configuration menu - View commit details
-
Copy full SHA for 1ed3db7 - Browse repository at this point
Copy the full SHA 1ed3db7View commit details -
Now that we have fiully transitioned to Rails-native multi-database support, we are no longer reliant on the 'multiverse' gem and can remove it.
Configuration menu - View commit details
-
Copy full SHA for 6bb34c2 - Browse repository at this point
Copy the full SHA 6bb34c2View commit details -
🗃️ Prohibit execution of non-DB-specific rake tasks
After transitioning to Rails-native multi-DB support, the behavior of some DB tasks changed such that they will now act on ALL databases and not just the primary database (ex. `rake db:migrate` will now migrate ALL databases). To avoid accidents, we re-define these tasks here to no-op and output a helpful message to redirect developers toward using their new database-specific counterparts instead.
Configuration menu - View commit details
-
Copy full SHA for b505f3e - Browse repository at this point
Copy the full SHA b505f3eView commit details -
🗃️ Prevent execution of vacols DB-specific rake tasks
Explicitly clear any generated database tasks for the vacols DB. Once on Rails 7+, we can instead add the `database_tasks: false` option to the `database.yml` to permit connection to the vacols database without generating database tasks for it: https://github.com/rails/rails/blob/984c3ef2775781d47efa9f541ce570daa2434a80/guides/source/active_record_multiple_databases.md?plain=1#L203-L219
Configuration menu - View commit details
-
Copy full SHA for a366478 - Browse repository at this point
Copy the full SHA a366478View commit details
Commits on May 23, 2024
-
♻️ Create new environment for GH workflow 'Make-docs-to-webpage'
Instead of performing a bunch of hard-to-maintain `sed` gymnastics to modify the existing 'test' environment, let's create a new 'make_docs' environment (based off of 'test') and configure it appropriately for use by the 'Make-docs-to-webpage' GH workflow.
Configuration menu - View commit details
-
Copy full SHA for 38efb92 - Browse repository at this point
Copy the full SHA 38efb92View commit details