Correspondence Intake Processor cleanup

[Rnmarshall93]

Resolves Correspondence Intake Processor cleanup

Description

This change refactors a few different models so that they're cleaner and inherit correctly.

• associated_with_claims_folder_mail_task.rb now inherits from CorrespondenceMailTask
• sent_to_roj_mail_task.rb now inherits from CorrespondenceMailTask
• vacols_updated_mail_task.rb now inherits from CorrespondenceMalTask
• In CorrespondenceIntakeProcessor, the tasks Returned or undeliverable mail, Sent to ROJ have been removed as they are deprecated.
• In CorrespondenceIntakeProcessor, the methods class_for_data and task_class_for_type have been refactored to task_class_for_task_related and task_class_for_task_unrelated additionally, two new methods have been added to replace their functionality. task_class_for_task_related and task_class_for_task_unrelated
• In CorrespondenceIntakeProcessor, the large list of tasks has been refactored into two distinct lists. TASKS_NOT_RELATED_TO_APPEAL_TASK_TYPES and TASKS_RELATED_TO_APPEAL_TASK_TYPES

Acceptance Criteria

• Code compiles correctly