-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature/appeals-45972 #21818
Merged
Merged
feature/appeals-45972 #21818
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Added Assignment Queue link to Switch Users test page * Updated controller to validate role and redirect * Updated error information * Updated rspec tests * Ricky/appeals-43523 (#21345) * Added Assignment Queue link to Switch Users test page * Updated controller to validate role and redirect * Updated error information * Updated rspec tests * Added Download Ineligible Judge List * APPEALS-43116 add sentry error capture to push priority job and updated specs (#21369) * Updated query to include css_id and updated id fetch * Updates button styling, fixed csv to have all values but judge name * Updated id to sattyid values, and added name data to column * fixed linting error * Updated logic to account for inactive users in both caseflow and vacols * Updated button component and cleaned up code * Updated handling of ids in situation where sattyid is unavailable in record * Updated to have individual columns for caseflow id and satty id * APPEALS-43117 Add QA Users for testing (#21580) * APPEALS-43117 Add QA Users for testing * Fix rspecs --------- Co-authored-by: Christopher Detlef <> * APPEALS-42266 Remove CaseDistributionLevers seed config in Rails helper and update required spec files * APPEALS-42266 fixing a couple of linting issues * APPEALS-43523 reverted the legacy tasks controller (#21713) * APPEALS-43523 reverted the legacy tasks controller * APPEALS-43523 reverted the erorrs concern too * Update legacy_tasks_controller_spec.rb * reverted raven call * APPEALS-46208 fixed code climate warning about a bad naming convention. * APPEALS-46208 fixed indentation --------- Co-authored-by: 631068 <rickybmanus@gmail.com> Co-authored-by: Blake Manus <33578594+Blake-Manus@users.noreply.github.com> Co-authored-by: kristeja <112115264+kristeja@users.noreply.github.com> Co-authored-by: cdetlefva <133903625+cdetlefva@users.noreply.github.com> Co-authored-by: kristeja <krishnateja.golla@va.gov>
* Added tests and added logic to account for sct distribution * Added more tests and changed logic * Adding comments * Fixing logic for SCT * Update test and logic * Fixing tests * Update docket switch mail task to match corrected logic * Fixing logic * Cleaning up refactor * Worked with the amazing ALex and we figured it out! * Fixing linting issue * Fix linting issues * Skipping flaky tests * Skipping another flaky test --------- Co-authored-by: Alexandra Ferencz <ferencz_alexandra@bah.com> Co-authored-by: raymond-hughes <raymond.hughes2@va.gov> Co-authored-by: Raymond Hughes <131811099+raymond-hughes@users.noreply.github.com>
* Upgrade aws-sdk gem to v3.2 * Update caseflow-commons hash * Apply new hash update * Skip flaky test --------- Co-authored-by: Matthew Thornton <ThorntonMatthew@users.noreply.github.com>
* Update gemfile and gemfile.lock to point to new bgs version * Skipping flake specs in review_spec.rb file
…/FY24Q3.3.0 Release/fy24 q3.3.0
* Remove UUID from attrs sent_to metrics. * pushing with some linting issues for visibility. * Change config implementation. * Remove UUID from spec * remove uuid from update_appellant job * diable rubocop for open_telemetry init * OTEL fixes * rescue, errors --------- Co-authored-by: mikefinneran <110622959+mikefinneran@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove UUID from attrs sent_to metrics.
pushing with some linting issues for visibility.
Change config implementation.
Remove UUID from spec
remove uuid from update_appellant job
diable rubocop for open_telemetry init
OTEL fixes
rescue, errors
Co-authored-by: mikefinneran 110622959+mikefinneran@users.noreply.github.com
Resolves Jira Issue Title
Description
Please explain the changes you made here.
Acceptance Criteria
Testing Plan
Frontend
User Facing Changes
Storybook Story
For Frontend (Presentation) Components
MyComponent.stories.js
alongsideMyComponent.jsx
)Backend
Database Changes
Only for Schema Changes
created_at
,updated_at
) for new tablesCaseflow::Migration
, especially when adding indexes (useadd_safe_index
) (see Writing DB migrations)migrate:rollback
works as desired (change
supported functions)make check-fks
; add any missing foreign keys or add toconfig/initializers/immigrant.rb
(see Record associations and Foreign Keys)belongs_to
for associations to enable the schema diagrams to be automatically updatedIntegrations: Adding endpoints for external APIs
Best practices
Code Documentation Updates
Tests
Test Coverage
Did you include any test coverage for your code? Check below:
Code Climate
Your code does not add any new code climate offenses? If so why?
Monitoring, Logging, Auditing, Error, and Exception Handling Checklist
Monitoring
Logging
Auditing
Error Handling
Exception Handling
Added Assignment Queue link to Switch Users test page
Updated controller to validate role and redirect
Updated error information
Updated rspec tests
Ricky/appeals-43523 (Ricky/appeals-43523 #21345)
Added Assignment Queue link to Switch Users test page
Updated controller to validate role and redirect
Updated error information
Updated rspec tests
Added Download Ineligible Judge List
APPEALS-43116 add sentry error capture to push priority job and updated specs (APPEALS-43116 Improve alerts for when Push Priority job fails #21369)
Updated query to include css_id and updated id fetch
Updates button styling, fixed csv to have all values but judge name
Updated id to sattyid values, and added name data to column
fixed linting error
Updated logic to account for inactive users in both caseflow and vacols
Updated button component and cleaned up code
Updated handling of ids in situation where sattyid is unavailable in record
Updated to have individual columns for caseflow id and satty id
APPEALS-43117 Add QA Users for testing (APPEALS-43117 Add QA Users for testing #21580)
APPEALS-43117 Add QA Users for testing
Fix rspecs
Co-authored-by: Christopher Detlef <>
APPEALS-42266 Remove CaseDistributionLevers seed config in Rails helper and update required spec files
APPEALS-42266 fixing a couple of linting issues
APPEALS-43523 reverted the legacy tasks controller (APPEALS-43523 reverted the legacy tasks controller #21713)
APPEALS-43523 reverted the legacy tasks controller
APPEALS-43523 reverted the erorrs concern too
Update legacy_tasks_controller_spec.rb
reverted raven call
APPEALS-46208 fixed code climate warning about a bad naming convention.
APPEALS-46208 fixed indentation
Co-authored-by: 631068 rickybmanus@gmail.com
Co-authored-by: Blake Manus 33578594+Blake-Manus@users.noreply.github.com
Co-authored-by: kristeja 112115264+kristeja@users.noreply.github.com
Co-authored-by: cdetlefva 133903625+cdetlefva@users.noreply.github.com
Co-authored-by: kristeja krishnateja.golla@va.gov