-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
hotfix/APPEALS-46639: SCT Bulk Assign Backend Pagination & AOD Filter #21850
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…end pagination for the bulk assign tab for the specialty case team.
…and a new redux action to remove tasks from a cached queue state. Also updated queue table to work with the redux caching instead of local state caching.
with the altered task selection redux action. Also added the ability to pass down the redux cache property to queue table. Refactored the UnassignedCasesPage to allow for backend pagination of queue table instead of only working via frontend loaded data from the redux store.
…trait to the task factory for specialty_case_team_assign_tasks. Added the caching combined reducer to the queue table reducers.
…TableBuilder.jsx into a utils file so it can be used in multiple components around the app.
…data that it should be expecting.
… reducer and action.
…ue table instead of always setting it to true. Removed some comments from the queueTableCacheSlice removeTaskIdsFromCache reducer method/action. Passed in the new useReduxCache property to TaskTable in the UnassignedCasesPage component for the sct bulk assign queue.
TylerBroyles
added
Stakeholder: VHA
Functionality associated with Veterans Health Administration workflows/feature requests
javascript
Pull requests that update Javascript code
ART: VHA
Ability to route VHA SCT appeals
labels
Jun 7, 2024
Code Climate has analyzed commit 2bfe003 and detected 0 issues on this pull request. View more on Code Climate. |
…lso included request issues in the includes for the sct queue to take advantage of these optimizations.
…ameters anymore for queue table.
almorbah
reviewed
Jun 20, 2024
almorbah
approved these changes
Jun 20, 2024
brandondorner
approved these changes
Jul 8, 2024
49 tasks
Closed in favor of #22389 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Ability to route VHA SCT appeals
ART: VHA
javascript
Pull requests that update Javascript code
Stakeholder: VHA
Functionality associated with Veterans Health Administration workflows/feature requests
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves APPEALS-46639
Description
Updated the Task Assignment page for the Specialty Case Team (SCT) to use backend pagination instead of frontend pagination. This includes updates to the UnassignedCasesPage, TaskTable, and QueueTable components as well as additions and modifications to the queue redux store.
Queue Table was also modified to support request caching via redux instead of local component state to further support existing bulk task assignment behavior for backend paginated task retrieval.
Acceptance Criteria
Testing Plan
Login as an SCT USER and navigate to the sct bulk assign queue either through the UI or the url /queue/[YOUR USER CSS_ID]/assign?role=sct_coordinator
Verify that the SCT bulk assign queue is now using backend pagination by clicking the second page of tasks and getting a page load instead of it instantly swapping to a new 15 tasks demonstrating that all the tasks are not loaded already.
Verify that the get parameters are present in the url bar
Verify that the aod cases are at the front of the queue
Verify the aod filter options are present
Verify that sorting and filtering works for the other columns
Verify that the task assignment still works by selecting a few tasks on page 1 and then moving to page 2 and selecting some tasks from a different set of 15 tasks.
Click the assign cases button and verify the success message and that the tasks you assigned are removed from their respective pages.
Login as a judge user and verify that the judge assignment page remains unchanged.
Navigate to the attorney assignment by clicking an attorney from the judge's judge team and verify that the attorney assignment page is also unchanged.
Frontend
User Facing Changes
Storybook Story
For Frontend (Presentation) Components
MyComponent.stories.js
alongsideMyComponent.jsx
)Backend
Database Changes
Only for Schema Changes
created_at
,updated_at
) for new tablesCaseflow::Migration
, especially when adding indexes (useadd_safe_index
) (see Writing DB migrations)migrate:rollback
works as desired (change
supported functions)make check-fks
; add any missing foreign keys or add toconfig/initializers/immigrant.rb
(see Record associations and Foreign Keys)belongs_to
for associations to enable the schema diagrams to be automatically updatedIntegrations: Adding endpoints for external APIs
Best practices
Code Documentation Updates
Tests
Test Coverage
Did you include any test coverage for your code? Check below:
Code Climate
Your code does not add any new code climate offenses? If so why?
Monitoring, Logging, Auditing, Error, and Exception Handling Checklist
Monitoring
Logging
Auditing
Error Handling
Exception Handling