Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

APPEALS-43129 Create a New Modal named "Edit Contractor" #21877

Merged
merged 62 commits into from
Jun 14, 2024

Conversation

lauren-e-thompson
Copy link
Contributor

@lauren-e-thompson lauren-e-thompson commented Jun 10, 2024

Resolves APPEALS-43129

Description

As a Caseflow Developer I need to create a new modal allowing the end user to edit a transcription contractor in Caseflow, and I need to move the "Back to Transcription queue" link above the page border

Acceptance Criteria

  • New Modal named "Edit Contractor_Name> information"
  • The New modal shall be accessible to End Users from the "Transcription Settings" page
  • Modal contains a text line info of "This will update the specified Contractors information."
  • Modal contains editable text field for Full Name of Transcription Contractor Company
  • Modal contains editable text field for Short Name for the company
  • Modal contains editable text field for POC first and last name
  • Modal contains editable text field for POC phone number
  • Modal contains editable text field for POC email address
  • Modal text fields are not optional
  • Modal contains cancel and submit buttons
  • "Back to Transcription queue" link above the page border

Tests

Test Coverage

Did you include any test coverage for your code? Check below:

  • RSpec
  • Jest
  • Other

Code Climate

Your code does not add any new code climate offenses? If so why?

  • No new code climate issues added

HunJerBAH and others added 30 commits March 1, 2024 13:32
amybids and others added 16 commits May 13, 2024 11:51
* Added Assignment Queue link to Switch Users test page

* Updated controller to validate role and redirect

* Updated error information

* Updated rspec tests

* Ricky/appeals-43523 (#21345)

* Added Assignment Queue link to Switch Users test page

* Updated controller to validate role and redirect

* Updated error information

* Updated rspec tests

* Added Download Ineligible Judge List

* APPEALS-43116 add sentry error capture to push priority job and updated specs (#21369)

* Updated query to include css_id and updated id fetch

* Updates button styling, fixed csv to have all values but judge name

* Updated id to sattyid values, and added name data to column

* fixed linting error

* Updated logic to account for inactive users in both caseflow and vacols

* Updated button component and cleaned up code

* Updated handling of ids in situation where sattyid is unavailable in record

* Updated to have individual columns for caseflow id and satty id

* APPEALS-43117 Add QA Users for testing (#21580)

* APPEALS-43117 Add QA Users for testing

* Fix rspecs

---------

Co-authored-by: Christopher Detlef <>

* APPEALS-42266 Remove CaseDistributionLevers seed config in Rails helper and update required spec files

* APPEALS-42266 fixing a couple of linting issues

* APPEALS-43523 reverted the legacy tasks controller (#21713)

* APPEALS-43523 reverted the legacy tasks controller

* APPEALS-43523 reverted the erorrs concern too

* Update legacy_tasks_controller_spec.rb

* reverted raven call

* APPEALS-46208 fixed code climate warning about a bad naming convention.

* APPEALS-46208 fixed indentation

---------

Co-authored-by: 631068 <rickybmanus@gmail.com>
Co-authored-by: Blake Manus <33578594+Blake-Manus@users.noreply.github.com>
Co-authored-by: kristeja <112115264+kristeja@users.noreply.github.com>
Co-authored-by: cdetlefva <133903625+cdetlefva@users.noreply.github.com>
Co-authored-by: kristeja <krishnateja.golla@va.gov>
* Added tests and added logic to account for sct distribution

* Added more tests and changed logic

* Adding comments

* Fixing logic for SCT

* Update test and logic

* Fixing tests

* Update docket switch mail task to match corrected logic

* Fixing logic

* Cleaning up refactor

* Worked with the amazing ALex and we figured it out!

* Fixing linting issue

* Fix linting issues

* Skipping flaky tests

* Skipping another flaky test

---------

Co-authored-by: Alexandra Ferencz <ferencz_alexandra@bah.com>
Co-authored-by: raymond-hughes <raymond.hughes2@va.gov>
Co-authored-by: Raymond Hughes <131811099+raymond-hughes@users.noreply.github.com>
* Upgrade aws-sdk gem to v3.2

* Update caseflow-commons hash

* Apply new hash update

* Skip flaky test

---------

Co-authored-by: Matthew Thornton <ThorntonMatthew@users.noreply.github.com>
* Update gemfile and gemfile.lock to point to new bgs version

* Skipping flake specs in review_spec.rb file
Update Oracle client link
@lauren-e-thompson lauren-e-thompson changed the base branch from master to feature/APPEALS-31792 June 10, 2024 19:10
Copy link

codeclimate bot commented Jun 10, 2024

Code Climate has analyzed commit 002912f and detected 24 issues on this pull request.

Here's the issue category breakdown:

Category Count
Duplication 2
Complexity 22

View more on Code Climate.

Copy link
Contributor

@mchbidwell mchbidwell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks to be a single snapshot that needs to be fixed/re-uploaded, transcription_settings, and 3 Linting issues (1 in TranscriptionSettings.jsx {A space is required before '}' object-curly-spacing}, 2 in OrganizationUsers.jsx {L34: 'userListStyle' is assigned a value but never used} and {L282: 'i' is defined but never used}

@mchbidwell mchbidwell merged commit f03263f into feature/APPEALS-31792 Jun 14, 2024
16 of 17 checks passed
@mchbidwell mchbidwell deleted the lthompson/APPEALS-43129 branch June 14, 2024 17:48
mchbidwell added a commit that referenced this pull request Jul 16, 2024
* APPEALS-43190 (#21448)

* APPEALS-43190 initial migration file

* APPEALS-43190 add seed data

* APPEALS-43190 add magic comment

* APPEALS-43190 move seed command

* APPEALS-43190 add bang!

* APPEALS-43190 update migration file

* APPEALS-43190 attribute name fix and updates

* APPEALS-43190 fix seed attribute

* APPEALS-43190 stubbed more seed data

* APPEALS-43190 remove seed comment

* APPEALS-43190 remove comment

* APPEALS-43190 add magic comment

* APPEALS-43190 update comments

* APPEALS-43137 (#21511)

* APPEALS-43190 initial migration file

* APPEALS-43190 add seed data

* APPEALS-43190 add magic comment

* APPEALS-43190 move seed command

* APPEALS-43190 add bang!

* APPEALS-43190 update migration file

* APPEALS-43190 attribute name fix and updates

* APPEALS-43190 fix seed attribute

* APPEALS-43190 stubbed more seed data

* APPEALS-43190 remove seed comment

* APPEALS-43190 remove comment

* APPEALS-43137 - Basic controller and route

* APPEALS-43137 - Test the new transcription settings controller

* APPEALS-43137 - Add basic route and tests for index

* APPEALS-43137 - Remove changes

* APPEALS-43137 - Fix JSON responses and error

* APPEALS-43137 - Change record to contractor

---------

Co-authored-by: breedbah <brandon.reed3@va.gov>

* APPEALS-43125 (#21550)

* APPEALS-43190 initial migration file

* APPEALS-43190 add seed data

* APPEALS-43190 add magic comment

* APPEALS-43190 move seed command

* APPEALS-43190 add bang!

* APPEALS-43190 update migration file

* APPEALS-43190 attribute name fix and updates

* APPEALS-43190 fix seed attribute

* APPEALS-43137 - Basic controller and route

* initial component folder creation and db update

* APPEALS-43190 stubbed more seed data

* APPEALS-43190 remove seed comment

* APPEALS-43190 remove comment

* APPEALS-43137 - Basic controller and route

* APPEALS-43137 - Test the new transcription settings controller

* APPEALS-43137 - Add basic route and tests for index

* Initial heading creation

* add container for transcription settings

* Remove errors

* Pushing with error - change to component style

* Updated component style - working

* Updated styling with all components present

* Add text to copy and update settings page

* Add test to check that page displays contractor content

* Clean up CSS

* Update Gemfile.lock

Added libv8 linux version back into file

---------

Co-authored-by: breedbah <brandon.reed3@va.gov>
Co-authored-by: Adam Ducker <adam.ducker@va.gov>
Co-authored-by: mchbidwell <122634362+mchbidwell@users.noreply.github.com>

* APPEALS-43138 (#21554)

* APPEALS_43138 init commit

* APPEALS-43138 update jsx

* APPEALS-43138 upudate transcription_c tests

* APPEALS-43138 add unit tests

* APPEALS - 43138 handle error

* APPEALS-43138 update snaphot

* APPEALS-43138 update snapshot details.test.js

* APPEALS-43138 lint TranscriptionSettingsContainer.jsx

* APPEALS-43138 lint TranscriptionSettings.jsx

* APPEALS-43138 update feature_helper.rb

* APPEALS-43138 update test

* APPEALS-43138 change feature_helper back

* APPEALS-43138 feature_helper

* APPEALS-43138 add delay

* APPEALS-43138 update feature helper

* APPEALS-43138 remove sleep(1)

* APPEALS-43138 add wait on dropdown

* APPEALS-43138 change back to original

* APPEALS-43138 add "wait"

* APPEALS-43138 - Testing a theory

* APPEALS-43138 add seed data to test

* APPELA-43138 update the wait in spec_helper

* APPELA-43138 - Remove test changes

---------

Co-authored-by: Adam Ducker <adam.ducker@va.gov>

* APPEALS-43195 - Create MVC for Contractors (#21628)

* APPEALS-43195 - Updated transcription setttings controller, models, tests

# Conflicts:
#	app/models/hearings/transcription_contractor.rb
#	spec/models/hearings/transcription_contractors_model_spec.rb

* APPEALS-43195 - Rename controller

* APPEALS-43195 - Sort contractors in dropdown

* Merging lastest changes from outside APPEALS-31792 (#21680)

* added saftey opperator and removed outdated date check

* removed leftover method that was breaking and unused.

* removed legacy appeal date check for MST on special issue list

* updated mst and pact badges to check decisions in flight (if any) then appeal model.

* removed bypass for special issue list for pact toggle for AMA.

* updated rake and seed comments

* allowed special issues page tracking for AMA MST issues when pact is enabled

* remove code changes causing cancel to progress forward

* Update scheduled jobs key and move job to different folder

* Update job to set user manually and pass in updated_by

* moved method definition validate_claim_code into ClaimLabelChange class

* fixed spacing issue

* msteele/APPEALS-45182 Fix transcription_files relationships on Hearings/LegacyHearings (#21492)

* APPEALS-45182 Reinforce has_many relationships

* APPEALS-45182 Add missing comma

* Resolve lint issue

---------

Co-authored-by: Matthew Thornton <ThorntonMatthew@users.noreply.github.com>

* fixed linting error

* fixed linting issue

* draft pr

* Hotfix/APPEALS-45218 (#21503)

* APPEALS-45218 reverted webex config arguments

* APPEALS-45218 reverted webex config arguments

* APPEALS-25218 Update WebexService to remove config in favor of individual arguments

* APPEALS-45218 Format comment

---------

Co-authored-by: msteele <Marc.Steele@va.gov>

* Wmedders21/appeals 44873 (#21469)

* add rubyzip gem

* Test: Hearings::ZipAndUploadTranscriptionFilesJob

* Feature: Hearings::ZipAndUploadTranscriptionFilesJob

* Add zip subfolder to tmp/transcription_files

* Move new gem to proper alphabetical position in list

* revert gem file changes

* update gem file with feature branch

* refactor #perform method parameters

* update parameter name

* Piedram/appeals 44897 (#21519)

* Create new Workflow transcription_packages: Step One

* add some changes

* Modified the parameters for ZipAndUploadTranscriptionFilesJob

* Modified spec test

* Update transcription_packages.rb

* remove extra blank line

---------

Co-authored-by: piedram <maite.piedrayera@va.gov>

* Wmedders21/appeals 44874 (#21512)

* add rubyzip gem

* Test: Hearings::ZipAndUploadTranscriptionFilesJob

* Feature: Hearings::ZipAndUploadTranscriptionFilesJob

* Add zip subfolder to tmp/transcription_files

* Move new gem to proper alphabetical position in list

* revert gem file changes

* update gem file with feature branch

* refactor #perform method parameters

* update parameter name

* add zip extension to valid file types

* Test: transcription file creation and upload to s3

* Hearings::ZipAndUploadTranscriptionFilesJob updates db and uploads to s3

* resolve merge conflict

* APPEALS-44876 Work order job file (#21504)

* APPEALS-44876 Work order job file

* Updated filename with work order name

* Refactored create table method and updated spec

---------

Co-authored-by: Jim Foley <james.foley4@va.gov>

* Completing AC for ticketing for styling and error portion of page. Now doing feature test

* B_reed/hotfix_APPEALS-45285 (#21531)

* APPEALS-45285 Bug Fix

* APPEALS-45285 update pexip_service_spec

* APPEALS-45285 remove white space

* Hotfix/APPEALS-45218-v2 (#21522)

* APPEALS-45218 reverted webex config arguments

* APPEALS-45218 reverted webex config arguments

* APPEALS-45218 added query argument to webex conference link

* APPEALS-45218: webex recordings endpoint correction

* APPEALS-45218 adjusted arguments during inititalizing of refresh tokens

* APPEALS-45218 fixed rspec

* APPEALS-45218: added error catching on webex service response

* APPEALS-45218: remove tested code

* APPEALS-45218 Go back to leveraging HTTPI response inherited methods

---------

Co-authored-by: Ariana Konhilas <konhilas_ariana@bah.com>
Co-authored-by: msteele <Marc.Steele@va.gov>

* added ability for user to search by css id

* added feature tests for using search bar

* reverted changes in package.json

* removed added file

* removed linting error

* msteele/APPEALS-45349 (#21539)

* APPEALS-45349 Check for error on HTTPI object, then create Webex response object and fail with specific error

* APPEALS-45349 Flip conditionals

* APPEALS-45349 Fix linting errors

* searchable by 2 characters instead of 1

* hotfix/APPEALS-45399-45401-45472 (#21555)

* APPEALS-45399-45401 Update fetch webex list and details to retrieve apikey from cred stash

* APPEALS-45399-45401 Remove CGI escape from fetch webex list job

* APPEALS-445399-45401 Update spec files for webex list and details job

* APPEALS-45399-45401 Include error handling for transcription issue mailer failed delivery

* Revert "APPEALS-45399-45401 Include error handling for transcription issue mailer failed delivery"

This reverts commit d9ce585c59444f9793e681e58060d71872057e4c.

* ccc

* gggg

* gggg

* Create new Workflow transcription_packages: Step Two (#21570)

* Add call function to the new job, and modified spec files

* call the jobs

* feature/APPEALS-44188-44282 - Deprecation fixes for Rails 6.1 (release) (#21614)

* 🔀 Squash merge jcroteau/APPEALS-44188-fix-deprecation-warning-class-level-methods-will-no-longer-inherit-scoping

* 🔀 Squash merge jcroteau/APPEALS-44282-fix-deprecation-not-conditions-will-no-longer-behave-as-nor

* Work order file upload to AWS s3 (#21582)

* Work order file upload to AWS s3

* refactor code for upload to AWS

* refactor code for instance variables

* Revert "refactor code for instance variables"

This reverts commit b61c72a3f2e30e4003e9d4a4dc57a01dbb105443.

* code refactor for work order file

* APPEALS-44877 refactor for work order

* APPEALS-44310: add notification for unexpected task trees and update tests (#21474)

* add notification for unexpected task trees and update tests

* add slack notification to distribution errors, set default slack url in SlackService

* add tests for distributions to validate handling of errors in the ama_statistics method

* fix bad check for allowable tasks

* fix tests which were expecting a url as arg to new slack service

* fix codeclimate warning

* APPEALS-45199: Update Quality Review selection probabilities #21518

* APPEALS-44423: Remove therubyracer and jshint gems (#21443)

* APPEALS-42941 copied over Matt's work (#21624)

* APPEALS-43190 (#21448)

* APPEALS-43190 initial migration file

* APPEALS-43190 add seed data

* APPEALS-43190 add magic comment

* APPEALS-43190 move seed command

* APPEALS-43190 add bang!

* APPEALS-43190 update migration file

* APPEALS-43190 attribute name fix and updates

* APPEALS-43190 fix seed attribute

* APPEALS-43190 stubbed more seed data

* APPEALS-43190 remove seed comment

* APPEALS-43190 remove comment

* APPEALS-43190 add magic comment

* APPEALS-43190 update comments

* Wmedders21/appeals 44875 (#21605)

* Add retry logic for upload failure

* fix indentation rubocop warning

* Refactor zip job

* remove blank line

---------

Co-authored-by: Jim Foley <james.foley4@va.gov>

* akonhilas/APPEALS-43193 (#21581)

* APPEALS-43193: Add new columns and indexes to transcriptions table

* APPEALS-43193: Add new columns and indexes to transcriptions table

* APPEALS-43193: move index to own file

* APPEALS-43193: Update transcription contractor id to bigint

* APPEALS-43193: bigint

* APPEALS-43193: add fk after trancription_contractors table added

* lint error resolution (#21631)

* hotfix/APPEALS-45472 (#21562)

* APPEALS-45472 Refactor error handling for transcription

* APPEALS-45472 Include missing provider in error details for fetch recording list job and update comment for mailer

* Hotfix/APPEALS-45818 (#21632)

* APPEALS-45818: parsing fix, remove topic param, fix response

* APPEALS-45818: revert list and details job back to original state, update tests

---------

Co-authored-by: Marc Steele <71673522+msteele96@users.noreply.github.com>

* APPEALS-44878 refactor for retry and upon success kickoff  zip file job (#21652)

* APPEALS-44878 refactor for retry and upon success kickoff  zip file job

* APPEALS-44878 refactor code

* APPEALS-44878 refactor xls path

* lint error fix

* msteele/APPEALS-45285-v2 Fix delete_conference in PexipService (#21634)

* APPEALS-45285 update ExternalApi::PexipService#delete_conference to accept virtual_hearing as the only argument

* APPEALS-45285 Update spec to use virtual_hearing

* APPEALS-45285 Linting fixes

* Piedram/appeals 45696 (#21655)

* Create new Workflow Error handling transcription_packages: Step Three related to appeals-31793

* MOdified spec file

* fix lint error

* APPEALS-45696 refactor for work_order_params

---------

Co-authored-by: Kamala Madamanchi <kamala.madamanchi@va.gov>
Co-authored-by: Jim Foley <james.foley4@va.gov>

* hotfix/APPEALS-45828 (#21625)

* APPEALS-45828 Include call to create webex conference links in base hearing update form

* APPEALS-45828 Update details feature spec to expect webex link creation on conversion from virtual

* Fix needing to reload to display co host link on details page

* Fix incorrect method name

* Remove temporary rendering of default pexip link for webex hearings after conversion

* APPEALS-45828 Fix hearing mailer spec context issues and null check for BAD_VIRTUAL_LINK_TEXT

* APPEALS-45828 Remove file name argument from fetch details job spec

* APPEALS-45828 Fail on bad hearing link if link nil or legacy link

* APPEALS-45828 Sanitize url string

* APPEALS-45828 Undo url sanitize

* Remove unused styles after merge

* Fix lint warnings

---------

Co-authored-by: HunJerBAH <Jeremy.Hunton@va.gov>
Co-authored-by: HunJerBAH <99915461+HunJerBAH@users.noreply.github.com>
Co-authored-by: msteele <Marc.Steele@va.gov>
Co-authored-by: Andrew Hadley <hadley_andrew@bah.com>
Co-authored-by: Marc Steele <71673522+msteele96@users.noreply.github.com>
Co-authored-by: Matthew Thornton <ThorntonMatthew@users.noreply.github.com>
Co-authored-by: IsaiahBar <isaiah.barnett@va.gov>
Co-authored-by: minhazur9 <65432922+minhazur9@users.noreply.github.com>
Co-authored-by: Will Medders <93014155+wmedders21@users.noreply.github.com>
Co-authored-by: Jim Foley <james.foley4@va.gov>
Co-authored-by: piedram <maite.piedrayera@va.gov>
Co-authored-by: Kamala Madamanchi <110078646+kamala-07@users.noreply.github.com>
Co-authored-by: breedbah <123968373+breedbah@users.noreply.github.com>
Co-authored-by: Ariana Konhilas <konhilas_ariana@bah.com>
Co-authored-by: raymond-hughes <raymond.hughes2@va.gov>
Co-authored-by: Jeff Marks <106996298+jefftmarks@users.noreply.github.com>
Co-authored-by: piedram <110848569+piedram@users.noreply.github.com>
Co-authored-by: Jeremy Croteau <jcroteau@users.noreply.github.com>
Co-authored-by: Craig Reese <109101548+craigrva@users.noreply.github.com>
Co-authored-by: cacevesva <109166981+cacevesva@users.noreply.github.com>
Co-authored-by: Amy Detwiler <133032208+amybids@users.noreply.github.com>
Co-authored-by: Ariana Konhilas <109693628+konhilas-ariana@users.noreply.github.com>
Co-authored-by: mikefinneran <110622959+mikefinneran@users.noreply.github.com>
Co-authored-by: Kamala Madamanchi <kamala.madamanchi@va.gov>

* APPEALS-43127 (#21702)

* APPEALS-43127 initial setup

* APPEALS-43127 modal is popping up and getting data

* APPEALS-43127 update tghe state

* APPEALS-43127 updated lint

* APPEALS-43127 remove unused function

* APPEALS-43127 change to searchableDropdown

* APPEALS-43127 update COPY.json

* APPEALS-43127 remove commented data

* APPEALS-43127 lint in modal

* APPEALS-43127 update COPY.json

* APPEALS-43127 update COPY.json

* APPEALS-43127 update COPY.json

* APPEALS-43172 removeContractorModal tests complete

* APPEALS-43127 update test and snapshot

* APPEALS-43127 update cancel button

* APPEALS-43127 lint

* APPEALS-43128 - Create a New Modal named "Add Contractor" (#21720)

* APPEALS-43128 - First pass at modal with form and basic validation

# Conflicts:
#	client/COPY.json
#	client/app/hearings/components/transcriptionProcessing/TranscriptionSettings.jsx

* APPEALS-43128 - Saving a contractor and displaying success

# Conflicts:
#	client/app/hearings/components/transcriptionProcessing/TranscriptionSettings.jsx

* APPEALS-43128 - Remove bad migration

* APPEALS-43128 - Update modal validation and handle error from server side

* APPEALS-43128 - Some cleanup and test writing

# Conflicts:
#	client/app/hearings/components/transcriptionProcessing/TranscriptionSettings.jsx

* APPEALS-43128 - Some minor updates to make the edit work easier when it starts

* APPEALS-43128 - Text changes for edit view to match designs

* APPEALS-43128 - Un-change a line

# Conflicts:
#	client/app/hearings/components/transcriptionProcessing/TranscriptionSettings.jsx

* APPEALS-43128 - Updates after new code was merged in

* APPEALS-43128 - Fixing jest problems

* APPEALS-43128 - Text adjustments from BA review

* APPEALS-45881 (#21787)

* Showing iterating contractors on transcription settings page

* Add changes to iteration and seed data

* Styling progress

* CSS fixes for a couple of alignment issues and some lint warnings

* Use state contractors instead of props so the list refreshes

* Updates for button area

* Forgot to update the snapshot

* Link frontend toggle switch to contractor table

---------

Co-authored-by: Adam Ducker <adam.ducker@va.gov>

* APPEALS-43129 Create a New Modal named "Edit Contractor" (#21877)

* added saftey opperator and removed outdated date check

* removed leftover method that was breaking and unused.

* removed legacy appeal date check for MST on special issue list

* updated mst and pact badges to check decisions in flight (if any) then appeal model.

* removed bypass for special issue list for pact toggle for AMA.

* updated rake and seed comments

* allowed special issues page tracking for AMA MST issues when pact is enabled

* remove code changes causing cancel to progress forward

* moved method definition validate_claim_code into ClaimLabelChange class

* fixed spacing issue

* fixed linting error

* fixed linting issue

* draft pr

* Completing AC for ticketing for styling and error portion of page. Now doing feature test

* added ability for user to search by css id

* added feature tests for using search bar

* reverted changes in package.json

* removed added file

* removed linting error

* searchable by 2 characters instead of 1

* ccc

* gggg

* gggg

* feature/APPEALS-44188-44282 - Deprecation fixes for Rails 6.1 (release) (#21614)

* 🔀 Squash merge jcroteau/APPEALS-44188-fix-deprecation-warning-class-level-methods-will-no-longer-inherit-scoping

* 🔀 Squash merge jcroteau/APPEALS-44282-fix-deprecation-not-conditions-will-no-longer-behave-as-nor

* APPEALS-44310: add notification for unexpected task trees and update tests (#21474)

* add notification for unexpected task trees and update tests

* add slack notification to distribution errors, set default slack url in SlackService

* add tests for distributions to validate handling of errors in the ama_statistics method

* fix bad check for allowable tasks

* fix tests which were expecting a url as arg to new slack service

* fix codeclimate warning

* APPEALS-45199: Update Quality Review selection probabilities #21518

* APPEALS-44423: Remove therubyracer and jshint gems (#21443)

* APPEALS-42941 copied over Matt's work (#21624)

* lint error resolution (#21631)

* Feature/appeals 46208.rc (#21746)

* Added Assignment Queue link to Switch Users test page

* Updated controller to validate role and redirect

* Updated error information

* Updated rspec tests

* Ricky/appeals-43523 (#21345)

* Added Assignment Queue link to Switch Users test page

* Updated controller to validate role and redirect

* Updated error information

* Updated rspec tests

* Added Download Ineligible Judge List

* APPEALS-43116 add sentry error capture to push priority job and updated specs (#21369)

* Updated query to include css_id and updated id fetch

* Updates button styling, fixed csv to have all values but judge name

* Updated id to sattyid values, and added name data to column

* fixed linting error

* Updated logic to account for inactive users in both caseflow and vacols

* Updated button component and cleaned up code

* Updated handling of ids in situation where sattyid is unavailable in record

* Updated to have individual columns for caseflow id and satty id

* APPEALS-43117 Add QA Users for testing (#21580)

* APPEALS-43117 Add QA Users for testing

* Fix rspecs

---------

Co-authored-by: Christopher Detlef <>

* APPEALS-42266 Remove CaseDistributionLevers seed config in Rails helper and update required spec files

* APPEALS-42266 fixing a couple of linting issues

* APPEALS-43523 reverted the legacy tasks controller (#21713)

* APPEALS-43523 reverted the legacy tasks controller

* APPEALS-43523 reverted the erorrs concern too

* Update legacy_tasks_controller_spec.rb

* reverted raven call

* APPEALS-46208 fixed code climate warning about a bad naming convention.

* APPEALS-46208 fixed indentation

---------

Co-authored-by: 631068 <rickybmanus@gmail.com>
Co-authored-by: Blake Manus <33578594+Blake-Manus@users.noreply.github.com>
Co-authored-by: kristeja <112115264+kristeja@users.noreply.github.com>
Co-authored-by: cdetlefva <133903625+cdetlefva@users.noreply.github.com>
Co-authored-by: kristeja <krishnateja.golla@va.gov>

* APPEALS-44148: Add ruby CE API Gem (#21520)

* hotfix/APPEALS-46182 (#21709)

* Added tests and added logic to account for sct distribution

* Added more tests and changed logic

* Adding comments

* Fixing logic for SCT

* Update test and logic

* Fixing tests

* Update docket switch mail task to match corrected logic

* Fixing logic

* Cleaning up refactor

* Worked with the amazing ALex and we figured it out!

* Fixing linting issue

* Fix linting issues

* Skipping flaky tests

* Skipping another flaky test

---------

Co-authored-by: Alexandra Ferencz <ferencz_alexandra@bah.com>
Co-authored-by: raymond-hughes <raymond.hughes2@va.gov>
Co-authored-by: Raymond Hughes <131811099+raymond-hughes@users.noreply.github.com>

* MattT/APPEALS-46383: Upgrade aws-sdk gem to v3.2 (#21748)

* Upgrade aws-sdk gem to v3.2

* Update caseflow-commons hash

* Apply new hash update

* Skip flaky test

---------

Co-authored-by: Matthew Thornton <ThorntonMatthew@users.noreply.github.com>

* Update gemfile and gemfile.lock to point to new bgs version (#21749)

* Update gemfile and gemfile.lock to point to new bgs version

* Skipping flake specs in review_spec.rb file

* Revert "APPEALS-44148: Add ruby CE API Gem (#21520)" (#21762)

This reverts commit 3a393d1f3f40b35b5063c2b7d0f1508ef5a61bb7.

* Update ruby-bgs gemfile and gemfile.lock to new version (#21761)

* Update MAC_INTEL.md

Update Oracle client link

* Resolved merge conflicts

* Call patch with updateContractor

* Progress with linking EditModal to Edit Contractor link

* Updated Edit contractor link details

* Edit Modal working with link and persisting changes

* Add rendering test to check for Edit contractor modal

* Fix styling and update copy

* Fix linting issues

* Update snapshot and fix linting issue

---------

Co-authored-by: HunJerBAH <Jeremy.Hunton@va.gov>
Co-authored-by: HunJerBAH <99915461+HunJerBAH@users.noreply.github.com>
Co-authored-by: Andrew Hadley <hadley_andrew@bah.com>
Co-authored-by: IsaiahBar <isaiah.barnett@va.gov>
Co-authored-by: raymond-hughes <raymond.hughes2@va.gov>
Co-authored-by: Jeremy Croteau <jcroteau@users.noreply.github.com>
Co-authored-by: Craig Reese <109101548+craigrva@users.noreply.github.com>
Co-authored-by: cacevesva <109166981+cacevesva@users.noreply.github.com>
Co-authored-by: Amy Detwiler <133032208+amybids@users.noreply.github.com>
Co-authored-by: mikefinneran <110622959+mikefinneran@users.noreply.github.com>
Co-authored-by: 631068 <rickybmanus@gmail.com>
Co-authored-by: Blake Manus <33578594+Blake-Manus@users.noreply.github.com>
Co-authored-by: kristeja <112115264+kristeja@users.noreply.github.com>
Co-authored-by: cdetlefva <133903625+cdetlefva@users.noreply.github.com>
Co-authored-by: kristeja <krishnateja.golla@va.gov>
Co-authored-by: youfoundmanesh <129548081+youfoundmanesh@users.noreply.github.com>
Co-authored-by: Alex Ferencz VA <156860944+aferencz1987VA@users.noreply.github.com>
Co-authored-by: Alexandra Ferencz <ferencz_alexandra@bah.com>
Co-authored-by: Raymond Hughes <131811099+raymond-hughes@users.noreply.github.com>
Co-authored-by: Matthew Thornton <99351305+ThorntonMatthew@users.noreply.github.com>
Co-authored-by: Matthew Thornton <ThorntonMatthew@users.noreply.github.com>
Co-authored-by: Alec Spottswood <ajspottswood@gmail.com>

* APPEALS-43134 Create a New Modal named "Edit Goals" (#22022)

* added saftey opperator and removed outdated date check

* removed leftover method that was breaking and unused.

* removed legacy appeal date check for MST on special issue list

* updated mst and pact badges to check decisions in flight (if any) then appeal model.

* removed bypass for special issue list for pact toggle for AMA.

* updated rake and seed comments

* allowed special issues page tracking for AMA MST issues when pact is enabled

* remove code changes causing cancel to progress forward

* moved method definition validate_claim_code into ClaimLabelChange class

* fixed spacing issue

* fixed linting error

* fixed linting issue

* draft pr

* Completing AC for ticketing for styling and error portion of page. Now doing feature test

* added ability for user to search by css id

* added feature tests for using search bar

* reverted changes in package.json

* removed added file

* removed linting error

* searchable by 2 characters instead of 1

* ccc

* gggg

* gggg

* feature/APPEALS-44188-44282 - Deprecation fixes for Rails 6.1 (release) (#21614)

* 🔀 Squash merge jcroteau/APPEALS-44188-fix-deprecation-warning-class-level-methods-will-no-longer-inherit-scoping

* 🔀 Squash merge jcroteau/APPEALS-44282-fix-deprecation-not-conditions-will-no-longer-behave-as-nor

* APPEALS-44310: add notification for unexpected task trees and update tests (#21474)

* add notification for unexpected task trees and update tests

* add slack notification to distribution errors, set default slack url in SlackService

* add tests for distributions to validate handling of errors in the ama_statistics method

* fix bad check for allowable tasks

* fix tests which were expecting a url as arg to new slack service

* fix codeclimate warning

* APPEALS-45199: Update Quality Review selection probabilities #21518

* APPEALS-44423: Remove therubyracer and jshint gems (#21443)

* APPEALS-42941 copied over Matt's work (#21624)

* lint error resolution (#21631)

* Feature/appeals 46208.rc (#21746)

* Added Assignment Queue link to Switch Users test page

* Updated controller to validate role and redirect

* Updated error information

* Updated rspec tests

* Ricky/appeals-43523 (#21345)

* Added Assignment Queue link to Switch Users test page

* Updated controller to validate role and redirect

* Updated error information

* Updated rspec tests

* Added Download Ineligible Judge List

* APPEALS-43116 add sentry error capture to push priority job and updated specs (#21369)

* Updated query to include css_id and updated id fetch

* Updates button styling, fixed csv to have all values but judge name

* Updated id to sattyid values, and added name data to column

* fixed linting error

* Updated logic to account for inactive users in both caseflow and vacols

* Updated button component and cleaned up code

* Updated handling of ids in situation where sattyid is unavailable in record

* Updated to have individual columns for caseflow id and satty id

* APPEALS-43117 Add QA Users for testing (#21580)

* APPEALS-43117 Add QA Users for testing

* Fix rspecs

---------

Co-authored-by: Christopher Detlef <>

* APPEALS-42266 Remove CaseDistributionLevers seed config in Rails helper and update required spec files

* APPEALS-42266 fixing a couple of linting issues

* APPEALS-43523 reverted the legacy tasks controller (#21713)

* APPEALS-43523 reverted the legacy tasks controller

* APPEALS-43523 reverted the erorrs concern too

* Update legacy_tasks_controller_spec.rb

* reverted raven call

* APPEALS-46208 fixed code climate warning about a bad naming convention.

* APPEALS-46208 fixed indentation

---------

Co-authored-by: 631068 <rickybmanus@gmail.com>
Co-authored-by: Blake Manus <33578594+Blake-Manus@users.noreply.github.com>
Co-authored-by: kristeja <112115264+kristeja@users.noreply.github.com>
Co-authored-by: cdetlefva <133903625+cdetlefva@users.noreply.github.com>
Co-authored-by: kristeja <krishnateja.golla@va.gov>

* APPEALS-44148: Add ruby CE API Gem (#21520)

* hotfix/APPEALS-46182 (#21709)

* Added tests and added logic to account for sct distribution

* Added more tests and changed logic

* Adding comments

* Fixing logic for SCT

* Update test and logic

* Fixing tests

* Update docket switch mail task to match corrected logic

* Fixing logic

* Cleaning up refactor

* Worked with the amazing ALex and we figured it out!

* Fixing linting issue

* Fix linting issues

* Skipping flaky tests

* Skipping another flaky test

---------

Co-authored-by: Alexandra Ferencz <ferencz_alexandra@bah.com>
Co-authored-by: raymond-hughes <raymond.hughes2@va.gov>
Co-authored-by: Raymond Hughes <131811099+raymond-hughes@users.noreply.github.com>

* MattT/APPEALS-46383: Upgrade aws-sdk gem to v3.2 (#21748)

* Upgrade aws-sdk gem to v3.2

* Update caseflow-commons hash

* Apply new hash update

* Skip flaky test

---------

Co-authored-by: Matthew Thornton <ThorntonMatthew@users.noreply.github.com>

* Update gemfile and gemfile.lock to point to new bgs version (#21749)

* Update gemfile and gemfile.lock to point to new bgs version

* Skipping flake specs in review_spec.rb file

* Revert "APPEALS-44148: Add ruby CE API Gem (#21520)" (#21762)

This reverts commit 3a393d1f3f40b35b5063c2b7d0f1508ef5a61bb7.

* Update ruby-bgs gemfile and gemfile.lock to new version (#21761)

* Update MAC_INTEL.md

Update Oracle client link

* Resolved merge conflicts

* APPEALS-44496 Fix Factory (#21770)

* APPEALS-44496 Fix Factory

* updated falky test

---------

Co-authored-by: Raymond Hughes <131811099+raymond-hughes@users.noreply.github.com>

* fix(va facilities): update per page param (#21754)

* Hotfix/appeals 44033:Fix Judge and Attorney tasks in the QualityReview workflow are being erroneously cancelled  (#21786)

* Adjusts the send_to_hearings_branch method to exclude JudgeQualityReviews when cancelling all Judge tasks and subtasks
rebase

* adjusts spacing and adds back deleted test

* Remove unnecessary schema changes and adds an exclamation mark to account for method that changes data

* add exclamation to handle_judge_tasks

---------

Co-authored-by: Zackary Borges-Rowe <borges-rowe_zackary@bah.com>
Co-authored-by: Raymond Hughes <131811099+raymond-hughes@users.noreply.github.com>

* Hotfix/appeals 45150 (#21627)

* Added distribution task with children status change on split appeal test

* Added tests and commented out pry session in appeal

* Changed split appeal test to test for both defects

* Added  conditional logic to status_is_valid_on_create in task model

* looking for defect

* Reverted changes to finalize split appeal method added condtional logic to schedule hearing tasks model

* Removed debugger and commented out lines

* Added erroneously removed lines of code and added spacing

* Fix linting errors

* Added conditional logic for appeal split process

---------

Co-authored-by: Alexandra Ferencz <ferencz_alexandra@bah.com>
Co-authored-by: raymond-hughes <raymond.hughes2@va.gov>
Co-authored-by: Raymond Hughes <131811099+raymond-hughes@users.noreply.github.com>

* hotfix/APPEALS-36313-V2 (#21782)

* avoid IHP task creation with an open pre-docket task

* Fix linting errors on RSpec

* Skip flaky BGS Share Error test

* comment failed test case

---------

Co-authored-by: Raymond Hughes <131811099+raymond-hughes@users.noreply.github.com>
Co-authored-by: raymond-hughes <raymond.hughes2@va.gov>

* APPEALS-47106 Caseflow Swagger (#21847)

* Add Rswag and convert existing API documentation (#21778)

* add rswag

* Update Gemfile.lock

* Setup yaml UI

* remove and reroute old swagger files

* update format and servers values

* Update route_docs_controller.rb

* Update cmp_controller.rb

* cmp endpoint yaml

* cmp endpoint to return 501

* CMP endpoint swagger flies

* update swagger files

* adjust server order, add auth token

* cmp parameter name change

* add comments

* Update users_controller.rb

* unit tests and linting

* lint fixes

* Update swagger_helper.rb

* skip flakey tests

* Update appeal_notifications_page_spec.rb

* Hotfix/appeals 36313 v2 (#21858)

* avoid IHP task creation with an open pre-docket task

* Fix linting errors on RSpec

* Skip flaky BGS Share Error test

* comment failed test case

* Add predocket coverage for IHP task creation when POA is updated

* adjust predocketed from active status to open to include on_hold status

* Remove commented out data staging for bgs POA rspec test

---------

Co-authored-by: Raymond Hughes <131811099+raymond-hughes@users.noreply.github.com>
Co-authored-by: raymond-hughes <raymond.hughes2@va.gov>

* feature/appeals-43220 (#21862)

* Adding 403 and 404 functionality to Reader.

* Adding icon to button.

* Fixing linting issues.

* Using the Link component and moving href into constant

* fix linter issues

---------

Co-authored-by: Brian Bommarito <brian@bommarito.me>

* feature/appeals-39842 (#21864)

* anusha/appeals-45976 (#21738)

* Change address format

* added rspec tests to cover hotfix

* testing for inclusion of expected values (addressLine1, etc.)

* rspec test -- wip

* still WIP

* Fix address tests.

* updated fakes

* Update internationalPostalCode

* appeals controller spec update

* http request changed and test

---------

Co-authored-by: Noelle Adkin <98478937+NoelleAd@users.noreply.github.com>
Co-authored-by: Anusha Palliyil <palliyil_anusha@bah.com>
Co-authored-by: Lauren Berry <berry_lauren@bah.com>

* lauren/APPEALS-39842 (#21739)

* Add scroll metrics start time fix and update metric message

* Add metrics attributes json in PdfPage constructor and add isPageVisible metric attribute

* Fix scroll message spacing

---------

Co-authored-by: laurenyj <44596134+laurenyj@users.noreply.github.com>

* noelle/appeals-39842 (#21740)

* Remove UUID from attrs sent_to metrics.

* Remove UUID from spec

* remove uuid from update_appellant job

---------

Co-authored-by: Noelle Adkin <98478937+NoelleAd@users.noreply.github.com>

* fix failing tests

---------

Co-authored-by: Noelle Adkin <98478937+NoelleAd@users.noreply.github.com>
Co-authored-by: Anusha Palliyil <palliyil_anusha@bah.com>
Co-authored-by: Lauren Berry <berry_lauren@bah.com>
Co-authored-by: laurenyj <44596134+laurenyj@users.noreply.github.com>

* APPEALS-44916: Case Distribution Affinity Calculations (#21666)

* APPEALS-44956: Add AppealAffinity model and database table (#21526)

* add migration for appeal_affinities

* add AppealAffinity model and associations, update migration for new column

* update index to be unique

* add factory, add tests

* add factory traits to appeal and case for appeal affinities

* add combination trait to appeal factory

* add appeal_affinity to skipped associations in ETL reporting

* add a validation, test

* Craig/appeals 44958 (#21564)

* add new job, update affinity model validation and after save hook

* add update from push job

* fix job extending distribution scopes

* add with appeal affinities to distribution scopes

* typo

* add error handling, add test file

* add distributed case factory, refactor naming in job

* fix factories, added tests

* fix migration for null affinity start date column

* fixes, added tests

* more test updates

* add return in job if no query results, tests for no query results

* add test for after_save hook adding dist task instructions

* set start dist job to queue affinity job after running

* fix update job and start dist job spec

* queue affinity update job from push job

* code clarity

* fix judge in seed file

* remove comment, fix hearing factory, disable some seeds for testing

* add more tests

* test refactor

* update appeals for dist query to add affinity start, add seed file, fix hearing factory, add stat to dist factory

* disable new seed on reset

* update seed file with vet names, add another seed category

* fix distirbuted case factory?

* actually fix GHA runs

* lint, test fixes

* change constants in new job

* APPEALS-44959: Modify affinity date checks to use appeal_affinity (#21611)

* swap distribution queries from distribution_task to appeal_affinities

* update seed files to use appeal affinities instead of distribution task

* clean up seed file method names

* add missing Timecop.return in ama affinity case seed

* fix name of a method in a seed file

* remove references to distribution task in distribution scopes

* fix push priority job tests

* fix naming of args in one of the seed files

* fix user seed, fix date format in distribution task instructions

* fix tests for date format update

* Calvin/APPEALS-44957-rake-affinity (#21577)

* grabbed receipt dates from distributed cases

* refactored for functionality + added method to grab appeals that match

* using receipt date, get all related appeals

* added update/creation plus cleaned prior imple.

* gets most recent distributed case receipt_date

* skips if receipt_date is nil for performance

* if appeal affinity is nil, it will now be updated

* created spec file

* fixed non ready appeals

* updated query to match new AC

* removing comment

* testing for each docket

* updated spec file

* added new tests to rspec

* updated start date to receipt date instead of Time.now

* fixed date/time rspec errors

* added rails logger to know when rake task has finished

* added tag for rails log

* removed nonpriority dockets for direct_review and evidence_submission

* fixed lint issue

* fixed flaky spec test

* limits distributed cases query to within the last week

* APPEALS-46016: Add Affinity Start Date to the Explain Page (#21660)

* add affinity start date to explain page

* add feature test to verify dates display

* update rake task and spec (#21731)

* APPEALS-46325: Add Seeds for AOD Appeals and Update Dates to Match CAVC (#21730)

* add aod hearing cases to ama affinity cases seed

* fix lever spec

* APPEALS-45148: Hook to clear saved affinity date (#21623)

* initial imp. idea

* AC1: check for affinity_start_date on assignment

* AC2/3: update affinity start date  w/ instr.

* updates to naming, instructions, and hook logic

* updates after review

* rspec coverage and addtional condition

* removed unused identifier

* removed reduntant 'self's

* added update on actual AA record

* updated to save aa record and addtional rspec

* added change to assignment on no record test

* check for assignment

* addd update to 'on_hold' status

* public method to handle legacy affinity appeals

* added .reload to :with_affinity_appeal

* added .reload to :ready_for_distribution

* updates to pass explain_spec

* switched boolean values

* typo

* readujsted order on :create for affinity appeal

* removed after(:create)

* testing rspec by readding after :create

* reloading in assertation

* addressing lint errors

* fix seeds/users_spec

* add case dist lever to new tests (#21776)

* remove unnecessarily included module from job (#21827)

* APPEALS-47211: Improve Performance of Distribution Queries (#21840)

* rework ready_for_distribution scope

* fix non-hearing docket distribution bug

* restart tests

---------

Co-authored-by: calvincostaBAH <108481161+calvincostaBAH@users.noreply.github.com>
Co-authored-by: Isaiah Saucedo <irsaucedo5@gmail.com>

* APPEALS-46540: Reduce time to deploy demo environments (#21791)

* APPEALS-42710: Modify local/demo seed data so that not all seed files need to be run when resetting/deploying (#21743)

* refactor users to use factories and create singletons

* code quality, reduce counts

* refactor substitutions

* refactor veterans health administration seed

* refactor MTV

* move education orgs to users seed

* move intake users to users seed, comment non-required seed files

* add veterans seed file from Sean's branch

* fix errors

* add hearing prep role to judges

* add optional seed file

* add optional seed file and button to run it in demo

* lint, specs

* remove priority dist from optional, test fix

* fix tests

* Disable repeated conditional in Test::UsersController

* feature/APPEALS-43597 RC (#21860)

* APPEALS-36759 Add sms_response_content and sms_response_time notifications table

* APPEALS-37003 First pass at job refactor

* APPEALS-37003 Add comments and update kwargs for va notify service

* APPEALS-37003 Update spec files

* APPEALS-37003 Update spec

* APPEALS-37003 Ensure user in job and create email_enabled method

* APPEALS-37003 Remove question mark

* Limit max retry attempts to 5

* Add ? to boolen return methods

* jcohen/APPEALS-43706 (#21444)

* APPEALS-43706 macros added to each model file for the polymorphic relationship to be setup.

* APPEALS-43706 migration made and yet to be run.

* APPEALS-43706 migrations ran and expected columns and indexes are in table.

* Fix some spec failures unrelated to this branch

* Limit schema diff

* Add a missing tab

* Fix more unrelated failures. Also prevent ACD lever seeds from overwriting spec output

* Fix last unrelated failure.

* APPEALS-43706 linting issues in va_notify_service fixed.

---------

Co-authored-by: Jonathan Cohen <cohen_jonathan@bah.com>
Co-authored-by: Matthew Thornton <ThorntonMatthew@users.noreply.github.com>

* [APPEALS-43598] Quarterly Notification Job refactoring (#21505)

* Quarterly Notification Job refactoring

* APPEALS-43598 Fix lint issues for QuarterlyNotificationsJob refactor

* APPEALS-43598 Fix db schema.rb file

* APPEALS-43598 Fix schema.rb file

* APPEALS-43598 Refactoring QuarterlyNotificationsJob for readability

* APPEALS-43598 Refactoring QuarterlyNotificationsJob and removing extra methods

* [APPEALS-43598] Update method name

---------

Co-authored-by: Matthew Thornton <99351305+ThorntonMatthew@users.noreply.github.com>

* APPEALS-44007: Eliminate Transmission of Notifications to Deceased Veterans (#21481)

* APPEALS-44007: Writing tests to ensure adding the 'failure due to deceased' information is properly set and added to the db

* updates to pr

* pushing changes for tonight

* updating spec file to handle enabling and disabling feature flags

* Update format_message_status

* Lint roll

* fixing conflicts

* Updates to send notification spec

* Fix one of the legacy test cases

* Remove accidental push

* Fix remaining test

---------

Co-authored-by: Noah Hansen <nhansen@Noahs-MacBook-Pro.local>
Co-authored-by: Matthew Thornton <ThorntonMatthew@users.noreply.github.com>
Co-authored-by: Matthew Thornton <99351305+ThorntonMatthew@users.noreply.github.com>

* MattT/APPEALS-45235: Remove Temporary PDF Files From tmp Directory After All eFolder Upload Attempts (#21557)

* Cleanup files after uploading to VBMS

* Only delete file if it exists

* Resolve linter issue

* Update specs

* Trigger CodeClimate

---------

Co-authored-by: Matthew Thornton <ThorntonMatthew@users.noreply.github.com>

* Add appeal alias for notifiable

* APPEALS-45346: Populate Polymorphic Association Columns When Creating New Notifications (#21575)

* APPEALS-45346: Populate Polymorphic Association Columns When Creating New Notifications

* fixing some errors

* updating factory

* updating tests

* updating tests and factory

* rubocop

---------

Co-authored-by: Noah Hansen <nhansen@Noahs-MacBook-Pro.local>
Co-authored-by: Matthew Thornton <99351305+ThorntonMatthew@users.noreply.github.com>

* APPEALS-43596 Adding JobMessageDeletionMiddleware to delete SQS messages for certain jobs

* APPEALS-43596 Adding tests

* APPEALS-43596 Fix codeclimate

* APPEALS-43714: Refactor VANotify Modules to Not Rely on Class Variables (#21596)

* APPEALS-43714: Refactor VANotify Modules to Not Rely on Class Variables

* pushing changes

* updating tests

* rubocop

* rubocop'n

* deleting repeat constants

* removing file in favor of EVENT_TYPE_FILTERS.json

* removing instances of using VA_NOTIFY_TEMPLATE_NAMES and using EVENT_TYPE_FILTERS instead

* replacing all instances of strings with constants

* fixing bug

* rubocop'n

* rubocop'n

* rubocop

---------

Co-authored-by: Noah Hansen <nhansen@Noahs-MacBook-Pro.local>
Co-authored-by: Matthew Thornton <99351305+ThorntonMatthew@users.noreply.github.com>

* Clean notification_events after notification report specs finish (#21662)

Co-authored-by: Matthew Thornton <ThorntonMatthew@users.noreply.github.com>

* MattT/APPEALS-43725: Extract `notify_appellant` Call from `QuaterlyNotificationsJob` to Decrease Runtime (#21643)

* Group notification types as scopes

* Add new job

* Fix typo

* Add back batching

* Batch send messages

* Multithread job queueing

* Reconfigure bulk enqueueing to utilize send_notifications.fifo queue

* Update the comment on QuaterlyNotificationsJob#perform

to adhere to the RDoc standard

* Use constants for template name

* Provide a more descriptive var name

* Remove unused env var

* Fix linting issues

* Prevent error from being thrown early in init job

* Add RDoc comments to appeal_state

* Add rdoc comment to init job

* Add another rdoc comment to the init job

* Use a more specific error class whenever an appeal

cannot be located within the init job

* Add a more specific error to CaseflowJob#enqueue_batch_of_jobs

* Add test for SendNotificationJob.queue_name_suffix

* Update QuarterlyNotificationsJob tests

* Update appeal_state_spec.rb to cover new scopes

* Add spec file for NotificationInitializationJob

* Add CaseflowJob specs

* Add CaseflowJob specs

* Address rubocop issue (by ignoring it)

* Kicking off CodeClimate

* Fix some lint issues

* Freeze constant

---------

Co-authored-by: Matthew Thornton <ThorntonMatthew@users.noreply.github.com>

* Move spec file to proper location

* APPEALS-43599 (#21696)

* APPEALS-43599 Refactoring SendNotificationJob

* APPEALS-43599 Remove comments

* APPEALS-43599 Suppress code smells from reek

* APPEALS-43599 Suppress code smells from reek

* jcohen/APPEALS-43727 (#21589)

* APPEALS-43727 Branch created. Extracted all the 'when' conditions in the case statement within appellant_notification.rb update_appeal_state method.

* APPEALS-43727 appellant_notification_service is created, logic from crowded method in appellant_notificaion.rb placed in newly created file, allowing redability.

* APPEALS-43727 added logic to appeal_state.rb, appellant_notification.rb updated with less logic, readable code through well named methods.

* APPEALS-43727 commit before merge from teammates work

* APPEALS-43727 removed freeze method on default status hash in appeal_state.rb. removed some rubocop disabling in appellant_notificaion.rb

* APPEALS-43727 extracted more logic from the appellant_notification module and placed it into the appeal_state class. Also got rid of rubocop declarations in app_notif and app_state as well. finally removed feature_toggle calls in appell_notif.

* APPEALS-43727 tests passing, code works

* APPEALS-43727 adding tests to appeal_state_spec to test functionality

* APPEALS-43727 rspec tests in appeal_state.

* APPEALS-43727 tests pass.

* Fixing code climate duplicate code issue

* fixing case statement

* code climate things

* rubocop

* APPEALS-43727 work completed.

* APPEALS-43727 PR comments applied. tests not in a working state.

* APPEALS-43727 PR comments applied. appeal_state_spec in working state.

* APPEALS-43727 PR comments applied. appellant_notification_spec.rb all green.

* Adjust spacing of comments in appeal_state.rb

* Utilize #external_id method over ternary

* Swap or conditional for blank?

* Fix another whitespace gap

* APPEALS-43727 PR comments applied. again after reset.

* APPEALS-43727 PR comments applied. flipped conditionals in appeal_state.rb

* Update app/models/concerns/appeal_concern.rb

* APPEALS-43727 code/test edits

* APPEALS-43727 bulk_task_reasssignment_spec reverted to orginal state, with the exception of an expectation that was on line 98

* APPEALS-43727 lint fix

---------

Co-authored-by: Jonathan Cohen <cohen_jonathan@bah.com>
Co-authored-by: Noah Hansen <nhansen@Noahs-MacBook-Pro.local>
Co-authored-by: Matthew Thornton <ThorntonMatthew@users.noreply.github.com>
Co-authored-by: Matthew Thornton <99351305+ThorntonMatthew@users.noreply.github.com>

* APPEALS-46179 (#21712)

* APPEALS-46179 Create JobExecutionTimes table

* APPEALS-46179 Add comment

* APPEALS-46179 Update schema

* APPEALS-46193 (#21753)

* APPEALS-46193 Add record to JobExecutionTime table when job is performed

* APPEALS-46193 Updating JobExecutionTimes table with an upsert query

* APPEALS-46193 Ignore JobExecutionTimes for certain jobs

* APPEALS-46193 Update ignore_job_execution_time? method

* APPEALS-46193 Adding tests

* Fix lint issues

* Update AWS dependencies

* Rollback gem reduction due to UAT issue

* Alter queue priority

* Forward error in SendNotificationJob

* Allow for notification audit records to remain in ProdTest

* Fix spec

* Fix typo in test fixture's name

* Fix lint infraction related to re-raising exceptions

* Address duplication CC error

* Reenable-privacy-mail-notifications (#21859)

* Add conditional for FOIA and Privacy Act mail

task to receives 'Privacy Act Pending' notifications

* Update spec

* Adjust some specs

* Add missing param

---------

Co-authored-by: Matthew Thornton <ThorntonMatthew@users.noreply.github.com>

* Remove byebug from spec

* Revert queue adjustment

* Remove unused method

---------

Co-authored-by: Jeff Marks <jeff.t.marks@gmail.com>
Co-authored-by: Matthew Thornton <ThorntonMatthew@users.noreply.github.com>
Co-authored-by: Jonathan Cohen <121630615+JCohDev@users.noreply.github.com>
Co-authored-by: Jonathan Cohen <cohen_jonathan@bah.com>
Co-authored-by: prernadevbah <132498915+prernadevbah@users.noreply.github.com>
Co-authored-by: noahhansen-gov <166541737+noahhansen-gov@users.noreply.github.com>
Co-authored-by: Noah Hansen <nhansen@Noahs-MacBook-Pro.local>
Co-authored-by: Prerna Devulapalli <prerna.devulapalli@va.gov>

* feature/appeals-39842.1 (#21871)

* Fix PdfFile test

* Delete client/app/readerprototype/components/ReaderDocument.jsx (#21870)

Delete empty ReaderDocument file

* Fix lint issue in PdfFile (#21873)

---------

Co-authored-by: laurenyj <44596134+laurenyj@users.noreply.github.com>

* Revert "APPEALS-44916: Case Distribution Affinity Calculations (#21666)" (#21888)

* Revert "APPEALS-44916: Case Distribution Affinity Calculations (#21666)"

This reverts commit 7aa04e6713759c3212820a78aa6500863dd7f91a.

* fix users seed spec

* Revert "feature/APPEALS-43597 RC (#21860)" (#21895)

This reverts commit df60ddb567c3e02556e85ba37d555768d3a0de7e.

* Revert "APPEALS-47106 Caseflow Swagger (#21847)" (#21901)

This reverts commit c3bc5012618d614c3d017ae0f260a91c6d4aebec.

* sbashamoni/APPEALS-43724 Node 16 version upgrade changes (#21966) (#21975)

* Update node verstion to 16 in git workflow

* Update node verstion to 16 in nvm and dockerfile for demo

* Update node version in yarn.lock and package.json and .nvmrc file

* Update node's version path to node16 in docker-bin/env.sh

* Update and upgrade to node16 in client

* More updates to yarn.lock and package.json

* Fix tests by Adam Shaw

* Upadate snapshot for ScheduleVeteran.test.js.snap

* Doing some code clean up

* Doiing some more clean up

* Add and remove spaces to match master

* One more space to take care of

* One more space to take care of again

* One more space to take care of again

---------

Co-authored-by: ramon-chavez <Ramon.Chavez@va.gov>

* APPEALS-47277 remove Vegas office (#21876)

* APPEALS-47277 remove Vagas office

* Removed Texas ID from other files and updated tests

* Snapshot update

---------

Co-authored-by: Ron Wabukenda <130374706+ronwabVa@users.noreply.github.com>
Co-authored-by: Raymond Hughes <131811099+raymond-hughes@users.noreply.github.com>

* hotfix/APPEALS-22403 (#21942)

* add identifier for filenumber or ssn in filenumber search

* linting

* codeclimate linting

* update match call to return boolean

---------

Co-authored-by: Ron Wabukenda <130374706+ronwabVa@users.noreply.github.com>
Co-authored-by: Raymond Hughes <131811099+raymond-hughes@users.noreply.github.com>

* APPEALS-46907: Update to Determination of Gen Pop Legacy Cases (#21986)

* Isaiah/merge 46910 (#21983)

* removed BFHINES checks and modified tests

* removed lingering bfhines test

* modified test

* most recent updates on tests for passing status

* removed refs to cavc updates

* Skip flaky test ro_viewhearsched_spec

---------

Co-authored-by: Isaiah Saucedo <irsaucedo5@gmail.com>

* APPEALS-44916: Case Distribution Affinity Calculations (#21899)

* APPEALS-44956: Add AppealAffinity model and database table (#21526)

* add migration for appeal_affinities

* add AppealAffinity model and associations, update migration for new column

* update index to be unique

* add factory, add tests

* add factory traits to appeal and case for appeal affinities

* add combination trait to appeal factory

* add appeal_affinity to skipped associations in ETL reporting

* add a validation, test

* Craig/appeals 44958 (#21564)

* add new job, update affinity model validation and after save hook

* add update from push job

* fix job extending distribution scopes

* add with appeal affinities to distribution scopes

* typo

* add error handling, add test file

* add distributed case factory, refactor naming in job

* fix factories, added tests

* fix migration for null affinity start date column

* fixes, added tests

* more test updates

* add return in job if no query results, tests for no query results

* add test for after_save hook adding dist task instructions

* set start dist job to queue affinity job after running

* fix update job and start dist job spec

* queue affinity update job from push job

* code clarity

* fix judge in seed file

* remove comment, fix hearing factory, disable some seeds for testing

* add more tests

* test refactor

* update appeals for dist query to add affinity start, add seed file, fix hearing factory, add stat to dist factory

* disable new seed on reset

* update seed file with vet names, add another seed category

* fix distirbuted case factory?

* actually fix GHA runs

* lint, test fixes

* change constants in new job

* APPEALS-44959: Modify affinity date checks to use appeal_affinity (#21611)

* swap distribution queries from distribution_task to appeal_affinities

* update seed files to use appeal affinities instead of distribution task

* clean up seed file method names

* add missing Timecop.return in ama affinity case seed

* fix name of a method in a seed file

* remove references to distribution task in distribution scopes

* fix push priority job tests

* fix naming of args in one of the seed files

* fix user seed, fix date format in distribution task instructions

* fix tests for date format update

* Calvin/APPEALS-44957-rake-affinity (#21577)

* grabbed receipt dates from distributed cases

* refactored for functionality + added method to grab appeals that match

* using receipt date, get all related appeals

* added update/creation plus cleaned prior imple.

* gets most recent distributed case receipt_date

* skips if receipt_date is nil for performance

* if appeal affinity is nil, it will now be updated

* created spec file

* fixed non ready appeals

* updated query to match new AC

* removing comment

* testing for each docket

* updated spec file

* added new tests to rspec

* updated start date to receipt date instead of Time.now

* fixed date/time rspec errors

* added rails logger to know when rake task has finished

* added tag for rails log

* removed nonpriority dockets for direct_review and evidence_submission

* fixed lint issue

* fixed flaky spec test

* limits distributed cases query to within the last week

* APPEALS-46016: Add Affinity Start Date to the Explain Page (#21660)

* add affinity start date to explain page

* add feature test to verify dates display

* update rake task and spec (#21731)

* APPEALS-46325: Add Seeds for AOD Appeals and Update Dates to Match CAVC (#21730)

* add aod hearing cases to ama affinity cases seed

* fix lever spec

* APPEALS-45148: Hook to clear saved affinity date (#21623)

* initial imp. idea

* AC1: check for affinity_start_date on assignment

* AC2/3: update affinity start date  w/ instr.

* updates to naming, instructions, and hook logic

* updates after review

* rspec coverage and addtional condition

* removed unused identifier

* removed reduntant 'self's

* added update on actual AA record

* updated to save aa record and addtional rspec

* added change to assignment on no record test

* check for assignment

* addd update to 'on_hold' status

* public method to handle legacy affinity appeals

* added .reload to :with_affinity_appeal

* added .reload to :ready_for_distribution

* updates to pass explain_spec

* switched boolean values

* typo

* readujsted order on :create for affinity appeal

* removed after(:create)

* testing rspec by readding after :create

* reloading in assertation

* addressing lint errors

* fix seeds/users_spec

* add case dist lever to new tests (#21776)

* remove unnecessarily included module from job (#21827)

* APPEALS-47211: Improve Performance of Distribution Queries (#21840)

* rework ready_for_distribution scope

* fix non-hearing docket distribution bug

* restart tests

* added null checks for appeal affinity in distribution queries, update tests (#21893)

* add check for appeal being active to distribution and associated slack message (#21902)

* Update users_spec.rb

---------

Co-authored-by: calvincostaBAH <108481161+calvincostaBAH@users.noreply.github.com>
Co-authored-by: Isaiah Saucedo <irsaucedo5@gmail.com>

* hotfix/APPEALS-45177: TaskTable Default Sorting Fix (#21772)

* Updated the TaskTable component to use the defaultSort property instead of the defaultSortIdx property for queue table since that property is not used anywhere. Added a default sorting hash to the UnassignedCasesPage component and now pass that down to TaskTable. Removed references to defaultSortIdx.

* Added the type column default sort to the AssignedCasesPage widget as well.

* Added a parenthesis for clarity around a boolean. Moved the defaultSortingHash out into a constants file.

---------

Co-authored-by: Robert Travis Pierce <robert@roberttravispierce.com>

* APPEALS-47106 Caseflow Swagger (#21993)

* Add Rswag and convert existing API documentation (#21778)

* add rswag

* Update Gemfile.lock

* Setup yaml UI

* remove and reroute old swagger files

* update format and servers values

* Update route_docs_controller.rb

* Update cmp_controller.rb

* cmp endpoint yaml

* cmp endpoint to return 501

* CMP endpoint swagger flies

* update swagger files

* adjust server order, add auth token

* cmp parameter name change

* add comments

* Update users_controller.rb

* unit tests and linting

* lint fixes

* Update swagger_helper.rb

* APPEALS-48048 Swagger Updates (#21909)

* update servers to not include a host

* remove host for server

* remove generated swaggers from definitions

* remove internal API endpoints from having generated swagger

* IDT servers fixes

* disable CMP swagger in prod and prodtest

* set authorization correctly

* fix what is required for CMP upload

* fix linting issues, update lint rake task to autocorrect for rubocop, add rubocop make command

* Update decision_reviews.yaml

* Update ama_issues.yaml

* Update vacols_issues.yaml

* Update swagger.yaml

* fix check failures

* Update docs_controller_spec.rb

* fix unit tests

* Update fetch_all_active_legacy_appeals_job_spec.rb

* Update rswag_ui.rb

* Update lint.rake

* Update decision_reviews_spec.rb

* Update fetch_all_active_legacy_appeals_job_spec.rb

* Update veterans_controller_spec.rb

* feature/APPEALS-43597 RC1.5.1 (#21996)

* APPEALS-36759 Add sms_response_content and sms_response_time notifications table

* APPEALS-37003 First pass at job refactor

* APPEALS-37003 Add comments and update kwargs for va notify service

* APPEALS-37003 Update spec files

* APPEALS-37003 Update spec

* APPEALS-37003 Ensure user in job and create email_enabled method

* APPEALS-37003 Remove question mark

* Limit max retry attempts to 5

* Add ? to boolen return methods

* jcohen/APPEALS-43706 (#21444)

* APPEALS-43706 macros added to each model file for the polymorphic relationship to be setup.

* APPEALS-43706 migration made and yet to be run.

* APPEALS-43706 migrations ran and expected columns and indexes are in table.

* Fix some spec failures unrelated to this branch

* Limit schema diff

* Add a missing tab

* Fix more unrelated failures. Also prevent ACD lever seeds from overwriting spec output

* Fix last unrelated failure.

* APPEALS-43706 linting issues in va_notify_service fixed.

---------

Co-authored-by: Jonathan Cohen <cohen_jonathan@bah.com>
Co-authored-by: Matthew Thornton <ThorntonMatthew@users.noreply.github.com>

* [APPEALS-43598] Quarterly Notification Job refactoring (#21505)

* Quarterly Notification Job refactoring

* APPEALS-43598 Fix lint issues for QuarterlyNotificationsJob refactor

* APPEALS-43598 Fix db schema.rb file

* APPEALS-43598 Fix schema.rb file

* APPEALS-43598 Refactoring QuarterlyNotificationsJob for readability

* APPEALS-43598 Refactoring QuarterlyNotificationsJob and removing extra methods

* [APPEALS-43598] Update method name

---------

Co-authored-by: Matthew Thornton <99351305+ThorntonMatthew@users.noreply.github.com>

* APPEALS-44007: Eliminate Transmission of Notifications to Deceased Veterans (#21481)

* APPEALS-44007: Writing tests to ensure adding the 'failure due to deceased' information is properly set and added to the db

* updates to pr

* pushing changes for tonight

* updating spec file to handle enabling and disabling feature flags

* Update format_message_status

* Lint roll

* fixing conflicts

* Updates to send notification spec

* Fix one of the legacy test cases

* Remove accidental push

* Fix remaining test

---------

Co-authored-by: Noah Hansen <nhansen@Noahs-MacBook-Pro.local>
Co-authored-by: Matthew Thornton <ThorntonMatthew@users.noreply.github.com>
Co-authored-by: Matthew Thornton <99351305+ThorntonMatthew@users.noreply.github.com>

* MattT/APPEALS-45235: Remove Temporary PDF Files From tmp Directory After All eFolder Upload Attempts (#21557)

* Cleanup files after uploading to VBMS

* Only delete file if it exists

*…
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.