APPEALS-51237: Optimize feature tests in intake/appeal/edit_spec.rb #22150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Code Climate has analyzed commit 8b51f90 and detected 1 issue on this pull request. Here's the issue category breakdown:
View more on Code Climate. |
raymond-hughes
approved these changes
Jul 19, 2024
HunJerBAH
approved these changes
Jul 19, 2024
craigrva
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves APPEALS-51237
Description
Refactor the
spec/feature/intake/appeal/edit_spec.rbfile to consolidate assertions between tests which were performing the same actions. Move contested claim task creation tests to thespec/controllers/appeals_controller_spec.rb filesince they were exclusively testing a single piece of back-end functionality.Acceptance Criteria