SeanC/APPEALS-42315 | Create separate Remand table, model and seed data

app/models/remand.rb

@@ -0,0 +1,4 @@
+# frozen_string_literal: true
+
+class Remand < SupplementalClaim
+end

db/migrate/20240716143816_add_type_column_and_index_to_supplemental_claims_for_remand_inheritance.rb

@@ -0,0 +1,9 @@
+class AddTypeColumnAndIndexToSupplementalClaimsForRemandInheritance < Caseflow::Migration
+  def change
+    safety_assured do
+      add_column :supplemental_claims, :type, :string, default: "SupplementalClaim", null: false, comment: "The class name for the single table inheritance type of Supplemental Claim for example Remand"
+    end
+
+    add_safe_index :supplemental_claims, [:type], name: "index_supplemental_claims_on_type"
+  end
+end

db/schema.rb

@@ -10,7 +10,7 @@
 #
 # It's strongly recommended that you check this file into your version control system.
 
-ActiveRecord::Schema.define(version: 2024_06_13_202232) do
+ActiveRecord::Schema.define(version: 2024_07_16_143816) do
 
   # These are extensions that must be enabled in order to support this database
   enable_extension "plpgsql"
@@ -1831,11 +1831,13 @@
     t.boolean "filed_by_va_gov", comment: "Indicates whether or not this form came from VA.gov"
     t.boolean "legacy_opt_in_approved", comment: "Indicates whether a Veteran opted to withdraw their Supplemental Claim request issues from the legacy system if a matching issue is found. If there is a matching legacy issue and it is not withdrawn, then that issue is ineligible to be a new request issue and a contention will not be created for it."
     t.date "receipt_date", comment: "The date that the Supplemental Claim form was received by central mail. Only issues decided prior to the receipt date will show up as contestable issues.  It is also the claim date for any associated end products that are established. Supplemental Claims do not have the same timeliness restriction on contestable issues as Appeals and Higher Level Reviews."
+    t.string "type", default: "SupplementalClaim", null: false, comment: "The class name for the single table inheritance type of Supplemental Claim for example Remand"
     t.datetime "updated_at"
     t.uuid "uuid", default: -> { "uuid_generate_v4()" }, null: false, comment: "The universally unique identifier for the Supplemental Claim. Can be used to link to the claim after it is completed."
     t.string "veteran_file_number", null: false, comment: "PII. The file number of the Veteran that the Supplemental Claim is for."
     t.boolean "veteran_is_not_claimant", comment: "Indicates whether the Veteran is the claimant on the Supplemental Claim form, or if the claimant is someone else like a spouse or a child. Must be TRUE if the Veteran is deceased."
     t.index ["decision_review_remanded_type", "decision_review_remanded_id"], name: "index_decision_issues_on_decision_review_remanded"
+    t.index ["type"], name: "index_supplemental_claims_on_type"
     t.index ["updated_at"], name: "index_supplemental_claims_on_updated_at"
     t.index ["uuid"], name: "index_supplemental_claims_on_uuid"
     t.index ["veteran_file_number"], name: "index_supplemental_claims_on_veteran_file_number"

db/seeds/veterans_health_administration.rb

@@ -54,6 +54,7 @@ def create_supplemental_claims
         3.times do
           CLAIMANT_TYPES.each do |claimant_type|
             create_sc_with_claimant(benefit_type, claimant_type)
+            create_sc_remand(benefit_type, claimant_type)
           end
         end
       end
@@ -83,6 +84,16 @@ def create_sc_with_claimant(benefit_type, claimant_type)
       sc.create_business_line_tasks!
     end
 
+    def create_sc_remand(benefit_type, claimant_type)
+      sc = create(
+        :remand,
+        benefit_type: benefit_type,
+        claimant_type: claimant_type,
+        number_of_claimants: 1
+      )
+      sc.create_business_line_tasks!
+    end
+
     # :reek:NestedIterators
     # this method is creating most of the data, but we can't get around it because of how many PO/VISN combos there are
     def create_vha_visn_pre_docket_queue

spec/factories/supplemental_claim.rb

@@ -7,6 +7,7 @@
     benefit_type { "compensation" }
     uuid { SecureRandom.uuid }
     veteran_is_not_claimant { true }
+    type { SupplementalClaim.name }
 
     transient do
       number_of_claimants { nil }
@@ -282,5 +283,10 @@
                decision_review: sc)
       end
     end
+
+    factory :remand, class: Remand do
+      type { Remand.name }
+      decision_review_remanded { create(:appeal) }
+    end
   end
 end