Feature/appeals 28087 36678 #22319
Merged
Feature/appeals 28087 36678 #22319
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…er (#20569) * added skeleton for api route * removed duplicate code * removed development envs for api and moved to creating an ApiKey * removing any changes to development.rb * removed extra auth code * removed before action --------- Co-authored-by: TuckerRose <tuckerrose@tuckerroses-mbp.lan>
…ute & Controller (#20601) * APPEALS-38232 - renamed controller to AC req, added decision_review_created_error endpoint, added decision_review_created_error method, and added RSpec for new method * APPEALS-38232 - add comments to RSpec
* initial Events migration and model creation * created model for DecisionReviewCreatedEvent * updated comment with example * added spec for DRCE model * APPEALS-36684 created event_records migration and added polymorphic associations to specific models, and added rspec for the event_record model * APPEALS-36684 - Updated RSpec tests and updated variables and got unhappy path to pass * cleaned lint * saving DRCE spec changes * fixed spec test * changed has_many to has_one * updated event model spec * added validation for ER poly associations * changed association to has_one * added new method and updated tests * added foreign key after running checks * some PR comment changes * refactored methods in EventConcern --------- Co-authored-by: Jonathan Tsang <tsang_jonathan@bah.com> Co-authored-by: Enrilo Ugalde <ugalde_enrilo@bah.com>
* fixed migration to update existing events table * rollbacked to fix schema * schema fixes --------- Co-authored-by: TuckerRose <tuckerrose@tuckerroses-mbp.lan>
* APPEALS-38926 - Created DecisionReviewCreatedError Service Class, added logic for handling service error, updated DecisonReviewCreatedController, and DecisionReviewCreatedController spec, with the updated service logic * APPEALS-38926- created RSpec Test for DecisionReviewCreatedError Service Class and edited the Rails.logger for the service class * APPEALS-38926 Added new info column to update transaction and added it to the RSpec test * APPEALS-38926 - added comments to the Service Class * APPEALS-38926 - Code Changes from TL Code Review, added rescues and fails * APPEALS-38926 - fixed lint
* created new service class * add rspec test cases * service class methods * controller action and spec * controller update * CC fixes * removed accidental line * changed to find_or_create_by * reworked error for redis lock * additional rspec for controller * fixed test * rspec fix * delete lock key afterwards * moved Event creation back into lock block --------- Co-authored-by: Jonathan Tsang <tsang_jonathan@bah.com>
… create user if needed (#20838) * added user creation class & test * removed extra lines * add comment to class * added context for args from avro --------- Co-authored-by: Jonathan Tsang <tsang_jonathan@bah.com>
* APPEALS-39664 - Created updated_vacols_on_optin module class, and removed extra private * APPEALS-39664 - created UpdatedVacolsOnOptin module, RSpec file, as well as sudo code for SOC and SSOC optin check in main service class DecisionReviewCreated * APPEALS-39664 - Created RSpec Test - PASS, Updated method name. * APPEALS-39664 - Added Error Handling to Sub Service Class * APPEALS-39664 - Removed un-needed comments * APPEALS-39664 - added include for the module UpdateVacolsOnOptin inside decision_review_created service * APPEALS-39664 - Added Custom Error , and updated all .perform! to .process! * APPEALS-39664 - Updated RSpec Test to reflect changes - all pass * Updated comment for decision_review_created Service Class
* Created attribute for failed claims on event and displaying failed claim * passing all failed events back to serializer * added controller tests for failed_claims and added class method for finding claims on events * renamed failed_claims to claim_errors --------- Co-authored-by: TuckerRose <tuckerrose@tuckerroses-mbp.lan>
…reate Intake (#20967) * APPEALS-40954 - Added Sudo Code for CreateIntake Logic * APPEALS-40954 - added logic to CreateIntake module * APPEALS-40954 - added Create Intake spec with error handling - All pass * APPEALS-40954 - Added CreateIntake Module to DecisionReviewCreated Main Service * APPEALS-40954 - updated folder name and namespace * APPEALS-40954 - Updated RSpec to match folder * APPEALS-40954- Upated decision review created servie include to match folder * Fixed failing test due to folder structure change
* Added new veteran creation module * saving test changes * rspec * fixed datetime assign * renamed var --------- Co-authored-by: Jonathan Tsang <tsang_jonathan@bah.com>
* APPEALS-40950 - update var veteran to vbms_veteran * updated private method in controller to match happy path params dcr to drc
…aimant if needed (#21044) * created service class and basic unit tests * added conditionals for veteran claimants and will create veteran claimant now * modified create claimant to use eventing data * change to a class * creating claimant correctly * test fixes * removed old comments * fixed type for veteran_is_not_claimant * changed specs to match pulling out hash params and removed event.reference id * moved back to dot notation * updated comments * fixed create claimant issue * updated process to use bang method and returning claimant --------- Co-authored-by: TuckerRose <tuckerrose@tuckerroses-mbp.lan>
…21108) * moved metricsService call to top of method * modified rspec case * moved metric logging spec case higher up --------- Co-authored-by: Jonathan Tsang <tsang_jonathan@bah.com>
* added interface + parser class * edited veteran parse methods * renamed var to "payload" * started refactor * more refactor + rspec * added EPE attr * dateTime conversions * added class comments * rubocop lint changes * fixed test case --------- Co-authored-by: Jonathan Tsang <tsang_jonathan@bah.com>
* APPEALS-41931 - Created create_ep_establishment file and class * APPEALS-41931 - added process! method that creates epe from payload * APPEALS-41931 - added logic for EventRecord being created and error handling * APPEALS-41931 - added comments to process method * APPEALS-41931 - set up rspec test * APPEALS-41931 - removed lint * APPEALS-41931-created Rspec and Test Pass * APPEALS-41931 - cleaned lint and added error test 100% code coverage * APPEALS-41931- fixed lint * APPEALS-41931- fixed lint and fixed %100 code cov * APPEALS-41931 - cleaned up lint and warn for Service Class * APPEALS-41931 - Added CreateEpEstablishment.process! to the decision_review_created Parent Service Class * APPEALS-41931 - refactor code to implement new parser * fixed linting issues * APPEALS-41931 - Updated Comments for CreateEpEstablishment * APPEALS-41931 - moved logical date int to parser and refactored code in Class and RSepc * edits
* added an error and commented out call for createclaim * added new parser logic * merge request changes * fixed rubocop issues and added checks for claim review attributes --------- Co-authored-by: TuckerRose <tuckerrose@tuckerroses-mbp.lan>
…d add additional parser methods (#21294) * APPEALS-42631 - create example.json * APPEALS-42631 - implemented example_response and load_example method and works as expected * APPEALS-42631 - created RSpec for DecisionReviewCreatedParser * APPEALS-42631 - Refactored parser and Added RSpec for current praser * APPEALS-42631 - added methods to parser for intake, claimant, and claim_review and added matching rspec for new methods * APPEALS-42631 - updated code per TL Comments * APPEALS-421631- added additional comments and fixing lint
* initial commit * implementation & error * renamed method * rspec * saving refactor progress * finished refactoring class * added comment * minor parser/rspec updates --------- Co-authored-by: Jonathan Tsang <tsang_jonathan@bah.com>
* added RI parser methods to rspec * updated config for Consumer --------- Co-authored-by: Jonathan Tsang <tsang_jonathan@bah.com>
…cords (#21334) * updated decision review created to uncomment actions and updated specs * remove binding.pry * removed comments * fixed a bunch of broken tests * fixed last broken tests * fixed params for methods and specs --------- Co-authored-by: TuckerRose <tuckerrose@tuckerroses-mbp.lan>
…ntedRecord (#21382) * APPEALS-43446 - renamed columns for backfill record to evented record migrate and rollback work as intended * APPEALS-43446 replaced all backfill_record with evented_record within the models associations and updated Rspec tests * APPEALS-43446 fixed error message
* fixed test and refactored controller * saving changes * init commit passing all the way to request_issues * all pass and functions as expected * lint * lint * updated initializer to use deep_symbolize_keys * updated headers to be more dry * added missing Intake attributes * fixed failing tests * updated createIntake test * fixed veteran rspec * fixed RI test * APPEALS-43446- Change name of BackfillRecord polymorphic model to EventedRecord (#21382) * APPEALS-43446 - renamed columns for backfill record to evented record migrate and rollback work as intended * APPEALS-43446 replaced all backfill_record with evented_record within the models associations and updated Rspec tests * APPEALS-43446 fixed error message * updated intake * modified intake --------- Co-authored-by: Jonathan Tsang <tsang_jonathan@bah.com>
* Set event info back to default default state for info is an empty json object * Correct linting errors * Test happy path with rspec * Refactor rspec example * Converte module to class * Remove module import --------- Co-authored-by: Nico Rithner <nicolas.rithner@va.gov>
* add "from event" value to Store * updated setup guide for M3 * added new badges * added jest * storybook file * additional story * bugfix * snap update
* draft processor method done * process_nonrating method moved to DecisionReviewCreated service * json example added, process_nonrating method updated * 4 rspec test added * useless json example removed * commented lines removed * condition added * condition added. * test updated * first condition moved out of the method * process_nonrating method call moved down * 1 comment removed, 1 added * process nonrating method rafactored, logic transferred into the parser * method refactored, rspec tests updated * rspec test slightly refactored --------- Co-authored-by: Nader Kutub <nader.kutub@va.gov>
* Edit Issues screen update * relocated row * updated capybara test * updated capybara to check for new added text
* Remove cache updating call for veteran when veteran is being created for an event * Change seeds api_key.rb to consumer_api_key.rb --------- Co-authored-by: Matt Ray <108031363+mattray-gov@users.noreply.github.com>
Remove extra logic
* ama_eventing_enabled feature check added * toggle renamed * rspec tests added * 2 comments added * toggle renamed, logic trasferred into controller, tests updated * empty line removed --------- Co-authored-by: Matt Ray <108031363+mattray-gov@users.noreply.github.com>
…rtment-of-veterans-affairs/caseflow into cmartine/APPEALS-49863
Co-authored-by: Matt Ray <108031363+mattray-gov@users.noreply.github.com>
* Update process_nonrating to process_nonrationg_issue_category Remove extra logic * Update rspec. Remove unused example --------- Co-authored-by: Matt Ray <108031363+mattray-gov@users.noreply.github.com>
…nts (#22132) * APPEALS-51223 refactored the claimant_validator class method claimant_details_required? to consider the conditional statement * APPEALS-51223 updated Rspec to confirm claimant address_line_1 is nil and error is empty * APPEALS-51223 made changes to to claimant_validator to have all Unit test passing * APPEALS-51223 added suggested changes * Revert "fix merge conflict with AMA" This reverts commit 6775316, reversing changes made to 66cf311. * added comments * Delete docker-bin/build.sh, I didnt make these changes * Revert "Delete docker-bin/build.sh, I didnt make these changes" This reverts commit 03a3830. --------- Co-authored-by: nader k <nader@nkconsulting.net>
* Hide UI changes behind featureFlag * fixed lint spacing warnings
…ature/APPEALS-28087-36678
…ture/APPEALS-28087-36678
* code climate spec fix * up argument count * created a parser helper for reusable methods * reset codeclimate back to original and added issue parser * modified methods to take in a hash instead of multiple params * reduced create params down to 3 params * added space inside * swapped to safe navigator for intake check * fixed spec * fixed linting issue * fixed failing spec * fixed merge conflicts with code changes for helper --------- Co-authored-by: TuckerRose <tuckerrose@tuckerroses-mbp.lan> Co-authored-by: TuckerRose <tuckerrose@TuckerRoses-MacBook-Pro.local> Co-authored-by: Nader Kutub <nader.kutub@va.gov>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.