Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

APPEALS-25419: CAVC Remand Distribution Updates #22472

Merged

Commits on Apr 30, 2024

  1. Calvin/APPEALS-43852-cavc-levers (#21441)

    * enabled cavc affinity levers in UI
    
    * updated rspec
    calvincostaBAH authored Apr 30, 2024
    Configuration menu
    Copy the full SHA
    dfe0102 View commit details
    Browse the repository at this point in the history
  2. [APPEALS-43849]Update CAVC Affinity Implementation for AMA Dockets to… (

    #21456)
    
    * [APPEALS-43849]Update CAVC Affinity Implementation for AMA Dockets to Account for Omit/Infinity
    
    * Affinity rules applied to non genpop
    
    * Addressed comments
    
    * Addressed comments
    
    * fixed rubocop issues + added clarity to where clause
    
    ---------
    
    Co-authored-by: Calvin <Calvin.Costa@va.gov>
    samasudhirreddy and calvincostaBAH authored Apr 30, 2024
    Configuration menu
    Copy the full SHA
    9c76ad3 View commit details
    Browse the repository at this point in the history

Commits on May 2, 2024

  1. APPEALS-44956: Add AppealAffinity model and database table (#21526)

    * add migration for appeal_affinities
    
    * add AppealAffinity model and associations, update migration for new column
    
    * update index to be unique
    
    * add factory, add tests
    
    * add factory traits to appeal and case for appeal affinities
    
    * add combination trait to appeal factory
    
    * add appeal_affinity to skipped associations in ETL reporting
    
    * add a validation, test
    craigrva authored May 2, 2024
    Configuration menu
    Copy the full SHA
    e09beac View commit details
    Browse the repository at this point in the history

Commits on May 9, 2024

  1. Craig/appeals 44958 (#21564)

    * add new job, update affinity model validation and after save hook
    
    * add update from push job
    
    * fix job extending distribution scopes
    
    * add with appeal affinities to distribution scopes
    
    * typo
    
    * add error handling, add test file
    
    * add distributed case factory, refactor naming in job
    
    * fix factories, added tests
    
    * fix migration for null affinity start date column
    
    * fixes, added tests
    
    * more test updates
    
    * add return in job if no query results, tests for no query results
    
    * add test for after_save hook adding dist task instructions
    
    * set start dist job to queue affinity job after running
    
    * fix update job and start dist job spec
    
    * queue affinity update job from push job
    
    * code clarity
    
    * fix judge in seed file
    
    * remove comment, fix hearing factory, disable some seeds for testing
    
    * add more tests
    
    * test refactor
    
    * update appeals for dist query to add affinity start, add seed file, fix hearing factory, add stat to dist factory
    
    * disable new seed on reset
    
    * update seed file with vet names, add another seed category
    
    * fix distirbuted case factory?
    
    * actually fix GHA runs
    
    * lint, test fixes
    
    * change constants in new job
    craigrva authored May 9, 2024
    Configuration menu
    Copy the full SHA
    4141f56 View commit details
    Browse the repository at this point in the history

Commits on May 10, 2024

  1. [Appeals 43850] Update Legacy Docket Queries to Account for the Previ…

    …ous Decision Judge and Type Action (#21556)
    
    * test changes for seans ticket
    
    * test changes
    
    * added joins to all required methods
    
    * fixed lint
    
    * fixed column ambiguity errors
    
    * cleaned up naming scheme
    
    * Documentation for JOIN_PREVIOUS_APPEALS constant
    
    ---------
    
    Co-authored-by: Calvin <Calvin.Costa@va.gov>
    seanrpa and calvincostaBAH authored May 10, 2024
    Configuration menu
    Copy the full SHA
    310ffcf View commit details
    Browse the repository at this point in the history

Commits on May 13, 2024

  1. APPEALS-44959: Modify affinity date checks to use appeal_affinity (#2…

    …1611)
    
    * swap distribution queries from distribution_task to appeal_affinities
    
    * update seed files to use appeal affinities instead of distribution task
    
    * clean up seed file method names
    
    * add missing Timecop.return in ama affinity case seed
    
    * fix name of a method in a seed file
    
    * remove references to distribution task in distribution scopes
    
    * fix push priority job tests
    
    * fix naming of args in one of the seed files
    
    * fix user seed, fix date format in distribution task instructions
    
    * fix tests for date format update
    craigrva authored May 13, 2024
    Configuration menu
    Copy the full SHA
    ff0f872 View commit details
    Browse the repository at this point in the history

Commits on May 16, 2024

  1. Configuration menu
    Copy the full SHA
    7a46496 View commit details
    Browse the repository at this point in the history

Commits on May 17, 2024

  1. APPEALS-44187: Factory Bot Additions (#21438)

    * AC1: values for bfddec and bfmpro
    
    * AC2: case issues updated to '3'
    
    * AC3-4: attorney and judge additions
    
    * ac 5: bfdpdcn addition
    
    * AC6: case type action addition
    
    * ac7: new folder match to original
    
    * ac8: case issues set to original
    
    * AC 3/4: added associations to original
    
    * ac3/4: updated logic to handle no args
    
    * ac3/4: return sattyid
    
    * ac7:updating folder assignment
    
    * ac7: added bfkey to except block
    
    * ac7/8: update to case issue list and validations dismissed
    
    * removed byebug
    
    * ac7: added 'ticknum' to except
    
    * lint fixes
    
    * lint fixes
    
    * lint fixes
    
    * lint fixes
    
    * nested trait into form_9 factory
    
    * new addtions
    
    * added .save to case issues
    
    * resolving correspondent and titrnum associations
    
    * fixed bfdc typo
    
    * factory additions
    
    * added ssn to associated corr.
    
    * removed transient and added .save
    
    * added after create to corr factory
    
    * veteran lookup check prior to create
    
    * committing missed 'end'
    
    * moved over veteran create to case fact.
    
    * move corr. association field to case fact.
    
    * lint issues + corres. save
    isaiahsaucedo authored May 17, 2024
    Configuration menu
    Copy the full SHA
    07bba3d View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    34641ca View commit details
    Browse the repository at this point in the history
  3. Calvin/APPEALS-44957-rake-affinity (#21577)

    * grabbed receipt dates from distributed cases
    
    * refactored for functionality + added method to grab appeals that match
    
    * using receipt date, get all related appeals
    
    * added update/creation plus cleaned prior imple.
    
    * gets most recent distributed case receipt_date
    
    * skips if receipt_date is nil for performance
    
    * if appeal affinity is nil, it will now be updated
    
    * created spec file
    
    * fixed non ready appeals
    
    * updated query to match new AC
    
    * removing comment
    
    * testing for each docket
    
    * updated spec file
    
    * added new tests to rspec
    
    * updated start date to receipt date instead of Time.now
    
    * fixed date/time rspec errors
    
    * added rails logger to know when rake task has finished
    
    * added tag for rails log
    
    * removed nonpriority dockets for direct_review and evidence_submission
    
    * fixed lint issue
    
    * fixed flaky spec test
    
    * limits distributed cases query to within the last week
    calvincostaBAH authored May 17, 2024
    Configuration menu
    Copy the full SHA
    0a4ccaf View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    e0afce1 View commit details
    Browse the repository at this point in the history
  5. APPEALS-46016: Add Affinity Start Date to the Explain Page (#21660)

    * add affinity start date to explain page
    
    * add feature test to verify dates display
    craigrva authored May 17, 2024
    Configuration menu
    Copy the full SHA
    6ce88de View commit details
    Browse the repository at this point in the history
  6. Sudhir/appeals 43851 (#21613)

    * Implement CAVC + AOD Affinity Lever for AMA Dockets
    
    * addressed comments
    
    * addressed comments
    
    * Addressed comments
    
    * added cavc_aod_affinity in case distribution lever model
    
    * addressed comments
    
    * addressed comments
    
    * updated specs
    
    * Updated specs
    
    * specs changes reverted
    
    * ama_aod and ama_non_aod queries updated
    
    * change the assertion in docket spec
    samasudhirreddy authored May 17, 2024
    Configuration menu
    Copy the full SHA
    8181165 View commit details
    Browse the repository at this point in the history

Commits on May 21, 2024

  1. Craig/appeals 46196 (#21689)

    * fix query, tested locally
    
    * add basic test to verify csv downloads aren't broken
    craigrva authored May 21, 2024
    Configuration menu
    Copy the full SHA
    6579ea9 View commit details
    Browse the repository at this point in the history

Commits on May 22, 2024

  1. APPEALS-43851: Add test to validate CAVC+AOD behavior on hearing dock…

    …et appeals affinities (#21678)
    
    * add test to validate cavc+aod on hearing docket appeals
    
    * lint, test case_docket_spec fix
    
    * modify case_docket_spec again
    
    * more test fix testing
    
    * attempt to fix test again
    
    * test removing prev appeals from nonpriority queries
    
    * more test tests
    
    * feature toggle change in test
    
    * reorder new portions of query
    
    * remove unused portions of queries in case_docket
    
    * revert unneeded change to query order
    
    * revert unneeded change to query order
    craigrva authored May 22, 2024
    Configuration menu
    Copy the full SHA
    baae791 View commit details
    Browse the repository at this point in the history

Commits on May 24, 2024

  1. Configuration menu
    Copy the full SHA
    13b195f View commit details
    Browse the repository at this point in the history
  2. APPEALS-46325: Add Seeds for AOD Appeals and Update Dates to Match CA…

    …VC (#21730)
    
    * add aod hearing cases to ama affinity cases seed
    
    * fix lever spec
    craigrva authored May 24, 2024
    Configuration menu
    Copy the full SHA
    3244e6d View commit details
    Browse the repository at this point in the history

Commits on May 30, 2024

  1. APPEALS-45148: Hook to clear saved affinity date (#21623)

    * initial imp. idea
    
    * AC1: check for affinity_start_date on assignment
    
    * AC2/3: update affinity start date  w/ instr.
    
    * updates to naming, instructions, and hook logic
    
    * updates after review
    
    * rspec coverage and addtional condition
    
    * removed unused identifier
    
    * removed reduntant 'self's
    
    * added update on actual AA record
    
    * updated to save aa record and addtional rspec
    
    * added change to assignment on no record test
    
    * check for assignment
    
    * addd update to 'on_hold' status
    
    * public method to handle legacy affinity appeals
    
    * added .reload to :with_affinity_appeal
    
    * added .reload to :ready_for_distribution
    
    * updates to pass explain_spec
    
    * switched boolean values
    
    * typo
    
    * readujsted order on :create for affinity appeal
    
    * removed after(:create)
    
    * testing rspec by readding after :create
    
    * reloading in assertation
    
    * addressing lint errors
    isaiahsaucedo authored May 30, 2024
    Configuration menu
    Copy the full SHA
    e3a0993 View commit details
    Browse the repository at this point in the history

Commits on May 31, 2024

  1. Configuration menu
    Copy the full SHA
    e1fd851 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    4a10fa8 View commit details
    Browse the repository at this point in the history
  3. fix seeds/users_spec

    craigrva committed May 31, 2024
    Configuration menu
    Copy the full SHA
    429d955 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    8978540 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    7bf16f1 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    7ffc3eb View commit details
    Browse the repository at this point in the history
  7. fix rubocop warning

    craigrva committed May 31, 2024
    Configuration menu
    Copy the full SHA
    f1ae936 View commit details
    Browse the repository at this point in the history

Commits on Jun 28, 2024

  1. Acd/appeals 43853 43854 (#21971)

    * Calvin/appeals 43853 (#21723)
    
    * initial updates
    
    * removing unnecessary variable
    
    * focused in on priority
    
    * removing non priority stuff
    
    * added general comments
    
    * added BFAC and AOD to cavc aod lever query
    
    * adding judge vacols id to query
    
    * aod affinity_start_date filter initial changes
    
    * fixed sorting
    
    * fixed rubocop issues
    
    * updated filter method
    
    * error handling
    
    * added ineligibility to queries for PREV_DECIDING_JUDGE
    
    * fixed SQL query + added comments
    
    * added exclude from affinity check into the case docket queries
    
    * error handling + fixing sql queries
    
    * rejects appeals without affinity_start_dates and nonmatching judges
    
    * fixing rubocop offenses
    
    * fixed inconsistencies between methods
    
    * fixed conditions for rejecting appeals
    
    * refactored cavc aod affinity filter to make it much easier to read
    
    * refactored code to account for AC6
    
    * error handling for empty exclude from affinity
    
    * reverted next if block to old logic to ensure it works
    
    * added PREV_DEC_JUDGE is not null
    
    * case.rb factory changes
    
    * added more options to legacy_cavc_appeal creation
    
    * cleaned up code for simpler reading
    
    * fix for aod legacy cavc creation
    
    * added tied to option to legacy cavc appeal factory
    
    * limits are now handled correctly in query
    
    * replaced return false to next if, as return false was causing unexpected behavior
    
    * fix rspecs + one edge case
    
    * added cavc aod lever creation to rspecs
    
    * removed bfac and aod from nonpriority query
    
    * cavc aod appeals w/excluded judges are now properly being filtered
    
    * refactored excluded judges check
    
    * added to old query to fix rspec errors
    
    * modified case factory bot
    
    * query now handles when prev_deciding_judge is nil
    
    * removed unnecessary condition
    
    * fixed case factory to now have tied_to attatched to orig appeal
    
    * fixed next if block within filter
    
    * handles omit scenarios + correctly rejects with next
    
    * working on rspec (still failing)
    
    * fix for ineligble VLJ when infinite
    
    * fixed rspec suite for cavc aod filters
    
    * fixed omit scenario in cavc aod affinity filter
    
    * consolidation & readability refactor
    
    * rubocop fixes
    
    * fixed spec error
    
    * Implement CAVC Affinity for Legacy Docket (#21706)
    
    * Implement CAVC Affinity for Legacy Docket
    
    * addressed comments
    
    * Added BFAC in the query
    
    * code changes for affinitty date
    
    * Added affinity code
    
    * code refactor and removed non priority code changes
    
    * fixed syntax change
    
    * Addressed comments
    
    * refactor cavc affinity filter
    
    * refactored code
    
    * code refactor
    
    * code refactor
    
    * Updated existing specs
    
    * code refactor
    
    * Added new rspecs
    
    * code refactor and added test  cases
    
    * code refactor
    
    * added test cases
    
    * fixes push_priority_spec
    
    * fixed rubocop issues
    
    * rubocop issue fixed
    
    * refactored code to make it easier to understand
    
    * refactored + fixed rspec and lint errors
    
    ---------
    
    Co-authored-by: Calvin <Calvin.Costa@va.gov>
    Co-authored-by: calvincostaBAH <108481161+calvincostaBAH@users.noreply.github.com>
    
    * basic creation of legacy affinity cases seed data
    
    * bug fixes, added bfcorlid with veterans, fully runs now
    
    * added new appeals for affinity_and_tied_to_judge
    
    * made data have realistic bfcorlids
    
    * changes document sequence to use less digits
    
    * added new file numbers for tied_to cases to make them easier to identify
    
    ---------
    
    Co-authored-by: samasudhirreddy <108430298+samasudhirreddy@users.noreply.github.com>
    calvincostaBAH and samasudhirreddy authored Jun 28, 2024
    Configuration menu
    Copy the full SHA
    d37db6e View commit details
    Browse the repository at this point in the history

Commits on Jul 3, 2024

  1. APPEALS-50692: Update Appeals Ready to Distribute CSV to include CAVC…

    … remand original judge (#22070)
    
    * CSV download functional
    
    * add tests, fix CSV query in CaseDocket
    
    * fix lint
    craigrva authored Jul 3, 2024
    Configuration menu
    Copy the full SHA
    65c552d View commit details
    Browse the repository at this point in the history

Commits on Jul 12, 2024

  1. Calvin/appeals 44313 (#22119)

    * initial seed data file
    
    * added legacy cavc and cavc aod affinity cases
    
    * update
    
    * fixed tied to for legacy appeals
    
    * added AOD versions of appeals
    
    * small lint fixes
    
    * ensured AOD cases for legacy hearings with exluded or ineligible judge
    
    * added vacols staff record creation for users without it
    calvincostaBAH authored Jul 12, 2024
    Configuration menu
    Copy the full SHA
    1233b7d View commit details
    Browse the repository at this point in the history

Commits on Jul 18, 2024

  1. APPEALS-47741: Update the UpdateAppealAffinityDatesJob to add appeal_…

    …affinity records for Legacy Appeals (#22023)
    
    * AC1: changes and respective tests
    
    * adjustements after refactoring
    
    * identifier mismatch
    
    * name update
    
    * name update
    
    * added appeal affinity filter
    
    * updated comment
    
    * remove byebug
    
    * update rspec to handle hash input
    
    * added no start date test case
    
    * updated process method test
    
    * removed 'todo' comment
    
    * dried up query string
    
    * aligned conditions
    
    * update to hash quotations
    
    * update to hash quotations
    
    * added legacy to priority receipt dates from dist.
    
    * moved append to resulting list
    
    * added legacy receipt date to push job hash
    
    * uncomment call to legacy
    
    * updated dist.id to @dist_id
    
    * uncomment call to process legacy appeals
    
    * handling update to legacy docket type
    
    * current rspec status
    
    * fixed typo
    
    * fix rspec
    
    * legacy spec additions
    
    * legacy spec additions
    
    * added legacy dist. case factory
    
    * removed vacols_judge ref
    
    * updates for spec
    
    * final review
    
    * removed comment
    
    * rubocop fixes
    isaiahsaucedo authored Jul 18, 2024
    Configuration menu
    Copy the full SHA
    dbcb5ba View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    d2bc0ed View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    1060303 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    6a69613 View commit details
    Browse the repository at this point in the history

Commits on Jul 25, 2024

  1. Calvin/appeals 52551 (#22293)

    * age_of_n_oldest_priority_appeals_available_to_judge time out changes
    
    * fixed timeout issue for distribute_priority_appeals
    
    * fixed lint errors
    calvincostaBAH authored Jul 25, 2024
    Configuration menu
    Copy the full SHA
    638a318 View commit details
    Browse the repository at this point in the history
  2. Craig/case docket optimization (#22294)

    * age_of_n_oldest_priority_appeals_available_to_judge time out changes
    
    * fixed timeout issue for distribute_priority_appeals
    
    * optimize case docket priority distribution methods
    
    * fix das deprecation distribution spec
    
    ---------
    
    Co-authored-by: Calvin <Calvin.Costa@va.gov>
    craigrva and calvincostaBAH authored Jul 25, 2024
    Configuration menu
    Copy the full SHA
    feb3aec View commit details
    Browse the repository at this point in the history

Commits on Jul 29, 2024

  1. Configuration menu
    Copy the full SHA
    e9304b3 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    29074e6 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    f44f713 View commit details
    Browse the repository at this point in the history

Commits on Jul 31, 2024

  1. Configuration menu
    Copy the full SHA
    746a71c View commit details
    Browse the repository at this point in the history

Commits on Aug 13, 2024

  1. Configuration menu
    Copy the full SHA
    3f9d4e3 View commit details
    Browse the repository at this point in the history

Commits on Aug 16, 2024

  1. APPEALS-53993: Update Implementation of Legacy Appeals with Hearing H…

    …eld (#22473)
    
    * implement new hearing requirement and test
    
    * first pass at seed data for testing
    
    * add new case to test and seed, fix typo and comments
    
    * update for new 8.2.1.1 requirement
    
    * fix rubocop warning
    
    * fix error in seed file
    
    * add new affinity scenario to seed data
    
    * make some seed methods private
    
    * fix rubocop warnings
    craigrva authored Aug 16, 2024
    Configuration menu
    Copy the full SHA
    7e2af42 View commit details
    Browse the repository at this point in the history

Commits on Aug 22, 2024

  1. Configuration menu
    Copy the full SHA
    2b84666 View commit details
    Browse the repository at this point in the history

Commits on Sep 3, 2024

  1. Configuration menu
    Copy the full SHA
    cfd6a6c View commit details
    Browse the repository at this point in the history