Re-enable failing specs.

spec/feature/reader/logs_controller_spec.rb

@@ -34,7 +34,7 @@
   end
 
   context "pdf_page_render_time_in_ms Feature toggle enabled" do
-    scenario "create a metric for pdf_page_render_time_in_ms" do
+    xscenario "create a metric for pdf_page_render_time_in_ms" do
       FeatureToggle.enable!(:metrics_get_pdfjs_doc)
       expect(Metric.any?).to be false # There are no metrics
       Capybara.default_max_wait_time = 5 # seconds

spec/feature/reader/reader_spec.rb

@@ -535,7 +535,7 @@
       click_on documents[0].type
 
       # Ensure PDF content loads (using :all because the text is hidden)
-      expect(page).to have_content(:all, "Important Decision Document!!!", wait: 10)
+      expect(page).to have_content(:all, "Important Decision Document!!!", wait: 20)
 
       add_comment("Foo")
 
@@ -746,10 +746,13 @@
         expect(page).to have_css("#commentIcon-container-#{annotation.id}")
       end
 
-      xscenario "Scroll to comment" do
+      scenario "Scroll to comment" do
         visit "/reader/appeal/#{appeal.vacols_id}/documents"
 
         click_on documents[0].type
+        page.driver.browser.manage.window.resize_to(1024, 1024)
+
+        find("h3", text: "Comments").click
 
         element_id = "cf-sidebar-accordion"
         scroll_to(id: element_id, value: 0)
@@ -773,16 +776,17 @@
         find("g[filter=\"url(##{id})\"]")
       end
 
-      xscenario "Scroll to comment icon" do
+      scenario "Scroll to comment icon" do
         visit "/reader/appeal/#{appeal.vacols_id}/documents"
 
-        click_on documents[0].type
-
+        click_on(documents[0].type, wait: 10)
+        find("h3", text: "Comments", wait: 5).click
         expect(page).to have_content(annotations[0].comment)
 
         # Wait for PDFJS to render the pages
         expect(page).to have_css(".page")
-
+        page.driver.browser.manage.window.resize_to(1024, 1024)
+        expect(page).to have_content(:all, "Important Decision Document!!!", wait: 20)
         # Click on the comment and ensure the scroll position changes
         # by the y value the comment.
         element_class = "ReactVirtualized__Grid__innerScrollContainer"
@@ -802,12 +806,14 @@
         find("g[filter=\"url(##{id})\"]")
       end
 
-      xscenario "Follow comment deep link" do
+      scenario "Follow comment deep link" do
         annotation = documents[1].annotations[0]
         # Open the document list before trying to go to deep link to pre-load the data
         visit "/reader/appeal/#{appeal.vacols_id}/documents/"
         visit "/reader/appeal/#{appeal.vacols_id}/documents/#{documents[1].id}?annotation=#{annotation.id}"
 
+        find("h3", text: "Comments").click
+
         expect(page).to have_content(annotation.comment)
         expect(page).to have_css(".page")
         expect(page).to have_css("#commentIcon-container-#{annotation.id}")
@@ -852,7 +858,7 @@
 
     # The zoom level is adjusted by changing the height of the container row in react-virtualized
     # Checking for text on the pages is flaky because of inconsistencies with react-virtualized rendering
-    xscenario "Zooming changes the size of pages" do
+    scenario "Zooming changes the size of pages" do
       # This is set in client/app/2.0/store/constants/reader.js as ZOOM_RATE
       zoom_rate = 0.3
 
@@ -879,12 +885,12 @@
       expect(ratio).to eq(1 - zoom_rate)
     end
 
-    xscenario "Open document, close/open sidebar, and open/close sidebar accordions" do
+    scenario "Open document, close/open sidebar, and open/close sidebar accordions" do
       visit "/reader/appeal/#{appeal.vacols_id}/documents/"
       click_on documents[0].type
 
       def click_accordion_header(index)
-        find_all(".rc-collapse-header")[index].click
+        find_all(".rc-collapse-header", wait: 5)[index].click
       end
 
       # Hide sidebar
@@ -997,7 +1003,7 @@
       end
     end
 
-    xscenario "Categories" do
+    scenario "Categories" do
       cats = {
         procedural: "Procedural",
         medical: "Medical",
@@ -1033,7 +1039,8 @@
         find(".cf-pdf-header .cf-pdf-doc-type-button-container", text: "BVA Decision")
         expect(cats_in_header).to match_array [cats[:procedural], cats[:case_summary]]
 
-        find(".checkbox-wrapper-procedural").click
+        find("h3", text: "Categories").click
+        find(".checkbox-wrapper-procedural", wait: 12).click
         find(".checkbox-wrapper-medical").click
 
         # this will wait for the categories to update in the header before expecting anything
@@ -1052,6 +1059,7 @@
         # this will wait for the document title to display before expecting anything
         find(".cf-pdf-header .cf-pdf-doc-type-button-container", text: "Form 9")
         expect(cats_in_header).to match_array [cats[:medical], cats[:other], cats[:case_summary]]
+        find("h3", text: "Categories").click
         expect(find("#case_summary", visible: false).disabled?).to be true
       end
 
@@ -1104,7 +1112,7 @@
     context "Tags" do
       let(:new_tag_text) { "Foo" }
 
       xscenario "adding and deleting tags" do
         TAG1 = "Medical"
         TAG2 = "Law document"
 
@@ -1113,7 +1121,8 @@
         SELECT_VALUE_LABEL_CLASS = ".cf-select__multi-value__label"
 
         visit "/reader/appeal/#{appeal.vacols_id}/documents"
-        click_on documents[0].type
+        click_on(documents[0].type, wait: 10)
+        find("h3", text: "Issue tags", wait: 5).click
 
         fill_in "tags", with: TAG1
 
@@ -1133,9 +1142,10 @@
         visit "/reader/appeal/#{appeal.vacols_id}/documents"
         click_on documents[1].type
 
+        find("h3", text: "Issue tags", wait: 10).click
         # tags for first document are shared in tag auto suggestions for second document
-        page.find("#tags").click
-        tag_options = find_all(".cf-select__option")
+        page.find("#tags", wait: 10).click
+        tag_options = find_all(".cf-select__option", wait: 10)
         expect(tag_options.count).to eq 4
 
         documents[0].tags.each_with_index do |tag, index|
@@ -1159,7 +1169,7 @@
         visit "/reader/appeal/#{appeal.vacols_id}/documents"
 
         click_on documents[0].type
-
+        find("h3", text: "Issue tags", wait: 10).click
         # verify that the tags on first doc still exist and tag deleted from second doc isn't suggested
         expect(page).to have_css(SELECT_VALUE_LABEL_CLASS, count: 4)
       end