feature/APPEALS-32376 (Release Candidate)

.vscode/launch.json

@@ -53,6 +53,21 @@
         "webpack:///*": "${webRoot}/*"
       }
     },
+    {
+      "name": "Jest - On Current File",
+      "type": "node",
+      "request": "launch",
+      "env": {
+        "NODE_ENV": "test"
+      },
+      "program": "${workspaceFolder}/client/node_modules/.bin/jest",
+      "args": [
+        "${relativeFile}"
+      ],
+      "cwd": "${workspaceRoot}/client",
+      "console": "integratedTerminal",
+      "internalConsoleOptions": "neverOpen"
+    }
   ],
   "compounds": [
     {

app/controllers/tasks_controller.rb

@@ -122,7 +122,7 @@ def update
       # and AssignHearingDispositionTask for virtual hearing related updates
       # Start with any alerts on the current task, then find alerts on the tasks
       # that resulted from the update
-      alerts = tasks.reduce(task.alerts) { |acc, t| acc + t.alerts }
+      alerts = tasks.reduce([]) { |acc, t| acc + t.alerts }
 
       tasks_hash[:alerts] = alerts if alerts # does not add to hash if alerts == []
 

app/helpers/hearings/calendar_template_helper.rb

@@ -18,11 +18,11 @@ def central_office_display_time(hearing)
     end
 
     def representative_display_time(hearing)
-      format_hearing_time(hearing.time.poa_time)
+      format_hearing_time(hearing.poa_time)
     end
 
     def appellant_display_time(hearing)
-      format_hearing_time(hearing.time.appellant_time)
+      format_hearing_time(hearing.appellant_time)
     end
 
     # time_zone is a TZInfo::DataTimezone object; date_time_utc is a Time object

app/jobs/application_job.rb

@@ -44,17 +44,6 @@ def capture_exception(error:, extra: {})
     end
   end
 
-  # Testing America/New_York TZ for all jobs in UAT.
-  # :nocov:
-  if Rails.deploy_env?(:uat)
-    around_perform do |_job, block|
-      Time.use_zone(Rails.configuration.time_zone) do
-        block.call
-      end
-    end
-  end
-  # :nocov:
-
   before_perform do
     if self.class.app_name.present?
       RequestStore.store[:application] = "#{self.class.app_name}_job"

app/jobs/middleware/job_time_zone_middleware.rb

@@ -0,0 +1,15 @@
+# frozen_string_literal: true
+
+# This middleware ensures all async jobs run in UTC.
+class JobTimeZoneMiddleware
+  # :reek:LongParameterList
+  def call(_worker, _queue, _msg, body, &block)
+    job_class = body["job_class"]
+    current_tz = Time.zone.name
+    if current_tz != "UTC"
+      Rails.logger.info("#{job_class} current timezone is #{current_tz}")
+    end
+
+    Time.use_zone("UTC", &block)
+  end
+end

app/mailers/hearing_mailer.rb

@@ -120,10 +120,10 @@ def calendar_invite_name
     end
   end
 
-  def formatted_time
+  def formatted_time(time)
     # Mon, Oct 19 at 10:30am CDT
     time_format = "%a, %b %-d at %-l:%M%P %Z"
-    @hearing.time.appellant_time.strftime(time_format)
+    time.strftime(time_format)
   end
 
   def appellant_name
@@ -137,9 +137,9 @@ def appellant_last_name
 
   def reminder_subject
     if recipient_info.title == HearingEmailRecipient::RECIPIENT_TITLES[:representative]
-      "Reminder: #{appellant_name}'s Board hearing is #{formatted_time} – Do Not Reply"
+      "Reminder: #{appellant_name}'s Board hearing is #{formatted_time(@hearing.poa_time)} – Do Not Reply"
     else
-      "Reminder: Your hearing is #{formatted_time} – Do Not Reply"
+      "Reminder: Your hearing is #{formatted_time(@hearing.appellant_time)} – Do Not Reply"
     end
   end
 
@@ -149,7 +149,7 @@ def confirmation_subject
     when HearingEmailRecipient::RECIPIENT_TITLES[:appellant]
       "Your Board hearing has been scheduled – Do Not Reply"
     when HearingEmailRecipient::RECIPIENT_TITLES[:representative]
-      "Confirmation: #{appellant_last_name}'s Board hearing is #{formatted_time} – Do Not Reply"
+      "Confirmation: #{appellant_last_name}'s Board hearing is #{formatted_time(@hearing.poa_time)} – Do Not Reply"
     when HearingEmailRecipient::RECIPIENT_TITLES[:judge]
       hearing_date = virtual_hearing.hearing.scheduled_for.to_formatted_s(:short_date)
 

app/mappers/hearing_mapper.rb

@@ -14,7 +14,7 @@ class << self
     def hearing_fields_to_vacols_codes(hearing_info)
       {
         request_type: validate_request_type(hearing_info[:request_type], hearing_info.keys),
-        scheduled_for: VacolsHelper.format_datetime_with_utc_timezone(hearing_info[:scheduled_for]),
+        scheduled_for: hearing_info[:scheduled_for],
         notes: notes_to_vacols_format(hearing_info[:notes]),
         disposition: disposition_to_vacols_format(hearing_info[:disposition], hearing_info.keys),
         hold_open: hold_open_to_vacols_format(hearing_info[:hold_open]),

app/models/concerns/has_hearing_email_recipients_concern.rb

@@ -115,8 +115,9 @@ def appellant_email_address
 
   def appellant_tz
     recipient = email_recipients.find_by(type: "AppellantHearingEmailRecipient")
-    return recipient.timezone if recipient.present?
-    return virtual_hearing[:appellant_tz] if virtual_hearing.present?
+    recipient&.timezone ||
+      virtual_hearing&.[](:appellant_tz) ||
+      appeal&.appellant_tz
   end
 
   def representative_email_address
@@ -127,8 +128,9 @@ def representative_email_address
 
   def representative_tz
     recipient = email_recipients.find_by(type: "RepresentativeHearingEmailRecipient")
-    return recipient.timezone if recipient.present?
-    return virtual_hearing[:representative_tz] if virtual_hearing.present?
+    recipient&.timezone ||
+      virtual_hearing&.[](:representative_tz) ||
+      appeal&.representative_tz
   end
 
   private

app/models/concerns/hearing_time_concern.rb

@@ -6,7 +6,44 @@ module HearingTimeConcern
   delegate :central_office_time_string, :scheduled_time_string,
            to: :time
 
+  #  A façade for a hearing's memoized time service instance - either {HearingTimeService} or {HearingDatetimeService},
+  # depending on the hearing's attributes.
+  #
+  # @return [HearingTimeService] if {Hearing#use_hearing_datetime?} or {LegacyHearing#use_hearing_datetime?} is false
+  # @return [HearingDatetimeService] if {Hearing#use_hearing_datetime?} or {LegacyHearing#use_hearing_datetime?} is true
   def time
-    @time ||= HearingTimeService.new(hearing: self)
+    @time ||= if use_hearing_datetime?
+                HearingDatetimeService.new(hearing: self)
+              else
+                HearingTimeService.new(hearing: self)
+              end
+  end
+
+  # The hearing's local time cast into the POA's timezone
+  #
+  # @return [Time]
+  #   The hearing time in the representative recipient's timezone, if available, else local time.
+  def poa_time
+    normalized_time(representative_tz)
+  end
+
+  # The hearing's local time cast into the appellant's timezone
+  #
+  # @return [Time]
+  #   The hearing time in appellant recipient's timezone, if available, else local time.
+  def appellant_time
+    normalized_time(appellant_tz)
+  end
+
+  private
+
+  # @param timezone [String] A timezone in a format readable by Rails ActiveSupport::TimeZone.
+  #
+  # @return [Time] The hearing's local time cast into the supplied timezone.
+  # @return [Time] Fall back to the hearing's default local time if the supplied timezone is nil.
+  def normalized_time(timezone)
+    return time.local_time if timezone.nil?
+
+    time.local_time.in_time_zone(timezone)
   end
 end

app/models/etl/hearing_record.rb

@@ -21,6 +21,7 @@ def mirrored_hearing_attributes
         :notes,
         :prepped,
         :representative_name,
+        :scheduled_in_timezone,
         :scheduled_time,
         :summary,
         :transcript_requested,

app/models/hearing.rb

@@ -187,12 +187,21 @@ def advance_on_docket_motion
       .first
   end
 
+  # returns scheduled datetime object considering the timezones
+  # @return [nil] if hearing_day is nil
+  # @return [Time] in scheduled_in_timezone timezone - if scheduled_datetime and scheduled_in_timezone are present
+  # @return [Time] else datetime in regional office timezone
+  # rubocop:disable Metrics/AbcSize
   def scheduled_for
     return nil unless hearing_day
 
+    # returns datetime in scheduled_in_timezone timezone
+    if scheduled_datetime.present? && scheduled_in_timezone.present?
+      return scheduled_datetime.in_time_zone(scheduled_in_timezone)
+    end
+
     # returns the date and time a hearing is scheduled for in the regional office's
     # time zone
-    #
     # When a hearing is scheduled, we save the hearing time to the scheduled_time
     # field. The time is converted to UTC upon save *relative to the timezone of
     # the user who saved it*, not relative to the timezone of the RO where the
@@ -211,7 +220,6 @@ def scheduled_for
     # to explicitly convert it to the time zone of the person who scheduled it,
     # then assemble and return a TimeWithZone object cast to the regional
     # office's time zone.
-
     updated_by_timezone = updated_by&.timezone || Time.zone.name
     scheduled_time_in_updated_by_timezone = scheduled_time.utc.in_time_zone(updated_by_timezone)
 
@@ -226,11 +234,18 @@ def scheduled_for
       )
     end
   end
+  # rubocop:enable Metrics/AbcSize
 
   def scheduled_for_past?
     scheduled_for < DateTime.yesterday.in_time_zone(regional_office_timezone)
   end
 
+  # Checks the scheduled_datetime value and returns
+  # @return [Boolean] true if scheduled_datetime is not nil, else false
+  def use_hearing_datetime?
+    scheduled_datetime.present?
+  end
+
   def worksheet_issues
     request_issues.map do |request_issue|
       HearingIssueNote.joins(:request_issue)
@@ -240,10 +255,10 @@ def worksheet_issues
 
   def regional_office
     @regional_office ||= begin
-                            RegionalOffice.find!(regional_office_key)
+                           RegionalOffice.find!(regional_office_key)
                          rescue RegionalOffice::NotFoundError
                            nil
-                          end
+                         end
   end
 
   def regional_office_key

app/models/hearings/forms/hearing_update_form.rb

@@ -59,7 +59,11 @@ def hearing_updates
       prepped: prepped,
       representative_name: representative_name,
       room: room,
-      scheduled_time: scheduled_time_string,
+      scheduled_time: HearingTimeService.process_scheduled_time(scheduled_time_string),
+      scheduled_datetime: hearing.time.class.prepare_datetime_for_storage(
+        date: hearing.hearing_day&.scheduled_for,
+        time_string: scheduled_time_string
+      ),
       summary: summary,
       transcript_requested: transcript_requested,
       transcript_sent_date: transcript_sent_date,

app/models/hearings/forms/legacy_hearing_update_form.rb

@@ -22,8 +22,9 @@ def after_update_hearing
 
   private
 
+  # rubocop:disable Metrics/MethodLength
   def hearing_updates
-    updates = {
+    {
       aod: aod,
       bva_poc: bva_poc,
       disposition: disposition,
@@ -35,14 +36,15 @@ def hearing_updates
       prepped: prepped,
       representative_name: representative_name,
       room: room,
-      scheduled_for: scheduled_for,
-      scheduled_time_string: scheduled_time_string,
+      scheduled_for: hearing.time.process_legacy_scheduled_time_string(
+        date: hearing.hearing_day&.scheduled_for,
+        time_string: scheduled_time_string
+      ),
       summary: summary,
       transcript_requested: transcript_requested,
       witness: witness,
       email_recipients_attributes: email_recipients_attributes
     }.compact
-
-    HearingTimeService.build_legacy_params_with_time(hearing, updates)
   end
+  # rubocop:enable Metrics/MethodLength
 end

app/models/legacy_hearing.rb

@@ -137,8 +137,10 @@ def external_id
   end
 
   def hearing_day_id_refers_to_vacols_row?
-    (original_request_type == HearingDay::REQUEST_TYPES[:central] && scheduled_for.to_date < Date.new(2019, 1, 1)) ||
-      (original_request_type == HearingDay::REQUEST_TYPES[:video] && scheduled_for.to_date < Date.new(2019, 4, 1))
+    perform_vacols_request unless @vacols_load_status == :success
+
+    (original_request_type == HearingDay::REQUEST_TYPES[:central] && @scheduled_for.to_date < Date.new(2019, 1, 1)) ||
+      (original_request_type == HearingDay::REQUEST_TYPES[:video] && @scheduled_for.to_date < Date.new(2019, 4, 1))
   end
 
   def hearing_day_id
@@ -207,6 +209,12 @@ def scheduled_for_past?
     scheduled_date < DateTime.yesterday.in_time_zone(regional_office_timezone)
   end
 
+  # Checks the scheduled_in_timezone value and returns
+  # @return [Boolean] true if scheduled_in_timezone is not nil, else false
+  def use_hearing_datetime?
+    scheduled_in_timezone.present?
+  end
+
   def held_open?
     hold_open && hold_open > 0
   end
@@ -360,6 +368,23 @@ def vacols_hearing_exists?
     end
   end
 
+  # The scheduled time for a legacy hearing after it have been retrieved from VACOLS and processed for time zone.
+  #
+  # @return [Time] a Time object in the calculated time zone and DST offset
+  def scheduled_for
+    perform_vacols_request unless @vacols_load_status == :success
+
+    return nil unless @scheduled_for
+
+    return @scheduled_for.in_time_zone(scheduled_in_timezone) if scheduled_in_timezone
+
+    HearingMapper.datetime_based_on_type(
+      datetime: @scheduled_for,
+      regional_office: HearingRepository.regional_office_for_scheduled_timezone(self, vacols_record),
+      type: vacols_record.hearing_type
+    )
+  end
+
   class << self
     def venues
       RegionalOffice::CITIES.merge(RegionalOffice::SATELLITE_OFFICES)