-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/appeals 47313.bugfix #22702
Merged
mikefinneran
merged 94 commits into
release/FY24Q4.4.0
from
feature/appeals-47313.bugfix
Sep 4, 2024
Merged
Feature/appeals 47313.bugfix #22702
mikefinneran
merged 94 commits into
release/FY24Q4.4.0
from
feature/appeals-47313.bugfix
Sep 4, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ersectionObserver
* Remove linting errors. * Fix broken specs. * Comment out failing reader tests. * Update reviewer.scss to fix lint errors * Add space in reviewer.scss to fix lint error * Update css name --------- Co-authored-by: laurenyj <44596134+laurenyj@users.noreply.github.com>
* Re-enable failing specs. * Reduce flakiness of specs. * Reduce flakiness of specs. * Reduce flakiness of specs. * Reduce flakiness of specs. --------- Co-authored-by: Davy Wentworth <david.wentworth@va.gov>
* fix PdfUIPageNumInput page width bug * Update prototype reader footer to match original reader footer css updates * Revert reviewer changes * move styles to the correct place to override width:100 * Remove unused prototype css * Update page input test snap * Revert Page component changes and update with ctx options --------- Co-authored-by: Sean Parker <Sean.Parker3@va.gov> Co-authored-by: mikefinneran <110622959+mikefinneran@users.noreply.github.com>
Co-authored-by: laurenyj <44596134+laurenyj@users.noreply.github.com>
…of-veterans-affairs/caseflow into feature/appeals-47313.bugfix
ThorntonMatthew
approved these changes
Sep 4, 2024
ThorntonMatthew
added a commit
that referenced
this pull request
Sep 4, 2024
* Feature/appeals 47313.bugfix (#22702) * Remove and reinstall pdfjs-dist@2.6.347 and use cdn to get rid of fake worker warning * Comment out pdfjs worker lines in documentViewer.js to get rid of fake worker warning * Add PdfDocument component with no batching * Add MVP working reader prototype 2.0 * Add reader prototype warning on toolbar * Add MVP zoom function * Add prototype route * Fix next and previous doc links with prototype path * Extract toolbar buttons out to ReaderToolbar component * Fix prop type in PdfDocument * Remove prototype logic * Clean up prototype with utils * Fix scroll issue on document list view for Reader * APPEALS-46785. Add text layer to prototype. * Revert pdf-annotate changes * Revert PdfFile imports and comment out pdfjs imports * Remove extra sidebar html in PdfDocument * Remove unnecessary props from PdfDocument * Add WIP rotate function * Clean up components and css * Add pageUtil and clean up PdfDocument * Update rotate function * Fix sidebar css to dynamically shrink * APPEALS-46785. Add test coverage for pageUtil#renderPage. * APPEALS-46785. Search functionality for Reader prototype. * Update yarn.lock after rebasing. * APPEALS-48219. Prototype version of issue tags. * Update css for page rotate function * Remove and reinstall pdfjs-dist@2.6.347 and use cdn to get rid of fake worker warning * APPEALS-46785. Add text layer to prototype. * Add current page display functionality * Fix getPageNumFromScrollTop function for when document has been rotated * Fix getPageNumFromScrollTop function to have max page number * Fix css for rotation * Add sidebar categories * APPEALS-49501. Fix keyboard shortcut modal. * APPEALS-49501. Make pageUtil into Page component for React efficiency. * APPEALS-49501. Comments rework. * APPEALS-49501. Fix test/lint errors. * APPEALS-515895. Add back-to-documents-list hotkey. * Layout cleanup and add toggle menu function * Add MVP WIP DocumentInfo * Refactor redux appeal and fix Sidebar CSS to scroll * Update vacolsId proptype to string * APPEALS-52496. Update layout of Reader Prototype to match original layout. * Cleaning up imports and removing glamor. * Potential fix for double render error. * Add reader prototype feature toggle * Fix same canvas render error * Add Fake PDFJS Worker solution * Add pdfjs worker to intializers assets * Remove ocr path from documents controller * Add WIP load document error handling * Add error handling for PdfDocument when document load failure * Remove logic to access prototype through url * Update page title for Reader * Revert schema * Extract logic to DocumentLoadError component * Move banner/format.js to caseflow util directory * Remove 2.0 components, screens, routes directories and get successful compile * Remove 2.0 layouts directory * Remove 2.0 Router component * Move ErrorBoundary and Loadable components to client/app/components * Remove 2.0/components/shared directory * Move 2.0 store * Remove vscode settings * Remove 2.0 path lines * Delete 2.0 path lines in webpack config * Add back in vscode files * Fix text layer error. Fix pages leaking between documents. * Add max width to sidebar css to fix long document type overflow * Update element name for jump to page function * Remove scroll into view smooth * Update current page calculation * Hide search bar when switching documents. * Add IntersectionObserver logic to Page * Add useState * Add IntersectionObserver logic * Revert current page logic to use page size estimations instead of IntersectionObserver * Remove pdfjs imports from documentViewer.js and PdfFile.jsx * Add page number validation for ReaderFooter page input field * Cleanup * Disable previous/next buttons while pdf downloads. (#22511) * Remove canvas and test relying on it. (#22495) * Use intersection observer to hide offscreen pages. * Replace observer with content-visibility css. * Address comments from code review. * Davywentwortht2it/fix failures (#22631) * Remove linting errors. * Fix broken specs. * Comment out failing reader tests. * Update reviewer.scss to fix lint errors * Add space in reviewer.scss to fix lint error * Update css name --------- Co-authored-by: laurenyj <44596134+laurenyj@users.noreply.github.com> * Re-enable failing specs. (#22666) * Re-enable failing specs. * Reduce flakiness of specs. * Reduce flakiness of specs. * Reduce flakiness of specs. * Reduce flakiness of specs. --------- Co-authored-by: Davy Wentworth <david.wentworth@va.gov> * Laurenyj/update prototypefooter (#22677) * fix PdfUIPageNumInput page width bug * Update prototype reader footer to match original reader footer css updates * Revert reviewer changes * move styles to the correct place to override width:100 * Remove unused prototype css * Update page input test snap * Revert Page component changes and update with ctx options --------- Co-authored-by: Sean Parker <Sean.Parker3@va.gov> Co-authored-by: mikefinneran <110622959+mikefinneran@users.noreply.github.com> * Add assets folder to public (#22701) Co-authored-by: laurenyj <44596134+laurenyj@users.noreply.github.com> --------- Co-authored-by: laurenyj <44596134+laurenyj@users.noreply.github.com> Co-authored-by: Davy Wentworth <david.wentworth@va.gov> Co-authored-by: Sean Parker <Sean.Parker3@va.gov> * Have feature test account for DST * AM/PM (#22709) Co-authored-by: Matthew Thornton <ThorntonMatthew@users.noreply.github.com> --------- Co-authored-by: mikefinneran <110622959+mikefinneran@users.noreply.github.com> Co-authored-by: laurenyj <44596134+laurenyj@users.noreply.github.com> Co-authored-by: Davy Wentworth <david.wentworth@va.gov> Co-authored-by: Sean Parker <Sean.Parker3@va.gov> Co-authored-by: Matthew Thornton <ThorntonMatthew@users.noreply.github.com>
ThorntonMatthew
added a commit
that referenced
this pull request
Sep 4, 2024
* Remove transaction_wrapper * Remove extra newline * APPEALS-51045: Remove ReceiveNotificationJob (#22207) Co-authored-by: nhansen3 <noah.hansen1323@gmail.com> * MattT/APPEALS-51115: Initialize FIFO SQS Queues Locally (#22182) * Set local env to utilize FIFO queues where appropriate FIFO queues are configured with the same attributes as our queues in higher environments. * Resolve failing test * Remove defunct test * Update make commands --------- Co-authored-by: Matthew Thornton <ThorntonMatthew@users.noreply.github.com> * APPEALS-51847: Institute Database Migration for Establishing 'sms_status_reason' and 'email_status_reason' Columns (#22208) * adding and running migration * adding comments to migration and re running db:migrate * pushing up original scheam * committing schema * small edit to migration and deleting unnecessary columns from schema --------- Co-authored-by: nhansen3 <noah.hansen1323@gmail.com> Co-authored-by: Matthew Thornton <99351305+ThorntonMatthew@users.noreply.github.com> * removing job and all mentions of job (#22212) Co-authored-by: nhansen3 <noah.hansen1323@gmail.com> Co-authored-by: Matthew Thornton <99351305+ThorntonMatthew@users.noreply.github.com> * MattT/APPEALS-51059: Alter Select Quarterly Statuses (#22239) * Alter status messages * Save more info in fake response * Swap keys * Add missing param * Test fixes. Also, setting appeal_docketed to false whenever appeals are decided or cancelled * Fix fasterer issue --------- Co-authored-by: Matthew Thornton <ThorntonMatthew@users.noreply.github.com> * MattT/APPEALS-51101: Rewrite ProcessNotificationStatusUpdateJob to Consume Messages from an SQS Queue (#22247) * Update fake response body * Try enabling localstack in CI * Init SqsService and alter most/all of the ProcessNotificationStatusUpdatesJob * Create SQS queues in test env * Change port formatting * Mount docker socket * Try localstack hostname * Wait for localstack in CI * Add more yarddoc comments * Log errors and number of messages processed * Add custom error classes * Add yarddoc comments to SqsService class * Create SqsService spec file * Redo much of ProcessNotificationStatusUpdatesJob's spec file * Disable line length checks for yarddoc comments --------- Co-authored-by: Matthew Thornton <ThorntonMatthew@users.noreply.github.com> * APPEALS-51087: Rewrite Api::V1::VaNotifyController#notification_update Controller Action to No Longer Utilize Redis (#22295) * initial push * rubocop'n * fixing tests? * rubocop'n * addressing most of matt's comments * removing yard doc files and keeping comment * rubocop --------- Co-authored-by: nhansen3 <noah.hansen1323@gmail.com> * Remove extra attribute * Fix incorrect log counts * Fix log statement * Fix typo * APPEALS-53603: Modify logic to always show recipient information if present (#22414) * initial commit * making rspec tests happy * linting * adding tests back and refactoring * small char error --------- Co-authored-by: nhansen3 <noah.hansen1323@gmail.com> * Sync decided appeals with states table (#22434) * APPEALS-52882 Sync decided appeals decision_mailed status * APPEALS-52882 Fix lint issues * APPEALS-52882 Fix codeclimate issues * APPEALS-52882 Address PR feedback * APPEALS-52882 Address PR feedback * Jcohen/APPEALS-52861 (#22450) * APPEALS-52861 Bug fix implemented. * APPEALS-52861 cleaned up some code through aliasing a common method name between appeal_types, eliminating a check that we do in the AppealDecisionMailed module. * APPEALS-52861 fixed method name error. * APPEALS-52861 fixed some tests. * APPEALS-52861 fixed More tests. * APPEALS-52861 fixed More tests. * APPEALS-52861 feature branch changes merged in with working branch and method name changes extracted. * APPEALS-52861 feature branch changes merged in with working branch and method name changes extracted, included case statement. * APPEALS-52861 moved case statement to another file to be the boolean check for constested status on an appeal. --------- Co-authored-by: Jonathan Cohen <cohen_jonathan@bah.com> Co-authored-by: Marc Steele <71673522+msteele96@users.noreply.github.com> * APPEALS-52892: For all legacy appeal states/notifications check status in VACOLS (#22455) * initial commit * addressing comments * small change * making tests happy * fixing spec tests * rubocop'n * reverting --------- Co-authored-by: nhansen3 <noah.hansen1323@gmail.com> Co-authored-by: Marc Steele <71673522+msteele96@users.noreply.github.com> * APPEALS-55159: Parameter Requirements Are Too Stringent Given What We Will Expect from VA Notify (#22561) * APPEALS-55159 * updating tests * APPEALS-55159 Refactor permitted and required params * APPEALS-55159 Fix linting issue --------- Co-authored-by: nhansen3 <noah.hansen1323@gmail.com> Co-authored-by: msteele <Marc.Steele@va.gov> Co-authored-by: Marc Steele <71673522+msteele96@users.noreply.github.com> * Adding rake task to sync decided appeals (#22492) * APPEALS-52872 Add rake task to sync decided appeals * APPEALS-52872 Remove byebug * APPEALS-52872 Fixing lint errors * APPEALS-52872 Addressing performance issues * APPEALS-52872 Addressing performance issues * APPEALS-52872 Fix ENV variable update * APPEALS-52872 Parallelizing AppealState updates * APPEALS-52872 Remove byebug --------- Co-authored-by: Marc Steele <71673522+msteele96@users.noreply.github.com> * Prevent Prodtest from contacting VA Notify Staging (#22629) * APPEALS-54918 Update VA Notify fake service and initializer * APPEALS-54918 Add CASEFLOW_BASE_URL env var in demo/dev * APPEALS-54918 Add seed file for API Key and added to main seed execution * APPEALS-54918 Add missing argument to method definition * APPEALS-54918 Update "to" params and fix linting issues * APPEALS-54918 Prevent post requests in test env * Rename ApiKeys seed file * Fix linting error on require statement * Add argument for call within sync_review_job.rb and minor refactor * Inherit seed from base, align with AMA for seed file placement * APPEALS-57210 Add ssl cert file to request in fake service * Dst_test_fix (#22708) * Feature/appeals 47313.bugfix (#22702) * Remove and reinstall pdfjs-dist@2.6.347 and use cdn to get rid of fake worker warning * Comment out pdfjs worker lines in documentViewer.js to get rid of fake worker warning * Add PdfDocument component with no batching * Add MVP working reader prototype 2.0 * Add reader prototype warning on toolbar * Add MVP zoom function * Add prototype route * Fix next and previous doc links with prototype path * Extract toolbar buttons out to ReaderToolbar component * Fix prop type in PdfDocument * Remove prototype logic * Clean up prototype with utils * Fix scroll issue on document list view for Reader * APPEALS-46785. Add text layer to prototype. * Revert pdf-annotate changes * Revert PdfFile imports and comment out pdfjs imports * Remove extra sidebar html in PdfDocument * Remove unnecessary props from PdfDocument * Add WIP rotate function * Clean up components and css * Add pageUtil and clean up PdfDocument * Update rotate function * Fix sidebar css to dynamically shrink * APPEALS-46785. Add test coverage for pageUtil#renderPage. * APPEALS-46785. Search functionality for Reader prototype. * Update yarn.lock after rebasing. * APPEALS-48219. Prototype version of issue tags. * Update css for page rotate function * Remove and reinstall pdfjs-dist@2.6.347 and use cdn to get rid of fake worker warning * APPEALS-46785. Add text layer to prototype. * Add current page display functionality * Fix getPageNumFromScrollTop function for when document has been rotated * Fix getPageNumFromScrollTop function to have max page number * Fix css for rotation * Add sidebar categories * APPEALS-49501. Fix keyboard shortcut modal. * APPEALS-49501. Make pageUtil into Page component for React efficiency. * APPEALS-49501. Comments rework. * APPEALS-49501. Fix test/lint errors. * APPEALS-515895. Add back-to-documents-list hotkey. * Layout cleanup and add toggle menu function * Add MVP WIP DocumentInfo * Refactor redux appeal and fix Sidebar CSS to scroll * Update vacolsId proptype to string * APPEALS-52496. Update layout of Reader Prototype to match original layout. * Cleaning up imports and removing glamor. * Potential fix for double render error. * Add reader prototype feature toggle * Fix same canvas render error * Add Fake PDFJS Worker solution * Add pdfjs worker to intializers assets * Remove ocr path from documents controller * Add WIP load document error handling * Add error handling for PdfDocument when document load failure * Remove logic to access prototype through url * Update page title for Reader * Revert schema * Extract logic to DocumentLoadError component * Move banner/format.js to caseflow util directory * Remove 2.0 components, screens, routes directories and get successful compile * Remove 2.0 layouts directory * Remove 2.0 Router component * Move ErrorBoundary and Loadable components to client/app/components * Remove 2.0/components/shared directory * Move 2.0 store * Remove vscode settings * Remove 2.0 path lines * Delete 2.0 path lines in webpack config * Add back in vscode files * Fix text layer error. Fix pages leaking between documents. * Add max width to sidebar css to fix long document type overflow * Update element name for jump to page function * Remove scroll into view smooth * Update current page calculation * Hide search bar when switching documents. * Add IntersectionObserver logic to Page * Add useState * Add IntersectionObserver logic * Revert current page logic to use page size estimations instead of IntersectionObserver * Remove pdfjs imports from documentViewer.js and PdfFile.jsx * Add page number validation for ReaderFooter page input field * Cleanup * Disable previous/next buttons while pdf downloads. (#22511) * Remove canvas and test relying on it. (#22495) * Use intersection observer to hide offscreen pages. * Replace observer with content-visibility css. * Address comments from code review. * Davywentwortht2it/fix failures (#22631) * Remove linting errors. * Fix broken specs. * Comment out failing reader tests. * Update reviewer.scss to fix lint errors * Add space in reviewer.scss to fix lint error * Update css name --------- Co-authored-by: laurenyj <44596134+laurenyj@users.noreply.github.com> * Re-enable failing specs. (#22666) * Re-enable failing specs. * Reduce flakiness of specs. * Reduce flakiness of specs. * Reduce flakiness of specs. * Reduce flakiness of specs. --------- Co-authored-by: Davy Wentworth <david.wentworth@va.gov> * Laurenyj/update prototypefooter (#22677) * fix PdfUIPageNumInput page width bug * Update prototype reader footer to match original reader footer css updates * Revert reviewer changes * move styles to the correct place to override width:100 * Remove unused prototype css * Update page input test snap * Revert Page component changes and update with ctx options --------- Co-authored-by: Sean Parker <Sean.Parker3@va.gov> Co-authored-by: mikefinneran <110622959+mikefinneran@users.noreply.github.com> * Add assets folder to public (#22701) Co-authored-by: laurenyj <44596134+laurenyj@users.noreply.github.com> --------- Co-authored-by: laurenyj <44596134+laurenyj@users.noreply.github.com> Co-authored-by: Davy Wentworth <david.wentworth@va.gov> Co-authored-by: Sean Parker <Sean.Parker3@va.gov> * Have feature test account for DST * AM/PM (#22709) Co-authored-by: Matthew Thornton <ThorntonMatthew@users.noreply.github.com> --------- Co-authored-by: mikefinneran <110622959+mikefinneran@users.noreply.github.com> Co-authored-by: laurenyj <44596134+laurenyj@users.noreply.github.com> Co-authored-by: Davy Wentworth <david.wentworth@va.gov> Co-authored-by: Sean Parker <Sean.Parker3@va.gov> Co-authored-by: Matthew Thornton <ThorntonMatthew@users.noreply.github.com> --------- Co-authored-by: Matthew Thornton <ThorntonMatthew@users.noreply.github.com> Co-authored-by: noahhansen-gov <166541737+noahhansen-gov@users.noreply.github.com> Co-authored-by: nhansen3 <noah.hansen1323@gmail.com> Co-authored-by: Matthew Thornton <99351305+ThorntonMatthew@users.noreply.github.com> Co-authored-by: prernadevbah <132498915+prernadevbah@users.noreply.github.com> Co-authored-by: Jonathan Cohen <121630615+JCohDev@users.noreply.github.com> Co-authored-by: Jonathan Cohen <cohen_jonathan@bah.com> Co-authored-by: mikefinneran <110622959+mikefinneran@users.noreply.github.com> Co-authored-by: laurenyj <44596134+laurenyj@users.noreply.github.com> Co-authored-by: Davy Wentworth <david.wentworth@va.gov> Co-authored-by: Sean Parker <Sean.Parker3@va.gov>
mikefinneran
added a commit
that referenced
this pull request
Sep 4, 2024
This reverts commit 0b8489f.
AdamShawBAH
pushed a commit
that referenced
this pull request
Sep 9, 2024
* Remove and reinstall pdfjs-dist@2.6.347 and use cdn to get rid of fake worker warning * Comment out pdfjs worker lines in documentViewer.js to get rid of fake worker warning * Add PdfDocument component with no batching * Add MVP working reader prototype 2.0 * Add reader prototype warning on toolbar * Add MVP zoom function * Add prototype route * Fix next and previous doc links with prototype path * Extract toolbar buttons out to ReaderToolbar component * Fix prop type in PdfDocument * Remove prototype logic * Clean up prototype with utils * Fix scroll issue on document list view for Reader * APPEALS-46785. Add text layer to prototype. * Revert pdf-annotate changes * Revert PdfFile imports and comment out pdfjs imports * Remove extra sidebar html in PdfDocument * Remove unnecessary props from PdfDocument * Add WIP rotate function * Clean up components and css * Add pageUtil and clean up PdfDocument * Update rotate function * Fix sidebar css to dynamically shrink * APPEALS-46785. Add test coverage for pageUtil#renderPage. * APPEALS-46785. Search functionality for Reader prototype. * Update yarn.lock after rebasing. * APPEALS-48219. Prototype version of issue tags. * Update css for page rotate function * Remove and reinstall pdfjs-dist@2.6.347 and use cdn to get rid of fake worker warning * APPEALS-46785. Add text layer to prototype. * Add current page display functionality * Fix getPageNumFromScrollTop function for when document has been rotated * Fix getPageNumFromScrollTop function to have max page number * Fix css for rotation * Add sidebar categories * APPEALS-49501. Fix keyboard shortcut modal. * APPEALS-49501. Make pageUtil into Page component for React efficiency. * APPEALS-49501. Comments rework. * APPEALS-49501. Fix test/lint errors. * APPEALS-515895. Add back-to-documents-list hotkey. * Layout cleanup and add toggle menu function * Add MVP WIP DocumentInfo * Refactor redux appeal and fix Sidebar CSS to scroll * Update vacolsId proptype to string * APPEALS-52496. Update layout of Reader Prototype to match original layout. * Cleaning up imports and removing glamor. * Potential fix for double render error. * Add reader prototype feature toggle * Fix same canvas render error * Add Fake PDFJS Worker solution * Add pdfjs worker to intializers assets * Remove ocr path from documents controller * Add WIP load document error handling * Add error handling for PdfDocument when document load failure * Remove logic to access prototype through url * Update page title for Reader * Revert schema * Extract logic to DocumentLoadError component * Move banner/format.js to caseflow util directory * Remove 2.0 components, screens, routes directories and get successful compile * Remove 2.0 layouts directory * Remove 2.0 Router component * Move ErrorBoundary and Loadable components to client/app/components * Remove 2.0/components/shared directory * Move 2.0 store * Remove vscode settings * Remove 2.0 path lines * Delete 2.0 path lines in webpack config * Add back in vscode files * Fix text layer error. Fix pages leaking between documents. * Add max width to sidebar css to fix long document type overflow * Update element name for jump to page function * Remove scroll into view smooth * Update current page calculation * Hide search bar when switching documents. * Add IntersectionObserver logic to Page * Add useState * Add IntersectionObserver logic * Revert current page logic to use page size estimations instead of IntersectionObserver * Remove pdfjs imports from documentViewer.js and PdfFile.jsx * Add page number validation for ReaderFooter page input field * Cleanup * Disable previous/next buttons while pdf downloads. (#22511) * Remove canvas and test relying on it. (#22495) * Use intersection observer to hide offscreen pages. * Replace observer with content-visibility css. * Address comments from code review. * Davywentwortht2it/fix failures (#22631) * Remove linting errors. * Fix broken specs. * Comment out failing reader tests. * Update reviewer.scss to fix lint errors * Add space in reviewer.scss to fix lint error * Update css name --------- Co-authored-by: laurenyj <44596134+laurenyj@users.noreply.github.com> * Re-enable failing specs. (#22666) * Re-enable failing specs. * Reduce flakiness of specs. * Reduce flakiness of specs. * Reduce flakiness of specs. * Reduce flakiness of specs. --------- Co-authored-by: Davy Wentworth <david.wentworth@va.gov> * Laurenyj/update prototypefooter (#22677) * fix PdfUIPageNumInput page width bug * Update prototype reader footer to match original reader footer css updates * Revert reviewer changes * move styles to the correct place to override width:100 * Remove unused prototype css * Update page input test snap * Revert Page component changes and update with ctx options --------- Co-authored-by: Sean Parker <Sean.Parker3@va.gov> Co-authored-by: mikefinneran <110622959+mikefinneran@users.noreply.github.com> * Add assets folder to public (#22701) Co-authored-by: laurenyj <44596134+laurenyj@users.noreply.github.com> --------- Co-authored-by: laurenyj <44596134+laurenyj@users.noreply.github.com> Co-authored-by: Davy Wentworth <david.wentworth@va.gov> Co-authored-by: Sean Parker <Sean.Parker3@va.gov>
AdamShawBAH
pushed a commit
that referenced
this pull request
Sep 9, 2024
* Remove transaction_wrapper * Remove extra newline * APPEALS-51045: Remove ReceiveNotificationJob (#22207) Co-authored-by: nhansen3 <noah.hansen1323@gmail.com> * MattT/APPEALS-51115: Initialize FIFO SQS Queues Locally (#22182) * Set local env to utilize FIFO queues where appropriate FIFO queues are configured with the same attributes as our queues in higher environments. * Resolve failing test * Remove defunct test * Update make commands --------- Co-authored-by: Matthew Thornton <ThorntonMatthew@users.noreply.github.com> * APPEALS-51847: Institute Database Migration for Establishing 'sms_status_reason' and 'email_status_reason' Columns (#22208) * adding and running migration * adding comments to migration and re running db:migrate * pushing up original scheam * committing schema * small edit to migration and deleting unnecessary columns from schema --------- Co-authored-by: nhansen3 <noah.hansen1323@gmail.com> Co-authored-by: Matthew Thornton <99351305+ThorntonMatthew@users.noreply.github.com> * removing job and all mentions of job (#22212) Co-authored-by: nhansen3 <noah.hansen1323@gmail.com> Co-authored-by: Matthew Thornton <99351305+ThorntonMatthew@users.noreply.github.com> * MattT/APPEALS-51059: Alter Select Quarterly Statuses (#22239) * Alter status messages * Save more info in fake response * Swap keys * Add missing param * Test fixes. Also, setting appeal_docketed to false whenever appeals are decided or cancelled * Fix fasterer issue --------- Co-authored-by: Matthew Thornton <ThorntonMatthew@users.noreply.github.com> * MattT/APPEALS-51101: Rewrite ProcessNotificationStatusUpdateJob to Consume Messages from an SQS Queue (#22247) * Update fake response body * Try enabling localstack in CI * Init SqsService and alter most/all of the ProcessNotificationStatusUpdatesJob * Create SQS queues in test env * Change port formatting * Mount docker socket * Try localstack hostname * Wait for localstack in CI * Add more yarddoc comments * Log errors and number of messages processed * Add custom error classes * Add yarddoc comments to SqsService class * Create SqsService spec file * Redo much of ProcessNotificationStatusUpdatesJob's spec file * Disable line length checks for yarddoc comments --------- Co-authored-by: Matthew Thornton <ThorntonMatthew@users.noreply.github.com> * APPEALS-51087: Rewrite Api::V1::VaNotifyController#notification_update Controller Action to No Longer Utilize Redis (#22295) * initial push * rubocop'n * fixing tests? * rubocop'n * addressing most of matt's comments * removing yard doc files and keeping comment * rubocop --------- Co-authored-by: nhansen3 <noah.hansen1323@gmail.com> * Remove extra attribute * Fix incorrect log counts * Fix log statement * Fix typo * APPEALS-53603: Modify logic to always show recipient information if present (#22414) * initial commit * making rspec tests happy * linting * adding tests back and refactoring * small char error --------- Co-authored-by: nhansen3 <noah.hansen1323@gmail.com> * Sync decided appeals with states table (#22434) * APPEALS-52882 Sync decided appeals decision_mailed status * APPEALS-52882 Fix lint issues * APPEALS-52882 Fix codeclimate issues * APPEALS-52882 Address PR feedback * APPEALS-52882 Address PR feedback * Jcohen/APPEALS-52861 (#22450) * APPEALS-52861 Bug fix implemented. * APPEALS-52861 cleaned up some code through aliasing a common method name between appeal_types, eliminating a check that we do in the AppealDecisionMailed module. * APPEALS-52861 fixed method name error. * APPEALS-52861 fixed some tests. * APPEALS-52861 fixed More tests. * APPEALS-52861 fixed More tests. * APPEALS-52861 feature branch changes merged in with working branch and method name changes extracted. * APPEALS-52861 feature branch changes merged in with working branch and method name changes extracted, included case statement. * APPEALS-52861 moved case statement to another file to be the boolean check for constested status on an appeal. --------- Co-authored-by: Jonathan Cohen <cohen_jonathan@bah.com> Co-authored-by: Marc Steele <71673522+msteele96@users.noreply.github.com> * APPEALS-52892: For all legacy appeal states/notifications check status in VACOLS (#22455) * initial commit * addressing comments * small change * making tests happy * fixing spec tests * rubocop'n * reverting --------- Co-authored-by: nhansen3 <noah.hansen1323@gmail.com> Co-authored-by: Marc Steele <71673522+msteele96@users.noreply.github.com> * APPEALS-55159: Parameter Requirements Are Too Stringent Given What We Will Expect from VA Notify (#22561) * APPEALS-55159 * updating tests * APPEALS-55159 Refactor permitted and required params * APPEALS-55159 Fix linting issue --------- Co-authored-by: nhansen3 <noah.hansen1323@gmail.com> Co-authored-by: msteele <Marc.Steele@va.gov> Co-authored-by: Marc Steele <71673522+msteele96@users.noreply.github.com> * Adding rake task to sync decided appeals (#22492) * APPEALS-52872 Add rake task to sync decided appeals * APPEALS-52872 Remove byebug * APPEALS-52872 Fixing lint errors * APPEALS-52872 Addressing performance issues * APPEALS-52872 Addressing performance issues * APPEALS-52872 Fix ENV variable update * APPEALS-52872 Parallelizing AppealState updates * APPEALS-52872 Remove byebug --------- Co-authored-by: Marc Steele <71673522+msteele96@users.noreply.github.com> * Prevent Prodtest from contacting VA Notify Staging (#22629) * APPEALS-54918 Update VA Notify fake service and initializer * APPEALS-54918 Add CASEFLOW_BASE_URL env var in demo/dev * APPEALS-54918 Add seed file for API Key and added to main seed execution * APPEALS-54918 Add missing argument to method definition * APPEALS-54918 Update "to" params and fix linting issues * APPEALS-54918 Prevent post requests in test env * Rename ApiKeys seed file * Fix linting error on require statement * Add argument for call within sync_review_job.rb and minor refactor * Inherit seed from base, align with AMA for seed file placement * APPEALS-57210 Add ssl cert file to request in fake service * Dst_test_fix (#22708) * Feature/appeals 47313.bugfix (#22702) * Remove and reinstall pdfjs-dist@2.6.347 and use cdn to get rid of fake worker warning * Comment out pdfjs worker lines in documentViewer.js to get rid of fake worker warning * Add PdfDocument component with no batching * Add MVP working reader prototype 2.0 * Add reader prototype warning on toolbar * Add MVP zoom function * Add prototype route * Fix next and previous doc links with prototype path * Extract toolbar buttons out to ReaderToolbar component * Fix prop type in PdfDocument * Remove prototype logic * Clean up prototype with utils * Fix scroll issue on document list view for Reader * APPEALS-46785. Add text layer to prototype. * Revert pdf-annotate changes * Revert PdfFile imports and comment out pdfjs imports * Remove extra sidebar html in PdfDocument * Remove unnecessary props from PdfDocument * Add WIP rotate function * Clean up components and css * Add pageUtil and clean up PdfDocument * Update rotate function * Fix sidebar css to dynamically shrink * APPEALS-46785. Add test coverage for pageUtil#renderPage. * APPEALS-46785. Search functionality for Reader prototype. * Update yarn.lock after rebasing. * APPEALS-48219. Prototype version of issue tags. * Update css for page rotate function * Remove and reinstall pdfjs-dist@2.6.347 and use cdn to get rid of fake worker warning * APPEALS-46785. Add text layer to prototype. * Add current page display functionality * Fix getPageNumFromScrollTop function for when document has been rotated * Fix getPageNumFromScrollTop function to have max page number * Fix css for rotation * Add sidebar categories * APPEALS-49501. Fix keyboard shortcut modal. * APPEALS-49501. Make pageUtil into Page component for React efficiency. * APPEALS-49501. Comments rework. * APPEALS-49501. Fix test/lint errors. * APPEALS-515895. Add back-to-documents-list hotkey. * Layout cleanup and add toggle menu function * Add MVP WIP DocumentInfo * Refactor redux appeal and fix Sidebar CSS to scroll * Update vacolsId proptype to string * APPEALS-52496. Update layout of Reader Prototype to match original layout. * Cleaning up imports and removing glamor. * Potential fix for double render error. * Add reader prototype feature toggle * Fix same canvas render error * Add Fake PDFJS Worker solution * Add pdfjs worker to intializers assets * Remove ocr path from documents controller * Add WIP load document error handling * Add error handling for PdfDocument when document load failure * Remove logic to access prototype through url * Update page title for Reader * Revert schema * Extract logic to DocumentLoadError component * Move banner/format.js to caseflow util directory * Remove 2.0 components, screens, routes directories and get successful compile * Remove 2.0 layouts directory * Remove 2.0 Router component * Move ErrorBoundary and Loadable components to client/app/components * Remove 2.0/components/shared directory * Move 2.0 store * Remove vscode settings * Remove 2.0 path lines * Delete 2.0 path lines in webpack config * Add back in vscode files * Fix text layer error. Fix pages leaking between documents. * Add max width to sidebar css to fix long document type overflow * Update element name for jump to page function * Remove scroll into view smooth * Update current page calculation * Hide search bar when switching documents. * Add IntersectionObserver logic to Page * Add useState * Add IntersectionObserver logic * Revert current page logic to use page size estimations instead of IntersectionObserver * Remove pdfjs imports from documentViewer.js and PdfFile.jsx * Add page number validation for ReaderFooter page input field * Cleanup * Disable previous/next buttons while pdf downloads. (#22511) * Remove canvas and test relying on it. (#22495) * Use intersection observer to hide offscreen pages. * Replace observer with content-visibility css. * Address comments from code review. * Davywentwortht2it/fix failures (#22631) * Remove linting errors. * Fix broken specs. * Comment out failing reader tests. * Update reviewer.scss to fix lint errors * Add space in reviewer.scss to fix lint error * Update css name --------- Co-authored-by: laurenyj <44596134+laurenyj@users.noreply.github.com> * Re-enable failing specs. (#22666) * Re-enable failing specs. * Reduce flakiness of specs. * Reduce flakiness of specs. * Reduce flakiness of specs. * Reduce flakiness of specs. --------- Co-authored-by: Davy Wentworth <david.wentworth@va.gov> * Laurenyj/update prototypefooter (#22677) * fix PdfUIPageNumInput page width bug * Update prototype reader footer to match original reader footer css updates * Revert reviewer changes * move styles to the correct place to override width:100 * Remove unused prototype css * Update page input test snap * Revert Page component changes and update with ctx options --------- Co-authored-by: Sean Parker <Sean.Parker3@va.gov> Co-authored-by: mikefinneran <110622959+mikefinneran@users.noreply.github.com> * Add assets folder to public (#22701) Co-authored-by: laurenyj <44596134+laurenyj@users.noreply.github.com> --------- Co-authored-by: laurenyj <44596134+laurenyj@users.noreply.github.com> Co-authored-by: Davy Wentworth <david.wentworth@va.gov> Co-authored-by: Sean Parker <Sean.Parker3@va.gov> * Have feature test account for DST * AM/PM (#22709) Co-authored-by: Matthew Thornton <ThorntonMatthew@users.noreply.github.com> --------- Co-authored-by: mikefinneran <110622959+mikefinneran@users.noreply.github.com> Co-authored-by: laurenyj <44596134+laurenyj@users.noreply.github.com> Co-authored-by: Davy Wentworth <david.wentworth@va.gov> Co-authored-by: Sean Parker <Sean.Parker3@va.gov> Co-authored-by: Matthew Thornton <ThorntonMatthew@users.noreply.github.com> --------- Co-authored-by: Matthew Thornton <ThorntonMatthew@users.noreply.github.com> Co-authored-by: noahhansen-gov <166541737+noahhansen-gov@users.noreply.github.com> Co-authored-by: nhansen3 <noah.hansen1323@gmail.com> Co-authored-by: Matthew Thornton <99351305+ThorntonMatthew@users.noreply.github.com> Co-authored-by: prernadevbah <132498915+prernadevbah@users.noreply.github.com> Co-authored-by: Jonathan Cohen <121630615+JCohDev@users.noreply.github.com> Co-authored-by: Jonathan Cohen <cohen_jonathan@bah.com> Co-authored-by: mikefinneran <110622959+mikefinneran@users.noreply.github.com> Co-authored-by: laurenyj <44596134+laurenyj@users.noreply.github.com> Co-authored-by: Davy Wentworth <david.wentworth@va.gov> Co-authored-by: Sean Parker <Sean.Parker3@va.gov>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves Jira Issue Title
Description
Please explain the changes you made here.
Acceptance Criteria
Testing Plan
Frontend
User Facing Changes
Storybook Story
For Frontend (Presentation) Components
MyComponent.stories.js
alongsideMyComponent.jsx
)Backend
Database Changes
Only for Schema Changes
created_at
,updated_at
) for new tablesCaseflow::Migration
, especially when adding indexes (useadd_safe_index
) (see Writing DB migrations)migrate:rollback
works as desired (change
supported functions)make check-fks
; add any missing foreign keys or add toconfig/initializers/immigrant.rb
(see Record associations and Foreign Keys)belongs_to
for associations to enable the schema diagrams to be automatically updatedIntegrations: Adding endpoints for external APIs
Best practices
Code Documentation Updates
Tests
Test Coverage
Did you include any test coverage for your code? Check below:
Code Climate
Your code does not add any new code climate offenses? If so why?
Monitoring, Logging, Auditing, Error, and Exception Handling Checklist
Monitoring
Logging
Auditing
Error Handling
Exception Handling