-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/appeals 44915.prodtest/fy24 q4.5.0 #22834
Merged
amybids
merged 74 commits into
prodtest/FY24Q4.5.0
from
feature/APPEALS-44915.prodtest/FY24Q4.5.0
Sep 13, 2024
Merged
Feature/appeals 44915.prodtest/fy24 q4.5.0 #22834
amybids
merged 74 commits into
prodtest/FY24Q4.5.0
from
feature/APPEALS-44915.prodtest/FY24Q4.5.0
Sep 13, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…fairs/caseflow into feature/APPEALS-44915
* APPEALS-51263 added the lever to the seeds file * APPEALS-51263 test cleanup for case_docket, case_distribution_levers_controller_spec and case_distribution_test_data_spec.rb
* creates trait in factory for non_ssc_avlj user * updates user in user factory with new traits in staff factory * adds randomized judge method * replaces user create with a vacols staff create and limits css_id to 12 using slogid, adds judge_role for active smemgrp * updates naming --------- Co-authored-by: Michael Beard <michael.beard@va.gov>
* APPEALS-45200. create Return Appeals tied to non-SSC AVLJs job * APPEALS-45200. WIP --------- Co-authored-by: SHarshain <spoosa@razortalent.com>
* Framework for seeds * Add comments and fill in further methods * Further shared dev work * Update names * Expanded possible functions * More functions for shared work * Combine everyones work into main branch * Combined work - testing * Combined work - testing complete * rubocop fix --------- Co-authored-by: Christopher Detlef <>
…22375) Co-authored-by: SHarshain <spoosa@razortalent.com>
* APPEALS-51487 Location 63 Query * fix naming and change query * Working code * Add 2 day limit to query * Remove commented out code * Fix lint issues * Remove binding.pry --------- Co-authored-by: Christopher Detlef <>
…e Movement Section Buttons (#22386) * APPEALS-45248 Add success banner alerts to Run seed files and case movement section buttons * APPEALS-45248 add fail job button and refactored code
* Added button, and initial csv generation of appeals tied to non ssc avljs * WIP. APPEALS-45204 tweaks to Push data into CSV * APPEALS-45204. fix the method error * APPEALS-45204. Lint fix * Updated query to fetch hearing and grab non ssc avlj names properly * Fixed outstanding issues and cleaned up seeds * implements new hearing_judge, separates assigned_avlj and signing_avlj * Fixed linting issues and other clean up --------- Co-authored-by: SHarshain <133917878+SHarshain@users.noreply.github.com> Co-authored-by: SHarshain <spoosa@razortalent.com> Co-authored-by: Michael Beard <michael.beard@va.gov>
* Added button, and initial csv generation of appeals tied to non ssc avljs * WIP. APPEALS-45204 tweaks to Push data into CSV * APPEALS-45204. fix the method error * APPEALS-45204. Lint fix * Updated query to fetch hearing and grab non ssc avlj names properly * Fixed outstanding issues and cleaned up seeds * implements new hearing_judge, separates assigned_avlj and signing_avlj * Fixed linting issues and other clean up * Updated name of CSV download button --------- Co-authored-by: SHarshain <133917878+SHarshain@users.noreply.github.com> Co-authored-by: SHarshain <spoosa@razortalent.com> Co-authored-by: Michael Beard <michael.beard@va.gov>
* APPEALS-51487 Location 63 Query * fix naming and change query * Working code * Add 2 day limit to query * Remove commented out code * Fix lint issues * Remove binding.pry * APPEALS-54138 Add button to seed non-SSC AVLJs --------- Co-authored-by: Christopher Detlef <>
Co-authored-by: Christopher Detlef <>
* Fix for routing table * Randomly select docket id number --------- Co-authored-by: Christopher Detlef <>
Co-authored-by: Amy Detwiler <133032208+amybids@users.noreply.github.com>
* Updated query to correctly grab seed data * Replaced AOD and CAVC fields with Priority, fixed csv file name --------- Co-authored-by: Amy Detwiler <133032208+amybids@users.noreply.github.com>
Co-authored-by: SHarshain <spoosa@razortalent.com>
…ran file numbers (#22524)
* APPEALS-54152 Move Appeals to loc 63 * Fix minor issues with the query and data displayed in the CSV * APPEALS-54152 Move qualifying appeals to Loc 63 --------- Co-authored-by: Christopher Detlef <>
* Fix off by 1 error for returntoboard job * removed the extraneous space * refactored the variables * refactored variable names to fix rubocop issues --------- Co-authored-by: Christopher Detlef <> Co-authored-by: 631966 <amy.detwiler@va.gov>
* Updates test coverage for full perform method * fixed linting issues * updates to receive and return a number of appeals moved * updates value from 10 to 2 moved appeals * adds trait to factory and lever to push priority spec
#22671) * APPEALS-56980 Fix for .perform_later functionality in higher environments * Remove lines of code that aren't needed and add built in checker * Fix 1 of 2 errors * Move local variables out of intialize or callback methods --------- Co-authored-by: Christopher Detlef <>
* APPEALS-54290 CSV for all tied VLJ cases * Added support for AMA appeals * Fix linting issues --------- Co-authored-by: Christopher Detlef <>
* Added VLJ and Inactive Non-SSC AVLJ seeds * Updated seeds to include signed and unsigned AMA appeals * Fixed AMA hearing to not error on creation --------- Co-authored-by: Amy Detwiler <133032208+amybids@users.noreply.github.com>
* APPEALS-57322 Add logging for Not Ready to Distribute appeals * Remove binding pry --------- Co-authored-by: Christopher Detlef <>
* Change the button label * Remove binding pry --------- Co-authored-by: Christopher Detlef <>
* Change the name of the SSC AVLJ * Remove binding pry --------- Co-authored-by: Christopher Detlef <>
* APPEALS-57428.Update job log when job completes with no records * Upmerge master * spec fix * fixed some bug errors * fixed linting issue --------- Co-authored-by: SHarshain <spoosa@razortalent.com> Co-authored-by: 631966 <amy.detwiler@va.gov>
Co-authored-by: SHarshain <spoosa@razortalent.com>
* APPEALS-57801 Fix merging error * rubocop fix --------- Co-authored-by: Christopher Detlef <>
* APPEALS-57058. WIP - check loc_63_appeals * APPEALS-57058. more test coverage --------- Co-authored-by: SHarshain <spoosa@razortalent.com>
* Created outline for CSV test for appeals tied to non ssc avljs * Updated rspec for appeals tied to non ssc avlj to have full coverage * Created initial spec file for appeeals tied to avljs and vljs query * Added testing support appeals_tied_to_avljs_and_vljs_query * Updated testing on appeals_tied_to_avlj_and_vljs * Updated framework on location 63 appeals CSV rspec testing * Fixed base test for appeals in location 63 CSV * Updated data structure to properly check test * Updated location 63 CSV to have full coverage * Fixed linting
* Psuedo code for specs * Framework for tests * Split work * APPEALS-55660. Test expansion (#22714) Co-authored-by: SHarshain <spoosa@razortalent.com> * APPEALS-55660 Expanded test coverage for ReturnToBaordJob * Combine work * Fix linting and add some error handling --------- Co-authored-by: Christopher Detlef <> Co-authored-by: SHarshain <133917878+SHarshain@users.noreply.github.com> Co-authored-by: SHarshain <spoosa@razortalent.com>
* APPEALS-58192 Fix location 63 query test * Fix rubocop issues --------- Co-authored-by: Christopher Detlef <>
craigrva
approved these changes
Sep 13, 2024
ryanpmessner
added a commit
that referenced
this pull request
Sep 13, 2024
…LS-23420-merged * origin/APPEALS-23420-merged: (37 commits) APPEALS-23420 use new query for veteran_ids endpoint Feature/appeals 44915.prodtest/fy24 q4.5.0 (#22834) Tracking PR for Feature/appeals 50887 (#22747) feature/APPEALS-50882 - Open Telemetry configuration and implementation (#22787) feature/APPEALS-34124-43428-29105-28925-33581 - Rails 6.1 upgrade (release) (#22776) fix lint add check for hearing date to levers being infinite added test cases for infinite and omit levers with desired outcomes APPEALS-53993: Update Implementation of Legacy Appeals with Hearing Held (#22473) Update admin_ui_spec.rb for CAVC levers being enabled Craig/case docket optimization (#22294) Calvin/appeals 52551 (#22293) Fix rubocop and tests (#22231) fix rubocop warnings (#22225) APPEALS-47741: Update the UpdateAppealAffinityDatesJob to add appeal_affinity records for Legacy Appeals (#22023) Calvin/appeals 44313 (#22119) APPEALS-50692: Update Appeals Ready to Distribute CSV to include CAVC remand original judge (#22070) Acd/appeals 43853 43854 (#21971) fix rubocop warning fix tests, add lever to factory, fix dist scopes (#21779) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves Jira Issue Title
Description
Please explain the changes you made here.
Acceptance Criteria
Testing Plan
Frontend
User Facing Changes
Storybook Story
For Frontend (Presentation) Components
MyComponent.stories.js
alongsideMyComponent.jsx
)Backend
Database Changes
Only for Schema Changes
created_at
,updated_at
) for new tablesCaseflow::Migration
, especially when adding indexes (useadd_safe_index
) (see Writing DB migrations)migrate:rollback
works as desired (change
supported functions)make check-fks
; add any missing foreign keys or add toconfig/initializers/immigrant.rb
(see Record associations and Foreign Keys)belongs_to
for associations to enable the schema diagrams to be automatically updatedIntegrations: Adding endpoints for external APIs
Best practices
Code Documentation Updates
Tests
Test Coverage
Did you include any test coverage for your code? Check below:
Code Climate
Your code does not add any new code climate offenses? If so why?
Monitoring, Logging, Auditing, Error, and Exception Handling Checklist
Monitoring
Logging
Auditing
Error Handling
Exception Handling