-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature/APPEALS-25121 (uat/FY24Q4.6.0) #22890
Merged
ThorntonMatthew
merged 584 commits into
uat/FY24Q4.6.0
from
feature/APPEALS-25121-uat-4.6.0
Sep 20, 2024
Merged
feature/APPEALS-25121 (uat/FY24Q4.6.0) #22890
ThorntonMatthew
merged 584 commits into
uat/FY24Q4.6.0
from
feature/APPEALS-25121-uat-4.6.0
Sep 20, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on/APPEALS-32381 lthompson/APPEALS-32381
…ence job spec, needs further review
…as/APPEALS-25117 akonhilas/APPEALS-25117
…APPEALS-34501 APPEALS-34501
…RT-phase-1-CC-cleanup HRT Phase 1 CC Fixes
* APPEALS-49560 moved non-virtual conference link creation to hearing concern * APPEALS-49560 moved non_virtual conference creation inside of reschedule method * APPEALS-49560 added a new spec test to test link creation * APPEALS-49560 refactored rspec * APPEALS-49560 removed additional method in after_create to prevent risk of duplication * APPEALS-49560 removed additional method in after_create to prevent risk of duplication
* APPEALS-49624: update api_call in fetch jobs for error emails, change i to breaks * APPEALS-49624: add rooms and room details to mailer preview, correct api url * APPEALS-49624: cleaning up rspecs * APPEALS-49624: update query format, add mailer tests * APPEALS-49624: update mailer keys * APPEALS-49624: fix lint errors * APPEALS-49624 Remove rubocop ignores and fix query format --------- Co-authored-by: msteele <Marc.Steele@va.gov>
* APPEALS-49560 moved non-virtual conference link creation to hearing concern * APPEALS-49560 moved non_virtual conference creation inside of reschedule method * APPEALS-49560 added a new spec test to test link creation * APPEALS-49560 refactored rspec * APPEALS-49560 removed additional method in after_create to prevent risk of duplication * APPEALS-49560 removed additional method in after_create to prevent risk of duplication * APPEALS-49560 added extra filtering for conference link querying and same fix applied to HearingPostponementRequestMailTask * Update app/models/concerns/hearing_concern.rb Co-authored-by: Marc Steele <71673522+msteele96@users.noreply.github.com> --------- Co-authored-by: Marc Steele <71673522+msteele96@users.noreply.github.com>
* remediated code climate issues * remediated code climate issues * remediated code climate issues * fixed duplicate code issues * fixed duplicate code issues * fixed duplicate code issues * APPEALS-50859 added new concern to abstract duplicate code * APPEALS-50859 fixed new concern climate issues * APPEALS-50859 added new config method for rooms endpoints to concern * APPEALS-50859 added new config method for rooms endpoints to concern * APPEALS-50859 added new config method for instant connect to concern * APPEALS-50859 added new config method for instant connect to concern
Code Climate has analyzed commit 0a4894c and detected 0 issues on this pull request. View more on Code Climate. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves Jira Issue Title
Description
Please explain the changes you made here.
Acceptance Criteria
Testing Plan
Frontend
User Facing Changes
Storybook Story
For Frontend (Presentation) Components
MyComponent.stories.js
alongsideMyComponent.jsx
)Backend
Database Changes
Only for Schema Changes
created_at
,updated_at
) for new tablesCaseflow::Migration
, especially when adding indexes (useadd_safe_index
) (see Writing DB migrations)migrate:rollback
works as desired (change
supported functions)make check-fks
; add any missing foreign keys or add toconfig/initializers/immigrant.rb
(see Record associations and Foreign Keys)belongs_to
for associations to enable the schema diagrams to be automatically updatedIntegrations: Adding endpoints for external APIs
Best practices
Code Documentation Updates
Tests
Test Coverage
Did you include any test coverage for your code? Check below:
Code Climate
Your code does not add any new code climate offenses? If so why?
Monitoring, Logging, Auditing, Error, and Exception Handling Checklist
Monitoring
Logging
Auditing
Error Handling
Exception Handling