-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/appeals 50679 uat #22896
Feature/appeals 50679 uat #22896
Commits on Jul 25, 2024
-
* added additional option to check box list * fixed some tests and code clean up * fixed more tests * fixed jest tests * changes per Pr feedback * added custom error display * fixed style for error message --------- Co-authored-by: Sean Craig <sean.craig2@va.gov>
Configuration menu - View commit details
-
Copy full SHA for 96c1cc8 - Browse repository at this point
Copy the full SHA 96c1cc8View commit details
Commits on Jul 29, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 19feddf - Browse repository at this point
Copy the full SHA 19feddfView commit details
Commits on Jul 31, 2024
-
Configuration menu - View commit details
-
Copy full SHA for d83f870 - Browse repository at this point
Copy the full SHA d83f870View commit details
Commits on Aug 13, 2024
-
adding logic to bring in issue-modification request and updating the … (
#22238) * adding logic to bring in issue-modification request and updating the csv logic * refactor logic to get pending status and null to request addition * pending status filter work fixing * adding withdrawal date and adding logic to display request issue components * getting edit of request rows and fixing cancelled data * fixing linter and fixing the query to make test happy * fixing specs failures * removing byebug * removing frontend changes, adding test, fixing the query to replace higherlevel review,adding new field in serializer * making code climate happy by doing some minor refactor * fixing the serializer spec failure * After merging APPEALS-45335, filter for Requested issues were broken, so refactored it and removed the unnecessary methood that i created * fixing code climate and spec was failing because of hard coded date * refactor the edit of request logic to take from version, refactored business line query to remove coalesce and fix test * fixing codeclimate, remove unnecessary field * refactor to make first comment appear first in edit of request * fixing linter issue, spec and refactor to fix the bug * fixing pending status filter issue and adding test for business line * fixing broken spec failure * adding user facilty * fixing the lead and lag function to prevent entry of pending status multiple times * fixing an issue in which in progress event was not being made * adding decision reason that was missed and fixing the event logic one more time * fixing the multiple issue modification request after decision has been made * refactor inprogress logic for approved data * fixing spec failure * fixing the first version logic to be more simpler and fixing name and adding spec * fixing more inprogess event * removing the disabled complexity and taking out the boolean condition to a separate method
Configuration menu - View commit details
-
Copy full SHA for c32a83d - Browse repository at this point
Copy the full SHA c32a83dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 06c84aa - Browse repository at this point
Copy the full SHA 06c84aaView commit details
Commits on Aug 22, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 98078b8 - Browse repository at this point
Copy the full SHA 98078b8View commit details
Commits on Aug 28, 2024
-
Al/APPEALS-45334 Individual change history table which includes Reass…
…ign Cases to CAMO events (#22483) * added logic for claim history events table * fixed linting errors * fixing test failures * added change Pr feedback * PR feedback round 2 * changes from round 2 of PR feedback * Added logic event data versions and tests to cover more edgecases * changed RequestedIssueFragment * Updated the individual claim history spec file for test failures. Updated an attribute in the IndividualClaimHistory page that was using the wrong getter. Fixed a code climate linting error. * Removing unnecessary clear filter * Combined some of the individual claim history tests into one test so it will run more quickly. * fixing the withdrawal date versioning issue for different level changes * fixing the spec failure and linter --------- Co-authored-by: Brandon Lee Dorner <Brandondorner@yahoo.com> Co-authored-by: = <tyler.broyles@va.gov> Co-authored-by: Prajwal Amatya <pamatya@take2it.com>
Configuration menu - View commit details
-
Copy full SHA for 4daaba2 - Browse repository at this point
Copy the full SHA 4daaba2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4c244d1 - Browse repository at this point
Copy the full SHA 4c244d1View commit details
Commits on Sep 10, 2024
-
TYLERB/APPEALS-57367: change-history-updates (#22479)
* Initial commit with new tests cases for issue modification requests for change history. * Added two cte queries to the business line change history query to properly work with a lead for the issue modification requests. Added new methods into the claim history event to work with this new lead and modified the existing issue modification in progress and pending event generation methods to better reflect the state of a claim that is going through the issue modficiation process. * Cleaned up unused code and todos. * Updated the claim history event create_imr_in_progress_status_event? with even more logic and edge cases. * Fixed a possible error when with a greater than operator could be used on a null value. * Fixed a few rspec tests. * Renamed a method and fixed a few code climate issues. * Fixed a bug in event status generation if there is a task with versions but no versions that change status. * Updated tests to work with new logic and remove a todo statement. * Fixed code complexity warnings. * Updated serializer spec to work with the bug fix. * Adjusted the pending method to prevent possible race conditions. * Fixed a bug where the incorrect decision event user would be shown for an issue modification request creation if the request has been decided when it should be the requestor as the event user. * Added the correct css ids to a few IMR change history events so that the filtering would work correctly. Also added some additional sql to properly filter based on css id and station id for requestor and decider joins. * Updated the IMR business line logic so that the decided at fields would always account for cancelled status since it uses updated at instead of decided at to determine when the IMR was closed. Fixed a bit of logic in the claim history event IMR in progress event generation to work another edge case. * Added in previous IMR edit versions for displaying it to the user. * Added a test for the change history service class to verify that request edit events have the correct attributes from the previous edits. * Fixed a typo for one of the table aliases in the business line query. * Fixed another typo where the facilities filter was using css id instead of station id from a copy/paste error. * adding changes for previous state array and some test modification * adding test for previous data * Fixed some outstanding test failures. * Fixed a linting error. Removed some duplicated code that happened when merging in the feature branch. Updated a factorybot method that was causing tests to fail. * Fixed a few code climate warnings. * Removed some puts statements in the individual claim history feature test. --------- Co-authored-by: Prajwal Amatya <pamatya@take2it.com>
Configuration menu - View commit details
-
Copy full SHA for 21bf071 - Browse repository at this point
Copy the full SHA 21bf071View commit details
Commits on Sep 12, 2024
-
Configuration menu - View commit details
-
Copy full SHA for de9cd83 - Browse repository at this point
Copy the full SHA de9cd83View commit details
Commits on Sep 13, 2024
-
Merged together the remand feature branch with the reassign cases to …
…camo change history updates feature branch.
Configuration menu - View commit details
-
Copy full SHA for 5bd5f05 - Browse repository at this point
Copy the full SHA 5bd5f05View commit details
Commits on Sep 20, 2024
-
TYLERB/APPEALS-58656: Change History CSV and Version Parsing fix (#22874
) * Fixed a modification request claim history in progress event generation bug that could occur when 3-4 pending requests were all created at the same time and then later cancelled at the same time. Also fixed an issue count bug used when building the issue type filter due to additional duplicate rows being inserted into issue type count query due to the left join to the issue modification requests table. * Altered the version parsing for change history to work with commas in the version strings since that was causing parsing errors. Altered the business line query to use '|||' as a delimeter instead of comma and also changed the array_agg functions to string agg to avoid the '{}' array type casting that was happening between postgres and rails. Updated tests to work with this new parsing. * Updated vha seed data to have associations to intake data so those seeded claims can correctly generate change history.
Configuration menu - View commit details
-
Copy full SHA for 9377934 - Browse repository at this point
Copy the full SHA 9377934View commit details