APPEALS-50679 | Reassign Cases to Camo Change History #22897
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ta (#22220) * added migration file for adding type column to supplemental claims table * created stub for remand model * added type to supplemental claim factory and new remand trait * added remand sc's to vha seeds * updated migration name and fixed typo * Changed migration to inherit from Caseflow::Mirgration * schema changes * reverting schema * changed the setting of the type column * fixed schema and renamed migration file * fixed migration and schema * updated the remands factory and seeds * fixed comment in schema --------- Co-authored-by: Robert Travis Pierce <robert@roberttravispierce.com>
* added additional option to check box list * fixed some tests and code clean up * fixed more tests * fixed jest tests * changes per Pr feedback * added custom error display * fixed style for error message --------- Co-authored-by: Sean Craig <sean.craig2@va.gov>
…view Queue tabs (#22206) * Added support for remands to the business_line.rb model and the index.js util file that parses the decision review type filters for the decision review queue. * Updated the business line spec file, the decision reviews controller spec tests, and the reviews spec feature test to support remands. * Added a decision review polymorphic helper to DRY up some of the polymorphic appeal concerns. * Overrode the remand model association to request issues so active record joins will work correctly. * Added another helper for sti polymorphic relationships. Fixed filtering for STI decision review types for remands. Updated tests and added factories for testing. * Code climate fixes and test fixes. * Fixed more test failures. Removed the remand request issues relationship since it was incorrectly implemented. Added a scope to supplemental claims for remands. Fixed an issue where board grant effectuation tasks without request issues were missing from the new task type count method. * Changed the UNION ALL to a UNION in the new task_type_count method to prevent duplicate row counts. Updated tests and fixed an issue where the board grant effectuation tasks were being counted for pending task queries.
* some preliminary remand & sc model updates * typo * some preliminary hlr checks? * undo seed change * decision issue and sc updates * attempt code climate fixes * another code climate fix * testing changes * useless variable.. * fix conditional in decision issue * fix undefined find_by method * attempt rspec fix * rspec fix attempt #2 * supplemental_claim_spec fix? * remove comma * code climate fix * added comment for transparency on remand creation, attempt fix for remands route * updated specs for decision_issue, hlr_spec, appeal_spec to account for remand creation type * fix lint error * fix lint error #2 --------- Co-authored-by: Jonathan Hoang <trinhjoanthan.hoang@va.gov>
* disable edit issues link for remands * add banners explaining that remands are not editable also makes sure that remands are not editable on the edit issues page
…Remand in conditions (#22356) * Initial commit. Changed the DecisionReviewType condition filter to a searchable dropdown and added the remands option to it as well. Updated the report page filter parsing to work with the searchable dropdown instead of checkboxes for the decision review type condition filter. * Updated the ReportPage jest test and the report page feature test to work with the decision review type filter as a searchable dropdown instead of checkboxes.
…Remand records via script (#22359) * initial verison of update script * remanded migration file * updated sc spec with type * schema * fixed a few issues in the migration * small fix to migration file * moved the type column check into a seperate it block * fixed wrong column in migration file * created a new migration for creating the view * updated the backfill migration file --------- Co-authored-by: Brandon Lee Dorner <Brandondorner@yahoo.com>
#22238) * adding logic to bring in issue-modification request and updating the csv logic * refactor logic to get pending status and null to request addition * pending status filter work fixing * adding withdrawal date and adding logic to display request issue components * getting edit of request rows and fixing cancelled data * fixing linter and fixing the query to make test happy * fixing specs failures * removing byebug * removing frontend changes, adding test, fixing the query to replace higherlevel review,adding new field in serializer * making code climate happy by doing some minor refactor * fixing the serializer spec failure * After merging APPEALS-45335, filter for Requested issues were broken, so refactored it and removed the unnecessary methood that i created * fixing code climate and spec was failing because of hard coded date * refactor the edit of request logic to take from version, refactored business line query to remove coalesce and fix test * fixing codeclimate, remove unnecessary field * refactor to make first comment appear first in edit of request * fixing linter issue, spec and refactor to fix the bug * fixing pending status filter issue and adding test for business line * fixing broken spec failure * adding user facilty * fixing the lead and lag function to prevent entry of pending status multiple times * fixing an issue in which in progress event was not being made * adding decision reason that was missed and fixing the event logic one more time * fixing the multiple issue modification request after decision has been made * refactor inprogress logic for approved data * fixing spec failure * fixing the first version logic to be more simpler and fixing name and adding spec * fixing more inprogess event * removing the disabled complexity and taking out the boolean condition to a separate method
* initial * some factory and spec updates * change history query update and spec fixes * code climate/lint fix * change @claim_type identifier * fix claim_history_event_spec.rb * test coverage for change history with Remand claim type * spec lint fixes * refactor claim_type filtering to account for remand subtype * business_line_spec fix * decision_reviews_controller_spec update for remand claim type * lint fixes for decision_reviews_controller_spec.rb * comment updates in business_line.rb * renamed mock data in change_history_reporter_spec * trigger GA * refactor claim type filter for less conditional handling * business line spec fix --------- Co-authored-by: Jonathan Hoang <trinhjoanthan.hoang@va.gov>
…ign Cases to CAMO events (#22483) * added logic for claim history events table * fixed linting errors * fixing test failures * added change Pr feedback * PR feedback round 2 * changes from round 2 of PR feedback * Added logic event data versions and tests to cover more edgecases * changed RequestedIssueFragment * Updated the individual claim history spec file for test failures. Updated an attribute in the IndividualClaimHistory page that was using the wrong getter. Fixed a code climate linting error. * Removing unnecessary clear filter * Combined some of the individual claim history tests into one test so it will run more quickly. * fixing the withdrawal date versioning issue for different level changes * fixing the spec failure and linter --------- Co-authored-by: Brandon Lee Dorner <Brandondorner@yahoo.com> Co-authored-by: = <tyler.broyles@va.gov> Co-authored-by: Prajwal Amatya <pamatya@take2it.com>
…as a seperate type than SupplementalClaims. Also added additional testing logic for the business line reporter for hlr and scs since it was only covering appeals. (#22664) Co-authored-by: Robert Travis Pierce <robert@roberttravispierce.com>
* Initial commit with new tests cases for issue modification requests for change history. * Added two cte queries to the business line change history query to properly work with a lead for the issue modification requests. Added new methods into the claim history event to work with this new lead and modified the existing issue modification in progress and pending event generation methods to better reflect the state of a claim that is going through the issue modficiation process. * Cleaned up unused code and todos. * Updated the claim history event create_imr_in_progress_status_event? with even more logic and edge cases. * Fixed a possible error when with a greater than operator could be used on a null value. * Fixed a few rspec tests. * Renamed a method and fixed a few code climate issues. * Fixed a bug in event status generation if there is a task with versions but no versions that change status. * Updated tests to work with new logic and remove a todo statement. * Fixed code complexity warnings. * Updated serializer spec to work with the bug fix. * Adjusted the pending method to prevent possible race conditions. * Fixed a bug where the incorrect decision event user would be shown for an issue modification request creation if the request has been decided when it should be the requestor as the event user. * Added the correct css ids to a few IMR change history events so that the filtering would work correctly. Also added some additional sql to properly filter based on css id and station id for requestor and decider joins. * Updated the IMR business line logic so that the decided at fields would always account for cancelled status since it uses updated at instead of decided at to determine when the IMR was closed. Fixed a bit of logic in the claim history event IMR in progress event generation to work another edge case. * Added in previous IMR edit versions for displaying it to the user. * Added a test for the change history service class to verify that request edit events have the correct attributes from the previous edits. * Fixed a typo for one of the table aliases in the business line query. * Fixed another typo where the facilities filter was using css id instead of station id from a copy/paste error. * adding changes for previous state array and some test modification * adding test for previous data * Fixed some outstanding test failures. * Fixed a linting error. Removed some duplicated code that happened when merging in the feature branch. Updated a factorybot method that was causing tests to fail. * Fixed a few code climate warnings. * Removed some puts statements in the individual claim history feature test. --------- Co-authored-by: Prajwal Amatya <pamatya@take2it.com>
…e() on a null or undefined value which could happen sometimes if the api filter options are in an incorrect state. (#22796) Co-authored-by: Robert Travis Pierce <robert@roberttravispierce.com>
…nd the changes to Caseflow::Migration. (#22825)
…camo change history updates feature branch.
) * Fixed a modification request claim history in progress event generation bug that could occur when 3-4 pending requests were all created at the same time and then later cancelled at the same time. Also fixed an issue count bug used when building the issue type filter due to additional duplicate rows being inserted into issue type count query due to the left join to the issue modification requests table. * Altered the version parsing for change history to work with commas in the version strings since that was causing parsing errors. Altered the business line query to use '|||' as a delimeter instead of comma and also changed the array_agg functions to string agg to avoid the '{}' array type casting that was happening between postgres and rails. Updated tests to work with this new parsing. * Updated vha seed data to have associations to intake data so those seeded claims can correctly generate change history.
brandondorner
force-pushed
the
feature/APPEALS-50679-uat-4.6.0
branch
from
81085fe
to
daeb17d
Compare
…-uat-4.6.0 # Conflicts: # spec/controllers/decision_reviews_controller_spec.rb
brandondorner
force-pushed
the
feature/APPEALS-50679-uat-4.6.0
branch
from
bb5a3d6
to
7aa3db3
Compare
…ure/APPEALS-50679-uat-4.6.0
…EALS-50679-uat-4.6.0 # Conflicts: # app/models/organizations/business_line.rb # app/services/claim_change_history/claim_history_event.rb # spec/models/business_line_spec.rb # spec/services/claim_change_history/change_history_reporter_spec.rb # spec/services/claim_change_history/claim_history_event_spec.rb
roberttravispierce
approved these changes
Sep 20, 2024
brandondorner
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves Jira Issue Title
Description
Please explain the changes you made here.
Acceptance Criteria
Testing Plan
Frontend
User Facing Changes
Storybook Story
For Frontend (Presentation) Components
MyComponent.stories.jsalongsideMyComponent.jsx)Backend
Database Changes
Only for Schema Changes
created_at,updated_at) for new tablesCaseflow::Migration, especially when adding indexes (useadd_safe_index) (see Writing DB migrations)migrate:rollbackworks as desired (changesupported functions)make check-fks; add any missing foreign keys or add toconfig/initializers/immigrant.rb(see Record associations and Foreign Keys)belongs_tofor associations to enable the schema diagrams to be automatically updatedIntegrations: Adding endpoints for external APIs
Best practices
Code Documentation Updates
Tests
Test Coverage
Did you include any test coverage for your code? Check below:
Code Climate
Your code does not add any new code climate offenses? If so why?
Monitoring, Logging, Auditing, Error, and Exception Handling Checklist
Monitoring
Logging
Auditing
Error Handling
Exception Handling