Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ki/APPEALS-42563 - Package Details: Inbound Ops Team Superuser/visor: Edit Information #22944

Merged
merged 11 commits into from
Oct 1, 2024

Conversation

KiMauVA
Copy link
Contributor

@KiMauVA KiMauVA commented Sep 24, 2024

Resolves APPEALS-42563 - Package Details: Inbound Ops Team Superuser/visor: Edit Information

Description

This creates a new modal editCorrespondenceGeneralInformation, that allows the VADOR, Correspondence Type, and Notes to be updated.
-Fixes some of the correspondence/correspondenceInfo issues on Correspondence Details page

Acceptance Criteria

  • Code compiles correctly

Testing Plan

  1. Log in as Inbound Ops Team User
  2. Navigate to Correspondence Details page for Pending/Completed Correspondence
  3. Click on "Package Details" tab.
  4. Click on new "Edit" button.
  5. Change any or all of the 3 options: VADOR, Correspondence Type, or Notes.
  6. Save.
  7. Verify changes on Correspondence Details Page.

TESTING NOTES

  1. The Save button should be disabled until a change is made to any of the 3 boxes. Once a change happens, the save button will stay active, even if reverting your changes.
  2. The Save action requires calling the serialized correspondences, which can take a bit. On Save click, it should change to a loading graphic, and will close the modal automatically on completion.
  3. VADOR has data validation in order to prevent future dates from being selected.

Frontend

User Facing Changes

  • Screenshots of UI changes added to PR

Correspondence Details with Edit Button

Screenshot 2024-09-26 at 4 28 21 PM

Edit General Information Modal

Screenshot 2024-09-26 at 4 28 33 PM

Edit General Information Modal with VADOR Date Error

Screenshot 2024-09-26 at 4 28 44 PM

Edit General Information Modal Saving

Screenshot 2024-09-26 at 4 29 04 PM

Correspondence Details after Edit

Screenshot 2024-09-26 at 4 29 38 PM

Best practices

Code Documentation Updates

  • Add or update code comments at the top of the class, module, and/or component.

Tests

Test Coverage

Did you include any test coverage for your code? Check below:

  • RSpec

Code Climate

Your code does not add any new code climate offenses? If so why?

  • No new code climate issues added

@KiMauVA KiMauVA changed the base branch from main to feature/APPEALS-34965 September 24, 2024 19:00
@KiMauVA KiMauVA marked this pull request as ready for review September 26, 2024 20:34
HunJerBAH
HunJerBAH previously approved these changes Sep 30, 2024
@HunJerBAH HunJerBAH merged commit a391340 into feature/APPEALS-34965 Oct 1, 2024
13 of 17 checks passed
@HunJerBAH HunJerBAH deleted the Ki/APPEALS-42563-main branch October 1, 2024 21:01
@KiMauVA KiMauVA mentioned this pull request Oct 3, 2024
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants