Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

making label changes and fixing feature tests #22958

Merged
merged 17 commits into from
Oct 4, 2024

Conversation

sulak-j
Copy link
Contributor

@sulak-j sulak-j commented Sep 24, 2024

Resolves Intake Form: have inactive Appeals only show the 12 tasks

Description

  • Added seed data script to create inactive appeals tied to veterans

Please Note: Seed data for inactive appeals will need to be added in demo before this will show as expected

  • Added the ability to find inactive appeals using the appeals search serializer
  • Added the ability for inbound ops users to only see the 12 tasks relating to inactive appeals when adding a task related to an appeal
  • Wrote tests to verify this functionality
  • Addressed a misspelled banner and banner tests to match the AC of this story

Acceptance Criteria

  • Code compiles correctly

Testing Plan

Go to Jira Issue/Test Plan Link or list them below

  1. Log into Caseflow as an inbound ops team user
  2. Navigate to queue/correspondence
  3. Select a veteran from the unassigned tab to go to the review package page
  4. If necessary, add a correspondence type, and click save.
  5. Scroll to the bottom and select "Create record"
  6. Navigate to step 2
  7. Find the "Tasks related to an existing Appeal" section and click the "yes" radio button
  8. Find an appeal where the "assigned to" is "Post-decision" (this will likely be on the last page), then click that checkbox.
  9. Scroll down and click the "+ Add tasks" button
  10. Click the task dropdown.
  11. Verify that there are only 12 options in this list. A quick way to check is to make sure the list does not contain "Change Of Address", as this is only available on active appeals
  12. Scroll back up and choose another appeal that is not one of the last four and is not assigned to post-decision
  13. For this appeal, select the "+ Add tasks" button and click the task dropdown.
  14. This time, the list should include more options and will now include "Change Of Address" in the list.
  15. Functionality for each can be verified to make sure list options disappear when chosen (except for other motion, which should only disappear after 2 are chosen), and that a max of four tasks can be created by that user

@sulak-j sulak-j changed the base branch from feature/APPEALS-34965 to main October 2, 2024 21:03
@sulak-j sulak-j changed the base branch from main to feature/APPEALS-34965 October 2, 2024 21:16
@sulak-j sulak-j marked this pull request as ready for review October 2, 2024 21:20
@cacevesva cacevesva changed the base branch from feature/APPEALS-34965 to feature/APPEALS-39909 October 4, 2024 23:13
@cacevesva cacevesva merged commit 70531ca into feature/APPEALS-39909 Oct 4, 2024
9 of 14 checks passed
@cacevesva cacevesva deleted the Justin/APPEALS-56221 branch October 4, 2024 23:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants