-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/appeals 49670 uat merge #23121
Commits on Jan 24, 2024
-
APPEALS-36688- Build out Decision Review Created API route & Controll…
…er (#20569) * added skeleton for api route * removed duplicate code * removed development envs for api and moved to creating an ApiKey * removing any changes to development.rb * removed extra auth code * removed before action --------- Co-authored-by: TuckerRose <tuckerrose@tuckerroses-mbp.lan>
Configuration menu - View commit details
-
Copy full SHA for 7633846 - Browse repository at this point
Copy the full SHA 7633846View commit details -
APPEALS-38232 -Build out Decision Review Created Event Failure API ro…
…ute & Controller (#20601) * APPEALS-38232 - renamed controller to AC req, added decision_review_created_error endpoint, added decision_review_created_error method, and added RSpec for new method * APPEALS-38232 - add comments to RSpec
Configuration menu - View commit details
-
Copy full SHA for 7a2f947 - Browse repository at this point
Copy the full SHA 7a2f947View commit details
Commits on Jan 25, 2024
-
Jonathan/appeals 36684 (#20516)
* initial Events migration and model creation * created model for DecisionReviewCreatedEvent * updated comment with example * added spec for DRCE model * APPEALS-36684 created event_records migration and added polymorphic associations to specific models, and added rspec for the event_record model * APPEALS-36684 - Updated RSpec tests and updated variables and got unhappy path to pass * cleaned lint * saving DRCE spec changes * fixed spec test * changed has_many to has_one * updated event model spec * added validation for ER poly associations * changed association to has_one * added new method and updated tests * added foreign key after running checks * some PR comment changes * refactored methods in EventConcern --------- Co-authored-by: Jonathan Tsang <tsang_jonathan@bah.com> Co-authored-by: Enrilo Ugalde <ugalde_enrilo@bah.com>
Configuration menu - View commit details
-
Copy full SHA for f9c04d8 - Browse repository at this point
Copy the full SHA f9c04d8View commit details
Commits on Feb 6, 2024
-
added migration, scopes and specs for events (#20707)
* fixed migration to update existing events table * rollbacked to fix schema * schema fixes --------- Co-authored-by: TuckerRose <tuckerrose@tuckerroses-mbp.lan>
Configuration menu - View commit details
-
Copy full SHA for c91ddf8 - Browse repository at this point
Copy the full SHA c91ddf8View commit details
Commits on Feb 8, 2024
-
* APPEALS-38926 - Created DecisionReviewCreatedError Service Class, added logic for handling service error, updated DecisonReviewCreatedController, and DecisionReviewCreatedController spec, with the updated service logic * APPEALS-38926- created RSpec Test for DecisionReviewCreatedError Service Class and edited the Rails.logger for the service class * APPEALS-38926 Added new info column to update transaction and added it to the RSpec test * APPEALS-38926 - added comments to the Service Class * APPEALS-38926 - Code Changes from TL Code Review, added rescues and fails * APPEALS-38926 - fixed lint
Configuration menu - View commit details
-
Copy full SHA for b6bd723 - Browse repository at this point
Copy the full SHA b6bd723View commit details
Commits on Feb 9, 2024
-
Jonathan/appeals 36689 (#20671)
* created new service class * add rspec test cases * service class methods * controller action and spec * controller update * CC fixes * removed accidental line * changed to find_or_create_by * reworked error for redis lock * additional rspec for controller * fixed test * rspec fix * delete lock key afterwards * moved Event creation back into lock block --------- Co-authored-by: Jonathan Tsang <tsang_jonathan@bah.com>
Configuration menu - View commit details
-
Copy full SHA for 51abc5e - Browse repository at this point
Copy the full SHA 51abc5eView commit details
Commits on Feb 16, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 580f725 - Browse repository at this point
Copy the full SHA 580f725View commit details
Commits on Feb 20, 2024
-
APPEALS-39663 Create CreateUserOnEvent service class and add logic to…
… create user if needed (#20838) * added user creation class & test * removed extra lines * add comment to class * added context for args from avro --------- Co-authored-by: Jonathan Tsang <tsang_jonathan@bah.com>
Configuration menu - View commit details
-
Copy full SHA for cea711f - Browse repository at this point
Copy the full SHA cea711fView commit details
Commits on Feb 23, 2024
-
* APPEALS-39664 - Created updated_vacols_on_optin module class, and removed extra private * APPEALS-39664 - created UpdatedVacolsOnOptin module, RSpec file, as well as sudo code for SOC and SSOC optin check in main service class DecisionReviewCreated * APPEALS-39664 - Created RSpec Test - PASS, Updated method name. * APPEALS-39664 - Added Error Handling to Sub Service Class * APPEALS-39664 - Removed un-needed comments * APPEALS-39664 - added include for the module UpdateVacolsOnOptin inside decision_review_created service * APPEALS-39664 - Added Custom Error , and updated all .perform! to .process! * APPEALS-39664 - Updated RSpec Test to reflect changes - all pass * Updated comment for decision_review_created Service Class
Configuration menu - View commit details
-
Copy full SHA for f4c32f2 - Browse repository at this point
Copy the full SHA f4c32f2View commit details -
* Created attribute for failed claims on event and displaying failed claim * passing all failed events back to serializer * added controller tests for failed_claims and added class method for finding claims on events * renamed failed_claims to claim_errors --------- Co-authored-by: TuckerRose <tuckerrose@tuckerroses-mbp.lan>
Configuration menu - View commit details
-
Copy full SHA for bb790ee - Browse repository at this point
Copy the full SHA bb790eeView commit details
Commits on Feb 28, 2024
-
JR/APPEALS-40954 Create CreateIntake service class and add logic to c…
…reate Intake (#20967) * APPEALS-40954 - Added Sudo Code for CreateIntake Logic * APPEALS-40954 - added logic to CreateIntake module * APPEALS-40954 - added Create Intake spec with error handling - All pass * APPEALS-40954 - Added CreateIntake Module to DecisionReviewCreated Main Service * APPEALS-40954 - updated folder name and namespace * APPEALS-40954 - Updated RSpec to match folder * APPEALS-40954- Upated decision review created servie include to match folder * Fixed failing test due to folder structure change
Configuration menu - View commit details
-
Copy full SHA for 0a3b620 - Browse repository at this point
Copy the full SHA 0a3b620View commit details
Commits on Mar 6, 2024
-
Jonathan/appeals 40950 (#20965)
* Added new veteran creation module * saving test changes * rspec * fixed datetime assign * renamed var --------- Co-authored-by: Jonathan Tsang <tsang_jonathan@bah.com>
Configuration menu - View commit details
-
Copy full SHA for fd26a8a - Browse repository at this point
Copy the full SHA fd26a8aView commit details
Commits on Mar 7, 2024
-
APPEALS-40950 - update var veteran to vbms_veteran (#21050)
* APPEALS-40950 - update var veteran to vbms_veteran * updated private method in controller to match happy path params dcr to drc
Configuration menu - View commit details
-
Copy full SHA for c4d1a49 - Browse repository at this point
Copy the full SHA c4d1a49View commit details
Commits on Mar 8, 2024
-
Create CreateClaimantOnEvent service class and add logic to create cl…
…aimant if needed (#21044) * created service class and basic unit tests * added conditionals for veteran claimants and will create veteran claimant now * modified create claimant to use eventing data * change to a class * creating claimant correctly * test fixes * removed old comments * fixed type for veteran_is_not_claimant * changed specs to match pulling out hash params and removed event.reference id * moved back to dot notation * updated comments * fixed create claimant issue * updated process to use bang method and returning claimant --------- Co-authored-by: TuckerRose <tuckerrose@tuckerroses-mbp.lan>
Configuration menu - View commit details
-
Copy full SHA for 40e6bbb - Browse repository at this point
Copy the full SHA 40e6bbbView commit details
Commits on Mar 13, 2024
-
APPEALS-41968 Modify Issues Endpoints & Update Metric Service Logic (#…
…21108) * moved metricsService call to top of method * modified rspec case * moved metric logging spec case higher up --------- Co-authored-by: Jonathan Tsang <tsang_jonathan@bah.com>
Configuration menu - View commit details
-
Copy full SHA for f6a58fa - Browse repository at this point
Copy the full SHA f6a58faView commit details
Commits on Mar 15, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 3efde93 - Browse repository at this point
Copy the full SHA 3efde93View commit details
Commits on Mar 18, 2024
-
Configuration menu - View commit details
-
Copy full SHA for a0f439f - Browse repository at this point
Copy the full SHA a0f439fView commit details
Commits on Mar 19, 2024
-
Jonathan/APPEALS-41957 (#21171)
* added interface + parser class * edited veteran parse methods * renamed var to "payload" * started refactor * more refactor + rspec * added EPE attr * dateTime conversions * added class comments * rubocop lint changes * fixed test case --------- Co-authored-by: Jonathan Tsang <tsang_jonathan@bah.com>
Configuration menu - View commit details
-
Copy full SHA for 4577fb9 - Browse repository at this point
Copy the full SHA 4577fb9View commit details
Commits on Mar 20, 2024
-
* APPEALS-41931 - Created create_ep_establishment file and class * APPEALS-41931 - added process! method that creates epe from payload * APPEALS-41931 - added logic for EventRecord being created and error handling * APPEALS-41931 - added comments to process method * APPEALS-41931 - set up rspec test * APPEALS-41931 - removed lint * APPEALS-41931-created Rspec and Test Pass * APPEALS-41931 - cleaned lint and added error test 100% code coverage * APPEALS-41931- fixed lint * APPEALS-41931- fixed lint and fixed %100 code cov * APPEALS-41931 - cleaned up lint and warn for Service Class * APPEALS-41931 - Added CreateEpEstablishment.process! to the decision_review_created Parent Service Class * APPEALS-41931 - refactor code to implement new parser * fixed linting issues * APPEALS-41931 - Updated Comments for CreateEpEstablishment * APPEALS-41931 - moved logical date int to parser and refactored code in Class and RSepc * edits
Configuration menu - View commit details
-
Copy full SHA for 8b67337 - Browse repository at this point
Copy the full SHA 8b67337View commit details
Commits on Mar 21, 2024
-
* added an error and commented out call for createclaim * added new parser logic * merge request changes * fixed rubocop issues and added checks for claim review attributes --------- Co-authored-by: TuckerRose <tuckerrose@tuckerroses-mbp.lan>
Configuration menu - View commit details
-
Copy full SHA for 79cef69 - Browse repository at this point
Copy the full SHA 79cef69View commit details
Commits on Mar 25, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 7f82f6e - Browse repository at this point
Copy the full SHA 7f82f6eView commit details
Commits on Apr 1, 2024
-
APPEALS-42631- Create Rspec for Parser with sample payload method, an…
…d add additional parser methods (#21294) * APPEALS-42631 - create example.json * APPEALS-42631 - implemented example_response and load_example method and works as expected * APPEALS-42631 - created RSpec for DecisionReviewCreatedParser * APPEALS-42631 - Refactored parser and Added RSpec for current praser * APPEALS-42631 - added methods to parser for intake, claimant, and claim_review and added matching rspec for new methods * APPEALS-42631 - updated code per TL Comments * APPEALS-421631- added additional comments and fixing lint
Configuration menu - View commit details
-
Copy full SHA for 50d1db3 - Browse repository at this point
Copy the full SHA 50d1db3View commit details -
* initial commit * implementation & error * renamed method * rspec * saving refactor progress * finished refactoring class * added comment * minor parser/rspec updates --------- Co-authored-by: Jonathan Tsang <tsang_jonathan@bah.com>
Configuration menu - View commit details
-
Copy full SHA for 57302b7 - Browse repository at this point
Copy the full SHA 57302b7View commit details
Commits on Apr 2, 2024
-
added RI parser methods to rspec (#21322)
* added RI parser methods to rspec * updated config for Consumer --------- Co-authored-by: Jonathan Tsang <tsang_jonathan@bah.com>
Configuration menu - View commit details
-
Copy full SHA for b538a70 - Browse repository at this point
Copy the full SHA b538a70View commit details
Commits on Apr 5, 2024
-
Update DecisionReviewCreated to make all calls and link all intake re…
…cords (#21334) * updated decision review created to uncomment actions and updated specs * remove binding.pry * removed comments * fixed a bunch of broken tests * fixed last broken tests * fixed params for methods and specs --------- Co-authored-by: TuckerRose <tuckerrose@tuckerroses-mbp.lan>
Configuration menu - View commit details
-
Copy full SHA for 260590a - Browse repository at this point
Copy the full SHA 260590aView commit details
Commits on Apr 15, 2024
-
APPEALS-43446- Change name of BackfillRecord polymorphic model to Eve…
…ntedRecord (#21382) * APPEALS-43446 - renamed columns for backfill record to evented record migrate and rollback work as intended * APPEALS-43446 replaced all backfill_record with evented_record within the models associations and updated Rspec tests * APPEALS-43446 fixed error message
Configuration menu - View commit details
-
Copy full SHA for 565c2ea - Browse repository at this point
Copy the full SHA 565c2eaView commit details -
Jr/ama controller refactor (#21365)
* fixed test and refactored controller * saving changes * init commit passing all the way to request_issues * all pass and functions as expected * lint * lint * updated initializer to use deep_symbolize_keys * updated headers to be more dry * added missing Intake attributes * fixed failing tests * updated createIntake test * fixed veteran rspec * fixed RI test * APPEALS-43446- Change name of BackfillRecord polymorphic model to EventedRecord (#21382) * APPEALS-43446 - renamed columns for backfill record to evented record migrate and rollback work as intended * APPEALS-43446 replaced all backfill_record with evented_record within the models associations and updated Rspec tests * APPEALS-43446 fixed error message * updated intake * modified intake --------- Co-authored-by: Jonathan Tsang <tsang_jonathan@bah.com>
Configuration menu - View commit details
-
Copy full SHA for 63453cf - Browse repository at this point
Copy the full SHA 63453cfView commit details
Commits on Apr 16, 2024
-
Configuration menu - View commit details
-
Copy full SHA for ff161fd - Browse repository at this point
Copy the full SHA ff161fdView commit details -
Configuration menu - View commit details
-
Copy full SHA for e018f1d - Browse repository at this point
Copy the full SHA e018f1dView commit details
Commits on Apr 17, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 62397be - Browse repository at this point
Copy the full SHA 62397beView commit details
Commits on Apr 19, 2024
-
Create end to end , happy path rspec's for Decision Created event Fea…
…ture (#21395) * updated more tests and fixed user creation * added in person creation * corrected headers and fixed broken tests * added type * fixed failing spec * creating event when person is created * updated spec to account for both events being created * ignored long lines for spec file * linting fixes * fixed more linting errors/ ignored long lines --------- Co-authored-by: TuckerRose <tuckerrose@tuckerroses-mbp.lan>
Configuration menu - View commit details
-
Copy full SHA for 884b1c0 - Browse repository at this point
Copy the full SHA 884b1c0View commit details -
Jonathan/appeals 43589 (#21397)
* saving * saving user class error progress * error handling for user creation * updated error handling/raises * validator methods * validations * update logical date converter * changed veteran service class to use file_number * added fields to hlr * updated epe data * removed byebug * fixed typos * Edit 5: adding detail_id to Intake * EDIT 6: add claimant_participant_id to epe * Edit 8: Intake is correctly linked to veteran * Edit 7: RI additions * fixed spacing * fixed typo * saving rspec changes * rspec updates * added datetime conversion for person dob * fixed rspec * remove unused methods --------- Co-authored-by: Jonathan Tsang <tsang_jonathan@bah.com>
Configuration menu - View commit details
-
Copy full SHA for 17b89cc - Browse repository at this point
Copy the full SHA 17b89ccView commit details
Commits on Apr 22, 2024
-
Merge branch 'isaiah/APPEALS-43421' of https://github.com/department-…
…of-veterans-affairs/caseflow into uat/FY24Q3.1.0
Configuration menu - View commit details
-
Copy full SHA for 64ed446 - Browse repository at this point
Copy the full SHA 64ed446View commit details -
feature/APPEALS-35707-29633-29632 (uat) (#21435)
* 🔀 Squash merge AlecK/APPEALS-35707 - Replace `database_cleaner` with `database_cleaner-active_record` * 🔀 Squash merge jcroteau/APPEALS-29632-fix-deprecation-action-view-base-instances * 🔀 Squash merge jcroteau/APPEALS-29633-fix-deprecation-warning-active_record-result-to_hash
Configuration menu - View commit details
-
Copy full SHA for 7733c4b - Browse repository at this point
Copy the full SHA 7733c4bView commit details
Commits on Apr 23, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 3827b60 - Browse repository at this point
Copy the full SHA 3827b60View commit details
Commits on May 2, 2024
-
awillis/APPEALS-45152 (#21506)
* APPEALS-45152 Updated the logic in create_claimant_on_event.rb to always generate a claimant record. Updated RSPEC. * APPEALS-45152 Cleaned up RSPEC. * APPEALS-45152 Fixed Failing RSPEC within decision_review_created_spec.rb * APPEALS-45152 Updated RSPEC within decision_review_created_spec.rb with addtional checks.
Configuration menu - View commit details
-
Copy full SHA for 8143e3f - Browse repository at this point
Copy the full SHA 8143e3fView commit details
Commits on May 3, 2024
-
APPEALS-44319 (#21449) (#21541)
* added logic for legacy issues in DRC * more legacy logic * updated rspec context lang * error cov --------- Co-authored-by: Jonathan Tsang <98970951+jtsangVA@users.noreply.github.com> Co-authored-by: Jonathan Tsang <tsang_jonathan@bah.com>
Configuration menu - View commit details
-
Copy full SHA for 290e80a - Browse repository at this point
Copy the full SHA 290e80aView commit details -
Konstantin/APPEALS-45175 (#21517)
* logical_date_converter re-written to work with yyyymmdd numbers from json payload * comments removed * comments removed2 * method rewitten * json example fixed * date in scenario_b_spec.rb replaced by valid ones, additional check for empty string parameter added to the logical_date_converter
Configuration menu - View commit details
-
Copy full SHA for 05777f1 - Browse repository at this point
Copy the full SHA 05777f1View commit details -
removed filter for non rating request issue dropdown (#21480)
* removed filter for non rating request issue dropdown * removed excluded types as we don't need to check this anymore * fixed broken test * added category back * no longer need test to check for missing categories since we're returning them all. --------- Co-authored-by: TuckerRose <tuckerrose@tuckerroses-mbp.lan>
Configuration menu - View commit details
-
Copy full SHA for bf220e1 - Browse repository at this point
Copy the full SHA bf220e1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9882434 - Browse repository at this point
Copy the full SHA 9882434View commit details
Commits on May 10, 2024
-
Configuration menu - View commit details
-
Copy full SHA for f8dd3c6 - Browse repository at this point
Copy the full SHA f8dd3c6View commit details -
Column added to RequestIssues table (#21578)
* added migration and simple spec to test * fixed schema deleted issues * updated spec to verify data being set * error was no longer trigger from update. removed check and passed in correct variable --------- Co-authored-by: TuckerRose <tuckerrose@tuckerroses-mbp.lan> Co-authored-by: TuckerRose <tuckerrose@TuckerRoses-MacBook-Pro.local>
Configuration menu - View commit details
-
Copy full SHA for 77c14d1 - Browse repository at this point
Copy the full SHA 77c14d1View commit details
Commits on May 13, 2024
-
added bgs_source to parser, controller and serializer along with specs (
#21621) Co-authored-by: TuckerRose <tuckerrose@tuckerroses-mbp.lan>
Configuration menu - View commit details
-
Copy full SHA for 11cd7c9 - Browse repository at this point
Copy the full SHA 11cd7c9View commit details -
Konstantin/appeals 45180 (#21591)
* bug is fixed, condition added to DecisionReviewCreatedController * rspec test added * json message updated * comment added * Update decision_review_created_controller.rb comment updated --------- Co-authored-by: Nader Kutub <nader.kutub@va.gov>
Configuration menu - View commit details
-
Copy full SHA for 99db704 - Browse repository at this point
Copy the full SHA 99db704View commit details
Commits on May 21, 2024
-
Konstantin/appeals 45149 (#21644)
* RequestIssueSerializer attributes added * development_item_reference_id, same_office, legacy_opt_in_approved attributes were added * merge conflicts resolved * merge conflict resolved * fixed * all datapoints were added * empty line removed * comment removed * refactored * app/controllers/api/docs/v3/ama_issues.yaml updated with new attributes * example of request issue updated app/controllers/api/docs/v3/ama_issues.yaml * null to nil edited in example ama_issues.yaml * example ama_issues.yaml updated * example ama_issues.yaml updated2 * linters fixed * linters fixed2 * linters are fixed
Configuration menu - View commit details
-
Copy full SHA for 9148093 - Browse repository at this point
Copy the full SHA 9148093View commit details
Commits on May 31, 2024
-
Configuration menu - View commit details
-
Copy full SHA for fd49f77 - Browse repository at this point
Copy the full SHA fd49f77View commit details
Commits on Jun 3, 2024
-
APPEALS-45883 - Remove End Product Establishment records within the E…
…vent Records table in Caseflow (#21745) * APPEALS-45883 - changes to remove the creating of Event Records for epe * APPEALS-45883 - remove removed event params from method calls * APPEALS-45883 removed Event Double * APPEALS-48553 updated event_record spec
Configuration menu - View commit details
-
Copy full SHA for bf0b13d - Browse repository at this point
Copy the full SHA bf0b13dView commit details -
removed eventing from create claim review (#21718)
* removed eventing from create claim review * checking why file is not being found for event_record * removed event var and require dependency * spec fixes * updated specs * fixed revert --------- Co-authored-by: TuckerRose <tuckerrose@tuckerroses-mbp.lan> Co-authored-by: Nader Kutub <nader.kutub@va.gov>
Configuration menu - View commit details
-
Copy full SHA for 578a25a - Browse repository at this point
Copy the full SHA 578a25aView commit details
Commits on Jun 7, 2024
-
Nrithner/appeals 45913 (#21716)
* Convert from milliseconds to datetime * Add expection to have datetime after parsing * Fix linting issues
Configuration menu - View commit details
-
Copy full SHA for 0ffb23b - Browse repository at this point
Copy the full SHA 0ffb23bView commit details -
APPEALS - 45914 & 45915 (#21744)
* Decision review parser and spec changes * remove byebug
Configuration menu - View commit details
-
Copy full SHA for 4cfffed - Browse repository at this point
Copy the full SHA 4cfffedView commit details -
Added db seed and testing (#21284)
* Added db seed and testing * Change ApiKey seed name to ConsumerApiKey, and associated changes --------- Co-authored-by: Matt Ray <matthew.ray@va.gov> Co-authored-by: Chris-Martine <christopher.martine@va.gov> Co-authored-by: Nader Kutub <nader.kutub@va.gov>
Configuration menu - View commit details
-
Copy full SHA for 78e47ec - Browse repository at this point
Copy the full SHA 78e47ecView commit details -
re-merge Cmartine/appeals 46861 (#21855)
* Edit DecisionReviewCreatedController to respond with ok status if event exists and is completed, edit test * Move checking if event exists and is completed into event model, edit tests * Fix linter errors --------- Co-authored-by: Chris-Martine <christopher.martine@va.gov>
Configuration menu - View commit details
-
Copy full SHA for 39bf8b1 - Browse repository at this point
Copy the full SHA 39bf8b1View commit details -
Nrithner/appeals 46860 (#21856)
* Set event info back to default default state for info is an empty json object * Correct linting errors * Test happy path with rspec * Refactor rspec example * Converte module to class * Remove module import --------- Co-authored-by: Nico Rithner <nicolas.rithner@va.gov>
Configuration menu - View commit details
-
Copy full SHA for 9ebba7f - Browse repository at this point
Copy the full SHA 9ebba7fView commit details
Commits on Jun 10, 2024
-
Jonathan/appeals 45899/45878 (#21714)
* add "from event" value to Store * updated setup guide for M3 * added new badges * added jest * storybook file * additional story * bugfix * snap update
Configuration menu - View commit details
-
Copy full SHA for 87e2e46 - Browse repository at this point
Copy the full SHA 87e2e46View commit details -
Konstantin/appeals 46175 (#21768)
* draft processor method done * process_nonrating method moved to DecisionReviewCreated service * json example added, process_nonrating method updated * 4 rspec test added * useless json example removed * commented lines removed * condition added * condition added. * test updated * first condition moved out of the method * process_nonrating method call moved down * 1 comment removed, 1 added * process nonrating method rafactored, logic transferred into the parser * method refactored, rspec tests updated * rspec test slightly refactored --------- Co-authored-by: Nader Kutub <nader.kutub@va.gov>
Configuration menu - View commit details
-
Copy full SHA for 4d40d05 - Browse repository at this point
Copy the full SHA 4d40d05View commit details
Commits on Jun 14, 2024
-
Edit Issues screen update (#21907)
* Edit Issues screen update * relocated row * updated capybara test * updated capybara to check for new added text
Configuration menu - View commit details
-
Copy full SHA for 04282c8 - Browse repository at this point
Copy the full SHA 04282c8View commit details
Commits on Jun 21, 2024
-
cmartine/APPEALS-46905 (#21884)
* Remove cache updating call for veteran when veteran is being created for an event * Change seeds api_key.rb to consumer_api_key.rb --------- Co-authored-by: Matt Ray <108031363+mattray-gov@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for 6fbfd20 - Browse repository at this point
Copy the full SHA 6fbfd20View commit details
Commits on Jun 28, 2024
-
Update process_nonrating to process_nonrationg_issue_category
Remove extra logic
Configuration menu - View commit details
-
Copy full SHA for 39a087f - Browse repository at this point
Copy the full SHA 39a087fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 1205dff - Browse repository at this point
Copy the full SHA 1205dffView commit details
Commits on Jul 1, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 12b33f1 - Browse repository at this point
Copy the full SHA 12b33f1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2099b27 - Browse repository at this point
Copy the full SHA 2099b27View commit details -
Konstantin/appeals 48306 (#21998)
* ama_eventing_enabled feature check added * toggle renamed * rspec tests added * 2 comments added * toggle renamed, logic trasferred into controller, tests updated * empty line removed --------- Co-authored-by: Matt Ray <108031363+mattray-gov@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for 66cf311 - Browse repository at this point
Copy the full SHA 66cf311View commit details
Commits on Jul 2, 2024
-
Merge branch 'feature/APPEALS-28087-36678' of https://github.com/depa…
…rtment-of-veterans-affairs/caseflow into cmartine/APPEALS-49863
Configuration menu - View commit details
-
Copy full SHA for 2e480f6 - Browse repository at this point
Copy the full SHA 2e480f6View commit details
Commits on Jul 8, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 9f8f0ef - Browse repository at this point
Copy the full SHA 9f8f0efView commit details
Commits on Jul 9, 2024
-
Configuration menu - View commit details
-
Copy full SHA for b01f056 - Browse repository at this point
Copy the full SHA b01f056View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0ed7092 - Browse repository at this point
Copy the full SHA 0ed7092View commit details
Commits on Jul 12, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 6775316 - Browse repository at this point
Copy the full SHA 6775316View commit details -
Configuration menu - View commit details
-
Copy full SHA for 344ad6e - Browse repository at this point
Copy the full SHA 344ad6eView commit details -
Change edited_by_css_id to return users css_id (#22062)
Co-authored-by: Matt Ray <108031363+mattray-gov@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for b74627f - Browse repository at this point
Copy the full SHA b74627fView commit details -
Configuration menu - View commit details
-
Copy full SHA for db7a594 - Browse repository at this point
Copy the full SHA db7a594View commit details -
Nrithner/appeals 49245 (#22107)
* Update process_nonrating to process_nonrationg_issue_category Remove extra logic * Update rspec. Remove unused example --------- Co-authored-by: Matt Ray <108031363+mattray-gov@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for a837dd1 - Browse repository at this point
Copy the full SHA a837dd1View commit details -
Configuration menu - View commit details
-
Copy full SHA for ad953c2 - Browse repository at this point
Copy the full SHA ad953c2View commit details
Commits on Jul 15, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 3be9adf - Browse repository at this point
Copy the full SHA 3be9adfView commit details
Commits on Jul 16, 2024
-
Configuration menu - View commit details
-
Copy full SHA for bf3001e - Browse repository at this point
Copy the full SHA bf3001eView commit details -
APPEALS-51223: Disable ClaimantValidator for DecisionReviewCreatedEve…
…nts (#22132) * APPEALS-51223 refactored the claimant_validator class method claimant_details_required? to consider the conditional statement * APPEALS-51223 updated Rspec to confirm claimant address_line_1 is nil and error is empty * APPEALS-51223 made changes to to claimant_validator to have all Unit test passing * APPEALS-51223 added suggested changes * Revert "fix merge conflict with AMA" This reverts commit 6775316, reversing changes made to 66cf311. * added comments * Delete docker-bin/build.sh, I didnt make these changes * Revert "Delete docker-bin/build.sh, I didnt make these changes" This reverts commit 03a3830. --------- Co-authored-by: nader k <nader@nkconsulting.net>
Configuration menu - View commit details
-
Copy full SHA for 06ec3ad - Browse repository at this point
Copy the full SHA 06ec3adView commit details
Commits on Jul 18, 2024
-
Jonathan/appeals 51926 (#22215)
* Hide UI changes behind featureFlag * fixed lint spacing warnings
Configuration menu - View commit details
-
Copy full SHA for 550a0df - Browse repository at this point
Copy the full SHA 550a0dfView commit details
Commits on Jul 19, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 18af3ea - Browse repository at this point
Copy the full SHA 18af3eaView commit details -
Merge remote-tracking branch 'origin/kshiflett/APPEALS-48965' into fe…
…ature/APPEALS-28087-36678
Configuration menu - View commit details
-
Copy full SHA for bf1927d - Browse repository at this point
Copy the full SHA bf1927dView commit details -
Merge remote-tracking branch 'origin/cmartine/APPEALS-49863' into fea…
…ture/APPEALS-28087-36678
Configuration menu - View commit details
-
Copy full SHA for 0db023f - Browse repository at this point
Copy the full SHA 0db023fView commit details
Commits on Jul 22, 2024
-
code climate spec fix (#22211)
* code climate spec fix * up argument count * created a parser helper for reusable methods * reset codeclimate back to original and added issue parser * modified methods to take in a hash instead of multiple params * reduced create params down to 3 params * added space inside * swapped to safe navigator for intake check * fixed spec * fixed linting issue * fixed failing spec * fixed merge conflicts with code changes for helper --------- Co-authored-by: TuckerRose <tuckerrose@tuckerroses-mbp.lan> Co-authored-by: TuckerRose <tuckerrose@TuckerRoses-MacBook-Pro.local> Co-authored-by: Nader Kutub <nader.kutub@va.gov>
Configuration menu - View commit details
-
Copy full SHA for e87e141 - Browse repository at this point
Copy the full SHA e87e141View commit details
Commits on Jul 26, 2024
-
Configuration menu - View commit details
-
Copy full SHA for b28fb17 - Browse repository at this point
Copy the full SHA b28fb17View commit details
Commits on Aug 2, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 0439702 - Browse repository at this point
Copy the full SHA 0439702View commit details
Commits on Aug 6, 2024
-
Konstantin/appeals 52321 (#22363)
* utc conversion method added in app/serializers/api/v3/issues/ama/request_issue_serializer.rb * set_contested_rating_issue_profile_date method updated in RequestIssue model, updated contested_rating_issue_profile_date in DecisionIssue model * decision issue updated, tests added * tests added, converters improve app/models/decision_issue.rb app/serializers/api/v3/issues/ama/request_issue_serializer.rb * set_contested_rating_issue_profile_date restored in request issue model * uneccessary logic removed * 3 more tests added * test added, error handling aaded in format_rating_profile_date method * Update decision_issue.rb * Update request_issue.rb
Configuration menu - View commit details
-
Copy full SHA for 57b6f0b - Browse repository at this point
Copy the full SHA 57b6f0bView commit details
Commits on Aug 9, 2024
-
* wip * added the parser to skeleton * removed commented code * added in parser logic * added dru_error route, error handling and params * added rspecs and fixed routing for update error to be a post * added empty spec * updated dru params to match intake json * rubocop fixes * more rubocop fixes * fixed routing to post now and updated specs --------- Co-authored-by: TuckerRose <tuckerrose@tuckerroses-mbp.lan>
Configuration menu - View commit details
-
Copy full SHA for 7e3426e - Browse repository at this point
Copy the full SHA 7e3426eView commit details
Commits on Aug 12, 2024
-
fixed logic for AMA issues API serializer attributes (#22358)
* fixed logic for added_by fields * methods for fetching removed_by user * withdrawn_by methods * methods for edited_by & instance vars * more logic for added_by methods * fixed failing tests * rspec updates * rspec for RIU addition * small changes * fix test failure
Configuration menu - View commit details
-
Copy full SHA for d7df63a - Browse repository at this point
Copy the full SHA d7df63aView commit details
Commits on Aug 13, 2024
-
Configuration menu - View commit details
-
Copy full SHA for e7c97de - Browse repository at this point
Copy the full SHA e7c97deView commit details
Commits on Aug 22, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 56b3d09 - Browse repository at this point
Copy the full SHA 56b3d09View commit details
Commits on Aug 26, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 50bf288 - Browse repository at this point
Copy the full SHA 50bf288View commit details -
Configuration menu - View commit details
-
Copy full SHA for eb9c353 - Browse repository at this point
Copy the full SHA eb9c353View commit details -
Konstantin/appeals 52318 (#22528)
* very loose prototype of class created * hopeless variant removed * updated parser per new design and updated specs * request_issues_updated_event updated * some improvments added * unused methods removed, some methods updated * after issues added * tests added * edited issues method returned, invalid tests removed * tests updated * 9 working tests added, RequestIssuesUpdateEvent variable instanciated * tests improved, attribute writers added * more test cases added, error handling in process! method added * added new version of parser and tests to it from Will's PR * uneccesary overrided classes removed * process_job call removed * process_job! restored, 3 more tests added * validate before perfom removed * linter issues addressed * linter issues addressed2 --------- Co-authored-by: TuckerRose <tuckerrose@tuckerroses-mbp.lan>
Configuration menu - View commit details
-
Copy full SHA for c220984 - Browse repository at this point
Copy the full SHA c220984View commit details
Commits on Aug 28, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 06cc15a - Browse repository at this point
Copy the full SHA 06cc15aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 765c61b - Browse repository at this point
Copy the full SHA 765c61bView commit details -
Configuration menu - View commit details
-
Copy full SHA for f7cdc93 - Browse repository at this point
Copy the full SHA f7cdc93View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0be4bc6 - Browse repository at this point
Copy the full SHA 0be4bc6View commit details -
Configuration menu - View commit details
-
Copy full SHA for d874156 - Browse repository at this point
Copy the full SHA d874156View commit details
Commits on Aug 29, 2024
-
Bug Fix for APPEALS-44115 (#22538)
* running ci * testing category * ci with conditional * set back to false * reverted to original spec * running ci * updated intake helpers to account for using none of these match option * ignored metrics abc size * removed from helper * removed comments * updated spec to check on each category * removed single quotes * fixed a flakey test that was failing on a duplicate key * linting fix * pushed up feature flag * lint clean up * swapped to different featureflag * fixing spec feature toggle param * added feature flags back * checking if label is there * flipped feature test to correct order --------- Co-authored-by: TuckerRose <tuckerrose@TuckerRoses-MBP.lan>
Configuration menu - View commit details
-
Copy full SHA for e251441 - Browse repository at this point
Copy the full SHA e251441View commit details
Commits on Sep 6, 2024
-
* new service class & error message * rspec * Update update_informal_conference_spec.rb
Configuration menu - View commit details
-
Copy full SHA for 7b94448 - Browse repository at this point
Copy the full SHA 7b94448View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9507897 - Browse repository at this point
Copy the full SHA 9507897View commit details
Commits on Sep 9, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 052a707 - Browse repository at this point
Copy the full SHA 052a707View commit details -
Configuration menu - View commit details
-
Copy full SHA for 010beca - Browse repository at this point
Copy the full SHA 010becaView commit details -
Configuration menu - View commit details
-
Copy full SHA for 3456dd2 - Browse repository at this point
Copy the full SHA 3456dd2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 692be83 - Browse repository at this point
Copy the full SHA 692be83View commit details -
Konstantin/appeals 52982 (#22715)
* eligibility-related methods added * methods fixed, date conversion for closed_at added * decision_review_updated_issue_parser created, json example updated, request_issues_update_event updated * tests for parser fixed after json example update * new attribute vbms_id added to request_issues table, decision_review_updated_issue_parser update respectively * request_issues_update_event attr_writers added, decision_review_created_issue_parser class name update and call of that parser updated * veteran removed from DecisionReviewUpdatedParser initilizer, methods marked for potential deletion * decision_review_updated_issue_parser updated and test added for it, comments added to request_issues_update_event * not necessary methods removed from parser, tests for them commented out for now * attributes_from_intake_data method overrided * :id replced by vbms_id, json example, parsers and test for it updated * parsers added, test updated * css_id, station and detail_type commented from the parser * parser cleaned, test for parser fixed, request_issues_update_event cleaned * process_issues! overriden in app/models/request_issues_update_event.rb, linter offenses fixed, testtypo fixed * vbms_id renamed to reference_id * comment typo fixed
Configuration menu - View commit details
-
Copy full SHA for 21bc269 - Browse repository at this point
Copy the full SHA 21bc269View commit details
Commits on Sep 10, 2024
-
Create Audit Tables for SC, HLR, Request Issues Appeals 55403 (#22689)
* migration added * schema updated correctly * added audit service and call to update evenr records * logic for update type * fixed typo in audit file and added spec * added insert * moved Insert DRUA to create request issues for created ones * updated event record to take in update type * passing in correct info attribute now * disabled unused params, can enable once we use them * remove <<<head * updated migration and added request_issue to info json * fixed spec where created at and updated timestamps format was different --------- Co-authored-by: TuckerRose <tuckerrose@TuckerRoses-MBP.lan> Co-authored-by: TuckerRose <tuckerrose@TuckerRoses-MacBook-Pro.local>
Configuration menu - View commit details
-
Copy full SHA for bf435b4 - Browse repository at this point
Copy the full SHA bf435b4View commit details
Commits on Sep 12, 2024
-
Configuration menu - View commit details
-
Copy full SHA for ca3bc5c - Browse repository at this point
Copy the full SHA ca3bc5cView commit details -
Configuration menu - View commit details
-
Copy full SHA for bd8cc81 - Browse repository at this point
Copy the full SHA bd8cc81View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2704366 - Browse repository at this point
Copy the full SHA 2704366View commit details
Commits on Sep 17, 2024
-
Merge branch 'master' of https://github.com/department-of-veterans-af…
…fairs/caseflow into craig/metabase
Configuration menu - View commit details
-
Copy full SHA for 6727416 - Browse repository at this point
Copy the full SHA 6727416View commit details -
Konstantin/appeals 57291 (#22853)
* decision_review_created/decision_review_created_parser.rb updated * rspec tests for decision_review_created parser added * issue parser updated, tests added * decision review updated parsers updated, tests added * linter issue addressed
Configuration menu - View commit details
-
Copy full SHA for 64065e5 - Browse repository at this point
Copy the full SHA 64065e5View commit details -
Konstantin/appeals 57283 (#22851)
* reference_id added to parser, json example and create_request_issues.rb * rspec tests for decision_review_created_issue_parser created * reference_id null error handling added, tests for create_request_issues.rb added * linter offenses fixed * new param permitted added in app/controllers/api/events/v1/decision_review_created_controller.rb * feature tests fixed
Configuration menu - View commit details
-
Copy full SHA for 59dddbc - Browse repository at this point
Copy the full SHA 59dddbcView commit details -
* service class and error * adding to DRU class method * linter line too long fix * small fix to riue * added rspec * fixed typo
Configuration menu - View commit details
-
Copy full SHA for 21296e7 - Browse repository at this point
Copy the full SHA 21296e7View commit details
Commits on Sep 19, 2024
-
Konstantin/appeals 57279 (#22859)
* DecisionReviewUpdateMissingIssueError handling is created * initializer added, typos fixed in request_issues_update_event.rb,more error handlings added, tests updated and added * little optimizationd added to app/models/request_issues_update_event.rb * attributes_from_intake_data fixed * commented code removed * review defined in decision_review_updated.rb * formatted a bit * useless comments removed * linter offenses cleaned, useless comments removed * Update request_issues_update_event.rb Result of auto conflict resolution fixed * useless comment removed * Update decision_review_updated.rb Lines 21,22 uncommented. * rubocop disable/enable added * additional positive tests added, RequestIssuesUpdateEvent updated * 2 tests added * linter issue fixed
Configuration menu - View commit details
-
Copy full SHA for 85b2407 - Browse repository at this point
Copy the full SHA 85b2407View commit details -
Jonathan/appeals 58619 (#22875)
* service class and error * adding to DRU class method * linter line too long fix * small fix to riue * added rspec * fixed typo * Added new service class + fixed typo * typos * more typo fixes * additional fields to epe.update * updated sample payload * unit test + time conversion --------- Co-authored-by: Nader Kutub <nader.kutub@va.gov>
Configuration menu - View commit details
-
Copy full SHA for 8423ccc - Browse repository at this point
Copy the full SHA 8423cccView commit details
Commits on Sep 20, 2024
-
Merge branch 'master' of https://github.com/department-of-veterans-af…
…fairs/caseflow into craig/metabase
Configuration menu - View commit details
-
Copy full SHA for f19bab4 - Browse repository at this point
Copy the full SHA f19bab4View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2160f10 - Browse repository at this point
Copy the full SHA 2160f10View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1683aad - Browse repository at this point
Copy the full SHA 1683aadView commit details -
Process newly added fields passed for DecissionReviewUpdated (#22876)
* added parser changes * removed empty line * updated json to match updated design and removed unused methods * remove ep code category * removed unused methods * fixing specs and linting * linting fix * updated json example to match * added edited_description to spec * added new json payload changes that required spec updates * removed binding.pry --------- Co-authored-by: TuckerRose <tuckerrose@TuckerRoses-MBP.lan>
Configuration menu - View commit details
-
Copy full SHA for 82f03ac - Browse repository at this point
Copy the full SHA 82f03acView commit details -
Refactor Created Events Logic to Handle Contested Issues (#22852)
* wip * added check for contested with specs * removed newline * fixed contested setting to if not eligible and fixed specs * removed setter for contested --------- Co-authored-by: TuckerRose <tuckerrose@TuckerRoses-MBP.lan>
Configuration menu - View commit details
-
Copy full SHA for 88e146a - Browse repository at this point
Copy the full SHA 88e146aView commit details
Commits on Sep 23, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 666fcab - Browse repository at this point
Copy the full SHA 666fcabView commit details -
Configuration menu - View commit details
-
Copy full SHA for 8b85ec0 - Browse repository at this point
Copy the full SHA 8b85ec0View commit details -
* issue parser applied * refactor request_issues_update_event * refactor request_issues_update_event- remove temp files * fix lint issues * fix linting issues * fix eligibility fields * add gaurd for missing participant in request issues serializer * add description fields to eligibility updates * bug fixes with controller --------- Co-authored-by: Nader Kutub <nader@nkconsulting.net> Co-authored-by: Nader Kutub <nader.kutub@va.gov>
Configuration menu - View commit details
-
Copy full SHA for 9e99887 - Browse repository at this point
Copy the full SHA 9e99887View commit details -
renamed epe to singular method call (#22914)
Co-authored-by: TuckerRose <tuckerrose@TuckerRoses-MBP.lan>
Configuration menu - View commit details
-
Copy full SHA for f983a53 - Browse repository at this point
Copy the full SHA f983a53View commit details -
Configuration menu - View commit details
-
Copy full SHA for adc5648 - Browse repository at this point
Copy the full SHA adc5648View commit details -
Configuration menu - View commit details
-
Copy full SHA for b037c59 - Browse repository at this point
Copy the full SHA b037c59View commit details
Commits on Sep 24, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 09af622 - Browse repository at this point
Copy the full SHA 09af622View commit details -
Merge pull request #22903 from department-of-veterans-affairs/dev-sup…
…port/APPEALS-55109 APPEALS-55109: Demo data viewer (Metabase)
Configuration menu - View commit details
-
Copy full SHA for 07e2c50 - Browse repository at this point
Copy the full SHA 07e2c50View commit details
Commits on Sep 25, 2024
-
API fix + epe feature test (#22956)
* API fix + epe feature test * add specs --------- Co-authored-by: Nader Kutub <nader@nkconsulting.net>
Configuration menu - View commit details
-
Copy full SHA for 4d6af23 - Browse repository at this point
Copy the full SHA 4d6af23View commit details
Commits on Sep 27, 2024
-
Feature/appeals 59173 (#22995)
* fix bug reatletd to new issues * fix DRU bugs * fix linting issue * fix event records bug * fix event records spec
Configuration menu - View commit details
-
Copy full SHA for fd0efc0 - Browse repository at this point
Copy the full SHA fd0efc0View commit details -
hotfix/APPEALS-23420: search defect
Add search query service for the api response for the `/search` page Add issues to legacy appeals Add assigned_to_judge Use correct id for list of request issues export proper attributes for hearing
Configuration menu - View commit details
-
Copy full SHA for 25ed7f1 - Browse repository at this point
Copy the full SHA 25ed7f1View commit details -
Revert "hotfix/APPEALS-23420: search defect" (#23011)
This reverts commit 25ed7f1.
Configuration menu - View commit details
-
Copy full SHA for c231266 - Browse repository at this point
Copy the full SHA c231266View commit details
Commits on Sep 30, 2024
-
bug fixes for error logs, audits, claim id (#23015)
* bug fixes for error logs, audits, claim id * fix redi lock on created event
Configuration menu - View commit details
-
Copy full SHA for 994a815 - Browse repository at this point
Copy the full SHA 994a815View commit details -
add reference id to AMA API (#23022)
* add reference id to AMA API * add withdrawn audit * audit spec fix
Configuration menu - View commit details
-
Copy full SHA for ad05091 - Browse repository at this point
Copy the full SHA ad05091View commit details -
Konstantin/appeals 58609 (#22970)
* draft test * typo fixed, byebug inside find_or_build_request_issue_from_intake_data * typo fixed, edited_description added to attributes in app/controllers/api/events/v1/decision_review_updated_controller.rb * test file renamed * commented lines removed * Update spec_helper.rb * Update scenario_edited_issues_spec.rb typo * success message updated, any updates check added, edited_description before check added * audit find_by fix and add create scenario --------- Co-authored-by: Nader Kutub <nader.kutub@va.gov> Co-authored-by: Nader Kutub <nader@nkconsulting.net>
Configuration menu - View commit details
-
Copy full SHA for 3b9bd4b - Browse repository at this point
Copy the full SHA 3b9bd4bView commit details
Commits on Oct 1, 2024
-
Konstantin/withdrawn issues feature test (#23028)
* withdrawn feature test added * more checks added to test * temp change * request_issue.reload removed
Configuration menu - View commit details
-
Copy full SHA for ce4f9f6 - Browse repository at this point
Copy the full SHA ce4f9f6View commit details -
Configuration menu - View commit details
-
Copy full SHA for a3a2c02 - Browse repository at this point
Copy the full SHA a3a2c02View commit details -
Configuration menu - View commit details
-
Copy full SHA for 20498fb - Browse repository at this point
Copy the full SHA 20498fbView commit details -
Jonathan/appeals 59166 (#22972)
* feature test, update hlr/sc optin value * featuretoggle change * featuretoggle
Configuration menu - View commit details
-
Copy full SHA for 0a61c06 - Browse repository at this point
Copy the full SHA 0a61c06View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1cf5244 - Browse repository at this point
Copy the full SHA 1cf5244View commit details -
Merge
feature/APPEALS-41559
intorelease/FY24Q4.6.1
(#23036)* Start feature work tracking PR with a TODO comment * Remove TODO comment for CodeClimate * SeanC/APPEALS-42315 | Create separate Remand table, model and seed data (#22220) * added migration file for adding type column to supplemental claims table * created stub for remand model * added type to supplemental claim factory and new remand trait * added remand sc's to vha seeds * updated migration name and fixed typo * Changed migration to inherit from Caseflow::Mirgration * schema changes * reverting schema * changed the setting of the type column * fixed schema and renamed migration file * fixed migration and schema * updated the remands factory and seeds * fixed comment in schema --------- Co-authored-by: Robert Travis Pierce <robert@roberttravispierce.com> * TYLERB/APPEALS-42455: Display new and migrated Remands in Decision Review Queue tabs (#22206) * Added support for remands to the business_line.rb model and the index.js util file that parses the decision review type filters for the decision review queue. * Updated the business line spec file, the decision reviews controller spec tests, and the reviews spec feature test to support remands. * Added a decision review polymorphic helper to DRY up some of the polymorphic appeal concerns. * Overrode the remand model association to request issues so active record joins will work correctly. * Added another helper for sti polymorphic relationships. Fixed filtering for STI decision review types for remands. Updated tests and added factories for testing. * Code climate fixes and test fixes. * Fixed more test failures. Removed the remand request issues relationship since it was incorrectly implemented. Added a scope to supplemental claims for remands. Fixed an issue where board grant effectuation tasks without request issues were missing from the new task type count method. * Changed the UNION ALL to a UNION in the new task_type_count method to prevent duplicate row counts. Updated tests and fixed an issue where the board grant effectuation tasks were being counted for pending task queries. * JHoang/APPEALS-42318 (#22270) * some preliminary remand & sc model updates * typo * some preliminary hlr checks? * undo seed change * decision issue and sc updates * attempt code climate fixes * another code climate fix * testing changes * useless variable.. * fix conditional in decision issue * fix undefined find_by method * attempt rspec fix * rspec fix attempt #2 * supplemental_claim_spec fix? * remove comma * code climate fix * added comment for transparency on remand creation, attempt fix for remands route * updated specs for decision_issue, hlr_spec, appeal_spec to account for remand creation type * fix lint error * fix lint error #2 --------- Co-authored-by: Jonathan Hoang <trinhjoanthan.hoang@va.gov> * APPEALS-42458 (#22365) * disable edit issues link for remands * add banners explaining that remands are not editable also makes sure that remands are not editable on the edit issues page * TYLERB/APPEALS-44922: Update Generate task report page UI to include Remand in conditions (#22356) * Initial commit. Changed the DecisionReviewType condition filter to a searchable dropdown and added the remands option to it as well. Updated the report page filter parsing to work with the searchable dropdown instead of checkboxes for the decision review type condition filter. * Updated the ReportPage jest test and the report page feature test to work with the decision review type filter as a searchable dropdown instead of checkboxes. * SeanC/APPEALS-42317 | Migrate existing Supplemental Claim Remands to Remand records via script (#22359) * initial verison of update script * remanded migration file * updated sc spec with type * schema * fixed a few issues in the migration * small fix to migration file * moved the type column check into a seperate it block * fixed wrong column in migration file * created a new migration for creating the view * updated the backfill migration file --------- Co-authored-by: Brandon Lee Dorner <Brandondorner@yahoo.com> * J hoang/appeals 44940 (#22428) * initial * some factory and spec updates * change history query update and spec fixes * code climate/lint fix * change @claim_type identifier * fix claim_history_event_spec.rb * test coverage for change history with Remand claim type * spec lint fixes * refactor claim_type filtering to account for remand subtype * business_line_spec fix * decision_reviews_controller_spec update for remand claim type * lint fixes for decision_reviews_controller_spec.rb * comment updates in business_line.rb * renamed mock data in change_history_reporter_spec * trigger GA * refactor claim type filter for less conditional handling * business line spec fix --------- Co-authored-by: Jonathan Hoang <trinhjoanthan.hoang@va.gov> * Initial commit for the brakeman sql injection warning fixes. (#22598) * Updated the business line reporter class to properly display Remands as a seperate type than SupplementalClaims. Also added additional testing logic for the business line reporter for hlr and scs since it was only covering appeals. (#22664) Co-authored-by: Robert Travis Pierce <robert@roberttravispierce.com> * Fixed a bug where the frontend would error due to calling .toLowerCase() on a null or undefined value which could happen sometimes if the api filter options are in an incorrect state. (#22796) Co-authored-by: Robert Travis Pierce <robert@roberttravispierce.com> * Updated the remand migration files to work with the rails 6 upgrade and the changes to Caseflow::Migration. (#22825) * added fix for failing test in decision_reviews_controller_spec (#22829) --------- Co-authored-by: Robert Travis Pierce <Pierce_Robert@ne.bah.com> Co-authored-by: Sean Craig <110493538+seancva@users.noreply.github.com> Co-authored-by: Tyler Broyles <109369527+TylerBroyles@users.noreply.github.com> Co-authored-by: jonathanh-va <111081469+jonathanh-va@users.noreply.github.com> Co-authored-by: Jonathan Hoang <trinhjoanthan.hoang@va.gov> Co-authored-by: Brandon Lee Dorner <Brandondorner@yahoo.com> Co-authored-by: Clay Sheppard <csheepy@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 1a978f3 - Browse repository at this point
Copy the full SHA 1a978f3View commit details -
APPEALS-50679 | Reassign Cases To Camo Change History (#23038)
* Start feature work tracking PR with a TODO comment * Remove TODO comment for CodeClimate * SeanC/APPEALS-42315 | Create separate Remand table, model and seed data (#22220) * added migration file for adding type column to supplemental claims table * created stub for remand model * added type to supplemental claim factory and new remand trait * added remand sc's to vha seeds * updated migration name and fixed typo * Changed migration to inherit from Caseflow::Mirgration * schema changes * reverting schema * changed the setting of the type column * fixed schema and renamed migration file * fixed migration and schema * updated the remands factory and seeds * fixed comment in schema --------- Co-authored-by: Robert Travis Pierce <robert@roberttravispierce.com> * TYLERB/APPEALS-42455: Display new and migrated Remands in Decision Review Queue tabs (#22206) * Added support for remands to the business_line.rb model and the index.js util file that parses the decision review type filters for the decision review queue. * Updated the business line spec file, the decision reviews controller spec tests, and the reviews spec feature test to support remands. * Added a decision review polymorphic helper to DRY up some of the polymorphic appeal concerns. * Overrode the remand model association to request issues so active record joins will work correctly. * Added another helper for sti polymorphic relationships. Fixed filtering for STI decision review types for remands. Updated tests and added factories for testing. * Code climate fixes and test fixes. * Fixed more test failures. Removed the remand request issues relationship since it was incorrectly implemented. Added a scope to supplemental claims for remands. Fixed an issue where board grant effectuation tasks without request issues were missing from the new task type count method. * Changed the UNION ALL to a UNION in the new task_type_count method to prevent duplicate row counts. Updated tests and fixed an issue where the board grant effectuation tasks were being counted for pending task queries. * JHoang/APPEALS-42318 (#22270) * some preliminary remand & sc model updates * typo * some preliminary hlr checks? * undo seed change * decision issue and sc updates * attempt code climate fixes * another code climate fix * testing changes * useless variable.. * fix conditional in decision issue * fix undefined find_by method * attempt rspec fix * rspec fix attempt #2 * supplemental_claim_spec fix? * remove comma * code climate fix * added comment for transparency on remand creation, attempt fix for remands route * updated specs for decision_issue, hlr_spec, appeal_spec to account for remand creation type * fix lint error * fix lint error #2 --------- Co-authored-by: Jonathan Hoang <trinhjoanthan.hoang@va.gov> * APPEALS-42458 (#22365) * disable edit issues link for remands * add banners explaining that remands are not editable also makes sure that remands are not editable on the edit issues page * TYLERB/APPEALS-44922: Update Generate task report page UI to include Remand in conditions (#22356) * Initial commit. Changed the DecisionReviewType condition filter to a searchable dropdown and added the remands option to it as well. Updated the report page filter parsing to work with the searchable dropdown instead of checkboxes for the decision review type condition filter. * Updated the ReportPage jest test and the report page feature test to work with the decision review type filter as a searchable dropdown instead of checkboxes. * SeanC/APPEALS-42317 | Migrate existing Supplemental Claim Remands to Remand records via script (#22359) * initial verison of update script * remanded migration file * updated sc spec with type * schema * fixed a few issues in the migration * small fix to migration file * moved the type column check into a seperate it block * fixed wrong column in migration file * created a new migration for creating the view * updated the backfill migration file --------- Co-authored-by: Brandon Lee Dorner <Brandondorner@yahoo.com> * J hoang/appeals 44940 (#22428) * initial * some factory and spec updates * change history query update and spec fixes * code climate/lint fix * change @claim_type identifier * fix claim_history_event_spec.rb * test coverage for change history with Remand claim type * spec lint fixes * refactor claim_type filtering to account for remand subtype * business_line_spec fix * decision_reviews_controller_spec update for remand claim type * lint fixes for decision_reviews_controller_spec.rb * comment updates in business_line.rb * renamed mock data in change_history_reporter_spec * trigger GA * refactor claim type filter for less conditional handling * business line spec fix --------- Co-authored-by: Jonathan Hoang <trinhjoanthan.hoang@va.gov> * Initial commit for the brakeman sql injection warning fixes. (#22598) * Updated the business line reporter class to properly display Remands as a seperate type than SupplementalClaims. Also added additional testing logic for the business line reporter for hlr and scs since it was only covering appeals. (#22664) Co-authored-by: Robert Travis Pierce <robert@roberttravispierce.com> * Fixed a bug where the frontend would error due to calling .toLowerCase() on a null or undefined value which could happen sometimes if the api filter options are in an incorrect state. (#22796) Co-authored-by: Robert Travis Pierce <robert@roberttravispierce.com> * Updated the remand migration files to work with the rails 6 upgrade and the changes to Caseflow::Migration. (#22825) * added fix for failing test in decision_reviews_controller_spec (#22829) * Al/APPEALS-45335 (#22228) * added additional option to check box list * fixed some tests and code clean up * fixed more tests * fixed jest tests * changes per Pr feedback * added custom error display * fixed style for error message --------- Co-authored-by: Sean Craig <sean.craig2@va.gov> * adding logic to bring in issue-modification request and updating the … (#22238) * adding logic to bring in issue-modification request and updating the csv logic * refactor logic to get pending status and null to request addition * pending status filter work fixing * adding withdrawal date and adding logic to display request issue components * getting edit of request rows and fixing cancelled data * fixing linter and fixing the query to make test happy * fixing specs failures * removing byebug * removing frontend changes, adding test, fixing the query to replace higherlevel review,adding new field in serializer * making code climate happy by doing some minor refactor * fixing the serializer spec failure * After merging APPEALS-45335, filter for Requested issues were broken, so refactored it and removed the unnecessary methood that i created * fixing code climate and spec was failing because of hard coded date * refactor the edit of request logic to take from version, refactored business line query to remove coalesce and fix test * fixing codeclimate, remove unnecessary field * refactor to make first comment appear first in edit of request * fixing linter issue, spec and refactor to fix the bug * fixing pending status filter issue and adding test for business line * fixing broken spec failure * adding user facilty * fixing the lead and lag function to prevent entry of pending status multiple times * fixing an issue in which in progress event was not being made * adding decision reason that was missed and fixing the event logic one more time * fixing the multiple issue modification request after decision has been made * refactor inprogress logic for approved data * fixing spec failure * fixing the first version logic to be more simpler and fixing name and adding spec * fixing more inprogess event * removing the disabled complexity and taking out the boolean condition to a separate method * Al/APPEALS-45334 Individual change history table which includes Reassign Cases to CAMO events (#22483) * added logic for claim history events table * fixed linting errors * fixing test failures * added change Pr feedback * PR feedback round 2 * changes from round 2 of PR feedback * Added logic event data versions and tests to cover more edgecases * changed RequestedIssueFragment * Updated the individual claim history spec file for test failures. Updated an attribute in the IndividualClaimHistory page that was using the wrong getter. Fixed a code climate linting error. * Removing unnecessary clear filter * Combined some of the individual claim history tests into one test so it will run more quickly. * fixing the withdrawal date versioning issue for different level changes * fixing the spec failure and linter --------- Co-authored-by: Brandon Lee Dorner <Brandondorner@yahoo.com> Co-authored-by: = <tyler.broyles@va.gov> Co-authored-by: Prajwal Amatya <pamatya@take2it.com> * TYLERB/APPEALS-57367: change-history-updates (#22479) * Initial commit with new tests cases for issue modification requests for change history. * Added two cte queries to the business line change history query to properly work with a lead for the issue modification requests. Added new methods into the claim history event to work with this new lead and modified the existing issue modification in progress and pending event generation methods to better reflect the state of a claim that is going through the issue modficiation process. * Cleaned up unused code and todos. * Updated the claim history event create_imr_in_progress_status_event? with even more logic and edge cases. * Fixed a possible error when with a greater than operator could be used on a null value. * Fixed a few rspec tests. * Renamed a method and fixed a few code climate issues. * Fixed a bug in event status generation if there is a task with versions but no versions that change status. * Updated tests to work with new logic and remove a todo statement. * Fixed code complexity warnings. * Updated serializer spec to work with the bug fix. * Adjusted the pending method to prevent possible race conditions. * Fixed a bug where the incorrect decision event user would be shown for an issue modification request creation if the request has been decided when it should be the requestor as the event user. * Added the correct css ids to a few IMR change history events so that the filtering would work correctly. Also added some additional sql to properly filter based on css id and station id for requestor and decider joins. * Updated the IMR business line logic so that the decided at fields would always account for cancelled status since it uses updated at instead of decided at to determine when the IMR was closed. Fixed a bit of logic in the claim history event IMR in progress event generation to work another edge case. * Added in previous IMR edit versions for displaying it to the user. * Added a test for the change history service class to verify that request edit events have the correct attributes from the previous edits. * Fixed a typo for one of the table aliases in the business line query. * Fixed another typo where the facilities filter was using css id instead of station id from a copy/paste error. * adding changes for previous state array and some test modification * adding test for previous data * Fixed some outstanding test failures. * Fixed a linting error. Removed some duplicated code that happened when merging in the feature branch. Updated a factorybot method that was causing tests to fail. * Fixed a few code climate warnings. * Removed some puts statements in the individual claim history feature test. --------- Co-authored-by: Prajwal Amatya <pamatya@take2it.com> * TYLERB/APPEALS-58656: Change History CSV and Version Parsing fix (#22874) * Fixed a modification request claim history in progress event generation bug that could occur when 3-4 pending requests were all created at the same time and then later cancelled at the same time. Also fixed an issue count bug used when building the issue type filter due to additional duplicate rows being inserted into issue type count query due to the left join to the issue modification requests table. * Altered the version parsing for change history to work with commas in the version strings since that was causing parsing errors. Altered the business line query to use '|||' as a delimeter instead of comma and also changed the array_agg functions to string agg to avoid the '{}' array type casting that was happening between postgres and rails. Updated tests to work with this new parsing. * Updated vha seed data to have associations to intake data so those seeded claims can correctly generate change history. * TYLERB/CHANGE-HISTORY-YAML-QUOTE-FIX (#22910) * Made an update to the claim history parse versions method to work with double quotations after the array_agg to string_agg change. * Updated the tests to work with the new string agg and version parsing method. * Skip flakey tests These are possibly flakey now due to the rails upgrade. We can come back and fix these once the work has been confirmed in UAT. * Add rubocop disables for line length These should be removed when the skips are removed. * Updated the report_page feature test to reduce flakyness in github actions. Also updated the DownloadHelpers module. --------- Co-authored-by: Brandon Dorner <brandonleedorner@gmail.com> --------- Co-authored-by: Robert Travis Pierce <Pierce_Robert@ne.bah.com> Co-authored-by: Robert Travis Pierce <robert@roberttravispierce.com> Co-authored-by: Sean Craig <110493538+seancva@users.noreply.github.com> Co-authored-by: Tyler Broyles <109369527+TylerBroyles@users.noreply.github.com> Co-authored-by: jonathanh-va <111081469+jonathanh-va@users.noreply.github.com> Co-authored-by: Jonathan Hoang <trinhjoanthan.hoang@va.gov> Co-authored-by: Clay Sheppard <csheepy@gmail.com> Co-authored-by: almorbah <149511814+almorbah@users.noreply.github.com> Co-authored-by: Sean Craig <sean.craig2@va.gov> Co-authored-by: Prajwal Amatya <122557351+pamatyatake2@users.noreply.github.com> Co-authored-by: = <tyler.broyles@va.gov> Co-authored-by: Prajwal Amatya <pamatya@take2it.com>
Configuration menu - View commit details
-
Copy full SHA for 170c1f1 - Browse repository at this point
Copy the full SHA 170c1f1View commit details -
APPEALS-54874: Update PG and Ruby-oci8 gems (#23041)
* update minimum version in gemfile and ran bundle install (#22503) * require ruby-oci8 in config/boot.rb to fix SIGV fault
Configuration menu - View commit details
-
Copy full SHA for 6736427 - Browse repository at this point
Copy the full SHA 6736427View commit details -
APPEALS-59294: Hearings seed file is creating DistributionTasks for l…
…egacy appeals (#23042) * set parent task for legacy appeal hearing tasks to root task * fix whitespace issue
Configuration menu - View commit details
-
Copy full SHA for 53e306b - Browse repository at this point
Copy the full SHA 53e306bView commit details -
APPEALS-36292: Conditionally render banner alerts based on which envi…
…ronment it is deployed on (#23040) * Conditionally render alerts based on which environment is deployed * setting Env alert banner sitewide * separate colors for different envs using the same alert type * lighter reds for prodtest alert so the text is more readable * give demo banner more contrast * adjust specific language for demo env * adjust logic to accept proper env var. Add style for preprod (yellow) * isolate env alert styles * remove duplicate 'demo' Alert * remove development env banner to fix tests * making conditional logic a little more bulletproof against 'production' * update CaseWorkerIndex snapshot * fix env var * update snapshot from hard 'uat' setting * conditionally render env alert on only the home page * sticky env header statuses * getting development alert banners to work * target correct frontend dependency for NavigationBar changes * connecting new frontend package with better prod exclusion logic * make the prodtest env badge a more readable color * cleaning up testing code * fix linting issues * Remove unnecessary space * new NavigationBar update * yarn install of new FE dependency * remove extra package.json * remove development env logic due to NODE_ENV bug * fixing broken logo link padding and colors * hardening logic to exclude other inputs * correcting operator logic * remove testing var * point caseflow-frontend to master * point at most recent caseflow-frontend master * linting issues fix * update Route and CaseWorker snapshot * update snapshot for process.env.DEPLOY_ENV --------- Co-authored-by: Sean Parker <Sean.Parker3@va.gov>
Configuration menu - View commit details
-
Copy full SHA for 23231f6 - Browse repository at this point
Copy the full SHA 23231f6View commit details
Commits on Oct 2, 2024
-
Master to Main documentation changes (#23034)
* Update WINDOWS_11.md replacing master with main * References to master are changed to main where applicable
Configuration menu - View commit details
-
Copy full SHA for 33d56fd - Browse repository at this point
Copy the full SHA 33d56fdView commit details -
fix DRU removed and DRUs for eventing feature, added feature tests an… (
#23055) * fix DRU removed and DRUs for eventing feature, added feature tests and RIUs checks * fix linting errors * fix mutex error spec * lint fixes
Configuration menu - View commit details
-
Copy full SHA for ed30075 - Browse repository at this point
Copy the full SHA ed30075View commit details -
* adds script and tests for the script * adjust the way scheduled_for is created since the previous method was removed * refactor some of the script * rename test file to include _spec * Empty-Commit --------- Co-authored-by: Zackary Borges-Rowe <borges-rowe_zackary@bah.com> Co-authored-by: Raymond Hughes <131811099+raymond-hughes@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for 2db0bfd - Browse repository at this point
Copy the full SHA 2db0bfdView commit details
Commits on Oct 3, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 381a3b5 - Browse repository at this point
Copy the full SHA 381a3b5View commit details -
Merge pull request #23057 from department-of-veterans-affairs/release…
…/FY24Q4.6.1 Release R2.6.0 FY24Q4.6.0
Configuration menu - View commit details
-
Copy full SHA for 2d6af31 - Browse repository at this point
Copy the full SHA 2d6af31View commit details -
Configuration menu - View commit details
-
Copy full SHA for 04d88cb - Browse repository at this point
Copy the full SHA 04d88cbView commit details
Commits on Oct 4, 2024
-
Merge pull request #23076 from department-of-veterans-affairs/revert-…
…23057-release/FY24Q4.6.1 Revert "Release R2.6.0 FY24Q4.6.0"
Configuration menu - View commit details
-
Copy full SHA for 4c28ecd - Browse repository at this point
Copy the full SHA 4c28ecdView commit details -
* remove sync attemps on RequestIssuesUpdateEvent and add auditing, fix nil discription * add audit record check on add issue scenario spec * fix changes? call * ermove audit mock * fix HIGHER_LEVEL_REVIEW check * Revert "fix HIGHER_LEVEL_REVIEW check" This reverts commit 1499727.
Configuration menu - View commit details
-
Copy full SHA for d6588ed - Browse repository at this point
Copy the full SHA d6588edView commit details -
Konstantin/appeals 59181 (#22992)
* eligible to ineligible test added * eligible_to_ineligible test added * one added, 2 updated * empty line removed * spec_helper restored * success message updated * empty line removed * succes message expectation update in tests * wording updated * typo fixed * linter addressed * scenario_create_issues_spec.rb deleted, it was an invalid draft accidently pushed in previous PR
Configuration menu - View commit details
-
Copy full SHA for 036520b - Browse repository at this point
Copy the full SHA 036520bView commit details -
add last sync to RIU's, update contention updated and remoted at , ac… (
#23092) * add last sync to RIU's, update contention updated and remoted at , account for CF intaked RIs based on original_casflow_request_issue_id * fix rspec * fix discription texts * fix missing descriptions
Configuration menu - View commit details
-
Copy full SHA for 3cf76d8 - Browse repository at this point
Copy the full SHA 3cf76d8View commit details
Commits on Oct 6, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 7b1d7c6 - Browse repository at this point
Copy the full SHA 7b1d7c6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 25b0668 - Browse repository at this point
Copy the full SHA 25b0668View commit details
Commits on Oct 7, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 2e3fbbb - Browse repository at this point
Copy the full SHA 2e3fbbbView commit details
Commits on Oct 8, 2024
-
fix the unidentified_text and contention_refference_id (#23119)
* fix the unidentified_text and contention_refference_id * fix rspec and lint
Configuration menu - View commit details
-
Copy full SHA for 851849c - Browse repository at this point
Copy the full SHA 851849cView commit details -
Merge remote-tracking branch 'origin/prodtest/FY24Q4.6.0' into featur…
…e/APPEALS-49670-uat-merge
Configuration menu - View commit details
-
Copy full SHA for 684e4d1 - Browse repository at this point
Copy the full SHA 684e4d1View commit details