Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Claim Evidence API Error Logging #23304

Merged
merged 4 commits into from
Oct 22, 2024

Conversation

tradesmanhelix
Copy link
Contributor

Resolves Create/Improve Caseflow Error Logging

Description

  • Updates Caseflow to send improved logging data on Claim Evidence API error.
  • Updates specs and supporting classes accordingly.

Acceptance Criteria

  • All specs passing

Testing Plan

  1. Run specs for changed files:
  • bundle exec rspec spec/services/external_api/vbms_service_spec.rb

Update the VBMSService and SensitivityChecker clases to use the
new ClaimEvidenceApiErrorHandler service.
@youfoundmanesh youfoundmanesh merged commit d3adb19 into current-user-mgmt Oct 22, 2024
12 of 14 checks passed
@tradesmanhelix tradesmanhelix deleted the asmith/APPEALS-60001 branch October 24, 2024 13:36
youfoundmanesh pushed a commit that referenced this pull request Oct 25, 2024
* Add CE API Error Handler Class

* Add Error Handling

Update the VBMSService and SensitivityChecker clases to use the
new ClaimEvidenceApiErrorHandler service.

* Add Specs

* Fix Lint Errors and Spec Failures
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants