Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tylerb/appeals 56610: Updates to 56610 #23344

Merged
merged 28 commits into from
Oct 25, 2024

Commits on Oct 7, 2024

  1. Initial commit that alters the business line logic to accept a date f…

    …ilter for the tasks completed at column and logic to support and filter by it via the database query.
    TylerBroyles committed Oct 7, 2024
    Configuration menu
    Copy the full SHA
    4904fe6 View commit details
    Browse the repository at this point in the history

Commits on Oct 8, 2024

  1. Added new tests for the tasksClosedAt filter to the business line spe…

    …c. Adjusted the between lambda filter to work for either ordering of the start date or end date as the first chronological date in the query. Optimized the business line spec by swapping to before all loops and instance variables to shorten the time it takes to run the test.
    TylerBroyles committed Oct 8, 2024
    Configuration menu
    Copy the full SHA
    bb81840 View commit details
    Browse the repository at this point in the history
  2. Rewrote a bit more of the business line spec to speed it up via one t…

    …ime test data setup rather than for each test.
    TylerBroyles committed Oct 8, 2024
    Configuration menu
    Copy the full SHA
    e1c84ce View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    54b9fe8 View commit details
    Browse the repository at this point in the history
  4. Removed some commented out code and changed the database cleaner to T…

    …ask.delete all to be a bit more specific on cleanup before the change history tests.
    TylerBroyles committed Oct 8, 2024
    Configuration menu
    Copy the full SHA
    c6e92e3 View commit details
    Browse the repository at this point in the history

Commits on Oct 9, 2024

  1. Configuration menu
    Copy the full SHA
    417c4db View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    3155ebc View commit details
    Browse the repository at this point in the history

Commits on Oct 10, 2024

  1. Configuration menu
    Copy the full SHA
    a091395 View commit details
    Browse the repository at this point in the history
  2. Updated the wording in the filter summary for the closedAt filter to …

    …say Date Compeleted instead of closedAt.
    TylerBroyles committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    f4b22cc View commit details
    Browse the repository at this point in the history
  3. Fixed a bug where the filter preservation was not working with the wa…

    …y the date filter params were added to the get params. Altered the Completed tasks tab description based on the Date Completed filter. Started adding a feature test for the completed date filtering.
    TylerBroyles committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    a81a22c View commit details
    Browse the repository at this point in the history

Commits on Oct 11, 2024

  1. Updated the formatting of the date in the completed tasks tab descrip…

    …tion to match mm/dd/yyyy format. Finished up the feature spec test for the completed date filtering.
    TylerBroyles committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    fce21a7 View commit details
    Browse the repository at this point in the history

Commits on Oct 22, 2024

  1. Configuration menu
    Copy the full SHA
    2d21542 View commit details
    Browse the repository at this point in the history
  2. Updated the expected values from the DatePicker to match what was in …

    …the feature branch. Updated the completed tasks tab description to once again be last 7 days for any business line that is not the VHA. Fixed a code climate issue with the new regex used for the filter preservation hook. Updated the new vha completed by date column to match the old column value so sorting and filtering will work correctly.
    TylerBroyles committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    8a862dd View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    528221b View commit details
    Browse the repository at this point in the history
  4. Fixed failing tests related to the completed date column, completed t…

    …asks description, and the clear filters change from the DatePicker.
    TylerBroyles committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    f7cc3c6 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    ed56d30 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    0b59585 View commit details
    Browse the repository at this point in the history

Commits on Oct 23, 2024

  1. Configuration menu
    Copy the full SHA
    5dda70a View commit details
    Browse the repository at this point in the history
  2. Altered the date picker validation code to disable the button if no d…

    …ate is selected for on, before, or after.
    TylerBroyles committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    c2c1ce8 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    a3281eb View commit details
    Browse the repository at this point in the history
  4. Updated the completed tasks tab description filtered by completed tex…

    …t to be less verbose. Change .nil? to .blank? in the closed_at filter parsing. Updated the test to reflect the new wording.
    TylerBroyles committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    5c48b00 View commit details
    Browse the repository at this point in the history

Commits on Oct 24, 2024

  1. Configuration menu
    Copy the full SHA
    8f9f74d View commit details
    Browse the repository at this point in the history
  2. Updated the Completed Cases text to contain no colon for the vha deci…

    …sion review queue. Fixed a bug in the date picker where the View All was not resetting the filter correctly.
    TylerBroyles committed Oct 24, 2024
    Configuration menu
    Copy the full SHA
    77465a5 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    3a944ae View commit details
    Browse the repository at this point in the history
  4. Fixed a few jest tests.

    TylerBroyles committed Oct 24, 2024
    Configuration menu
    Copy the full SHA
    5e2ac1a View commit details
    Browse the repository at this point in the history
  5. Fixed a bug that could occur if you are trying to filter by a column …

    …that does not exist in a different queue.
    TylerBroyles committed Oct 24, 2024
    Configuration menu
    Copy the full SHA
    c1fe72d View commit details
    Browse the repository at this point in the history

Commits on Oct 25, 2024

  1. Configuration menu
    Copy the full SHA
    69655fc View commit details
    Browse the repository at this point in the history
  2. Fixed a text issue when swapping between business lines with the same…

    … user that has a filter from the vha business line.
    TylerBroyles committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    e6f04e1 View commit details
    Browse the repository at this point in the history