Create a join model for request issues and decision issues #7886
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
pkarman
approved these changes
Nov 16, 2018
app/models/rating_issue.rb
Outdated
| @@ -47,14 +47,20 @@ def save_decision_issue | |||
| # if a DecisionIssue already exists then do not touch it. These should be immutable. | |||
| return if decision_issue | |||
|
|
|||
| DecisionIssue.create!( | |||
| created_decision_issue = DecisionIssue.create!( | |||
There was a problem hiding this comment.
we probably want to wrap the 2 create calls in a transaction
| create_table :request_decision_issues do |t| | ||
| t.integer :request_issue_id | ||
| t.integer :decision_issue_id | ||
| t.timestamps |
There was a problem hiding this comment.
just an observation that we haven't consistently used the AR timestamps on our models. I like doing it, and maybe we should formally endorse that pattern system-wide.
There was a problem hiding this comment.
I always add these. I think they are useful.
anyakhvost
added
the
Ready-to-Merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the first PR for #7884
Description