Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[VA-11537] Add feedback button to redesigned homepage #1384

Merged
merged 1 commit into from
Dec 2, 2022

Conversation

maxx1128
Copy link
Contributor

@maxx1128 maxx1128 commented Nov 30, 2022

Description

The redesigned homepage needs the feedback button to be implemented the same way as the current homepage and stay accessible.

closes #11537
relates to #11570

Testing done & Screenshots

Visual testing

Screen Shot 2022-11-30 at 9 59 57 AM

QA steps

What needs to be checked to prove this works?

  1. Check out this branch and do a local PR build
  2. Go to http://localhost:3002/new-home-page/
  3. Confirm that the feedback button is present, working, and accessible

What needs to be checked to prove it didn't break any related things?

  1. Check that all other links and functionality on the new homepage still work
  2. Check that the current homepage still works

What variations of circumstances (users, actions, values) need to be checked?

  1. Different screen sizes
    • View the page on small and big screen sizes to confirm the button is still there and reachable
  2. Screen reader usage
    • Access the button with a screen reader and confirm its functionality is still understandable and it can be used
  3. Screen zooming in and out
    • Zoom in up to 400% and see the button can still be reached

Acceptance criteria

  • The new homepage has the same feedback button as the existing one
  • The new homepage feedback button is properly styled like the mockups
  • The new homepage button is accessible

Definition of done

  • Events are logged appropriately
  • Documentation has been updated, if applicable
  • A link has been provided to the originating GitHub issue (or connected to it via ZenHub)
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs

@maxx1128 maxx1128 requested review from a team as code owners November 30, 2022 15:45
Copy link
Contributor

@apisandipas apisandipas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good to me.

@jilladams
Copy link
Contributor

Feedback button looks good, presents same as on current live homepage, submits successfully. Merging.

@jilladams jilladams merged commit a8474df into main Dec 2, 2022
@jilladams jilladams deleted the VA-11537-new-homepage-feedback-button branch December 2, 2022 22:28
@jilladams
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Redesigned homepage - implement feedback button for launch
3 participants