All Workflows Use ASG Self-Hosted Runners #1496
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
va-vfs-bot
temporarily deployed
to
master/main/eo-content-release-use-asg-runners
va-vfs-bot
temporarily deployed
to
master/main/eo-content-release-use-asg-runners
va-vfs-bot
temporarily deployed
to
master/main/eo-content-release-use-asg-runners
va-vfs-bot
temporarily deployed
to
master/main/eo-content-release-use-asg-runners
va-vfs-bot
temporarily deployed
to
master/main/eo-content-release-use-asg-runners
…runners exclusively.
va-vfs-bot
temporarily deployed
to
master/main/eo-content-release-use-asg-runners
olivereri
changed the title
va-vfs-bot
temporarily deployed
to
master/main/eo-content-release-use-asg-runners
va-vfs-bot
temporarily deployed
to
master/main/eo-content-release-use-asg-runners
timcosgrove
approved these changes
Mar 6, 2023
olivereri
added a commit
that referenced
this pull request
Mar 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The Content-Release workflow depends on self-hosted runners that were created, on-demand, by a third-party Github Action (GHA). This action failed to deregister, stop, and terminate on-demand instances leading to 127 EC2 instances accumulating in the DSVA AWS account. It is estimated to currently cost the Department of Veteran Affairs over $94,909 dollars a month. Migrating the content-release workflow to use Auto-Scaling Group (ASG) created runners prevents the creation of new on-demand runners.
Furthermore, all other content-build related workflows that use self-hosted GHA runners are set to explicitly use ASG runners. This will prevent workflows from running on existing registered on-demand runners and allow of the completion of this clean-up ticket.
closes:
department-of-veterans-affairs/va.gov-cms#11402
department-of-veterans-affairs/va.gov-team#44319
relates
department-of-veterans-affairs/va.gov-cms#11405
department-of-veterans-affairs/va.gov-team#50148
department-of-veterans-affairs/va.gov-cms#12435
Testing done & Screenshots
Content-Release build phase is using an ASG hosted run, and successfully checks out repository code without error.
QA steps
What needs to be checked to prove this works?
Content-Build GHA workflows continue to work normally.
What needs to be checked to prove it didn't break any related things?
Content-build repo Github Action workflows.
Acceptance criteria