Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integration branch for Form Engine POC #2233

Merged
merged 2 commits into from
Sep 24, 2024
Merged

Integration branch for Form Engine POC #2233

merged 2 commits into from
Sep 24, 2024

Conversation

ryguyk
Copy link
Contributor

@ryguyk ryguyk commented Aug 10, 2024 •
edited
Loading

Summary

This PR tracks an integration branch for the Form Engine proof of concept.

Individual PRs merged into this integration branch:

Related issue(s)

Proof-of-Concept epic

Indivudal issues

Testing done/QA Steps

Unit tests added for individual PRs.

Manual smoke tests to ensure expected new behavior and existing behavior:
Note: This must be done locally or on a Tugboat environment where Digital Node content type exists.

  • Ensure expected behavior when Digital Form nodes are present
    • Create at least one Digital Form node
    • Run build
    • Ensure data/cms/digital-forms.json exists and has data
  • Ensure expected behavior when no Digital Form nodes exist
    • Remove all Digital Form nodes
    • Run build
    • Ensure no errors are thrown and build completes
    • Ensure data/cms/digital-forms.json exists but has empty data set

Screenshots

N/A

What areas of the site does it impact?

This code creates a new KISS data file. It should not impact any other areas.

Acceptance criteria

Manual test/QA steps are completed.

Quality Assurance & Testing

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Linting warnings have been addressed
  • Documentation has been updated (link to documentation *if necessary)
  • Screenshot of the developed feature is added
  • Accessibility testing has been performed

Error Handling

  • Browser console contains no warnings or errors.
  • Events are being sent to the appropriate logging solution
  • Feature/bug has a monitor built into Datadog or Grafana (if applicable)

Authentication

  • Did you login to a local build and verify all authenticated routes work as expected with a test user

Requested Feedback

None

@va-vfs-bot va-vfs-bot requested a review from a team August 10, 2024 12:52
va-vfs-bot
va-vfs-bot reviewed Aug 10, 2024
View reviewed changes
Copy link
Collaborator

@va-vfs-bot va-vfs-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ESLint is disabled

vets-website uses ESLint to help enforce code quality. In most situations we would like ESLint to remain enabled.

What you can do

See if the code can be refactored to avoid disabling ESLint, or wait for a VSP review.

src/site/stages/build/drupal/static-data-files/config.unit.spec.js
@@ -0,0 +1,15 @@
/* eslint-disable @department-of-veterans-affairs/axe-check-required */
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ESLint disabled here

...stages/build/drupal/static-data-files/digitalForm/fragments/digitalForm.graphql.unit.spec.js
@@ -0,0 +1,21 @@
/* eslint-disable @department-of-veterans-affairs/axe-check-required */
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ESLint disabled here

...build/drupal/static-data-files/digitalForm/fragments/nameAndDateOfBirth.graphql.unit.spec.js
@@ -0,0 +1,14 @@
/* eslint-disable @department-of-veterans-affairs/axe-check-required */
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ESLint disabled here

src/site/stages/build/drupal/static-data-files/digitalForm/index.unit.spec.js
@@ -0,0 +1,52 @@
/* eslint-disable @department-of-veterans-affairs/axe-check-required */
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ESLint disabled here

src/site/stages/build/drupal/static-data-files/digitalForm/postProcessDigitalForm.unit.spec.js
@@ -0,0 +1,180 @@
/* eslint-disable @department-of-veterans-affairs/axe-check-required */
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ESLint disabled here

@va-vfs-bot va-vfs-bot temporarily deployed to master/main/integration-form-engine-poc August 10, 2024 12:55 Inactive
@ryguyk ryguyk force-pushed the integration-form-engine-poc branch from 870ea49 to aeb51af Compare August 26, 2024 16:27
@va-vfs-bot va-vfs-bot temporarily deployed to master/main/integration-form-engine-poc August 26, 2024 16:32 Inactive
@ryguyk ryguyk changed the title DNM: Integration branch for Form Engine POC Integration branch for Form Engine POC Sep 4, 2024
@ryguyk ryguyk marked this pull request as ready for review September 4, 2024 14:09
@ryguyk ryguyk requested review from a team as code owners September 4, 2024 14:09
eselkin
eselkin approved these changes Sep 4, 2024
View reviewed changes
Copy link
Contributor

@eselkin eselkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. You even test that the graphql strings have correct content. Excellent.

@va-vfs-bot va-vfs-bot temporarily deployed to master/main/integration-form-engine-2 September 4, 2024 18:46 Inactive
derekhouck and others added 2 commits September 18, 2024 10:45
@derekhouck @ryguyk
VATEAM-87714: Add KISS configuration for Digital Forms (#2213)
66f5048 
* Create postProcessDigitalForm function

* Add nameAndDateOfBirth fragment

* Create digitalForm GraphQL fragment

* Import nameAndDateOfBirth into digitalForm fragment

* Create digitalForm query object

* Import digitalForm fragment into query object

* Export postProcessDigitalForm as postProcess

* Add Digital Forms to DATA_FILES array

* Fix module imports

* Fix typo

* Adds blank line for consistent spacing.

---------

Co-authored-by: Ryan Koch <ryan.koch.0213@gmail.com>
@derekhouck @ryguyk
VATEAM-88634: Create a normalization layer for Digital Forms (#2215)
e3d84e6 
* Add normalizeForms step to postProcessDigitalForm

* Add subtitle to normalized form

* Add OMB Number to normalized form

* Normalize chapters for each form

* Add additional fields for Name and Date of Birth step

* Fix import spec

* Remove redundant JSON parsing

* Remove JSON conversion from returned value

* Add formID and rename id to cmsId

* Remove subTitle

* Refactor normalizeForms method

* Refactor normalizeChapters

* Defend against malformed query responses

* Remove unused import
@va-vfs-bot va-vfs-bot temporarily deployed to master/main/integration-form-engine-2 September 18, 2024 16:03 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to master/main/integration-form-engine-2 September 20, 2024 19:07 Inactive
@ryguyk ryguyk merged commit 1a911f0 into main Sep 24, 2024
39 of 42 checks passed
@ryguyk ryguyk deleted the integration-form-engine-poc branch September 24, 2024 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@va-vfs-bot va-vfs-bot va-vfs-bot left review comments

@eselkin eselkin eselkin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ryguyk @eselkin @va-vfs-bot @derekhouck