DNM: Integration form engine 2 #2273

ryguyk · 2024-09-16T16:04:32Z

DO NOT MERGE

Individual PRs:

Note: Delete the description statements, complete each step. None are optional, but can be justified as to why they cannot be completed as written. Provide known gaps to testing that may raise the risk of merging to production.

Summary

(Summarize the changes that have been made to the platform)
(If bug, how to reproduce)
(What is the solution, why is this the solution)
(Which team do you work for, does your team own the maintenance of this component?)
(If using a flipper, what is the end date of the flipper being required/success criteria being targeted)

Related issue(s)

Link to ticket created in va.gov-team repo
department-of-veterans-affairs/va.gov-team#0000
Link to previous change of the code/bug (if applicable)
department-of-veterans-affairs/vets-website#0000
Link to epic if not included in ticket
department-of-veterans-affairs/va.gov-team#0000

Testing done

Describe what the old behavior was prior to the change
Describe the steps required to verify your changes are working as expected
Describe the tests completed and the results
_Exclusively stating 'Specs and automated tests passing' is NOT acceptable as appropriate testing
Optionally, provide a link to your test plan and test execution records

Screenshots

Note: This field is mandatory for UI changes (non-component work should NOT have screenshots).

	Before	After
Mobile
Desktop

What areas of the site does it impact?

(Describe what parts of the site are impacted if code touched other areas)

Acceptance criteria

Quality Assurance & Testing

I fixed|updated|added unit tests and integration tests for each feature (if applicable).
No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
Linting warnings have been addressed
Documentation has been updated (link to documentation *if necessary)
Screenshot of the developed feature is added
Accessibility testing has been performed

Error Handling

Browser console contains no warnings or errors.
Events are being sent to the appropriate logging solution
Feature/bug has a monitor built into Datadog or Grafana (if applicable)

Authentication

Did you login to a local build and verify all authenticated routes work as expected with a test user

Requested Feedback

(OPTIONAL) What should the reviewers know in addition to the above. Is there anything specific you wish the reviewer to assist with. Do you have any concerns with this PR, why?

* Create postProcessDigitalForm function * Add nameAndDateOfBirth fragment * Create digitalForm GraphQL fragment * Import nameAndDateOfBirth into digitalForm fragment * Create digitalForm query object * Import digitalForm fragment into query object * Export postProcessDigitalForm as postProcess * Add Digital Forms to DATA_FILES array * Fix module imports * Fix typo * Adds blank line for consistent spacing. --------- Co-authored-by: Ryan Koch <ryan.koch.0213@gmail.com>

* Add normalizeForms step to postProcessDigitalForm * Add subtitle to normalized form * Add OMB Number to normalized form * Normalize chapters for each form * Add additional fields for Name and Date of Birth step * Fix import spec * Remove redundant JSON parsing * Remove JSON conversion from returned value * Add formID and rename id to cmsId * Remove subTitle * Refactor normalizeForms method * Refactor normalizeChapters * Defend against malformed query responses * Remove unused import

* Add OMB info to Digital Form GraphQL query * Normalize OMB info * Remove Date object from formatDate

va-vfs-bot

ESLint is disabled

vets-website uses ESLint to help enforce code quality. In most situations we would like ESLint to remain enabled.

What you can do

See if the code can be refactored to avoid disabling ESLint, or wait for a VSP review.

va-vfs-bot · 2024-09-16T16:05:05Z

src/site/stages/build/drupal/static-data-files/config.unit.spec.js

@@ -0,0 +1,15 @@
+/* eslint-disable @department-of-veterans-affairs/axe-check-required */


ESLint disabled here

va-vfs-bot · 2024-09-16T16:05:05Z

...stages/build/drupal/static-data-files/digitalForm/fragments/digitalForm.graphql.unit.spec.js

@@ -0,0 +1,26 @@
+/* eslint-disable @department-of-veterans-affairs/axe-check-required */


ESLint disabled here

va-vfs-bot · 2024-09-16T16:05:06Z

...build/drupal/static-data-files/digitalForm/fragments/nameAndDateOfBirth.graphql.unit.spec.js

@@ -0,0 +1,14 @@
+/* eslint-disable @department-of-veterans-affairs/axe-check-required */


ESLint disabled here

va-vfs-bot · 2024-09-16T16:05:06Z

src/site/stages/build/drupal/static-data-files/digitalForm/index.unit.spec.js

@@ -0,0 +1,52 @@
+/* eslint-disable @department-of-veterans-affairs/axe-check-required */


ESLint disabled here

va-vfs-bot · 2024-09-16T16:05:06Z

src/site/stages/build/drupal/static-data-files/digitalForm/postProcessDigitalForm.unit.spec.js

@@ -0,0 +1,180 @@
+/* eslint-disable @department-of-veterans-affairs/axe-check-required */


ESLint disabled here

va-vfs-bot

ESLint is disabled

vets-website uses ESLint to help enforce code quality. In most situations we would like ESLint to remain enabled.

What you can do

See if the code can be refactored to avoid disabling ESLint, or wait for a VSP review.

va-vfs-bot · 2024-09-18T15:44:54Z

...rupal/static-data-files/digitalForm/fragments/identificationInformation.graphql.unit.spec.js

@@ -0,0 +1,15 @@
+/* eslint-disable @department-of-veterans-affairs/axe-check-required */


ESLint disabled here

* Create postProcessDigitalForm function * Add nameAndDateOfBirth fragment * Create digitalForm GraphQL fragment * Import nameAndDateOfBirth into digitalForm fragment * Create digitalForm query object * Import digitalForm fragment into query object * Export postProcessDigitalForm as postProcess * Add Digital Forms to DATA_FILES array * Fix module imports * Fix typo * Adds blank line for consistent spacing. --------- Co-authored-by: Ryan Koch <ryan.koch.0213@gmail.com>

* Add normalizeForms step to postProcessDigitalForm * Add subtitle to normalized form * Add OMB Number to normalized form * Normalize chapters for each form * Add additional fields for Name and Date of Birth step * Fix import spec * Remove redundant JSON parsing * Remove JSON conversion from returned value * Add formID and rename id to cmsId * Remove subTitle * Refactor normalizeForms method * Refactor normalizeChapters * Defend against malformed query responses * Remove unused import

…-engine-2

…ation-form-engine-2

Normalizes the Address Paragraph type.

va-vfs-bot

ESLint is disabled

vets-website uses ESLint to help enforce code quality. In most situations we would like ESLint to remain enabled.

What you can do

See if the code can be refactored to avoid disabling ESLint, or wait for a VSP review.

va-vfs-bot · 2024-10-04T20:02:15Z

...ite/stages/build/drupal/static-data-files/digitalForm/fragments/address.graphql.unit.spec.js

@@ -0,0 +1,13 @@
+/* eslint-disable @department-of-veterans-affairs/axe-check-required */


ESLint disabled here

derekhouck and others added 6 commits September 11, 2024 21:28

Add OMB info to Digital Form GraphQL query

49ce1af

Normalize OMB info

0cec642

Remove Date object from formatDate

4d7dc20

VATEAM-90733: Normalize OMB info fields (#2252)

52edb57

* Add OMB info to Digital Form GraphQL query * Normalize OMB info * Remove Date object from formatDate

va-vfs-bot requested a review from a team September 16, 2024 16:05

va-vfs-bot reviewed Sep 16, 2024

View reviewed changes

derekhouck added 4 commits September 16, 2024 14:07

Add Identification Information fragment

b64c733

Import identificationInformation fragment into digitalForm fragment

62fdaab

Extract Identification Information fields

ee1a69f

Fix imports

9a6014e

va-vfs-bot reviewed Sep 18, 2024

View reviewed changes

derekhouck and others added 2 commits September 18, 2024 10:45

ryguyk force-pushed the integration-form-engine-2 branch from 195a33f to e3d84e6 Compare September 18, 2024 15:46

va-vfs-bot deployed to master/main/integration-form-engine-poc September 18, 2024 16:03 View deployment

va-vfs-bot temporarily deployed to master/main/integration-form-engine-2 September 18, 2024 16:03 Inactive

va-vfs-bot temporarily deployed to master/main/integration-form-engine-2 September 20, 2024 19:07 Inactive

derekhouck added 3 commits October 2, 2024 10:36

Merge branch 'main' into integration-form-engine-2

a314931

Merge branch '90733-normalize-omb-info-section' into integration-form…

3633329

…-engine-2

Merge branch '91741-normalize-identification-information' into integr…

628f6cb

…ation-form-engine-2

va-vfs-bot temporarily deployed to master/main/integration-form-engine-2 October 2, 2024 16:07 Inactive

VATEAM-92265: Normalize Address Digital Form pattern output (#2301)

0166a12

Normalizes the Address Paragraph type.

va-vfs-bot reviewed Oct 4, 2024

View reviewed changes

va-vfs-bot deployed to master/main/integration-form-engine-2 October 4, 2024 20:14 View deployment

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

DNM: Integration form engine 2 #2273

DNM: Integration form engine 2 #2273

ryguyk commented Sep 16, 2024 •

edited by derekhouck

Loading

va-vfs-bot left a comment

va-vfs-bot Sep 16, 2024

va-vfs-bot Sep 16, 2024

va-vfs-bot Sep 16, 2024

va-vfs-bot Sep 16, 2024

va-vfs-bot Sep 16, 2024

va-vfs-bot left a comment

va-vfs-bot Sep 18, 2024

va-vfs-bot left a comment

va-vfs-bot Oct 4, 2024

		@@ -0,0 +1,15 @@
		/* eslint-disable @department-of-veterans-affairs/axe-check-required */

		@@ -0,0 +1,26 @@
		/* eslint-disable @department-of-veterans-affairs/axe-check-required */

		@@ -0,0 +1,14 @@
		/* eslint-disable @department-of-veterans-affairs/axe-check-required */

		@@ -0,0 +1,52 @@
		/* eslint-disable @department-of-veterans-affairs/axe-check-required */

		@@ -0,0 +1,180 @@
		/* eslint-disable @department-of-veterans-affairs/axe-check-required */

		@@ -0,0 +1,13 @@
		/* eslint-disable @department-of-veterans-affairs/axe-check-required */

DNM: Integration form engine 2 #2273

Are you sure you want to change the base?

DNM: Integration form engine 2 #2273

Conversation

ryguyk commented Sep 16, 2024 • edited by derekhouck Loading

Summary

Related issue(s)

Testing done

Screenshots

What areas of the site does it impact?

Acceptance criteria

Quality Assurance & Testing

Error Handling

Authentication

Requested Feedback

va-vfs-bot left a comment

Choose a reason for hiding this comment

ESLint is disabled

What you can do

va-vfs-bot Sep 16, 2024

Choose a reason for hiding this comment

va-vfs-bot Sep 16, 2024

Choose a reason for hiding this comment

va-vfs-bot Sep 16, 2024

Choose a reason for hiding this comment

va-vfs-bot Sep 16, 2024

Choose a reason for hiding this comment

va-vfs-bot Sep 16, 2024

Choose a reason for hiding this comment

va-vfs-bot left a comment

Choose a reason for hiding this comment

ESLint is disabled

What you can do

va-vfs-bot Sep 18, 2024

Choose a reason for hiding this comment

va-vfs-bot left a comment

Choose a reason for hiding this comment

ESLint is disabled

What you can do

va-vfs-bot Oct 4, 2024

Choose a reason for hiding this comment

ryguyk commented Sep 16, 2024 •

edited by derekhouck

Loading