Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VACMS 18501 - working correct title and custom event #2286

Merged
merged 3 commits into from
Sep 30, 2024

Conversation

eselkin
Copy link
Contributor

@eselkin eselkin commented Sep 24, 2024

Summary

  • Updates DST analytics back to custom event but adds the correct title for the section
  • Collect/assign the correct title to a string to send to analytics
  • Sitewide team (we own facilities pages)

Related issue(s)

Testing done

  • Checked several VAMC pages for the list of link teasers (Manual testing)

Screenshots

View of console from click on link in list Screenshot 2024-09-24 at 3 39 49 PM

What areas of the site does it impact?

VAMC Facility pages

Acceptance criteria

  • Uses custom event in stead of DST component analytics
  • Does not fire DST component analytics
  • Has title from section clicked in details of custom event

Quality Assurance & Testing

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Linting warnings have been addressed
  • Documentation has been updated (link to documentation *if necessary)
  • Screenshot of the developed feature is added
  • Accessibility testing has been performed

Error Handling

  • Browser console contains no warnings or errors.
  • Events are being sent to the appropriate logging solution
  • Feature/bug has a monitor built into Datadog or Grafana (if applicable)

Authentication

  • Did you login to a local build and verify all authenticated routes work as expected with a test user

Requested Feedback

Check section in a VAMC page like:
/philadelphia-health-care/locations/corporal-michael-j-crescenz-department-of-veterans-affairs/#other-services-at-va-philadelp
Or
/philadelphia-health-care/#other-services-at-va-philadelp

@eselkin eselkin marked this pull request as ready for review September 24, 2024 22:44
@eselkin eselkin requested a review from a team as a code owner September 24, 2024 22:44
Copy link
Contributor

@randimays randimays left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked this page in the review instance: http://6d98b4daf85d566c9ae6e02a093864eb.review.vetsgov-internal/philadelphia-health-care/locations/corporal-michael-j-crescenz-department-of-veterans-affairs/#other-services-at-va-philadelp and clicked on "Read annual reports and newsletters from VISN 4" but I didn't see that custom event, even though it's evident that it should be on this element 🤔

Screenshot 2024-09-25 at 9 56 12 AM Screenshot 2024-09-25 at 9 57 54 AM Screenshot 2024-09-25 at 9 56 30 AM

@eselkin
Copy link
Contributor Author

eselkin commented Sep 25, 2024

@randimays Odd, I'm seeing it on that exact element (maybe hard reload?):
Screenshot 2024-09-25 at 3 20 37 PM

It gets hidden by a lot of other console stuff if you don't do a Command+click to open the link in a new tab by the way.

Copy link
Contributor

@randimays randimays left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@eselkin Weird; now I'm seeing it. Guess something shook loose since last week! :D LGTM

@eselkin eselkin merged commit 1cf209d into main Sep 30, 2024
24 checks passed
@eselkin eselkin deleted the VACMS-18501-revert-to-custom-analytics branch September 30, 2024 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants