Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VACMS 19339 - change breakpoint names #2292

Merged
merged 6 commits into from
Sep 27, 2024

Conversation

eselkin
Copy link
Contributor

@eselkin eselkin commented Sep 26, 2024

Summary

  • Changes breakpoint names to new USWDS names
  • Sitewide team (We own facilities pages)

Related issue(s)

Testing done

  • Manual testing
  • Tested Vet Center and VAMC pages and VBA Pages

Screenshots

Views seem the same on mobile sized screens

current broken VA.gov boston-vet-center Screenshot 2024-09-27 at 10 47 17 AM
Fixed boston-vet-center Screenshot 2024-09-27 at 10 47 58 AM
Broken VA.gov Boston Health Care (system) Screenshot 2024-09-27 at 10 49 17 AM
fixed Boston Health Care (system) Screenshot 2024-09-27 at 10 49 10 AM
current VA.gov Boston HEalth Care system mobile Screenshot 2024-09-27 at 10 52 20 AM
PR as above on mobile Screenshot 2024-09-27 at 10 52 09 AM

What areas of the site does it impact?

Facilities pages that were updated to newest DST packages

Acceptance criteria

  • Vet Center pages render as before the update (i.e. images on right side of address block)
  • VAMC pages render as before the update (ditto)

Quality Assurance & Testing

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Linting warnings have been addressed
  • Documentation has been updated (link to documentation *if necessary)
  • Screenshot of the developed feature is added
  • Accessibility testing has been performed

Error Handling

  • Browser console contains no warnings or errors.
  • Events are being sent to the appropriate logging solution
  • Feature/bug has a monitor built into Datadog or Grafana (if applicable)

Authentication

  • Did you login to a local build and verify all authenticated routes work as expected with a test user

Requested Feedback

(OPTIONAL) What should the reviewers know in addition to the above. Is there anything specific you wish the reviewer to assist with. Do you have any concerns with this PR, why?

@va-vfs-bot va-vfs-bot temporarily deployed to master/main/VACMS-19339-screen-size-breakpoint-names September 26, 2024 20:52 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to master/VACMS-19339-screen-size-breakpoint-names/VACMS-19339-screen-size-breakpoint-names September 26, 2024 22:48 Inactive
Copy link

@SnowboardTechie SnowboardTechie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, verified using provided demo urls

@eselkin eselkin merged commit 41bd3c8 into main Sep 27, 2024
27 checks passed
@eselkin eselkin deleted the VACMS-19339-screen-size-breakpoint-names branch September 27, 2024 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants